)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"379d0eeb87462595cd4abdc5116c9370da33f4ec","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch also fix review comment of change-id"},{"line_number":16,"context_line":"5081359295e5311ca725e80efa0bc4b2ec811a0e and define a constant for"},{"line_number":17,"context_line":"\u0027\\u2026\u0027 and use it in all files."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1893305"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_aea42aa4","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":7},"updated":"2020-09-10 08:52:41.000000000","message":"Let\u0027s add a note that it\u0027s a \u0027...\u0027  into the commit message","commit_id":"245b9c106bc93e87f6369a61e0a3902e4ca2e5a6"}],"horizon/constants.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8dd7e4090b78d1cae2ea0640ffb38b12866b2509","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f560f44_3ee05a97","updated":"2020-09-09 15:29:53.000000000","message":"Do we really need a separate file just for one constant?\nWhy not just put it in exceptions.py?","commit_id":"1d2141c8cd6eaf287af6ce75203f3a305537ea2b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"f59f9e4999b86cd4215b94d2512afa14744bfeb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f560f44_547a4f87","in_reply_to":"9f560f44_3ee05a97","updated":"2020-09-09 16:35:31.000000000","message":"Done.","commit_id":"1d2141c8cd6eaf287af6ce75203f3a305537ea2b"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8dd7e4090b78d1cae2ea0640ffb38b12866b2509","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"UNICODE \u003d \u0027\\u2026\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1ef6365e","line":13,"updated":"2020-09-09 15:29:53.000000000","message":"\"unicode\" says nothing about what this constant is and how it is used. A more descriptive name like \"separator\" could work better?","commit_id":"1d2141c8cd6eaf287af6ce75203f3a305537ea2b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"f59f9e4999b86cd4215b94d2512afa14744bfeb5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"UNICODE \u003d \u0027\\u2026\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b46bebb6","line":13,"in_reply_to":"9f560f44_1ef6365e","updated":"2020-09-09 16:35:31.000000000","message":"Done.","commit_id":"1d2141c8cd6eaf287af6ce75203f3a305537ea2b"}],"horizon/exceptions.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7c0419e4e9764df5744d8550587aeed883308c51","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SEPERATOR \u003d \u0027\\u2026\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class HorizonReporterFilter(SafeExceptionReporterFilter):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3843456e","line":34,"updated":"2020-09-10 00:10:10.000000000","message":"I would like to know why this unicode character was chosen as a separator. It is worth having some background/reason here.\n\nI looked through the original patch which implemented the error message refactoring, but failed to find it.","commit_id":"245b9c106bc93e87f6369a61e0a3902e4ca2e5a6"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"b53daf14702b31b7c5f6fe0926608cf3fce9d0d9","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SEPERATOR \u003d \u0027\\u2026\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class HorizonReporterFilter(SafeExceptionReporterFilter):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3e57adcc","line":34,"in_reply_to":"9f560f44_3843456e","updated":"2020-09-10 01:45:51.000000000","message":"you can refer this https://review.opendev.org/#/c/708069/3/horizon/exceptions.py@264","commit_id":"245b9c106bc93e87f6369a61e0a3902e4ca2e5a6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eec77795ca24323d52d011dcc7a119013a0e5cd9","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SEPERATOR \u003d \u0027\\u2026\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class HorizonReporterFilter(SafeExceptionReporterFilter):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_c49b4470","line":34,"in_reply_to":"9f560f44_3e57adcc","updated":"2020-09-10 05:39:02.000000000","message":"but I don\u0027t see why there....","commit_id":"245b9c106bc93e87f6369a61e0a3902e4ca2e5a6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2904442e3aac44db1a21e4ce4c113af32a2be8ba","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SEPERATOR \u003d \u0027\\u2026\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class HorizonReporterFilter(SafeExceptionReporterFilter):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_cef07e94","line":34,"in_reply_to":"9f560f44_5843946c","updated":"2020-09-10 09:03:35.000000000","message":"Ah.. okay...\n\nApparently, as you know, the current approach would be broken if translated messages contains this unicode string. This is just a potential risk right now, but I don\u0027t know translators never use it. Ideally it is nice to have some escaping mechanism for such string, but I thought it is too much for the initial implementation and did not comment it, but I thought it is worth clarifying why it was chosen.\n\nI believe you all and future developers can remember/know this potential issue.","commit_id":"245b9c106bc93e87f6369a61e0a3902e4ca2e5a6"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"25b3aa8993d4a2599bd033917e576671e78f7fd1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SEPERATOR \u003d \u0027\\u2026\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class HorizonReporterFilter(SafeExceptionReporterFilter):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_5843946c","line":34,"in_reply_to":"9f560f44_c49b4470","updated":"2020-09-10 07:28:43.000000000","message":"TBH I have not remembered why I used \u0027\\u2026\u0027. I am using \u0027...\u0027 before then radomir suggest me to use \u0027\\u2026\u0027 it then I changed it","commit_id":"245b9c106bc93e87f6369a61e0a3902e4ca2e5a6"}],"horizon/static/horizon/js/horizon.messages.js":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ec5711bf6198de9d50798e52f0dafcf69b16fac5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  var this_alert \u003d $(template.render(params)).hide().prependTo(\"#main_content .messages\").fadeIn(100);"},{"line_number":51,"context_line":"  horizon.autoDismissAlert(this_alert);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  // NOTE: messages template engine doesn\u0027t support conditional rendering yet"},{"line_number":54,"context_line":"  // So it\u0027s a temporary work-around to hide details link when details is empty."},{"line_number":55,"context_line":"  if (details \u003d\u003d\u003d undefined || details \u003d\u003d\u003d \"\") {"},{"line_number":56,"context_line":"    this_alert.find(\"#details_link\").remove();"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":"  return this_alert;"},{"line_number":59,"context_line":"};"},{"line_number":60,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"9f560f44_18ddca13","line":57,"range":{"start_line":53,"start_character":3,"end_line":57,"end_character":3},"updated":"2020-09-08 09:18:14.000000000","message":"Since I\u0027m a co-author of this part of code, I\u0027m putting +1 for the whole change","commit_id":"1d2141c8cd6eaf287af6ce75203f3a305537ea2b"}],"horizon/templatetags/splitfilter.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ebfeac65564a8941f2a289bf56a017747c2603c5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@register.filter(name\u003d\u0027split_message\u0027)"},{"line_number":21,"context_line":"def split_message(value):"},{"line_number":22,"context_line":"    return value.split(exceptions.SEPERATOR)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4cd116cc","line":22,"updated":"2020-09-10 10:33:25.000000000","message":"pep8: C0321: More than one statement on a single line (multiple-statements)","commit_id":"10322c9800fa44d7182f5c2bf9333aa5682b1767"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"05462009f83914b2722d29281cc8478663530d68","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@register.filter(name\u003d\u0027split_message\u0027)"},{"line_number":21,"context_line":"def split_message(value):"},{"line_number":22,"context_line":"    return value.split(exceptions.SEPERATOR)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_6c6a1aed","line":22,"in_reply_to":"9f560f44_4cd116cc","updated":"2020-09-10 10:41:41.000000000","message":"I think pep8 is very confused here...","commit_id":"10322c9800fa44d7182f5c2bf9333aa5682b1767"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5b913707725ca4253d5235c627da8b783aa30357","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@register.filter(name\u003d\u0027split_message\u0027)"},{"line_number":21,"context_line":"def split_message(value):"},{"line_number":22,"context_line":"    return value.split(exceptions.SEPERATOR)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_0299a71d","line":22,"updated":"2020-09-10 12:07:03.000000000","message":"pep8: C0321: More than one statement on a single line (multiple-statements)","commit_id":"2f9014586f90af96e39e882cc23f8cf012d28947"}]}