)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8832c5805ade643c1f51e6f4336b9f0d4ea37591","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the default_availability_zone for VM creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the OPENSTACK_DEFAULT_AVAILABILITY_ZONE settings in VM creation"},{"line_number":10,"context_line":"dashboard in order to let administrator select a default availability"},{"line_number":11,"context_line":"zone instead of a random one when many are available."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"58876b06_d2f1d8e6","line":9,"updated":"2020-11-27 00:35:25.000000000","message":"Same here, LAUNCH_INSTANCE_DEFAULTS changed, not OPENSTACK_DEFAULT_AVAILABILITY_ZONE added","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"044cc48aa3df0f39b55fdb8f19925ef0a346b50c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the default_availability_zone for VM creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the OPENSTACK_DEFAULT_AVAILABILITY_ZONE settings in VM creation"},{"line_number":10,"context_line":"dashboard in order to let administrator select a default availability"},{"line_number":11,"context_line":"zone instead of a random one when many are available."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"3847b246_5e7001f2","line":9,"in_reply_to":"58876b06_d2f1d8e6","updated":"2020-11-27 01:16:21.000000000","message":"Done","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a2fe69054952bec3bf93094efb88cf45c0efcee8","unresolved":false,"context_lines":[{"line_number":368,"context_line":"      if (model.availabilityZones.length \u003d\u003d\u003d 1) {"},{"line_number":369,"context_line":"        model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":370,"context_line":"      } else if (model.availabilityZones.length \u003e 1) {"},{"line_number":371,"context_line":"        if (settings.OPENSTACK_DEFAULT_AVAILABILITY_ZONE \u003d\u003d\u003d \"Any\") {"},{"line_number":372,"context_line":"          // There are 2 or more; allow ability for nova scheduler to pick,"},{"line_number":373,"context_line":"          // and make that the default."},{"line_number":374,"context_line":"          model.availabilityZones.unshift({"}],"source_content_type":"text/javascript","patch_set":5,"id":"9f560f44_ae6caf07","line":371,"updated":"2020-10-02 08:09:17.000000000","message":"In the Angular side, we can refer to settings only allowed in REST_API_REQUIRED_SETTINGS. I wonder how this works. I might be missing something.\n(The setting LAUNCH_INSTANCE_DEFAULTS which I suggest in the other file is listed in REST_API_REQUIRED_SETTINGS, so it should work.)","commit_id":"0c3248b64759306757205d19b5c0eda8265ea50b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8832c5805ade643c1f51e6f4336b9f0d4ea37591","unresolved":true,"context_lines":[{"line_number":251,"context_line":"          });"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        promise \u003d $q.all(["},{"line_number":254,"context_line":"          launchInstanceDefaults.then(setDefaultAZ),"},{"line_number":255,"context_line":"          novaAPI.getAvailabilityZones().then(onGetAvailabilityZones)"},{"line_number":256,"context_line":"            .finally(onGetAvailabilityZonesComplete),"},{"line_number":257,"context_line":"          novaAPI.getFlavors({"}],"source_content_type":"text/javascript","patch_set":24,"id":"9dcb0ecd_1978789b","line":254,"updated":"2020-11-27 00:35:25.000000000","message":"You can move here L#266 \"launchInstanceDefaults.then(setDefaultValues, noop),\" and don\u0027t use the separate function setDefaultAZ.","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"044cc48aa3df0f39b55fdb8f19925ef0a346b50c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"          });"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        promise \u003d $q.all(["},{"line_number":254,"context_line":"          launchInstanceDefaults.then(setDefaultAZ),"},{"line_number":255,"context_line":"          novaAPI.getAvailabilityZones().then(onGetAvailabilityZones)"},{"line_number":256,"context_line":"            .finally(onGetAvailabilityZonesComplete),"},{"line_number":257,"context_line":"          novaAPI.getFlavors({"}],"source_content_type":"text/javascript","patch_set":24,"id":"fdf740ed_f757cc65","line":254,"in_reply_to":"9dcb0ecd_1978789b","updated":"2020-11-27 01:16:21.000000000","message":"Done","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8832c5805ade643c1f51e6f4336b9f0d4ea37591","unresolved":true,"context_lines":[{"line_number":300,"context_line":"    function setDefaultValues(defaults) {"},{"line_number":301,"context_line":"      if (!defaults) {"},{"line_number":302,"context_line":"        return;"},{"line_number":303,"context_line":"      }"},{"line_number":304,"context_line":"      if (\u0027config_drive\u0027 in defaults) {"},{"line_number":305,"context_line":"        model.newInstanceSpec.config_drive \u003d defaults.config_drive;"},{"line_number":306,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":24,"id":"79e2438d_012edd8b","line":303,"updated":"2020-11-27 00:35:25.000000000","message":"Move here L#295-L#297 and drop the function setDefaultAZ.","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"044cc48aa3df0f39b55fdb8f19925ef0a346b50c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    function setDefaultValues(defaults) {"},{"line_number":301,"context_line":"      if (!defaults) {"},{"line_number":302,"context_line":"        return;"},{"line_number":303,"context_line":"      }"},{"line_number":304,"context_line":"      if (\u0027config_drive\u0027 in defaults) {"},{"line_number":305,"context_line":"        model.newInstanceSpec.config_drive \u003d defaults.config_drive;"},{"line_number":306,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":24,"id":"1eb305cd_3651c51b","line":303,"in_reply_to":"79e2438d_012edd8b","updated":"2020-11-27 01:16:21.000000000","message":"Done","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ddcf23a48ee5aae07c4ed416c78cd645a2db7e7b","unresolved":true,"context_lines":[{"line_number":301,"context_line":"      if (\u0027hide_create_volume\u0027 in defaults) {"},{"line_number":302,"context_line":"        model.newInstanceSpec.hide_create_volume \u003d defaults.hide_create_volume;"},{"line_number":303,"context_line":"      }"},{"line_number":304,"context_line":"      if (\u0027default_availability_zone\u0027 in defaults) {"},{"line_number":305,"context_line":"        model.default_availability_zone \u003d defaults.default_availability_zone;"},{"line_number":306,"context_line":"      }"},{"line_number":307,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":29,"id":"2fe41144_30f66599","line":304,"updated":"2020-11-27 17:06:00.000000000","message":"This branch is not covered with tests. I added this and tested, coverage percentage is enough now:\n\n        it(\u0027should default availability_zone if setting not provided\u0027, function() {\n          delete settings.LAUNCH_INSTANCE_DEFAULTS.default_availability_zone;\n          model.initialize(true);\n          scope.$apply();\n\n          expect(model.newInstanceSpec.availability_zone).toBe(\u0027\u0027);\n        });","commit_id":"bd11cd9374034880e7163a1f71f043f9ca6cab42"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"35a13f5ecb6f2f5640ec4f69a24db464c4f058ae","unresolved":true,"context_lines":[{"line_number":301,"context_line":"      if (\u0027hide_create_volume\u0027 in defaults) {"},{"line_number":302,"context_line":"        model.newInstanceSpec.hide_create_volume \u003d defaults.hide_create_volume;"},{"line_number":303,"context_line":"      }"},{"line_number":304,"context_line":"      if (\u0027default_availability_zone\u0027 in defaults) {"},{"line_number":305,"context_line":"        model.default_availability_zone \u003d defaults.default_availability_zone;"},{"line_number":306,"context_line":"      }"},{"line_number":307,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":29,"id":"f14ee20d_bcf33638","line":304,"in_reply_to":"2fe41144_30f66599","updated":"2020-11-27 17:12:31.000000000","message":"I thought I added that test.","commit_id":"bd11cd9374034880e7163a1f71f043f9ca6cab42"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"0011a913b967c7e0ea78c56ff16b689aab8a09d0","unresolved":false,"context_lines":[{"line_number":301,"context_line":"      if (\u0027hide_create_volume\u0027 in defaults) {"},{"line_number":302,"context_line":"        model.newInstanceSpec.hide_create_volume \u003d defaults.hide_create_volume;"},{"line_number":303,"context_line":"      }"},{"line_number":304,"context_line":"      if (\u0027default_availability_zone\u0027 in defaults) {"},{"line_number":305,"context_line":"        model.default_availability_zone \u003d defaults.default_availability_zone;"},{"line_number":306,"context_line":"      }"},{"line_number":307,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":29,"id":"6815c89f_b2f7e0fb","line":304,"in_reply_to":"f14ee20d_bcf33638","updated":"2020-11-27 18:37:03.000000000","message":"It is in my latest patch :\n~~~\n+        it(\u0027should have proper availability_zone if settings are missing\u0027, function() {\n+          delete settings.LAUNCH_INSTANCE_DEFAULTS;\n+          model.initialize(true);\n+          scope.$apply();\n+\n+          expect(model.newInstanceSpec.availability_zone).toBe(\u0027\u0027);\n+        });\n~~~","commit_id":"bd11cd9374034880e7163a1f71f043f9ca6cab42"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"360439e5613a88f9a9b9376fc070338c5e77c6a3","unresolved":true,"context_lines":[{"line_number":379,"context_line":"          model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":380,"context_line":"        } else {"},{"line_number":381,"context_line":"          // if default_availability_zone is set, use that AZ by default."},{"line_number":382,"context_line":"          model.availabilityZones.unshift({"},{"line_number":383,"context_line":"            label: gettext(\"Default Availability Zone\"),"},{"line_number":384,"context_line":"            value: gettext(model.default_availability_zone)"},{"line_number":385,"context_line":"          });"},{"line_number":386,"context_line":"          model.newInstanceSpec.availability_zone \u003d model.default_availability_zone;"},{"line_number":387,"context_line":"        }"},{"line_number":388,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":33,"id":"e0826374_5ad92a3e","line":385,"range":{"start_line":382,"start_character":10,"end_line":385,"end_character":13},"updated":"2021-02-18 10:49:58.000000000","message":"When I tested the patch, this entry is a bit confusing to me.\nThe confusing points are:\n- We have two entries for a default availability zone (zone name one and \"Default Availability Zone\")\n- \"Default Availability Zone\" is not selected by default. The zone name one is selected by default.\nMy suggestion is to change the label of the default availability zone to something kilke \"az2 (default)\" and drop \"Default Availability Zone\"\" menu. I believe it is much eaiser to understand.","commit_id":"27134b108dac9ecae4d7304a3acfa4899b8a9448"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7342751fc7381aa25907691f9a65464244b76995","unresolved":true,"context_lines":[{"line_number":379,"context_line":"          model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":380,"context_line":"        } else {"},{"line_number":381,"context_line":"          // if default_availability_zone is set, use that AZ by default."},{"line_number":382,"context_line":"          model.availabilityZones.unshift({"},{"line_number":383,"context_line":"            label: gettext(\"Default Availability Zone\"),"},{"line_number":384,"context_line":"            value: gettext(model.default_availability_zone)"},{"line_number":385,"context_line":"          });"},{"line_number":386,"context_line":"          model.newInstanceSpec.availability_zone \u003d model.default_availability_zone;"},{"line_number":387,"context_line":"        }"},{"line_number":388,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":33,"id":"7cbb6d12_e7a7d0a5","line":385,"range":{"start_line":382,"start_character":10,"end_line":385,"end_character":13},"in_reply_to":"e0826374_5ad92a3e","updated":"2021-02-18 11:36:11.000000000","message":"I updated the patch to address my above comment. Does it work for you?","commit_id":"27134b108dac9ecae4d7304a3acfa4899b8a9448"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2bca4d467a674efe43bf708be098ad841aaa4a1b","unresolved":true,"context_lines":[{"line_number":379,"context_line":"          model.newInstanceSpec.availability_zone \u003d model.availabilityZones[0].value;"},{"line_number":380,"context_line":"        } else {"},{"line_number":381,"context_line":"          // if default_availability_zone is set, use that AZ by default."},{"line_number":382,"context_line":"          model.newInstanceSpec.availability_zone \u003d model.default_availability_zone;"},{"line_number":383,"context_line":"          // Add \"(default)\" suffix to the default AZ."},{"line_number":384,"context_line":"          var default_az \u003d model.availabilityZones.find("},{"line_number":385,"context_line":"            z \u003d\u003e z.value \u003d\u003d\u003d model.default_availability_zone)"}],"source_content_type":"text/javascript","patch_set":34,"id":"3b02aafb_a375ced7","line":382,"updated":"2021-02-18 12:13:00.000000000","message":"In addition to the below, this also should be called only when the default AZ is found in the AZ list retrieved.","commit_id":"aa821cbf79bc9a45410634d60241a63576189631"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2bca4d467a674efe43bf708be098ad841aaa4a1b","unresolved":true,"context_lines":[{"line_number":382,"context_line":"          model.newInstanceSpec.availability_zone \u003d model.default_availability_zone;"},{"line_number":383,"context_line":"          // Add \"(default)\" suffix to the default AZ."},{"line_number":384,"context_line":"          var default_az \u003d model.availabilityZones.find("},{"line_number":385,"context_line":"            z \u003d\u003e z.value \u003d\u003d\u003d model.default_availability_zone)"},{"line_number":386,"context_line":"          default_az.label \u003d interpolate(gettext(\"%s (default)\"), [default_az.value]);"},{"line_number":387,"context_line":"        }"},{"line_number":388,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":34,"id":"7a711b2b_12b8b7db","line":385,"updated":"2021-02-18 12:13:00.000000000","message":"find() can return undefined if an operator configures the default AZ to non-existing AZ. I need to check it and call the next line only if it exists.","commit_id":"aa821cbf79bc9a45410634d60241a63576189631"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.spec.js":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"27b8d1264d3a4eac3bf5b729ec3b944b4f7e2f5e","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        beforeEach(function () {"},{"line_number":163,"context_line":"          settings \u003d {"},{"line_number":164,"context_line":"            LAUNCH_INSTANCE_DEFAULTS: {"},{"line_number":165,"context_line":"              create_volume: true,"},{"line_number":166,"context_line":"              hide_create_volume: false,"},{"line_number":167,"context_line":"              config_drive: false,"}],"source_content_type":"text/javascript","patch_set":13,"id":"188c26e2_a3e82493","line":164,"updated":"2020-11-26 17:55:57.000000000","message":"Add default_availability_zone here","commit_id":"4008f997e85e58049de406ef8b5238000d76ef69"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"916b51ca26ea656b55731235c6bd9d0b8b4c48a8","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        beforeEach(function () {"},{"line_number":163,"context_line":"          settings \u003d {"},{"line_number":164,"context_line":"            LAUNCH_INSTANCE_DEFAULTS: {"},{"line_number":165,"context_line":"              create_volume: true,"},{"line_number":166,"context_line":"              hide_create_volume: false,"},{"line_number":167,"context_line":"              config_drive: false,"}],"source_content_type":"text/javascript","patch_set":13,"id":"95d20cc3_5e38dd61","line":164,"in_reply_to":"188c26e2_a3e82493","updated":"2020-11-27 01:16:58.000000000","message":"Done","commit_id":"4008f997e85e58049de406ef8b5238000d76ef69"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"27b8d1264d3a4eac3bf5b729ec3b944b4f7e2f5e","unresolved":true,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"          expect(model.newInstanceSpec.availability_zone).toEqual(\"\");"},{"line_number":498,"context_line":"        });"},{"line_number":499,"context_line":"        it(\u0027should default availability_zone to set based on setting\u0027, function() {"},{"line_number":500,"context_line":"          settings.LAUNCH_INSTANCE_DEFAULTS.default_availability_zone \u003d \"nova\";"},{"line_number":501,"context_line":"          model.initialize(true);"},{"line_number":502,"context_line":"          scope.$apply();"}],"source_content_type":"text/javascript","patch_set":13,"id":"ff8cdc13_ff2befee","line":499,"updated":"2020-11-26 17:55:57.000000000","message":"Please add a blank line between the tests","commit_id":"4008f997e85e58049de406ef8b5238000d76ef69"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"916b51ca26ea656b55731235c6bd9d0b8b4c48a8","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"          expect(model.newInstanceSpec.availability_zone).toEqual(\"\");"},{"line_number":498,"context_line":"        });"},{"line_number":499,"context_line":"        it(\u0027should default availability_zone to set based on setting\u0027, function() {"},{"line_number":500,"context_line":"          settings.LAUNCH_INSTANCE_DEFAULTS.default_availability_zone \u003d \"nova\";"},{"line_number":501,"context_line":"          model.initialize(true);"},{"line_number":502,"context_line":"          scope.$apply();"}],"source_content_type":"text/javascript","patch_set":13,"id":"19d72a0a_40f3ef41","line":499,"in_reply_to":"ff8cdc13_ff2befee","updated":"2020-11-27 01:16:58.000000000","message":"Done","commit_id":"4008f997e85e58049de406ef8b5238000d76ef69"}],"openstack_dashboard/defaults.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a2fe69054952bec3bf93094efb88cf45c0efcee8","unresolved":false,"context_lines":[{"line_number":375,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_DOMAIN \u003d \u0027Default\u0027"},{"line_number":376,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_ROLE \u003d \u0027_member_\u0027"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"OPENSTACK_DEFAULT_AVAILABILITY_ZONE \u003d \"Any\""},{"line_number":379,"context_line":"# The OPENSTACK_KEYSTONE_BACKEND settings can be used to identify the"},{"line_number":380,"context_line":"# capabilities of the auth backend for Keystone."},{"line_number":381,"context_line":"# If Keystone has been configured to use LDAP as the auth backend then set"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_0e731bea","line":378,"updated":"2020-10-02 08:09:17.000000000","message":"I would suggest to add this to LAUNCH_INSTANCE_DEFAULTS.\nI believe LAUNCH_INSTANCE_DEFAULTS fits to this use case.","commit_id":"0c3248b64759306757205d19b5c0eda8265ea50b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b75b80fb6169e73eec65d71c688209f28bcf39d7","unresolved":false,"context_lines":[{"line_number":375,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_DOMAIN \u003d \u0027Default\u0027"},{"line_number":376,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_ROLE \u003d \u0027_member_\u0027"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"OPENSTACK_DEFAULT_AVAILABILITY_ZONE \u003d \"Any\""},{"line_number":379,"context_line":"# The OPENSTACK_KEYSTONE_BACKEND settings can be used to identify the"},{"line_number":380,"context_line":"# capabilities of the auth backend for Keystone."},{"line_number":381,"context_line":"# If Keystone has been configured to use LDAP as the auth backend then set"}],"source_content_type":"text/x-python","patch_set":5,"id":"d83eb599_3a6a3ee4","line":378,"in_reply_to":"9a386961_c4fb5e6f","updated":"2020-11-26 12:42:40.000000000","message":"LAUNCH_INSTANCE_DEFAULTS setting is a place to define settings used in the launch instance form.\nIt is not limited to boolean options. It is just because we have only boolean options and we don\u0027t see any other type options so far.","commit_id":"0c3248b64759306757205d19b5c0eda8265ea50b"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"f18dc41c847c2c331f545fbf398a29438f9b5578","unresolved":false,"context_lines":[{"line_number":375,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_DOMAIN \u003d \u0027Default\u0027"},{"line_number":376,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_ROLE \u003d \u0027_member_\u0027"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"OPENSTACK_DEFAULT_AVAILABILITY_ZONE \u003d \"Any\""},{"line_number":379,"context_line":"# The OPENSTACK_KEYSTONE_BACKEND settings can be used to identify the"},{"line_number":380,"context_line":"# capabilities of the auth backend for Keystone."},{"line_number":381,"context_line":"# If Keystone has been configured to use LDAP as the auth backend then set"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a386961_c4fb5e6f","line":378,"in_reply_to":"9f560f44_0e731bea","updated":"2020-11-21 20:19:21.000000000","message":"I did see that but they were only booleans ... Would we mind having non booleans values in there ?  Or change the code so it\u0027s a boolean instead ?","commit_id":"0c3248b64759306757205d19b5c0eda8265ea50b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8832c5805ade643c1f51e6f4336b9f0d4ea37591","unresolved":true,"context_lines":[{"line_number":258,"context_line":"    \u0027disable_volume\u0027: False,"},{"line_number":259,"context_line":"    \u0027disable_volume_snapshot\u0027: False,"},{"line_number":260,"context_line":"    \u0027enable_scheduler_hints\u0027: True,"},{"line_number":261,"context_line":"    \u0027default_availability_zone\u0027: \u0027Any\u0027,"},{"line_number":262,"context_line":"}"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"# The absolute path to the directory where message files are collected."}],"source_content_type":"text/x-python","patch_set":24,"id":"7fa53991_cd3489ec","line":261,"updated":"2020-11-27 00:35:25.000000000","message":"No need for comma here","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"044cc48aa3df0f39b55fdb8f19925ef0a346b50c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    \u0027disable_volume\u0027: False,"},{"line_number":259,"context_line":"    \u0027disable_volume_snapshot\u0027: False,"},{"line_number":260,"context_line":"    \u0027enable_scheduler_hints\u0027: True,"},{"line_number":261,"context_line":"    \u0027default_availability_zone\u0027: \u0027Any\u0027,"},{"line_number":262,"context_line":"}"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"# The absolute path to the directory where message files are collected."}],"source_content_type":"text/x-python","patch_set":24,"id":"4febb0e1_9acc3a61","line":261,"in_reply_to":"7fa53991_cd3489ec","updated":"2020-11-27 01:16:21.000000000","message":"Done","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"}],"releasenotes/notes/add_default_availability_zone-9c070832b2992958.yaml":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8832c5805ade643c1f51e6f4336b9f0d4ea37591","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When multiple availability zones are available, the default behavior is to"},{"line_number":5,"context_line":"    allow the scheduler to spawn a VM in any of them.   This new setting"},{"line_number":6,"context_line":"    OPENSTACK_DEFAULT_AVAILABILITY_ZONE allows an administrator to specify"},{"line_number":7,"context_line":"    a default static availability zone for new VM creation."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"eab9f350_15895569","line":5,"updated":"2020-11-27 00:35:25.000000000","message":"Please remove redundant whitespaces","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"044cc48aa3df0f39b55fdb8f19925ef0a346b50c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When multiple availability zones are available, the default behavior is to"},{"line_number":5,"context_line":"    allow the scheduler to spawn a VM in any of them.   This new setting"},{"line_number":6,"context_line":"    OPENSTACK_DEFAULT_AVAILABILITY_ZONE allows an administrator to specify"},{"line_number":7,"context_line":"    a default static availability zone for new VM creation."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"8c9c638e_707b8045","line":5,"in_reply_to":"eab9f350_15895569","updated":"2020-11-27 01:16:21.000000000","message":"Done","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8832c5805ade643c1f51e6f4336b9f0d4ea37591","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When multiple availability zones are available, the default behavior is to"},{"line_number":5,"context_line":"    allow the scheduler to spawn a VM in any of them.   This new setting"},{"line_number":6,"context_line":"    OPENSTACK_DEFAULT_AVAILABILITY_ZONE allows an administrator to specify"},{"line_number":7,"context_line":"    a default static availability zone for new VM creation."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"4f10e375_0aee477a","line":6,"updated":"2020-11-27 00:35:25.000000000","message":"There\u0027s no OPENSTACK_DEFAULT_AVAILABILITY_ZONE anymore, you\u0027re adding it to LAUNCH_INSTANCE_DEFAULTS. Please correct.","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"044cc48aa3df0f39b55fdb8f19925ef0a346b50c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When multiple availability zones are available, the default behavior is to"},{"line_number":5,"context_line":"    allow the scheduler to spawn a VM in any of them.   This new setting"},{"line_number":6,"context_line":"    OPENSTACK_DEFAULT_AVAILABILITY_ZONE allows an administrator to specify"},{"line_number":7,"context_line":"    a default static availability zone for new VM creation."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"eaf2be77_247e0dba","line":6,"in_reply_to":"4f10e375_0aee477a","updated":"2020-11-27 01:16:21.000000000","message":"Done","commit_id":"6f06935662e74ffc1c540610303b8cd9e324ac26"}]}