)]}'
{"horizon/templates/horizon/_scripts.html":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% comment %} Compress jQuery, Angular, Plugins, Bootstrap, Hogan.js and Horizon-specific JS. {% endcomment %}"},{"line_number":8,"context_line":"{% compress js %}"},{"line_number":9,"context_line":"    {% for file in HORIZON_CONFIG.js_files %}"},{"line_number":10,"context_line":"        \u003cscript src\u003d\u0027{{ STATIC_URL }}{{ file }}\u0027 type\u003d\u0027text/javascript\u0027 charset\u003d\u0027utf-8\u0027\u003e\u003c/script\u003e"},{"line_number":11,"context_line":"    {% endfor %}"},{"line_number":12,"context_line":"    \u003cscript src\u003d\u0027{{ STATIC_URL }}horizon/lib/angular/angular-cookies.js\u0027 type\u003d\u0027text/javascript\u0027"}],"source_content_type":"text/html","patch_set":21,"id":"1ae5cdf2_2ef20e6f","line":9,"updated":"2014-06-26 21:03:31.000000000","message":"There are alot of changes in this file. I\u0027m pretty sure you don\u0027t want to do that. I\u0027d reset all these lines back to the original","commit_id":"4197d1947f5f35bcb2835e17edb2fd6712a5bb3d"}],"openstack_dashboard/dashboards/project/databases/tables.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"02cc6c8ca8afaaba7b06cf165a7d252a48c40231","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    name \u003d tables.Column(\"name\","},{"line_number":167,"context_line":"                         link\u003d(\"horizon:project:databases:detail\"),"},{"line_number":168,"context_line":"                         verbose_name\u003d_(\"Database Name\"))"},{"line_number":169,"context_line":"    datastore \u003d tables.Column(get_datastore,"},{"line_number":170,"context_line":"                              verbose_name\u003d_(\"Datastore\"))"},{"line_number":171,"context_line":"    datastore_version \u003d tables.Column(get_datastore_version,"},{"line_number":172,"context_line":"                                      verbose_name\u003d_(\"Datastore Version\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2Fxhk%3D","line":169,"updated":"2014-04-10 14:03:09.000000000","message":"why two columns? I think a single column with \u0027datastore - version\u0027 would be fine. Like: \u0027mysql - 5.5\u0027 or \u0027redis - 2.4\u0027","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"unresolved":false,"context_lines":[{"line_number":166,"context_line":"    name \u003d tables.Column(\"name\","},{"line_number":167,"context_line":"                         link\u003d(\"horizon:project:databases:detail\"),"},{"line_number":168,"context_line":"                         verbose_name\u003d_(\"Database Name\"))"},{"line_number":169,"context_line":"    datastore \u003d tables.Column(get_datastore,"},{"line_number":170,"context_line":"                              verbose_name\u003d_(\"Datastore\"))"},{"line_number":171,"context_line":"    datastore_version \u003d tables.Column(get_datastore_version,"},{"line_number":172,"context_line":"                                      verbose_name\u003d_(\"Datastore Version\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2FsnM%3D","line":169,"in_reply_to":"AAAAW3%2F%2Fupw%3D","updated":"2014-04-11 03:38:05.000000000","message":"Fine if y\u0027all want to waste a column on this go for it. But Auston, style 2 and 3 will still look goofy in two columns . If the admins want something that looks nice they\u0027ll choose #1. Basically when you look at the heading of the table you\u0027ll see \u0027Datastore\u0027, \u0027Datastore Version\u0027 right next to each other. I see those as one column with two pieces of data, the fact that you need to include the word \u0027Datastore\u0027 in the Version column says that this information is useless without some other supporting data :)","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"2b2f55f59ab95e1b429dd877a32dd8db41117fba","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    name \u003d tables.Column(\"name\","},{"line_number":167,"context_line":"                         link\u003d(\"horizon:project:databases:detail\"),"},{"line_number":168,"context_line":"                         verbose_name\u003d_(\"Database Name\"))"},{"line_number":169,"context_line":"    datastore \u003d tables.Column(get_datastore,"},{"line_number":170,"context_line":"                              verbose_name\u003d_(\"Datastore\"))"},{"line_number":171,"context_line":"    datastore_version \u003d tables.Column(get_datastore_version,"},{"line_number":172,"context_line":"                                      verbose_name\u003d_(\"Datastore Version\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2Fupw%3D","line":169,"in_reply_to":"AAAAW3%2F%2FxZk%3D","updated":"2014-04-10 19:37:28.000000000","message":"if we didn\u0027t have datastore and datastore-version as very distinct fields, i\u0027d agreed robert. but, considering it\u0027s up to the provider on how things are categorized:\n\nstyle 1:\n\n    datastore \u003d\u003e mysql, datastore-version \u003d\u003e 5.5\n    datastore \u003d\u003e mongodb, datastore-version \u003d\u003e 2.4.9\n    ...\n\nstyle 2:\n\n    datastore \u003d\u003e mysql-5.5, datastore-version \u003d\u003e 5.5.12\n    datastore \u003d\u003e mysql-5.5, datastore-version \u003d\u003e 5.5.15\n    datastore \u003d\u003e mysql-5.6, datastore-version \u003d\u003e 5.6.17\n\nstyle 2:\n\n    datastore \u003d\u003e rdbms, datastore-version \u003d\u003e mysql-5.5\n    datastore \u003d\u003e rdbms, datastore-version \u003d\u003e mysql-5.6\n    datastore \u003d\u003e rdbms, datastore-version \u003d\u003e postgres 9.2\n    datastore \u003d\u003e nosql, datastore-version \u003d\u003e mongodb-2.4.9\n\netc. etc.\n\nconcatenating the two won\u0027t make sense.","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0ccc8e8740277b7d43c9a2bcbec351014c5cb6ce","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    name \u003d tables.Column(\"name\","},{"line_number":167,"context_line":"                         link\u003d(\"horizon:project:databases:detail\"),"},{"line_number":168,"context_line":"                         verbose_name\u003d_(\"Database Name\"))"},{"line_number":169,"context_line":"    datastore \u003d tables.Column(get_datastore,"},{"line_number":170,"context_line":"                              verbose_name\u003d_(\"Datastore\"))"},{"line_number":171,"context_line":"    datastore_version \u003d tables.Column(get_datastore_version,"},{"line_number":172,"context_line":"                                      verbose_name\u003d_(\"Datastore Version\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2FxZk%3D","line":169,"in_reply_to":"AAAAW3%2F%2Fxhk%3D","updated":"2014-04-10 14:10:47.000000000","message":"i disagree, two colums is more meaningful than one, since an instance have separate attributes for version and type, they _should_ be the seprate items, so i\u0027m totally up for the it\u0027s own colums per type and version","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":165,"context_line":"                         link\u003d(\"horizon:project:databases:detail\"),"},{"line_number":166,"context_line":"                         verbose_name\u003d_(\"Database Name\"))"},{"line_number":167,"context_line":"    datastore \u003d tables.Column(get_datastore,"},{"line_number":168,"context_line":"                              verbose_name\u003d_(\"Datastore\"))"},{"line_number":169,"context_line":"    datastore_version \u003d tables.Column(get_datastore_version,"},{"line_number":170,"context_line":"                                      verbose_name\u003d_(\"Datastore Version\"))"},{"line_number":171,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_0cbd2002","line":168,"updated":"2014-07-07 22:42:43.000000000","message":"Does it make sense to call it \u0027Datastore Type\u0027 instead of just \u0027Datastore\u0027? Thanks.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                         link\u003d(\"horizon:project:databases:detail\"),"},{"line_number":166,"context_line":"                         verbose_name\u003d_(\"Database Name\"))"},{"line_number":167,"context_line":"    datastore \u003d tables.Column(get_datastore,"},{"line_number":168,"context_line":"                              verbose_name\u003d_(\"Datastore\"))"},{"line_number":169,"context_line":"    datastore_version \u003d tables.Column(get_datastore_version,"},{"line_number":170,"context_line":"                                      verbose_name\u003d_(\"Datastore Version\"))"},{"line_number":171,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_a100b666","line":168,"in_reply_to":"baada198_0cbd2002","updated":"2014-07-08 00:31:19.000000000","message":"We could, but I think \"Datastore\" is sufficient enough.  This also saves us the extra space used up if we include \"Type\", which would be beneficial if additional columns are added.\n\nBut if more folks vote for \"Datastore Type\", I can change it.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"}],"openstack_dashboard/dashboards/project/databases/tabs.py":[{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_template_name(self, request):"},{"line_number":32,"context_line":"        instance \u003d self.tab_group.kwargs[\u0027instance\u0027]"},{"line_number":33,"context_line":"        return (\u0027project/databases/_detail_overview_%s.html\u0027"},{"line_number":34,"context_line":"                % instance.datastore[\u0027type\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class UserTab(tabs.TableTab):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ae5cdf2_f1fac7b8","line":34,"updated":"2014-06-26 21:15:53.000000000","message":"actually - what will happen for a datastore type that doesn\u0027t have an associated html file - e.g. vertica - _detail_overview_vertica.html won\u0027t exist so should it revert to somethign else in that case ?","commit_id":"4197d1947f5f35bcb2835e17edb2fd6712a5bb3d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_template_name(self, request):"},{"line_number":32,"context_line":"        instance \u003d self.tab_group.kwargs[\u0027instance\u0027]"},{"line_number":33,"context_line":"        return (\u0027project/databases/_detail_overview_%s.html\u0027"},{"line_number":34,"context_line":"                % instance.datastore[\u0027type\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class UserTab(tabs.TableTab):"}],"source_content_type":"text/x-python","patch_set":21,"id":"baada198_60baed0b","line":34,"in_reply_to":"1ae5cdf2_f1fac7b8","updated":"2014-07-08 23:46:17.000000000","message":"Hi Andrew,\n\nOriginally (see patchset #14), I had just one template \"_detail_overview.html\" with inline javascript to handle any supported datastores.  This would cover the case you are bringing up.\n\nBut Robert suggested that we not inline javascript and have a separate html template for each supported datastore.  \n\nFor any nonsupported datastores (e.g. vertica), I am assuming it is up to the provider to add this support (e.g. _detail_overview_veritca.html).\n\nCan you ping Robert?","commit_id":"4197d1947f5f35bcb2835e17edb2fd6712a5bb3d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_template_name(self, request):"},{"line_number":32,"context_line":"        instance \u003d self.tab_group.kwargs[\u0027instance\u0027]"},{"line_number":33,"context_line":"        return (\u0027project/databases/_detail_overview_%s.html\u0027"},{"line_number":34,"context_line":"                % instance.datastore[\u0027type\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class UserTab(tabs.TableTab):"}],"source_content_type":"text/x-python","patch_set":21,"id":"baada198_00713177","line":34,"in_reply_to":"baada198_60baed0b","updated":"2014-07-08 23:47:42.000000000","message":"Actually, scratch that.  I think I know of a way to cover your case.  I\u0027ll submit a new patch set soon.","commit_id":"4197d1947f5f35bcb2835e17edb2fd6712a5bb3d"}],"openstack_dashboard/dashboards/project/databases/templates/databases/_detail_overview.html":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"02cc6c8ca8afaaba7b06cf165a7d252a48c40231","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/dl\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\u003cscript\u003e"},{"line_number":43,"context_line":"  function load(datastore, host)"},{"line_number":44,"context_line":"  {"},{"line_number":45,"context_line":"    if (datastore.toLowerCase() \u003d\u003d \"mysql\") {"}],"source_content_type":"text/html","patch_set":14,"id":"AAAAW3%2F%2FxjQ%3D","line":42,"updated":"2014-04-10 14:03:09.000000000","message":"This is a little crazy, I would not do this with javascipt. I would either make this template a base template then in the view choose _details_overview_(datastore).html or make this section an include {% include \"databases/_details_overview_{{ datastore}}.html %} I\u0027m not quite sure if the latter is possible in Django templates. Either way will make customizing the datastore specific templates much easier than working with inline javascript.","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"6a8982221f39837128dd3b0c1675ac7dd4773f70","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/dl\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\u003cscript\u003e"},{"line_number":43,"context_line":"  function load(datastore, host)"},{"line_number":44,"context_line":"  {"},{"line_number":45,"context_line":"    if (datastore.toLowerCase() \u003d\u003d \"mysql\") {"}],"source_content_type":"text/html","patch_set":14,"id":"AAAAW3%2F%2FZDM%3D","line":42,"in_reply_to":"AAAAW3%2F%2Fsn8%3D","updated":"2014-04-14 22:35:23.000000000","message":"Done","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/dl\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\u003cscript\u003e"},{"line_number":43,"context_line":"  function load(datastore, host)"},{"line_number":44,"context_line":"  {"},{"line_number":45,"context_line":"    if (datastore.toLowerCase() \u003d\u003d \"mysql\") {"}],"source_content_type":"text/html","patch_set":14,"id":"AAAAW3%2F%2Fsn8%3D","line":42,"in_reply_to":"AAAAW3%2F%2Ft2Q%3D","updated":"2014-04-11 03:38:05.000000000","message":"You need to override the get_template_name:\n\nhttps://github.com/openstack/horizon/blob/master/horizon/tabs/base.py#L336\n\nsomething like:\n\n     def get_template_name(self, request):\n        instance \u003d self.tab_group.kwargs[\u0027instance\u0027]\n        return \u0027project/databases/%s_details_overview.html\u0027 % instance.datastore","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"94bb818273023edb39cb146b52d9a82f5d1e7653","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/dl\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\u003cscript\u003e"},{"line_number":43,"context_line":"  function load(datastore, host)"},{"line_number":44,"context_line":"  {"},{"line_number":45,"context_line":"    if (datastore.toLowerCase() \u003d\u003d \"mysql\") {"}],"source_content_type":"text/html","patch_set":14,"id":"AAAAW3%2F%2Ft2Q%3D","line":42,"in_reply_to":"AAAAW3%2F%2FxjQ%3D","updated":"2014-04-10 21:54:18.000000000","message":"Right.  The latter wouldn\u0027t be possible.\n\nFor the first approach, how can I get the datastore?\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/databases/tabs.py#L26-L32","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u003cdt\u003e{% trans \"RAM\" %}\u003c/dt\u003e"},{"line_number":20,"context_line":"        \u003cdd\u003e{{ instance.full_flavor.ram|mbformat }}\u003c/dd\u003e"},{"line_number":21,"context_line":"    \u003c/dl\u003e"},{"line_number":22,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"1ae5cdf2_6ed176cb","line":22,"updated":"2014-06-26 21:03:31.000000000","message":"You need to add the empty block here for the children to extend:\n\n    {% block connection_info %}\n    {% endblock %}","commit_id":"4197d1947f5f35bcb2835e17edb2fd6712a5bb3d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \u003cdd\u003e{{ instance.name }}\u003c/dd\u003e"},{"line_number":11,"context_line":"        \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"        \u003cdd\u003e{{ instance.id }}\u003c/dd\u003e"},{"line_number":13,"context_line":"        \u003cdt\u003e{% trans \"Datastore\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"        \u003cdd\u003e{{ instance.datastore.type }}\u003c/dd\u003e"},{"line_number":15,"context_line":"        \u003cdt\u003e{% trans \"Datastore Version\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"        \u003cdd\u003e{{ instance.datastore.version }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_460de536","line":13,"updated":"2014-07-16 20:12:26.000000000","message":"All new instance will have a datastore since you made it a required field, but how about for old existing instances? Would those instance have a datastore?\n\nIf not, please handle that case.\n\nYou might also need to rebase due to this patch: https://review.openstack.org/106858","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \u003cdd\u003e{{ instance.name }}\u003c/dd\u003e"},{"line_number":11,"context_line":"        \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"        \u003cdd\u003e{{ instance.id }}\u003c/dd\u003e"},{"line_number":13,"context_line":"        \u003cdt\u003e{% trans \"Datastore\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"        \u003cdd\u003e{{ instance.datastore.type }}\u003c/dd\u003e"},{"line_number":15,"context_line":"        \u003cdt\u003e{% trans \"Datastore Version\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"        \u003cdd\u003e{{ instance.datastore.version }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_1c0b3c7e","line":13,"in_reply_to":"baada198_460de536","updated":"2014-07-16 21:28:07.000000000","message":"Old existing instances also already have datastore.type and datastore.version as it exists from Trove API.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"}],"openstack_dashboard/dashboards/project/databases/templates/databases/_detail_overview_cassandra.html":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load i18n sizeformat %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003ch3\u003e{% trans \"Instance Overview\" %}\u003c/h3\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv class\u003d\"status row-fluid detail\"\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"facab960_686d9704","line":2,"updated":"2014-04-28 21:42:47.000000000","message":"Instead of deleting the _detail_overview.html, it should be made a base template. This template should extend that template, since all the Info is repeated in each template. Move the common data to the base and add a block below for the connection info","commit_id":"95aff619ffdc36363cb752da646cf8a9dab55ca5"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"        \u003cdd\u003e{{ instance.full_flavor.ram|mbformat }}\u003c/dd\u003e"},{"line_number":21,"context_line":"    \u003c/dl\u003e"},{"line_number":22,"context_line":"\u003c/div\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\u003cdiv class\u003d\"addresses row-fluid detail\"\u003e"},{"line_number":25,"context_line":"    \u003ch4\u003e{% trans \"Connection Info\" %}\u003c/h4\u003e"},{"line_number":26,"context_line":"    \u003chr class\u003d\"header_rule\"\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"facab960_88401b58","line":23,"updated":"2014-04-28 21:42:47.000000000","message":"{% block connection_info %}","commit_id":"95aff619ffdc36363cb752da646cf8a9dab55ca5"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1361c573aae2bc97b51064ba018bd866e218ecdf","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \u003cdl\u003e"},{"line_number":9,"context_line":"        {% with instance.host as host %}"},{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e{{ host }}\u003c/dd\u003e"},{"line_number":12,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"},{"line_number":13,"context_line":"            \u003cdd\u003e9160\u003c/dd\u003e"},{"line_number":14,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"baada198_9a4a9024","line":11,"updated":"2014-07-03 21:29:06.000000000","message":"This is across all these files, but when \"host\" \u003d \"Not Assigned\"  the following values don\u0027t make sense really.","commit_id":"4060f2ea4e8f33c6e5c251c3375f12a1de66e93d"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":8,"context_line":"    \u003cdl\u003e"},{"line_number":9,"context_line":"        {% with instance.host as host %}"},{"line_number":10,"context_line":"        {% if host !\u003d \"Not Assigned\" %}"},{"line_number":11,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"            \u003cdd\u003e{{ host }}\u003c/dd\u003e"},{"line_number":13,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_29a736a8","line":10,"updated":"2014-07-07 19:42:50.000000000","message":"It looks like everything from lines 4-10 is repeated in the various detail templates.  Maybe those lines should remain in _detail_overview.html and the detail templates could be only the variable part.\n\nAlso, \"Not Assigned\" appears to be translated in views.py.  The check should be as well (and in all of the detail files if they aren\u0027t combined)","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":8,"context_line":"    \u003cdl\u003e"},{"line_number":9,"context_line":"        {% with instance.host as host %}"},{"line_number":10,"context_line":"        {% if host !\u003d \"Not Assigned\" %}"},{"line_number":11,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"            \u003cdd\u003e{{ host }}\u003c/dd\u003e"},{"line_number":13,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_04c6ac49","line":10,"in_reply_to":"baada198_02cc0788","updated":"2014-07-08 20:02:37.000000000","message":"Hmm, I hadn\u0027t realized exactly what this looked like.  I\u0027m not sure I\u0027ve ever had to do this, but I think the relevant example is here:\nhttps://docs.djangoproject.com/en/dev/topics/i18n/translation/#trans-template-tag\n\nand look at the example labelled \"If you’d like to retrieve a translated string without displaying it\"","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":8,"context_line":"    \u003cdl\u003e"},{"line_number":9,"context_line":"        {% with instance.host as host %}"},{"line_number":10,"context_line":"        {% if host !\u003d \"Not Assigned\" %}"},{"line_number":11,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"            \u003cdd\u003e{{ host }}\u003c/dd\u003e"},{"line_number":13,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_f42403b1","line":10,"in_reply_to":"baada198_04c6ac49","updated":"2014-07-08 21:10:36.000000000","message":"Sweet.  That works.  Thanks.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":8,"context_line":"    \u003cdl\u003e"},{"line_number":9,"context_line":"        {% with instance.host as host %}"},{"line_number":10,"context_line":"        {% if host !\u003d \"Not Assigned\" %}"},{"line_number":11,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"            \u003cdd\u003e{{ host }}\u003c/dd\u003e"},{"line_number":13,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_02cc0788","line":10,"in_reply_to":"baada198_29a736a8","updated":"2014-07-07 21:15:30.000000000","message":"How do I translate this in the if check?\n\nHaven\u0027t been able to figure this out.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"9caf8ed06754b68934fa15568b0ef1d89277dab6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":8,"context_line":"    \u003cdl\u003e"},{"line_number":9,"context_line":"        {% with instance.host as host %}"},{"line_number":10,"context_line":"        {% trans \"Not Assigned\" as not_assigned %}"},{"line_number":11,"context_line":"        {% if host !\u003d not_assigned %}"},{"line_number":12,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":13,"context_line":"            \u003cdd\u003e{{ host }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":28,"id":"baada198_01d59742","line":10,"updated":"2014-07-09 18:35:19.000000000","message":"All this handling of a translated Not Assigned seems to be making up for a poor decision in views.py of shoving a translated string into the instance data.  If the value was left as None and translated later where consumed, that would be cleaner.  This is in most cases going to do a translation lookup for a hostname or IP that doesn\u0027t exist in list of translated strings list.\n\nFix https://github.com/openstack/horizon/blob/cc75a0f53c9e9dfe96e108b90e49431a25624d33/openstack_dashboard/dashboards/project/databases/views.py#L44 and things will be a lot cleaner.","commit_id":"64f736e30039ba48ff6e920a3cfec575dd36fecb"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"},{"line_number":18,"context_line":"            \u003cdd\u003e9160\u003c/dd\u003e"},{"line_number":19,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":20,"context_line":"            \u003cdd\u003ecqlsh {{ host }} 9160\u003c/dd\u003e"},{"line_number":21,"context_line":"            {% endif %} \u003c!-- ends else block --\u003e"},{"line_number":22,"context_line":"        {% endwith %}"},{"line_number":23,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"baada198_7d8781b5","line":20,"updated":"2014-07-11 15:15:39.000000000","message":"cqlh works on 9042","commit_id":"e17e1581f955ed0c57316af58e1a7186af19febe"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"},{"line_number":18,"context_line":"            \u003cdd\u003e9160\u003c/dd\u003e"},{"line_number":19,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":20,"context_line":"            \u003cdd\u003ecqlsh {{ host }} 9160\u003c/dd\u003e"},{"line_number":21,"context_line":"            {% endif %} \u003c!-- ends else block --\u003e"},{"line_number":22,"context_line":"        {% endwith %}"},{"line_number":23,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"baada198_c2f06169","line":20,"in_reply_to":"baada198_17f57956","updated":"2014-07-14 21:16:33.000000000","message":"nikhil and michael are correct; unless you\u0027re running a non-standard cassandra install, cqlsh is over 9160.\n\n    $ cqlsh localhost 9160\n    Connected to Test Cluster at localhost:9160.\n    [cqlsh 4.1.1 | Cassandra 2.0.9 | CQL spec 3.1.1 | Thrift protocol 19.39.0]\n    Use HELP for help.\n    cqlsh\u003e exit\n    \n\n    $ cqlsh localhost 9042\n    Traceback (most recent call last):\n      File \"/usr/bin/cqlsh\", line 2084, in \u003cmodule\u003e\n        main(*read_options(sys.argv[1:], os.environ))\n      File \"/usr/bin/cqlsh\", line 2067, in main\n        single_statement\u003doptions.execute)\n      File \"/usr/bin/cqlsh\", line 490, in __init__\n        cql_version\u003dcqlver, transport\u003dtransport)\n      File \"/usr/share/cassandra/lib/cql-internal-only-1.4.1.zip/cql-1.4.1/cql/connection.py\", line 143, in connect\n      File \"/usr/share/cassandra/lib/cql-internal-only-1.4.1.zip/cql-1.4.1/cql/connection.py\", line 59, in __init__\n      File \"/usr/share/cassandra/lib/cql-internal-only-1.4.1.zip/cql-1.4.1/cql/thrifteries.py\", line 159, in establish_connection\n      File \"/usr/share/cassandra/lib/cql-internal-only-1.4.1.zip/cql-1.4.1/cql/cassandra/Cassandra.py\", line 1265, in describe_version\n      File \"/usr/share/cassandra/lib/cql-internal-only-1.4.1.zip/cql-1.4.1/cql/cassandra/Cassandra.py\", line 1275, in recv_describe_version\n      File \"/usr/share/cassandra/lib/thrift-python-internal-only-0.9.1.zip/thrift/protocol/TBinaryProtocol.py\", line 126, in readMessageBegin\n      File \"/usr/share/cassandra/lib/thrift-python-internal-only-0.9.1.zip/thrift/protocol/TBinaryProtocol.py\", line 206, in readI32\n      File \"/usr/share/cassandra/lib/thrift-python-internal-only-0.9.1.zip/thrift/transport/TTransport.py\", line 63, in readAll\n    EOFError\n\nthis is good to merge.","commit_id":"e17e1581f955ed0c57316af58e1a7186af19febe"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"},{"line_number":18,"context_line":"            \u003cdd\u003e9160\u003c/dd\u003e"},{"line_number":19,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":20,"context_line":"            \u003cdd\u003ecqlsh {{ host }} 9160\u003c/dd\u003e"},{"line_number":21,"context_line":"            {% endif %} \u003c!-- ends else block --\u003e"},{"line_number":22,"context_line":"        {% endwith %}"},{"line_number":23,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"baada198_17f57956","line":20,"in_reply_to":"baada198_4497413a","updated":"2014-07-11 18:34:14.000000000","message":"According to these docs, the default port for cqlsh is 9160:\n\nhttps://wiki.apache.org/cassandra/GettingStarted\n\nhttp://www.datastax.com/docs/1.1/dml/using_cql\n\nIf you look at http://www.datastax.com/docs/datastax_enterprise3.1/security/dse_firewall_ports, you\u0027ll find that 9042 is the CQL native client port, but I believe that cqlsh uses 9160, which is the Thrift client port.","commit_id":"e17e1581f955ed0c57316af58e1a7186af19febe"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u003cdt\u003e{% trans \"Database Port\" %}\u003c/dt\u003e"},{"line_number":18,"context_line":"            \u003cdd\u003e9160\u003c/dd\u003e"},{"line_number":19,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":20,"context_line":"            \u003cdd\u003ecqlsh {{ host }} 9160\u003c/dd\u003e"},{"line_number":21,"context_line":"            {% endif %} \u003c!-- ends else block --\u003e"},{"line_number":22,"context_line":"        {% endwith %}"},{"line_number":23,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"baada198_4497413a","line":20,"in_reply_to":"baada198_7d8781b5","updated":"2014-07-11 18:04:44.000000000","message":"Port 9042 does not work for me.\n\nAll the cassandra docs use 9160 as their examples.\n\nhttp://www.datastax.com/documentation/cql/3.0/cql/cql_reference/cqlsh.htmlhttp://www.datastax.com/docs/1.0/dml/using_cql","commit_id":"e17e1581f955ed0c57316af58e1a7186af19febe"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_26aab185","line":1,"updated":"2014-07-16 20:12:26.000000000","message":"should this be extends instead?","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_97b7253a","line":1,"in_reply_to":"baada198_26aab185","updated":"2014-07-16 21:28:07.000000000","message":"Done","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_863c5dc1","line":13,"updated":"2014-07-16 20:12:26.000000000","message":"missing \u003c/dd\u003e here","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_40994678","line":13,"in_reply_to":"baada198_123a43e7","updated":"2014-07-16 22:37:55.000000000","message":"Ah, whoops.  Thanks.  Done.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_123a43e7","line":13,"in_reply_to":"baada198_7c68b821","updated":"2014-07-16 22:17:41.000000000","message":"line #16 is part of the else condition.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_7c68b821","line":13,"in_reply_to":"baada198_863c5dc1","updated":"2014-07-16 21:28:07.000000000","message":"See line #16.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            \u003c/dd\u003e"},{"line_number":15,"context_line":"            {% else %}"},{"line_number":16,"context_line":"                {{ host }}"},{"line_number":17,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":35,"id":"baada198_dd2294a2","line":14,"updated":"2014-07-17 05:26:54.000000000","message":"Michael, I think you are missing \u003cdd\u003e tag before the else statement.","commit_id":"3d7e567449e746dc63f7091be8ca8f20b278ce75"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            \u003c/dd\u003e"},{"line_number":15,"context_line":"            {% else %}"},{"line_number":16,"context_line":"                {{ host }}"},{"line_number":17,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":35,"id":"baada198_4d17a454","line":14,"in_reply_to":"baada198_b2adfb9d","updated":"2014-07-17 13:36:18.000000000","message":"Thank you Lin Hua. Learned something new.","commit_id":"3d7e567449e746dc63f7091be8ca8f20b278ce75"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            \u003c/dd\u003e"},{"line_number":15,"context_line":"            {% else %}"},{"line_number":16,"context_line":"                {{ host }}"},{"line_number":17,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":35,"id":"baada198_b2adfb9d","line":14,"in_reply_to":"baada198_dd2294a2","updated":"2014-07-17 13:04:18.000000000","message":"\u003cdd\u003e tag in line #11 used by both in the if/else statement","commit_id":"3d7e567449e746dc63f7091be8ca8f20b278ce75"}],"openstack_dashboard/dashboards/project/databases/templates/databases/_detail_overview_couchbase.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_66c82957","line":1,"updated":"2014-07-16 20:12:26.000000000","message":"should this be extends instead?","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_7791b199","line":1,"in_reply_to":"baada198_66c82957","updated":"2014-07-16 21:28:07.000000000","message":"Done","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_06784d8e","line":13,"updated":"2014-07-16 20:12:26.000000000","message":"missing \u003c/dd\u003e","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_bc72500f","line":13,"in_reply_to":"baada198_06784d8e","updated":"2014-07-16 21:28:07.000000000","message":"See line #16.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            \u003c/dd\u003e"},{"line_number":15,"context_line":"            {% else %}"},{"line_number":16,"context_line":"                {{ host }}"},{"line_number":17,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":35,"id":"baada198_7d4c2877","line":14,"updated":"2014-07-17 05:26:54.000000000","message":"Same issue with the \u003cdd\u003e tag here","commit_id":"3d7e567449e746dc63f7091be8ca8f20b278ce75"}],"openstack_dashboard/dashboards/project/databases/templates/databases/_detail_overview_mongodb.html":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u003cdd\u003e27017\u003c/dd\u003e"},{"line_number":15,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"            \u003cdd\u003emongo --host {{ host }}\u003c/dd\u003e"},{"line_number":17,"context_line":"            \u003cdd\u003emongodb://[USERNAME:PASSWORD@]{{ host }}:27017/DATABASE\u003c/dd\u003e"},{"line_number":18,"context_line":"        {% endif %}"},{"line_number":19,"context_line":"        {% endwith %}"},{"line_number":20,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_c9fb1abf","line":17,"updated":"2014-07-07 19:42:50.000000000","message":"I wonder if the substitution part of the connection string should be translatable?  I think this is a human based substitution, right?  not picking up some kind of environment variable?  If so, I recommend translation.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u003cdd\u003e27017\u003c/dd\u003e"},{"line_number":15,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"            \u003cdd\u003emongo --host {{ host }}\u003c/dd\u003e"},{"line_number":17,"context_line":"            \u003cdd\u003emongodb://[USERNAME:PASSWORD@]{{ host }}:27017/DATABASE\u003c/dd\u003e"},{"line_number":18,"context_line":"        {% endif %}"},{"line_number":19,"context_line":"        {% endwith %}"},{"line_number":20,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_e298f3c1","line":17,"in_reply_to":"baada198_c9fb1abf","updated":"2014-07-07 21:15:30.000000000","message":"Done","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_a6c24132","line":1,"updated":"2014-07-16 20:12:26.000000000","message":"should this be extends instead?","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_97bc8508","line":1,"in_reply_to":"baada198_a6c24132","updated":"2014-07-16 21:28:07.000000000","message":"Done","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_467245ae","line":13,"updated":"2014-07-16 20:12:26.000000000","message":"\u003c/dd\u003e missing","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_f73a2197","line":13,"in_reply_to":"baada198_467245ae","updated":"2014-07-16 21:28:07.000000000","message":"See line #16.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            \u003c/dd\u003e"},{"line_number":15,"context_line":"            {% else %}"},{"line_number":16,"context_line":"                {{ host }}"},{"line_number":17,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":35,"id":"baada198_bd56c004","line":14,"updated":"2014-07-17 05:26:54.000000000","message":"missing \u003cdd\u003e tag here","commit_id":"3d7e567449e746dc63f7091be8ca8f20b278ce75"}],"openstack_dashboard/dashboards/project/databases/templates/databases/_detail_overview_mysql.html":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u003cdd\u003e3306\u003c/dd\u003e"},{"line_number":15,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"            \u003cdd\u003emysql -h {{ host }} -u USERNAME -p\u003c/dd\u003e"},{"line_number":17,"context_line":"            \u003cdd\u003emysql://USERNAME:PASSWORD@{{ host }}:3306/DATABASE\u003c/dd\u003e"},{"line_number":18,"context_line":"        {% endif %}"},{"line_number":19,"context_line":"        {% endwith %}"},{"line_number":20,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_09c7d264","line":17,"updated":"2014-07-07 19:42:50.000000000","message":"Same username/password comment as previous file.  Also I\u0027d expect the [] brackets here to indicate a substitution is required.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u003cdd\u003e3306\u003c/dd\u003e"},{"line_number":15,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"            \u003cdd\u003emysql -h {{ host }} -u USERNAME -p\u003c/dd\u003e"},{"line_number":17,"context_line":"            \u003cdd\u003emysql://USERNAME:PASSWORD@{{ host }}:3306/DATABASE\u003c/dd\u003e"},{"line_number":18,"context_line":"        {% endif %}"},{"line_number":19,"context_line":"        {% endwith %}"},{"line_number":20,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_82ef371d","line":17,"in_reply_to":"baada198_09c7d264","updated":"2014-07-07 21:15:30.000000000","message":"Done.  Not sure if we want the [] brackets.\n\nSee _detail_overview_mongodb.html.  The [] brackets came straight from the mongodb docs where it means optional.\n\nhttp://api.mongodb.org/java/current/com/mongodb/MongoURI.html\n\nI don\u0027t recall seeing this in the mysql docs.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u003cdd\u003e3306\u003c/dd\u003e"},{"line_number":15,"context_line":"            \u003cdt\u003e{% trans \"Connection Examples\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"            \u003cdd\u003emysql -h {{ host }} -u USERNAME -p\u003c/dd\u003e"},{"line_number":17,"context_line":"            \u003cdd\u003emysql://USERNAME:PASSWORD@{{ host }}:3306/DATABASE\u003c/dd\u003e"},{"line_number":18,"context_line":"        {% endif %}"},{"line_number":19,"context_line":"        {% endwith %}"},{"line_number":20,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":26,"id":"baada198_642be833","line":17,"in_reply_to":"baada198_82ef371d","updated":"2014-07-08 20:02:37.000000000","message":"Yes, I believe you are correct","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_c6bf35a9","line":1,"updated":"2014-07-16 20:12:26.000000000","message":"should this be extends instead?","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_b78b4967","line":1,"in_reply_to":"baada198_c6bf35a9","updated":"2014-07-16 21:28:07.000000000","message":"Done","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_a66081d0","line":13,"updated":"2014-07-16 20:12:26.000000000","message":"missing \u003c/dd\u003e","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_fc63e83e","line":13,"in_reply_to":"baada198_a66081d0","updated":"2014-07-16 21:28:07.000000000","message":"See line #16.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            \u003c/dd\u003e"},{"line_number":15,"context_line":"            {% else %}"},{"line_number":16,"context_line":"                {{ host }}"},{"line_number":17,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":35,"id":"baada198_1d3b2cc9","line":14,"updated":"2014-07-17 05:26:54.000000000","message":"missing \u003cdd\u003e tag?","commit_id":"3d7e567449e746dc63f7091be8ca8f20b278ce75"}],"openstack_dashboard/dashboards/project/databases/templates/databases/_detail_overview_redis.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_e6db591f","line":1,"updated":"2014-07-16 20:12:26.000000000","message":"should this be extends instead?","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% include \"project/databases/_detail_overview.html\" %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block connection_info %}"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_37f739f7","line":1,"in_reply_to":"baada198_e6db591f","updated":"2014-07-16 21:28:07.000000000","message":"Done","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_069f6db5","line":13,"updated":"2014-07-16 20:12:26.000000000","message":"missing \u003c/dd\u003e","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            {% else %}"},{"line_number":15,"context_line":"                {{ host }}"},{"line_number":16,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":32,"id":"baada198_1c597c8e","line":13,"in_reply_to":"baada198_069f6db5","updated":"2014-07-16 21:28:07.000000000","message":"See line #16.","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \u003cdd\u003e"},{"line_number":12,"context_line":"            {% if not host %}"},{"line_number":13,"context_line":"                {% trans \"Not Assigned\" %}"},{"line_number":14,"context_line":"            \u003c/dd\u003e"},{"line_number":15,"context_line":"            {% else %}"},{"line_number":16,"context_line":"                {{ host }}"},{"line_number":17,"context_line":"            \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":35,"id":"baada198_3d4ab055","line":14,"updated":"2014-07-17 05:26:54.000000000","message":"missing \u003cdd\u003e tag","commit_id":"3d7e567449e746dc63f7091be8ca8f20b278ce75"}],"openstack_dashboard/dashboards/project/databases/tests.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":75,"context_line":"        res \u003d self.client.get(INDEX_URL)"},{"line_number":76,"context_line":"        self.assertTemplateUsed(res, \u0027project/databases/index.html\u0027)"},{"line_number":77,"context_line":"        self.assertMessageCount(res, error\u003d1)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @test.create_stubs("},{"line_number":80,"context_line":"        {api.trove: (\u0027instance_list\u0027, \u0027flavor_list\u0027)})"},{"line_number":81,"context_line":"    def test_index_pagination(self):"}],"source_content_type":"text/x-python","patch_set":32,"id":"baada198_2698f169","line":78,"updated":"2014-07-16 20:12:26.000000000","message":"Maybe add a test for opening instance details that doesn\u0027t have datastore?","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":75,"context_line":"        res \u003d self.client.get(INDEX_URL)"},{"line_number":76,"context_line":"        self.assertTemplateUsed(res, \u0027project/databases/index.html\u0027)"},{"line_number":77,"context_line":"        self.assertMessageCount(res, error\u003d1)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @test.create_stubs("},{"line_number":80,"context_line":"        {api.trove: (\u0027instance_list\u0027, \u0027flavor_list\u0027)})"},{"line_number":81,"context_line":"    def test_index_pagination(self):"}],"source_content_type":"text/x-python","patch_set":32,"id":"baada198_f792214a","line":78,"in_reply_to":"baada198_2698f169","updated":"2014-07-16 21:28:07.000000000","message":"Trove API calls for instance has datastore (type and version).\n\ninstance_list returns list of instances, each with its datastore (type and version).\n\ninstance_get returns this instance which has its datastore (type and version).","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"}],"openstack_dashboard/dashboards/project/databases/workflows/create_instance.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"02cc6c8ca8afaaba7b06cf165a7d252a48c40231","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                min_value\u003d0,"},{"line_number":39,"context_line":"                                initial\u003d1,"},{"line_number":40,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":41,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":42,"context_line":"                                  required\u003dTrue,"},{"line_number":43,"context_line":"                                  help_text\u003d_(\"Type of datastore\"),"},{"line_number":44,"context_line":"                                  widget\u003dfields.SelectWidget("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2FxdQ%3D","line":41,"updated":"2014-04-10 14:03:09.000000000","message":"So, I really don\u0027t like this UI, basically two select boxes that the second one is changing always seems wierd. Why can this just be one dropdrown like:\n\n     \u0027mysql - 5.5\u0027\n     \u0027mysql - 5.1\u0027\n     \u0027mongodb - 2.1\u0027\n\nand so on. That might clean up a bunch of your logic below and simplify the UI for the users.","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"6a8982221f39837128dd3b0c1675ac7dd4773f70","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                min_value\u003d0,"},{"line_number":39,"context_line":"                                initial\u003d1,"},{"line_number":40,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":41,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":42,"context_line":"                                  required\u003dTrue,"},{"line_number":43,"context_line":"                                  help_text\u003d_(\"Type of datastore\"),"},{"line_number":44,"context_line":"                                  widget\u003dfields.SelectWidget("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2FZDU%3D","line":41,"in_reply_to":"AAAAW3%2F%2Fshs%3D","updated":"2014-04-14 22:35:23.000000000","message":"Thanks, Robert, for the suggestion and example.\n\nI agree that if the use case is small (i.e. only a few datastore types and versions), one dropdown would be more user friendly.\n\nBut given that it\u0027s up to the service provider (as Auston said), I feel we should account for this (now rather than later) as 2 separate fields (datastore-type, datastore-version).\n\nI tried to make the 2 dropdown approach as user-friendly as possible.  Most of the work on the Javascript frontend where if the service provider only has:\n1) one datastore-type, it will be AUTO selected\n2) one datastore-version for the selected datastore-type, it will be AUTO selected","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                min_value\u003d0,"},{"line_number":39,"context_line":"                                initial\u003d1,"},{"line_number":40,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":41,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":42,"context_line":"                                  required\u003dTrue,"},{"line_number":43,"context_line":"                                  help_text\u003d_(\"Type of datastore\"),"},{"line_number":44,"context_line":"                                  widget\u003dfields.SelectWidget("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2Fshs%3D","line":41,"in_reply_to":"AAAAW3%2F%2FupI%3D","updated":"2014-04-11 03:38:05.000000000","message":"Good point Auston, but I still think this should be one drop down. Instead I suggest using optgroups as the version is the info you want selected you can do that by simply passing a list with named groups. See an example here:\n\nhttps://docs.djangoproject.com/en/1.6/ref/models/fields/#field-choices\n\n     choices \u003d (\n          (\u0027mysql\u0027, \n                 (\u00275.5\u0027, \u00275.5\u0027),\n                 (\u00275.1\u0027, \u00275.1\u0027),\n          ),\n          (\u0027mongodb\u0027,\n                  (\u00272.4.9\u0027, \u00272.4.9\u0027),\n          )\n      )\n\nI would prefer that the first iteration is as simple as possible. I would doubt that many service providers are going to offer every possible combination of datastore and version, that would seem like a nightmare to support. But if that becomes a large issue at that time the UI should evolve to become more complex and responsive.","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e7863826d81dd742022fcea73045e9d564aefa71","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                min_value\u003d0,"},{"line_number":39,"context_line":"                                initial\u003d1,"},{"line_number":40,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":41,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":42,"context_line":"                                  required\u003dTrue,"},{"line_number":43,"context_line":"                                  help_text\u003d_(\"Type of datastore\"),"},{"line_number":44,"context_line":"                                  widget\u003dfields.SelectWidget("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2Furw%3D","line":41,"in_reply_to":"AAAAW3%2F%2FwAg%3D","updated":"2014-04-10 19:28:50.000000000","message":"i think it\u0027s fine.\nhere\u0027s the example: flavors\n\npublic clouds have more like 30 types of flavors, so, it works fine, i don\u0027t think that\u0027s huge list is a the problem","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"7e7eb4c1ae6908efb7233ff9d8968afaa8d9bd2d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                min_value\u003d0,"},{"line_number":39,"context_line":"                                initial\u003d1,"},{"line_number":40,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":41,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":42,"context_line":"                                  required\u003dTrue,"},{"line_number":43,"context_line":"                                  help_text\u003d_(\"Type of datastore\"),"},{"line_number":44,"context_line":"                                  widget\u003dfields.SelectWidget("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2FwAg%3D","line":41,"in_reply_to":"AAAAW3%2F%2FxdQ%3D","updated":"2014-04-10 16:34:57.000000000","message":"I thought about this.  Yes, a single dropdown would make it simpler for the users but only if the list is small.  In the future, as we support more datastore types and more versions for each datastore type, this list will only grow.","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0ccc8e8740277b7d43c9a2bcbec351014c5cb6ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                min_value\u003d0,"},{"line_number":39,"context_line":"                                initial\u003d1,"},{"line_number":40,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":41,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":42,"context_line":"                                  required\u003dTrue,"},{"line_number":43,"context_line":"                                  help_text\u003d_(\"Type of datastore\"),"},{"line_number":44,"context_line":"                                  widget\u003dfields.SelectWidget("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2FxX0%3D","line":41,"in_reply_to":"AAAAW3%2F%2FxdQ%3D","updated":"2014-04-10 14:10:47.000000000","message":"agreed, there could be only one choise field - datastore version, than you can retrieve datastore type by the datastore version and it\u0027s totally ok","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"2b2f55f59ab95e1b429dd877a32dd8db41117fba","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                min_value\u003d0,"},{"line_number":39,"context_line":"                                initial\u003d1,"},{"line_number":40,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":41,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":42,"context_line":"                                  required\u003dTrue,"},{"line_number":43,"context_line":"                                  help_text\u003d_(\"Type of datastore\"),"},{"line_number":44,"context_line":"                                  widget\u003dfields.SelectWidget("}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAW3%2F%2FupI%3D","line":41,"in_reply_to":"AAAAW3%2F%2FxdQ%3D","updated":"2014-04-10 19:37:28.000000000","message":"if we didn\u0027t have datastore and datastore-version as very distinct fields, i\u0027d agreed robert. but, considering it\u0027s up to the provider on how things are categorized:\n\nstyle 1:\n    datastore \u003d\u003e mysql, datastore-version \u003d\u003e 5.5\n    datastore \u003d\u003e mongodb, datastore-version \u003d\u003e 2.4.9\n    ...\n\nstyle 2:\n    datastore \u003d\u003e mysql-5.5, datastore-version \u003d\u003e 5.5.12\n    datastore \u003d\u003e mysql-5.5, datastore-version \u003d\u003e 5.5.15\n    datastore \u003d\u003e mysql-5.6, datastore-version \u003d\u003e 5.6.17\n\nstyle 2:\n    datastore \u003d\u003e rdbms, datastore-version \u003d\u003e mysql-5.5\n    datastore \u003d\u003e rdbms, datastore-version \u003d\u003e mysql-5.6\n    datastore \u003d\u003e rdbms, datastore-version \u003d\u003e postgres 9.2\n    datastore \u003d\u003e nosql, datastore-version \u003d\u003e mongodb-2.4.9\n\netc. etc.\n\nconcatenating the two won\u0027t make sense.","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1361c573aae2bc97b51064ba018bd866e218ecdf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def populate_datastore_choices(self, request, context):"},{"line_number":79,"context_line":"        choices \u003d ()"},{"line_number":80,"context_line":"        datastores \u003d self.datastores(request)"},{"line_number":81,"context_line":"        if datastores is not None and len(datastores) \u003e 1:"},{"line_number":82,"context_line":"            initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":83,"context_line":"                        \u0027--- Select datastore type and version ---\u0027))"},{"line_number":84,"context_line":"            choices \u003d choices + (initial,)"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_ba491462","line":81,"updated":"2014-07-03 21:29:06.000000000","message":"this block of code seems wrong.  You have an is not None check here +1","commit_id":"4060f2ea4e8f33c6e5c251c3375f12a1de66e93d"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1361c573aae2bc97b51064ba018bd866e218ecdf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        choices \u003d ()"},{"line_number":80,"context_line":"        datastores \u003d self.datastores(request)"},{"line_number":81,"context_line":"        if datastores is not None and len(datastores) \u003e 1:"},{"line_number":82,"context_line":"            initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":83,"context_line":"                        \u0027--- Select datastore type and version ---\u0027))"},{"line_number":84,"context_line":"            choices \u003d choices + (initial,)"},{"line_number":85,"context_line":"        for ds in datastores:"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_fa9d4cbd","line":82,"updated":"2014-07-03 21:29:06.000000000","message":"now setting the initial choice","commit_id":"4060f2ea4e8f33c6e5c251c3375f12a1de66e93d"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1361c573aae2bc97b51064ba018bd866e218ecdf","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":83,"context_line":"                        \u0027--- Select datastore type and version ---\u0027))"},{"line_number":84,"context_line":"            choices \u003d choices + (initial,)"},{"line_number":85,"context_line":"        for ds in datastores:"},{"line_number":86,"context_line":"            versions \u003d self.datastore_versions(request, ds.name)"},{"line_number":87,"context_line":"            if len(datastores) \u003d\u003d 1 and len(versions) \u003e 1:"},{"line_number":88,"context_line":"                initial \u003d ((\u0027select_datastore_type_version\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_fa846c5f","line":85,"updated":"2014-07-03 21:29:06.000000000","message":"This is not in the \"is not None\" check which is leaves us open to uncaught exceptions","commit_id":"4060f2ea4e8f33c6e5c251c3375f12a1de66e93d"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1361c573aae2bc97b51064ba018bd866e218ecdf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            choices \u003d choices + (initial,)"},{"line_number":85,"context_line":"        for ds in datastores:"},{"line_number":86,"context_line":"            versions \u003d self.datastore_versions(request, ds.name)"},{"line_number":87,"context_line":"            if len(datastores) \u003d\u003d 1 and len(versions) \u003e 1:"},{"line_number":88,"context_line":"                initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":89,"context_line":"                            \u0027--- Select datastore type and version ---\u0027))"},{"line_number":90,"context_line":"                choices \u003d choices + (initial,)"}],"source_content_type":"text/x-python","patch_set":24,"id":"baada198_faeb8c10","line":87,"updated":"2014-07-03 21:29:06.000000000","message":"setting initial again?","commit_id":"4060f2ea4e8f33c6e5c251c3375f12a1de66e93d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def clean(self):"},{"line_number":45,"context_line":"        if self.data.get(\"datastore\", None) \u003d\u003d \"select_datastore_type_version\":"},{"line_number":46,"context_line":"            msg \u003d _(\"You must select a datastore_type version.\")"},{"line_number":47,"context_line":"            self._errors[\"datastore\"] \u003d self.error_class([msg])"},{"line_number":48,"context_line":"        return self.cleaned_data"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_ac6fd4fa","line":46,"updated":"2014-07-07 22:42:43.000000000","message":"This message could be something similar to the message below for this type: \u0027Please select a datastore type and version\"","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def clean(self):"},{"line_number":45,"context_line":"        if self.data.get(\"datastore\", None) \u003d\u003d \"select_datastore_type_version\":"},{"line_number":46,"context_line":"            msg \u003d _(\"You must select a datastore_type version.\")"},{"line_number":47,"context_line":"            self._errors[\"datastore\"] \u003d self.error_class([msg])"},{"line_number":48,"context_line":"        return self.cleaned_data"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_21d586e4","line":46,"in_reply_to":"baada198_ac6fd4fa","updated":"2014-07-08 00:31:19.000000000","message":"I\u0027m following the precedent set.  See here:\n\nhttps://github.com/openstack/horizon/blob/cc75a0f53c9e9dfe96e108b90e49431a25624d33/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L187\n\nSearch for \"You must\".","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except Exception:"},{"line_number":75,"context_line":"            LOG.exception(\"Exception while obtaining datastore version list\")"},{"line_number":76,"context_line":"            self._datastore_versions \u003d []"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def populate_datastore_choices(self, request, context):"},{"line_number":79,"context_line":"        choices \u003d ()"},{"line_number":80,"context_line":"        datastores \u003d self.datastores(request)"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_fdcb346f","line":77,"updated":"2014-07-07 22:42:43.000000000","message":"Where is this method \u0027populate_datastore_choices\u0027 being called? I might have missed it. Thanks.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except Exception:"},{"line_number":75,"context_line":"            LOG.exception(\"Exception while obtaining datastore version list\")"},{"line_number":76,"context_line":"            self._datastore_versions \u003d []"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def populate_datastore_choices(self, request, context):"},{"line_number":79,"context_line":"        choices \u003d ()"},{"line_number":80,"context_line":"        datastores \u003d self.datastores(request)"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_81e652e6","line":77,"in_reply_to":"baada198_fdcb346f","updated":"2014-07-08 00:31:19.000000000","message":"https://github.com/openstack/horizon/blob/2c4752b98bde9b389e5043d80ffbfb94fd19a9c2/horizon/workflows/base.py#L147-L151","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # More than one datastore type, enforce user to choose"},{"line_number":83,"context_line":"            if len(datastores) \u003e 1:"},{"line_number":84,"context_line":"                initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":85,"context_line":"                            \u0027--- Select datastore type and version ---\u0027))"},{"line_number":86,"context_line":"                choices \u003d choices + (initial,)"},{"line_number":87,"context_line":"            for ds in datastores:"},{"line_number":88,"context_line":"                versions \u003d self.datastore_versions(request, ds.name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_c9b15a48","line":85,"updated":"2014-07-07 19:42:50.000000000","message":"Initial value should be translatable and should not include the \"---\" in the label.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # More than one datastore type, enforce user to choose"},{"line_number":83,"context_line":"            if len(datastores) \u003e 1:"},{"line_number":84,"context_line":"                initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":85,"context_line":"                            \u0027--- Select datastore type and version ---\u0027))"},{"line_number":86,"context_line":"                choices \u003d choices + (initial,)"},{"line_number":87,"context_line":"            for ds in datastores:"},{"line_number":88,"context_line":"                versions \u003d self.datastore_versions(request, ds.name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_9825e65d","line":85,"in_reply_to":"baada198_229e6b63","updated":"2014-07-07 22:42:43.000000000","message":"Cant we just set the \u0027initial\u0027 variable once for len(datastores) \u003e\u003d 1? Also, if there are no datastores available for any reason, do we want to show a default message?","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # More than one datastore type, enforce user to choose"},{"line_number":83,"context_line":"            if len(datastores) \u003e 1:"},{"line_number":84,"context_line":"                initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":85,"context_line":"                            \u0027--- Select datastore type and version ---\u0027))"},{"line_number":86,"context_line":"                choices \u003d choices + (initial,)"},{"line_number":87,"context_line":"            for ds in datastores:"},{"line_number":88,"context_line":"                versions \u003d self.datastore_versions(request, ds.name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_21a746a8","line":85,"in_reply_to":"baada198_9825e65d","updated":"2014-07-08 00:31:19.000000000","message":"No.  If there is only ONE datastore with ONE version, we shouldn\u0027t have this \"initial\" variable.  It should be auto selected in this case.\n\nIf there are no datastores, we don\u0027t want to show a default message.  The purpose of the \"initial\" variable is to enforce the user to choose under the following cases:\n1) at least two datastores\n2) only one datastore with at least two versions","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            # More than one datastore type, enforce user to choose"},{"line_number":83,"context_line":"            if len(datastores) \u003e 1:"},{"line_number":84,"context_line":"                initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":85,"context_line":"                            \u0027--- Select datastore type and version ---\u0027))"},{"line_number":86,"context_line":"                choices \u003d choices + (initial,)"},{"line_number":87,"context_line":"            for ds in datastores:"},{"line_number":88,"context_line":"                versions \u003d self.datastore_versions(request, ds.name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_229e6b63","line":85,"in_reply_to":"baada198_c9b15a48","updated":"2014-07-07 21:16:22.000000000","message":"Done","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"unresolved":false,"context_lines":[{"line_number":90,"context_line":"                # enforce user to choose"},{"line_number":91,"context_line":"                if len(datastores) \u003d\u003d 1 and len(versions) \u003e 1:"},{"line_number":92,"context_line":"                    initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":93,"context_line":"                                \u0027--- Select datastore type and version ---\u0027))"},{"line_number":94,"context_line":"                    choices \u003d choices + (initial,)"},{"line_number":95,"context_line":"                version_choices \u003d ()"},{"line_number":96,"context_line":"                for v in versions:"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_69884e71","line":93,"updated":"2014-07-07 19:42:50.000000000","message":"same as above","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                # enforce user to choose"},{"line_number":91,"context_line":"                if len(datastores) \u003d\u003d 1 and len(versions) \u003e 1:"},{"line_number":92,"context_line":"                    initial \u003d ((\u0027select_datastore_type_version\u0027,"},{"line_number":93,"context_line":"                                \u0027--- Select datastore type and version ---\u0027))"},{"line_number":94,"context_line":"                    choices \u003d choices + (initial,)"},{"line_number":95,"context_line":"                version_choices \u003d ()"},{"line_number":96,"context_line":"                for v in versions:"}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_628b031f","line":93,"in_reply_to":"baada198_69884e71","updated":"2014-07-07 21:16:22.000000000","message":"Done","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def handle(self, request, context):"},{"line_number":310,"context_line":"        try:"},{"line_number":311,"context_line":"            datastore \u003d self.context[\u0027datastore\u0027].split(\u0027,\u0027)[0]"},{"line_number":312,"context_line":"            datastore_version \u003d self.context[\u0027datastore\u0027].split(\u0027,\u0027)[1]"},{"line_number":313,"context_line":"            LOG.info(\"Launching database instance with parameters \""},{"line_number":314,"context_line":"                     \"{name\u003d%s, volume\u003d%s, flavor\u003d%s, \""},{"line_number":315,"context_line":"                     \"datastore\u003d%s, datastore_version\u003d%s, \""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_bda1bc47","line":312,"updated":"2014-07-07 22:42:43.000000000","message":"Can this datastore_version have more than one version. I am looking at the populate_datastore_versions method and the datastore_choices variable. What happens if the version_choices has more than 1 versions. Thanks.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"c7100696fc1659c7f8bca9f2eb4462ecc3653a4b","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def handle(self, request, context):"},{"line_number":310,"context_line":"        try:"},{"line_number":311,"context_line":"            datastore \u003d self.context[\u0027datastore\u0027].split(\u0027,\u0027)[0]"},{"line_number":312,"context_line":"            datastore_version \u003d self.context[\u0027datastore\u0027].split(\u0027,\u0027)[1]"},{"line_number":313,"context_line":"            LOG.info(\"Launching database instance with parameters \""},{"line_number":314,"context_line":"                     \"{name\u003d%s, volume\u003d%s, flavor\u003d%s, \""},{"line_number":315,"context_line":"                     \"datastore\u003d%s, datastore_version\u003d%s, \""}],"source_content_type":"text/x-python","patch_set":26,"id":"baada198_c1ccca6c","line":312,"in_reply_to":"baada198_bda1bc47","updated":"2014-07-08 00:31:19.000000000","message":"This datastore_version is the one selected.","commit_id":"82be3cb1ed535d9dc4a8afa18c9ca035b28a1576"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"9caf8ed06754b68934fa15568b0ef1d89277dab6","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def clean(self):"},{"line_number":45,"context_line":"        if self.data.get(\"datastore\", None) \u003d\u003d \"select_datastore_type_version\":"},{"line_number":46,"context_line":"            msg \u003d _(\"You must select a datastore_type version.\")"},{"line_number":47,"context_line":"            self._errors[\"datastore\"] \u003d self.error_class([msg])"},{"line_number":48,"context_line":"        return self.cleaned_data"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_c6a9f57c","line":46,"updated":"2014-07-09 18:35:19.000000000","message":"The issue in patch 26 is with the underscore not the other wording.","commit_id":"64f736e30039ba48ff6e920a3cfec575dd36fecb"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"9caf8ed06754b68934fa15568b0ef1d89277dab6","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def clean(self):"},{"line_number":45,"context_line":"        if self.data.get(\"datastore\", None) \u003d\u003d \"select_datastore_type_version\":"},{"line_number":46,"context_line":"            msg \u003d _(\"You must select a datastore_type version.\")"},{"line_number":47,"context_line":"            self._errors[\"datastore\"] \u003d self.error_class([msg])"},{"line_number":48,"context_line":"        return self.cleaned_data"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"baada198_57710d76","line":46,"in_reply_to":"baada198_c6a9f57c","updated":"2014-07-09 19:18:11.000000000","message":"underscore in datastore_type","commit_id":"64f736e30039ba48ff6e920a3cfec575dd36fecb"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"                for v in versions:"},{"line_number":97,"context_line":"                    version_choices \u003d (version_choices +"},{"line_number":98,"context_line":"                                       ((ds.name + \u0027,\u0027 + v.name, v.name),))"},{"line_number":99,"context_line":"                datastore_choices \u003d (ds.name, version_choices)"},{"line_number":100,"context_line":"                choices \u003d choices + (datastore_choices,)"},{"line_number":101,"context_line":"        return choices"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"baada198_929e5362","line":99,"updated":"2014-07-09 19:52:22.000000000","message":"Michael,it looks like with this implementation user will be able to select a datastore only if it has 1 or more versions to select from (that is, the version itself is the selectable choice here). In the case where there is a datastore with no version, that datastore will be in the drop down list but wont be selectable. If we want to enforce user to select a datastore with a version, cant we ignore those datastore types without a version and not include/show them in this drop down list? I am not sure where to post a screen capture. Maybe that would help. Thanks.","commit_id":"186c88c5d042270b99f391883fa964fc5de83b97"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"                for v in versions:"},{"line_number":97,"context_line":"                    version_choices \u003d (version_choices +"},{"line_number":98,"context_line":"                                       ((ds.name + \u0027,\u0027 + v.name, v.name),))"},{"line_number":99,"context_line":"                datastore_choices \u003d (ds.name, version_choices)"},{"line_number":100,"context_line":"                choices \u003d choices + (datastore_choices,)"},{"line_number":101,"context_line":"        return choices"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"baada198_66602236","line":99,"in_reply_to":"baada198_929e5362","updated":"2014-07-09 21:05:36.000000000","message":"Good catch.  I completely agree with you.  Look out for a new patchset.","commit_id":"186c88c5d042270b99f391883fa964fc5de83b97"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                initial\u003d1,"},{"line_number":36,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":37,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":38,"context_line":"                                  help_text\u003d_(\"Type and version of datastore\"))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    class Meta:"},{"line_number":41,"context_line":"        name \u003d _(\"Details\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"baada198_46f7a5f5","line":38,"updated":"2014-07-16 20:12:26.000000000","message":"missing period at the end","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                initial\u003d1,"},{"line_number":36,"context_line":"                                help_text\u003d_(\"Size of the volume in GB.\"))"},{"line_number":37,"context_line":"    datastore \u003d forms.ChoiceField(label\u003d_(\"Datastore\"),"},{"line_number":38,"context_line":"                                  help_text\u003d_(\"Type and version of datastore\"))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    class Meta:"},{"line_number":41,"context_line":"        name \u003d _(\"Details\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"baada198_5c521469","line":38,"in_reply_to":"baada198_46f7a5f5","updated":"2014-07-16 21:28:07.000000000","message":"Done","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"}],"openstack_dashboard/test/test_data/trove_data.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"unresolved":false,"context_lines":[{"line_number":151,"context_line":"    datastore1 \u003d datastores.Datastore(datastores.Datastores(None),"},{"line_number":152,"context_line":"                                      DATASTORE_ONE)"},{"line_number":153,"context_line":"    #datastore2 \u003d datastores.Datastore(datastores.Datastores(None),"},{"line_number":154,"context_line":"    #                                  DATASTORE_TWO)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    version1 \u003d datastores.\\"},{"line_number":157,"context_line":"        DatastoreVersion(datastores.DatastoreVersions(None),"}],"source_content_type":"text/x-python","patch_set":32,"id":"baada198_a65321e1","line":154,"updated":"2014-07-16 20:12:26.000000000","message":"Why is this commented out?\n\nif unused, remove and cleanup DATASTORE_TWO too","commit_id":"c5dd8217082ad4b35a15f3935a30ddd72639367d"}],"requirements.txt":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9d37dacf57d49b7b89bf346195e83ad3d1a9e1cf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python-neutronclient\u003e\u003d2.3.4,\u003c3"},{"line_number":20,"context_line":"python-novaclient\u003e\u003d2.16.0"},{"line_number":21,"context_line":"python-swiftclient\u003e\u003d1.6"},{"line_number":22,"context_line":"python-troveclient\u003e\u003d1.0.3"},{"line_number":23,"context_line":"pytz\u003e\u003d2010h"},{"line_number":24,"context_line":"six\u003e\u003d1.5.2"}],"source_content_type":"text/plain","patch_set":8,"id":"AAAAVn%2F%2FERg%3D","side":"PARENT","line":22,"updated":"2014-03-10 08:46:41.000000000","message":"remove troveclient from requirements is a typo, right?","commit_id":"e8e839996a6214269bd74bffd9f46b8107143616"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0ccc8e8740277b7d43c9a2bcbec351014c5cb6ce","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python-neutronclient\u003e\u003d2.3.4,\u003c3"},{"line_number":20,"context_line":"python-novaclient\u003e\u003d2.17.0"},{"line_number":21,"context_line":"python-swiftclient\u003e\u003d1.6"},{"line_number":22,"context_line":"python-troveclient\u003e\u003d1.0.4"},{"line_number":23,"context_line":"pytz\u003e\u003d2010h"},{"line_number":24,"context_line":"six\u003e\u003d1.5.2"}],"source_content_type":"text/plain","patch_set":14,"id":"AAAAW3%2F%2FxW4%3D","line":22,"updated":"2014-04-10 14:10:47.000000000","message":"openstack requirements now has 1.0.3 version, so, it should be updated first","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"93054d49e9719561d9e2aed4773eb0f312c479eb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python-neutronclient\u003e\u003d2.3.4,\u003c3"},{"line_number":20,"context_line":"python-novaclient\u003e\u003d2.17.0"},{"line_number":21,"context_line":"python-swiftclient\u003e\u003d1.6"},{"line_number":22,"context_line":"python-troveclient\u003e\u003d1.0.4"},{"line_number":23,"context_line":"pytz\u003e\u003d2010h"},{"line_number":24,"context_line":"six\u003e\u003d1.5.2"}],"source_content_type":"text/plain","patch_set":14,"id":"AAAAW3%2F%2FteY%3D","line":22,"in_reply_to":"AAAAW3%2F%2Fusc%3D","updated":"2014-04-10 23:22:09.000000000","message":"review denis is referring to: https://review.openstack.org/#/c/86542/","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e7863826d81dd742022fcea73045e9d564aefa71","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python-neutronclient\u003e\u003d2.3.4,\u003c3"},{"line_number":20,"context_line":"python-novaclient\u003e\u003d2.17.0"},{"line_number":21,"context_line":"python-swiftclient\u003e\u003d1.6"},{"line_number":22,"context_line":"python-troveclient\u003e\u003d1.0.4"},{"line_number":23,"context_line":"pytz\u003e\u003d2010h"},{"line_number":24,"context_line":"six\u003e\u003d1.5.2"}],"source_content_type":"text/plain","patch_set":14,"id":"AAAAW3%2F%2Fusc%3D","line":22,"in_reply_to":"AAAAW3%2F%2FwKY%3D","updated":"2014-04-10 19:28:50.000000000","message":"Yes, i know that, but, openstack-requirements still work with 1.0.3, so, review already submitted, please wait until it gets merged\n\ncurrent version - https://github.com/openstack/requirements/blob/master/global-requirements.txt#L94","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"},{"author":{"_account_id":9895,"name":"Michael Yu","email":"michayu@ebaysf.com","username":"michayu"},"change_message_id":"7e7eb4c1ae6908efb7233ff9d8968afaa8d9bd2d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python-neutronclient\u003e\u003d2.3.4,\u003c3"},{"line_number":20,"context_line":"python-novaclient\u003e\u003d2.17.0"},{"line_number":21,"context_line":"python-swiftclient\u003e\u003d1.6"},{"line_number":22,"context_line":"python-troveclient\u003e\u003d1.0.4"},{"line_number":23,"context_line":"pytz\u003e\u003d2010h"},{"line_number":24,"context_line":"six\u003e\u003d1.5.2"}],"source_content_type":"text/plain","patch_set":14,"id":"AAAAW3%2F%2FwKY%3D","line":22,"in_reply_to":"AAAAW3%2F%2FxW4%3D","updated":"2014-04-10 16:34:57.000000000","message":"1.0.4 is required because it has the python-troveclient/troveclient/v1/datastores.py.  This is needed for this Horizon patch, otherwise it won\u0027t work.","commit_id":"3323a2f44c2cc75a003820f67a9629f0dd5d6b9f"}]}
