)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"fa40c65ea27f2a20be3adec881f31eee49b7a36d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"handle missing access_rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we delete the access_rules for keystone_version \u003c 3.13, but we don\u0027t"},{"line_number":10,"context_line":"make the same check in the cleanup method, leading to a KeyError"},{"line_number":11,"context_line":"exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I02e124d90f99d400d8c59bff2c563fdc85e624d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_918e06ce","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":10},"updated":"2020-11-05 10:42:58.000000000","message":"Could you add more detail on what\u0027s the issue and how to reproduce it?","commit_id":"8557469a6198edb9194265513fde9a10e0d87d41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8adbbabab74b883edc2baef570b488b98c30775d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"handle missing access_rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we delete the access_rules for keystone_version \u003c 3.13, but we don\u0027t"},{"line_number":10,"context_line":"make the same check in the cleanup method, leading to a KeyError"},{"line_number":11,"context_line":"exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I02e124d90f99d400d8c59bff2c563fdc85e624d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8fbda2f8_17d6aac8","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":10},"in_reply_to":"1f621f24_918e06ce","updated":"2020-12-23 02:59:54.000000000","message":"keystone API \u003c 3.13 means keystone is from stein or older.\nHorizon master is expected to work with the same release or one older release.\nWe are in Wallaby development and the latest release is Victoria.\nI don\u0027t see any reason we need to consider three or more older releases.","commit_id":"8557469a6198edb9194265513fde9a10e0d87d41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e508cdb6dd2e7e694ce2c9b144bb0ccb5c7e33ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"handle missing access_rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we delete the access_rules for keystone_version \u003c 3.13, but we don\u0027t"},{"line_number":10,"context_line":"make the same check in the cleanup method, leading to a KeyError"},{"line_number":11,"context_line":"exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I02e124d90f99d400d8c59bff2c563fdc85e624d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"edbad802_880abe05","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":10},"in_reply_to":"8fbda2f8_17d6aac8","updated":"2020-12-23 03:08:26.000000000","message":"On second thought, Wallaby with Stein keystone needs to be considered as we check feature availability for at most N-4 releases [1]. Wallaby releases - 4 \u003d Stein release.\nInstead, we need to add an inline comment to explain why KeyError is needed.\n\n\u003e Could you add more detail on what\u0027s the issue and how to reproduce it?\n\nIt can happen when horizon is used with keystone stein (for example during upgrade).\n\n\n[1] https://docs.openstack.org/horizon/latest/contributor/policies/supported-software.html","commit_id":"8557469a6198edb9194265513fde9a10e0d87d41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"569d9a76026b80c6a39585378b1a43608b922505","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"handle missing access_rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we delete the access_rules for keystone_version \u003c 3.13, but we don\u0027t"},{"line_number":10,"context_line":"make the same check in the cleanup method, leading to a KeyError"},{"line_number":11,"context_line":"exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I02e124d90f99d400d8c59bff2c563fdc85e624d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2078a829_04d2c429","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":10},"in_reply_to":"edbad802_880abe05","updated":"2021-03-18 03:53:27.000000000","message":"I added a note in the commit message.","commit_id":"8557469a6198edb9194265513fde9a10e0d87d41"}],"openstack_dashboard/dashboards/identity/application_credentials/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e508cdb6dd2e7e694ce2c9b144bb0ccb5c7e33ea","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        except yaml.YAMLError:"},{"line_number":139,"context_line":"            msg \u003d (_(\u0027Access rules must be a valid JSON or YAML list.\u0027))"},{"line_number":140,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":141,"context_line":"        except KeyError:"},{"line_number":142,"context_line":"            pass"},{"line_number":143,"context_line":"        return cleaned_data"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"059bc896_ac9f69d4","line":141,"updated":"2020-12-23 03:08:26.000000000","message":"It is better to add a comment on why KeyError should be caught from the code maintenance perspective.","commit_id":"8557469a6198edb9194265513fde9a10e0d87d41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2cf120b31d6234d9940ae361ae2553ba10704a3b","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        except yaml.YAMLError:"},{"line_number":139,"context_line":"            msg \u003d (_(\u0027Access rules must be a valid JSON or YAML list.\u0027))"},{"line_number":140,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":141,"context_line":"        except KeyError:"},{"line_number":142,"context_line":"            pass"},{"line_number":143,"context_line":"        return cleaned_data"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e99e6458_bebc3914","line":141,"in_reply_to":"059bc896_ac9f69d4","updated":"2020-12-23 03:12:15.000000000","message":"I think \"if \u0027access_rules\u0027 in cleaned_data\" is clearer than catching KeyError.","commit_id":"8557469a6198edb9194265513fde9a10e0d87d41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"569d9a76026b80c6a39585378b1a43608b922505","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        except yaml.YAMLError:"},{"line_number":139,"context_line":"            msg \u003d (_(\u0027Access rules must be a valid JSON or YAML list.\u0027))"},{"line_number":140,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":141,"context_line":"        except KeyError:"},{"line_number":142,"context_line":"            pass"},{"line_number":143,"context_line":"        return cleaned_data"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"05e9b9ea_6c598886","line":141,"in_reply_to":"e99e6458_bebc3914","updated":"2021-03-18 03:53:27.000000000","message":"I updated the code and also added a comment on keystone API version.","commit_id":"8557469a6198edb9194265513fde9a10e0d87d41"}]}