)]}'
{"horizon/static/framework/util/navigations/navigations.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5bfa17f13d1f50e89c5d8333ab30b9db527685eb","unresolved":true,"context_lines":[{"line_number":112,"context_line":"    function setAbsoluteURI(webroot, url) {"},{"line_number":113,"context_line":"      if (webroot.endsWith(\"/\") \u0026\u0026 url.startsWith(\"/\")) {"},{"line_number":114,"context_line":"        webroot \u003d webroot.slice(0, -1);"},{"line_number":115,"context_line":"      }"},{"line_number":116,"context_line":"      return webroot + url;"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"0eb29e60_dcc466d6","line":115,"updated":"2020-12-03 07:10:22.000000000","message":"Do we need to consider a case where webroot does not end with / and url does not start with / ?\nThis is the only case the logic here does not cover.","commit_id":"f7442851c4b85a6a091635f0930c07dbd43cf8fb"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"136daf39c6b978808691e372798410caf0508ae3","unresolved":true,"context_lines":[{"line_number":112,"context_line":"    function setAbsoluteURI(webroot, url) {"},{"line_number":113,"context_line":"      if (webroot.endsWith(\"/\") \u0026\u0026 url.startsWith(\"/\")) {"},{"line_number":114,"context_line":"        webroot \u003d webroot.slice(0, -1);"},{"line_number":115,"context_line":"      }"},{"line_number":116,"context_line":"      return webroot + url;"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"aedec62f_bc6dd717","line":115,"in_reply_to":"0eb29e60_dcc466d6","updated":"2020-12-03 19:03:35.000000000","message":"Not likely. If for some reason WEBROOT doesn\u0027t ends with \"/\", we will encounter more problems in our way to ngdetails page, for example login url is defined as WEBROOT + \u0027auth/login/\u0027. I guess I could even just check if url starts with \u0027/\u0027, but I wanted to keep consistency with https://opendev.org/openstack/horizon/src/branch/master/openstack_auth/utils.py#L139-L145","commit_id":"f7442851c4b85a6a091635f0930c07dbd43cf8fb"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"1f51d086d36a80ab594907a30cc6dda46a0ee642","unresolved":true,"context_lines":[{"line_number":112,"context_line":"    function setAbsoluteURI(webroot, url) {"},{"line_number":113,"context_line":"      if (webroot.endsWith(\"/\") \u0026\u0026 url.startsWith(\"/\")) {"},{"line_number":114,"context_line":"        webroot \u003d webroot.slice(0, -1);"},{"line_number":115,"context_line":"      }"},{"line_number":116,"context_line":"      return webroot + url;"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"ad9261b3_4f26c217","line":115,"in_reply_to":"43c2ffbf_93c21682","updated":"2020-12-07 17:39:45.000000000","message":"Thanks for your review!\n\nYes, we have WEBROOT section in settings.rst and the line \n\"For example, if you\u0027re accessing the Dashboard via https://\u003cyour server\u003e/dashboard, you would set this to \"/dashboard/\".\" \nmore or less tells us that we need to end WEBROOT with \"/\" but we could indeed add a clear note on this.","commit_id":"f7442851c4b85a6a091635f0930c07dbd43cf8fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d83c8878d0cca743cbaeeebe24f036d7000f6bd8","unresolved":true,"context_lines":[{"line_number":112,"context_line":"    function setAbsoluteURI(webroot, url) {"},{"line_number":113,"context_line":"      if (webroot.endsWith(\"/\") \u0026\u0026 url.startsWith(\"/\")) {"},{"line_number":114,"context_line":"        webroot \u003d webroot.slice(0, -1);"},{"line_number":115,"context_line":"      }"},{"line_number":116,"context_line":"      return webroot + url;"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"43c2ffbf_93c21682","line":115,"in_reply_to":"aedec62f_bc6dd717","updated":"2020-12-07 14:50:09.000000000","message":"Thanks for checking it in detail. It sounds reasonable.\n\nLooking at our codebase, it looks like WEBROOT is expected to end with \u0027/\u0027, but it is not documented in the settings reference. It looks better to add a note on this. This is a separate topic of course.","commit_id":"f7442851c4b85a6a091635f0930c07dbd43cf8fb"}]}