)]}'
{"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/keypair.controller.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7f5f9710185fd305dbf604dda2446ba9b081c1b","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    ctrl.setAdminPassword \u003d false;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    ctrl.adminPassError \u003d gettext(\u0027The password does not meet the requirements.\u0027);"},{"line_number":112,"context_line":"    ctrl.adminPassConfError \u003d gettext(\u0027Passwords do not match.\u0027);"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    //////////"}],"source_content_type":"text/javascript","patch_set":3,"id":"b283e3ec_8cf973cf","line":111,"updated":"2021-01-19 02:16:09.000000000","message":"question: The message says \"does not meet the requiremens\". Where is the password requirements validated?","commit_id":"0d7f50c805657af1828f15ca262b69fe637f9497"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"c9c5d536a77f7fffa5eff9f04bddf32a92bf7194","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    ctrl.setAdminPassword \u003d false;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    ctrl.adminPassError \u003d gettext(\u0027The password does not meet the requirements.\u0027);"},{"line_number":112,"context_line":"    ctrl.adminPassConfError \u003d gettext(\u0027Passwords do not match.\u0027);"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    //////////"}],"source_content_type":"text/javascript","patch_set":3,"id":"dcbd563c_ee1e0ba1","line":111,"in_reply_to":"b283e3ec_8cf973cf","updated":"2021-01-21 23:47:47.000000000","message":"Thanks! The validator for old Launch Instance dialog is set to \".*\" in HORIZON_CONFIG. I am not sure yet what is the most elegant way to forward it to angular part. I\u0027ll set it directly as password pattern at keypair.html for now. Do you have any suggestions? We could set it at defaults.py along with OPENSTACK_HYPERVISOR_FEATURES for example or at _conf.html along with other HORIZON_CONFIG settings.","commit_id":"0d7f50c805657af1828f15ca262b69fe637f9497"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dd240568aaa48c25e8b66a2a1bd776ac364cc644","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    ctrl.setAdminPassword \u003d false;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    ctrl.adminPassError \u003d gettext(\u0027The password does not meet the requirements.\u0027);"},{"line_number":112,"context_line":"    ctrl.adminPassConfError \u003d gettext(\u0027Passwords do not match.\u0027);"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    //////////"}],"source_content_type":"text/javascript","patch_set":3,"id":"ebb99d65_9d8a8ca3","line":111,"in_reply_to":"dcbd563c_ee1e0ba1","updated":"2021-01-22 03:15:50.000000000","message":"What is the default expexted pattern if we don\u0027t specify \"pattern\"? If it accepts any pattern, we don\u0027t need to specify \"pattern\" as you do in patch set 4.\n\nRegarding the admin password form we are talking about now, I think we can accept any string as it looks like the nova API accepts any string in adminPass. If nova applies any restriction on admin password, it can be done in the nova side and horizon can just forward the input to nova.\n\nIMHO we don\u0027t need to make the pattern configurable.\n\nDoes it answer to your question?","commit_id":"0d7f50c805657af1828f15ca262b69fe637f9497"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"381a79893b28b9abeeaa4089b44c669c9e69f3ef","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    ctrl.setAdminPassword \u003d false;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    ctrl.adminPassError \u003d gettext(\u0027The password does not meet the requirements.\u0027);"},{"line_number":112,"context_line":"    ctrl.adminPassConfError \u003d gettext(\u0027Passwords do not match.\u0027);"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    //////////"}],"source_content_type":"text/javascript","patch_set":3,"id":"d0e7f7c6_c6cb62d5","line":111,"in_reply_to":"ebb99d65_9d8a8ca3","updated":"2021-01-22 16:24:52.000000000","message":"Yes, thank you. I\u0027ll remove this message since we\u0027re not using it anyway.","commit_id":"0d7f50c805657af1828f15ca262b69fe637f9497"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/keypair.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dd240568aaa48c25e8b66a2a1bd776ac364cc644","unresolved":true,"context_lines":[{"line_number":55,"context_line":"                       name\u003d\"adminPassword\""},{"line_number":56,"context_line":"                       ng-model\u003d\"model.newInstanceSpec.admin_pass\""},{"line_number":57,"context_line":"                       type\u003d\"password\""},{"line_number":58,"context_line":"                       pattern\u003d\".*\"\u003e"},{"line_number":59,"context_line":"              \u003c/div\u003e"},{"line_number":60,"context_line":"            \u003c/div\u003e"},{"line_number":61,"context_line":""}],"source_content_type":"text/html","patch_set":4,"id":"f7a25ef2_35add6ee","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":35},"updated":"2021-01-22 03:15:50.000000000","message":"What is the default? If the default is \".*\", it means we don\u0027t need to specify it explicitly.","commit_id":"0500f00510572c591119d6d9cd153fe8dceb7db0"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"381a79893b28b9abeeaa4089b44c669c9e69f3ef","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       name\u003d\"adminPassword\""},{"line_number":56,"context_line":"                       ng-model\u003d\"model.newInstanceSpec.admin_pass\""},{"line_number":57,"context_line":"                       type\u003d\"password\""},{"line_number":58,"context_line":"                       pattern\u003d\".*\"\u003e"},{"line_number":59,"context_line":"              \u003c/div\u003e"},{"line_number":60,"context_line":"            \u003c/div\u003e"},{"line_number":61,"context_line":""}],"source_content_type":"text/html","patch_set":4,"id":"b65f87f2_0c0a0955","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":35},"in_reply_to":"f7a25ef2_35add6ee","updated":"2021-01-22 16:24:52.000000000","message":"It is \".*\". My intention was to mark a placeholder here, but I agree, it doesn\u0027t make much sense now.","commit_id":"0500f00510572c591119d6d9cd153fe8dceb7db0"}]}