)]}'
{"openstack_dashboard/dashboards/admin/networks/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6728be6ecad93461fea2ebbc6f536bf52325cce","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, min_value\u003d68,"},{"line_number":152,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":153,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":154,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @classmethod"},{"line_number":157,"context_line":"    def _instantiate(cls, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2287f715_12ff91f7","line":154,"updated":"2021-01-19 00:06:38.000000000","message":"See my comments for the help text in project/networks/workflows.py.","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"246473c54de9a1726fe8dd60ed18ed9f9ee1099d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, min_value\u003d68,"},{"line_number":152,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":153,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":154,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @classmethod"},{"line_number":157,"context_line":"    def _instantiate(cls, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"16face3b_9fa0fe44","line":154,"in_reply_to":"2287f715_12ff91f7","updated":"2021-01-19 19:38:47.000000000","message":"Done","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6728be6ecad93461fea2ebbc6f536bf52325cce","unresolved":true,"context_lines":[{"line_number":289,"context_line":"                        data[\u0027segmentation_id\u0027])"},{"line_number":290,"context_line":"            if \u0027az_hints\u0027 in data and data[\u0027az_hints\u0027]:"},{"line_number":291,"context_line":"                params[\u0027availability_zone_hints\u0027] \u003d data[\u0027az_hints\u0027]"},{"line_number":292,"context_line":"            if \u0027mtu\u0027 in data and data[\u0027mtu\u0027]:"},{"line_number":293,"context_line":"                params[\u0027mtu\u0027] \u003d data[\u0027mtu\u0027]"},{"line_number":294,"context_line":"            network \u003d api.neutron.network_create(request, **params)"},{"line_number":295,"context_line":"            LOG.debug(\u0027Network %s was successfully created.\u0027, data[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"238f631e_bf2b008c","line":292,"range":{"start_line":292,"start_character":15,"end_line":292,"end_character":28},"updated":"2021-01-19 00:06:38.000000000","message":"See my comment in project/networks/workflows.py.","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"246473c54de9a1726fe8dd60ed18ed9f9ee1099d","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                        data[\u0027segmentation_id\u0027])"},{"line_number":290,"context_line":"            if \u0027az_hints\u0027 in data and data[\u0027az_hints\u0027]:"},{"line_number":291,"context_line":"                params[\u0027availability_zone_hints\u0027] \u003d data[\u0027az_hints\u0027]"},{"line_number":292,"context_line":"            if \u0027mtu\u0027 in data and data[\u0027mtu\u0027]:"},{"line_number":293,"context_line":"                params[\u0027mtu\u0027] \u003d data[\u0027mtu\u0027]"},{"line_number":294,"context_line":"            network \u003d api.neutron.network_create(request, **params)"},{"line_number":295,"context_line":"            LOG.debug(\u0027Network %s was successfully created.\u0027, data[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"603c6151_0ceaa4b3","line":292,"range":{"start_line":292,"start_character":15,"end_line":292,"end_character":28},"in_reply_to":"238f631e_bf2b008c","updated":"2021-01-19 19:38:47.000000000","message":"Done","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"}],"openstack_dashboard/dashboards/project/networks/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cef3a554a4fc998db86a36187db8feb7deee7f3b","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                    \"scheduled. Leaving this unset is equivalent to \""},{"line_number":67,"context_line":"                    \"selecting all availability zones\"))"},{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, initial\u003d1500,"},{"line_number":70,"context_line":"        min_value\u003d68, max_value\u003d2147483647,"},{"line_number":71,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":72,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"2944da34_ba7420aa","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":53},"updated":"2021-01-15 07:11:37.000000000","message":"It varies depending on deployment situations. For example, in my devstack env on a baremetal with vxlan, the default MTU is 1450, so I cannot create a network without changing the value.\n\nMy suggestion is to accept a blank as MTU which lets neutron decide the default MTU value.\nFrom the implementation perspective, if \u0027mtu\u0027 is blank, \u0027mtu\u0027 is not specified in \"params\" below.","commit_id":"b879d5828c73d7f544ccf94eb040350be5127f1e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cfffeee2e839db52e97147d1becdda79f3950cbd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    \"scheduled. Leaving this unset is equivalent to \""},{"line_number":67,"context_line":"                    \"selecting all availability zones\"))"},{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, initial\u003d1500,"},{"line_number":70,"context_line":"        min_value\u003d68, max_value\u003d2147483647,"},{"line_number":71,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":72,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"eb1d913e_d6e7c2a0","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":53},"in_reply_to":"2944da34_ba7420aa","updated":"2021-01-15 17:02:40.000000000","message":"Yeah, I\u0027ve thought about it, thanks! Also accepting a blank field will reduce test changes too.","commit_id":"b879d5828c73d7f544ccf94eb040350be5127f1e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cef3a554a4fc998db86a36187db8feb7deee7f3b","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                    \"selecting all availability zones\"))"},{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, initial\u003d1500,"},{"line_number":70,"context_line":"        min_value\u003d68, max_value\u003d2147483647,"},{"line_number":71,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":72,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":73,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"61c89295_0a86589d","line":70,"range":{"start_line":70,"start_character":22,"end_line":70,"end_character":43},"updated":"2021-01-15 07:11:37.000000000","message":"Is this needed? MTU 2GB is not realistic. Deployments have specific max values per network technologies and network configurations and the values would be much smaller than this value (2147483647)","commit_id":"b879d5828c73d7f544ccf94eb040350be5127f1e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6728be6ecad93461fea2ebbc6f536bf52325cce","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                    \"selecting all availability zones\"))"},{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, initial\u003d1500,"},{"line_number":70,"context_line":"        min_value\u003d68, max_value\u003d2147483647,"},{"line_number":71,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":72,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":73,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9138d13f_c7a3ce85","line":70,"range":{"start_line":70,"start_character":22,"end_line":70,"end_character":43},"in_reply_to":"1ead0bcf_5418ab02","updated":"2021-01-19 00:06:38.000000000","message":"NOTE: 4GB is just a theoretical maximum value in IPv6, so there is no practical reason we should set the max value here.\n\nThe similar thing can be applied to the min value. The min value is different depending on which IP version (IPv4 vs IPv6). IPv6 requires 1280 bytes. I think we can defer more strict check to neutron API. Let\u0027s keep 68 as it is true at least for IPv4.","commit_id":"b879d5828c73d7f544ccf94eb040350be5127f1e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cfffeee2e839db52e97147d1becdda79f3950cbd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                    \"selecting all availability zones\"))"},{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, initial\u003d1500,"},{"line_number":70,"context_line":"        min_value\u003d68, max_value\u003d2147483647,"},{"line_number":71,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":72,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":73,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ead0bcf_5418ab02","line":70,"range":{"start_line":70,"start_character":22,"end_line":70,"end_character":43},"in_reply_to":"61c89295_0a86589d","updated":"2021-01-15 17:02:40.000000000","message":"There\u0027s a note about even 4GB here: https://bugs.launchpad.net/neutron/+bug/1859362. But I agree, we do not need this cap it in Horizon. Thank you for your review!","commit_id":"b879d5828c73d7f544ccf94eb040350be5127f1e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6728be6ecad93461fea2ebbc6f536bf52325cce","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                    \"selecting all availability zones\"))"},{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, min_value\u003d68,"},{"line_number":70,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":71,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":72,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9204d76c_dce2cf56","line":70,"range":{"start_line":70,"start_character":52,"end_line":70,"end_character":70},"updated":"2021-01-19 00:06:38.000000000","message":"MTU is not for connection. This controls the max packet size the nwtwork created can be forwarded. Could you consider rephrasing it to something more appropriate?","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"246473c54de9a1726fe8dd60ed18ed9f9ee1099d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                    \"selecting all availability zones\"))"},{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, min_value\u003d68,"},{"line_number":70,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":71,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":72,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf9b5ddd_5a41533b","line":70,"range":{"start_line":70,"start_character":52,"end_line":70,"end_character":70},"in_reply_to":"9204d76c_dce2cf56","updated":"2021-01-19 19:38:47.000000000","message":"Done","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6728be6ecad93461fea2ebbc6f536bf52325cce","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, min_value\u003d68,"},{"line_number":70,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":71,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":72,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4dc82141_eb4957b0","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":53},"updated":"2021-01-19 00:06:38.000000000","message":"Is \"local\" necessary? If so what does \"local\" mean?","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"246473c54de9a1726fe8dd60ed18ed9f9ee1099d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    mtu \u003d forms.IntegerField("},{"line_number":69,"context_line":"        label\u003d_(\"MTU\"), required\u003dFalse, min_value\u003d68,"},{"line_number":70,"context_line":"        help_text\u003d_(\"Maximum Transmission Unit size for the connection. \""},{"line_number":71,"context_line":"                    \"Minimum is 68 bytes if the local subnet is IPv4. \""},{"line_number":72,"context_line":"                    \"Minimum is 1280 bytes if the local subnet is IPv6.\"))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"601a5c51_ab5f1f1f","line":71,"range":{"start_line":71,"start_character":48,"end_line":71,"end_character":53},"in_reply_to":"4dc82141_eb4957b0","updated":"2021-01-19 19:38:47.000000000","message":"Quite confusing indeed.","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c6728be6ecad93461fea2ebbc6f536bf52325cce","unresolved":true,"context_lines":[{"line_number":490,"context_line":"                      \u0027shared\u0027: data[\u0027shared\u0027]}"},{"line_number":491,"context_line":"            if \u0027az_hints\u0027 in data and data[\u0027az_hints\u0027]:"},{"line_number":492,"context_line":"                params[\u0027availability_zone_hints\u0027] \u003d data[\u0027az_hints\u0027]"},{"line_number":493,"context_line":"            if \u0027mtu\u0027 in data and data[\u0027mtu\u0027]:"},{"line_number":494,"context_line":"                params[\u0027mtu\u0027] \u003d data[\u0027mtu\u0027]"},{"line_number":495,"context_line":"            network \u003d api.neutron.network_create(request, **params)"},{"line_number":496,"context_line":"            self.context[\u0027net_id\u0027] \u003d network.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"4bce4fa0_054d4872","line":493,"range":{"start_line":493,"start_character":15,"end_line":493,"end_character":28},"updated":"2021-01-19 00:06:38.000000000","message":"This is unnecessary. I think you use the same pattern for az_hints, but az_hints is a conditional field (L.78-90) but mtu is not.","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"246473c54de9a1726fe8dd60ed18ed9f9ee1099d","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                      \u0027shared\u0027: data[\u0027shared\u0027]}"},{"line_number":491,"context_line":"            if \u0027az_hints\u0027 in data and data[\u0027az_hints\u0027]:"},{"line_number":492,"context_line":"                params[\u0027availability_zone_hints\u0027] \u003d data[\u0027az_hints\u0027]"},{"line_number":493,"context_line":"            if \u0027mtu\u0027 in data and data[\u0027mtu\u0027]:"},{"line_number":494,"context_line":"                params[\u0027mtu\u0027] \u003d data[\u0027mtu\u0027]"},{"line_number":495,"context_line":"            network \u003d api.neutron.network_create(request, **params)"},{"line_number":496,"context_line":"            self.context[\u0027net_id\u0027] \u003d network.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"2f8221c1_40c4ff30","line":493,"range":{"start_line":493,"start_character":15,"end_line":493,"end_character":28},"in_reply_to":"4bce4fa0_054d4872","updated":"2021-01-19 19:38:47.000000000","message":"Done","commit_id":"5bebe6d61d982b21ce3caa204529902dabaa02d8"}]}