)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5cc8f4ad4eb334cad98c2850dc15e0b23bb7f4dc","unresolved":true,"context_lines":[{"line_number":10,"context_line":"were moved to \u0027collections.abc\u0027 in 3.3. The aliases will be"},{"line_number":11,"context_line":"removed in 3.10 [1]. So this patch import abc from"},{"line_number":12,"context_line":"collections.abc in those files where abc is directly imported"},{"line_number":13,"context_line":"from collection before."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://docs.python.org/3/library/collections.abc.html"},{"line_number":16,"context_line":"Change-Id: I173f4d647474c21c5d062280bd5703edffb4978e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f173be89_ad25831d","line":13,"updated":"2021-02-12 04:04:22.000000000","message":"Could you udpate the commit message to highlight what is changed more clearly?\nWe already use collections.abc.XXX so \"Switch to collections.abc.*\" is not appropriate.\nIn my understanding, \"import collections\" does not enable \"collections.abc.*\" and we need to import \"collections.abc\" explicitly. I think this is the main point of the change but this is not mentioend anywhere in the commit message.","commit_id":"8f287aa71dbc73f2e332c965b656929f8190468c"}],"horizon/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"457691c6d681fba5855f9b2155522da0b9c0b833","unresolved":true,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import collections"},{"line_number":24,"context_line":"from collections import abc"},{"line_number":25,"context_line":"import copy"},{"line_number":26,"context_line":"from importlib import import_module"},{"line_number":27,"context_line":"import inspect"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbe6b75_3113340a","line":24,"updated":"2021-02-18 01:59:16.000000000","message":"I prefer to \"import collections.abc\" over the proposed one because python has \u0027abc\" class. We already use \"Import collections.abc\" in openstack_dashboard/api/base.py and neutron.py. Thought?","commit_id":"5cc930627d1489e02224e7f63779c8835273409c"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"37a2ada29b0541ac6f98e871fe8f5a4e13f45692","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import collections"},{"line_number":24,"context_line":"from collections import abc"},{"line_number":25,"context_line":"import copy"},{"line_number":26,"context_line":"from importlib import import_module"},{"line_number":27,"context_line":"import inspect"}],"source_content_type":"text/x-python","patch_set":4,"id":"97a56a23_5d929fe1","line":24,"in_reply_to":"b851cf6b_092dc1cd","updated":"2021-03-04 18:48:48.000000000","message":"Done.","commit_id":"5cc930627d1489e02224e7f63779c8835273409c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4cc5439e043b869c9dcc968f7f2f2652d8086bfb","unresolved":true,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import collections"},{"line_number":24,"context_line":"from collections import abc"},{"line_number":25,"context_line":"import copy"},{"line_number":26,"context_line":"from importlib import import_module"},{"line_number":27,"context_line":"import inspect"}],"source_content_type":"text/x-python","patch_set":4,"id":"b851cf6b_092dc1cd","line":24,"in_reply_to":"dfbe6b75_3113340a","updated":"2021-03-04 14:52:10.000000000","message":"I agree, it does look better and requires fewer changes.","commit_id":"5cc930627d1489e02224e7f63779c8835273409c"}],"horizon/tables/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1426a00028734264ae163ac78d734fc00336af30","unresolved":true,"context_lines":[{"line_number":395,"context_line":"        if callable(self.transform):"},{"line_number":396,"context_line":"            data \u003d self.transform(datum)"},{"line_number":397,"context_line":"        # Dict lookups"},{"line_number":398,"context_line":"        elif (isinstance(datum, collections.abc.Mapping) and"},{"line_number":399,"context_line":"              self.transform in datum):"},{"line_number":400,"context_line":"            data \u003d datum.get(self.transform)"},{"line_number":401,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"50a8f838_ece31f95","side":"PARENT","line":398,"range":{"start_line":398,"start_character":32,"end_line":398,"end_character":47},"updated":"2021-02-10 12:01:10.000000000","message":"Personally collections.abc.XXX is easier to understand than abc.XXX. Do we need to drop \"collections.\" perfix. The code already uses collectionbs.abc and it looks like a style change. This is not a fix of deprecation warning.","commit_id":"944902c5c268fc1c287fb0a59f85e4c6674a7fb6"}]}