)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e4eeb0983692af03c5ecb0b3e7821a2d3fcb239e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"used in django-pyscss. It also add six in requirements.txt"},{"line_number":12,"context_line":"as we use six module for this workaround."},{"line_number":13,"context_line":"This is just to run horizon for testing with Django 3.0+."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If79289b7518dd8eaf292a90d6fb790beb154cb7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4fd9c572_7be90800","line":14,"updated":"2021-09-16 06:55:40.000000000","message":"It would be nice to mention the reason that six is re-added to requirements.txt","commit_id":"134723c9d246fcdb21e3cb2ac66f5cbabfc796ec"}],"horizon/test/django_pyscss_fix/__init__.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a9286903b1a5030013c9998759ca9fbdc2ed0b7f","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import six"},{"line_number":16,"context_line":"import six.moves"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Temporary workaround for a situation that django-pyscss depends on"},{"line_number":19,"context_line":"# a vendored version of six, django.utils.six which was dropped in Django 3.0."},{"line_number":20,"context_line":"# TODO(amotoki): Drop the workaround once django-pyscss supports Django 3.0+."}],"source_content_type":"text/x-python","patch_set":2,"id":"20aadb30_fa3059cb","line":17,"updated":"2021-02-26 09:51:06.000000000","message":"At least Django version check is required here.","commit_id":"521a0b2057653c2a3466da289e225d141ae37726"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"cac0ad3e0141e0ce3c1fe441343d48835e272343","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import six"},{"line_number":16,"context_line":"import six.moves"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Temporary workaround for a situation that django-pyscss depends on"},{"line_number":19,"context_line":"# a vendored version of six, django.utils.six which was dropped in Django 3.0."},{"line_number":20,"context_line":"# TODO(amotoki): Drop the workaround once django-pyscss supports Django 3.0+."}],"source_content_type":"text/x-python","patch_set":2,"id":"cd6bca52_a21cbf41","line":17,"in_reply_to":"20aadb30_fa3059cb","updated":"2021-09-15 19:21:51.000000000","message":"Done.","commit_id":"521a0b2057653c2a3466da289e225d141ae37726"}],"openstack_dashboard/django_pyscss_fix/__init__.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8f14a325edd795727e43811fbd320ced6ae78b38","unresolved":true,"context_lines":[{"line_number":14,"context_line":"import os"},{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"import six.moves"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from django.conf import settings"}],"source_content_type":"text/x-python","patch_set":2,"id":"b3a4dab5_47eaed27","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"updated":"2021-09-15 15:26:28.000000000","message":"This requires \"six\" is installed. We dropped six from requirements.txt, so six needs to be re-added to clarify we needs \"six\".","commit_id":"521a0b2057653c2a3466da289e225d141ae37726"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"cac0ad3e0141e0ce3c1fe441343d48835e272343","unresolved":true,"context_lines":[{"line_number":14,"context_line":"import os"},{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"import six.moves"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from django.conf import settings"}],"source_content_type":"text/x-python","patch_set":2,"id":"165e0f44_39b91292","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"in_reply_to":"b3a4dab5_47eaed27","updated":"2021-09-15 19:21:51.000000000","message":"Done.","commit_id":"521a0b2057653c2a3466da289e225d141ae37726"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a9286903b1a5030013c9998759ca9fbdc2ed0b7f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import six.moves"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from django.conf import settings"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Temporary workaround for a situation that django-pyscss depends on"},{"line_number":23,"context_line":"# a vendored version of six, django.utils.six which was dropped in Django 3.0."},{"line_number":24,"context_line":"# TODO(amotoki): Drop the workaround once django-pyscss supports Django 3.0+."}],"source_content_type":"text/x-python","patch_set":2,"id":"0b30c37e_863322c1","line":21,"updated":"2021-02-26 09:51:06.000000000","message":"Django version check is required.","commit_id":"521a0b2057653c2a3466da289e225d141ae37726"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6ee1d0db497bd0bad9d10b302d21142a20e6df7b","unresolved":true,"context_lines":[{"line_number":25,"context_line":"# TODO(amotoki): Drop the workaround once django-pyscss supports Django 3.0+."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"major, __, __ \u003d map(int, django.__version__.split(\u0027.\u0027))"},{"line_number":29,"context_line":"if major \u003e\u003d 3:"},{"line_number":30,"context_line":"    sys.modules[\u0027django.utils.six\u0027] \u003d six"},{"line_number":31,"context_line":"    sys.modules[\u0027django.utils.six.moves\u0027] \u003d six.moves"}],"source_content_type":"text/x-python","patch_set":4,"id":"831768f3_439b24b7","line":28,"updated":"2021-09-16 03:29:42.000000000","message":"Why not using django.VERSION? The first element is the major version.\n\n django.VERSION \u003e\u003d (3, )\n\nor\n\n django.VESRION[0] \u003e\u003d 3\n\nshould work.","commit_id":"ce919152955d3ea09f07d466726b50e7a368a4da"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"3ac547c759e9e569dba71bb2993eaee01c222a66","unresolved":true,"context_lines":[{"line_number":25,"context_line":"# TODO(amotoki): Drop the workaround once django-pyscss supports Django 3.0+."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"major, __, __ \u003d map(int, django.__version__.split(\u0027.\u0027))"},{"line_number":29,"context_line":"if major \u003e\u003d 3:"},{"line_number":30,"context_line":"    sys.modules[\u0027django.utils.six\u0027] \u003d six"},{"line_number":31,"context_line":"    sys.modules[\u0027django.utils.six.moves\u0027] \u003d six.moves"}],"source_content_type":"text/x-python","patch_set":4,"id":"63ad1968_1d60fd28","line":28,"in_reply_to":"831768f3_439b24b7","updated":"2021-09-16 04:52:42.000000000","message":"Done.","commit_id":"ce919152955d3ea09f07d466726b50e7a368a4da"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1459fe2d23fd3a1c9c64a228c29be45cf4561ea0","unresolved":true,"context_lines":[{"line_number":25,"context_line":"# TODO(amotoki): Drop the workaround once django-pyscss supports Django 3.0+."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if django.__version__[0] \u003e\u003d 3:"},{"line_number":29,"context_line":"    sys.modules[\u0027django.utils.six\u0027] \u003d six"},{"line_number":30,"context_line":"    sys.modules[\u0027django.utils.six.moves\u0027] \u003d six.moves"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1bc7dae1_4175396b","line":28,"range":{"start_line":28,"start_character":3,"end_line":28,"end_character":21},"updated":"2021-09-16 06:22:01.000000000","message":"Should be django.VERSION.\nDo not access the internal constant.","commit_id":"cf3a3edde0d8e99757a88228cd3a4ee914c80ee5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e4eeb0983692af03c5ecb0b3e7821a2d3fcb239e","unresolved":true,"context_lines":[{"line_number":24,"context_line":"# a vendored version of six, django.utils.six which was dropped in Django 3.0."},{"line_number":25,"context_line":"# TODO(amotoki): Drop the workaround once django-pyscss supports Django 3.0+."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if django.VERSION[0] \u003e\u003d 3:"},{"line_number":29,"context_line":"    sys.modules[\u0027django.utils.six\u0027] \u003d six"},{"line_number":30,"context_line":"    sys.modules[\u0027django.utils.six.moves\u0027] \u003d six.moves"}],"source_content_type":"text/x-python","patch_set":6,"id":"87bc983c_9a2dbb67","line":27,"updated":"2021-09-16 06:55:40.000000000","message":"nit: These blank lines looks unnecessary.","commit_id":"134723c9d246fcdb21e3cb2ac66f5cbabfc796ec"}]}
