)]}'
{"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25ea2e463b902728bf5c2dee8e8cc8f770175a3f","unresolved":true,"context_lines":[{"line_number":694,"context_line":"          if (isValidSnapshot(image) \u0026\u0026 enabledSnapshot) {"},{"line_number":695,"context_line":"            model.imageSnapshots.push(image);"},{"line_number":696,"context_line":"          } else if (isValidImage(image) \u0026\u0026 enabledImage) {"},{"line_number":697,"context_line":"            image.name_or_id \u003d image.name || image.id;"},{"line_number":698,"context_line":"            model.images.push(image);"},{"line_number":699,"context_line":"          }"},{"line_number":700,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":3,"id":"6be40840_2480cc79","line":697,"range":{"start_line":697,"start_character":12,"end_line":697,"end_character":54},"updated":"2021-03-08 06:57:16.000000000","message":"This should not be backported as it was added as part of 19.0.0 release (wallaby).","commit_id":"51efabd69acd4e52ca98efabcb9548e15a7d395c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2da8ccd020ddc339f0abe842b2fca1431538972f","unresolved":true,"context_lines":[{"line_number":694,"context_line":"          if (isValidSnapshot(image) \u0026\u0026 enabledSnapshot) {"},{"line_number":695,"context_line":"            model.imageSnapshots.push(image);"},{"line_number":696,"context_line":"          } else if (isValidImage(image) \u0026\u0026 enabledImage) {"},{"line_number":697,"context_line":"            image.name_or_id \u003d image.name || image.id;"},{"line_number":698,"context_line":"            model.images.push(image);"},{"line_number":699,"context_line":"          }"},{"line_number":700,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":3,"id":"4fdd2f86_93420ff6","line":697,"range":{"start_line":697,"start_character":12,"end_line":697,"end_character":54},"in_reply_to":"0c20c3d1_df596652","updated":"2021-03-08 07:50:08.000000000","message":"\u003e In theory, multiple fixes should be mixed in a single commit.\n\nWoops. Correction: .... should NOT be ....","commit_id":"51efabd69acd4e52ca98efabcb9548e15a7d395c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7876cf3ea025fe62271a8aa82573dd77a2e4b0da","unresolved":true,"context_lines":[{"line_number":694,"context_line":"          if (isValidSnapshot(image) \u0026\u0026 enabledSnapshot) {"},{"line_number":695,"context_line":"            model.imageSnapshots.push(image);"},{"line_number":696,"context_line":"          } else if (isValidImage(image) \u0026\u0026 enabledImage) {"},{"line_number":697,"context_line":"            image.name_or_id \u003d image.name || image.id;"},{"line_number":698,"context_line":"            model.images.push(image);"},{"line_number":699,"context_line":"          }"},{"line_number":700,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":3,"id":"0c20c3d1_df596652","line":697,"range":{"start_line":697,"start_character":12,"end_line":697,"end_character":54},"in_reply_to":"6364246d_1d8e420f","updated":"2021-03-08 07:48:44.000000000","message":"In theory, multiple fixes should be mixed in a single commit. This is not special. It is true not only for stable branches  but also the master branch. This is the reason I am against this change.\nIf needed, we should backport it separately. Do not mix these two.","commit_id":"51efabd69acd4e52ca98efabcb9548e15a7d395c"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"43217c1fd5165b229faf6f5840fd34a44920e251","unresolved":true,"context_lines":[{"line_number":694,"context_line":"          if (isValidSnapshot(image) \u0026\u0026 enabledSnapshot) {"},{"line_number":695,"context_line":"            model.imageSnapshots.push(image);"},{"line_number":696,"context_line":"          } else if (isValidImage(image) \u0026\u0026 enabledImage) {"},{"line_number":697,"context_line":"            image.name_or_id \u003d image.name || image.id;"},{"line_number":698,"context_line":"            model.images.push(image);"},{"line_number":699,"context_line":"          }"},{"line_number":700,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":3,"id":"6364246d_1d8e420f","line":697,"range":{"start_line":697,"start_character":12,"end_line":697,"end_character":54},"in_reply_to":"6be40840_2480cc79","updated":"2021-03-08 07:35:41.000000000","message":"yes right. I am thinking to backport [1] in stable branches as well after that it will also work here. what you say because it also fixed bug 1853551 in stable/victoria branch or is to wrong to backport it?\n\n[1] https://review.opendev.org/c/openstack/horizon/+/695619.","commit_id":"51efabd69acd4e52ca98efabcb9548e15a7d395c"}]}