)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c93686eaef243a7e66cf0b36dd32e24f69f6780c","unresolved":true,"context_lines":[{"line_number":19,"context_line":"pagination allows, the ports from newer instances would no longer"},{"line_number":20,"context_line":"appear in the drop-down, and the form would fail to validate, even"},{"line_number":21,"context_line":"though the choice of port on initial form was correct."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"430b10e8_aed26e8a","line":22,"updated":"2021-03-17 23:39:29.000000000","message":"No bug report is associated?","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"3c256bcdf786afee05b911c84801653af1458800","unresolved":true,"context_lines":[{"line_number":19,"context_line":"pagination allows, the ports from newer instances would no longer"},{"line_number":20,"context_line":"appear in the drop-down, and the form would fail to validate, even"},{"line_number":21,"context_line":"though the choice of port on initial form was correct."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6f3f0832_264692f7","line":22,"in_reply_to":"0c2d3147_b3a49084","updated":"2021-03-18 11:41:54.000000000","message":"I do want to backport it, reported #1920010.","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4242b0e81134ceea2618371dc052ed85a24cf047","unresolved":true,"context_lines":[{"line_number":19,"context_line":"pagination allows, the ports from newer instances would no longer"},{"line_number":20,"context_line":"appear in the drop-down, and the form would fail to validate, even"},{"line_number":21,"context_line":"though the choice of port on initial form was correct."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0c2d3147_b3a49084","line":22,"in_reply_to":"2555fd95_a628b236","updated":"2021-03-18 10:18:18.000000000","message":"If you plan to backport it, an upstream bug would be helpful. Otherwise, I have no preference.\n\nTODO is just about renaming instance_id to port_id, so I don\u0027t think it is the main thing you would like to fix.","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"b980ec6473bc2a315fb3ed759957c4c76781a3e8","unresolved":true,"context_lines":[{"line_number":19,"context_line":"pagination allows, the ports from newer instances would no longer"},{"line_number":20,"context_line":"appear in the drop-down, and the form would fail to validate, even"},{"line_number":21,"context_line":"though the choice of port on initial form was correct."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2555fd95_a628b236","line":22,"in_reply_to":"430b10e8_aed26e8a","updated":"2021-03-18 08:35:54.000000000","message":"I did not find an upstream bug related to this, but there was a TODO in the code. Should I create a bug?","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"deda4e82dbb8add9afc7019d0296045c0776d3ff","unresolved":true,"context_lines":[{"line_number":19,"context_line":"pagination allows, the ports from newer instances would no longer"},{"line_number":20,"context_line":"appear in the drop-down, and the form would fail to validate, even"},{"line_number":21,"context_line":"though the choice of port on initial form was correct."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fe6fbef6_51d6e0c1","line":22,"in_reply_to":"6f3f0832_264692f7","updated":"2021-03-18 12:19:12.000000000","message":"Really appreciated. I understood the issue more correctly than from the commit message.","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"}],"openstack_dashboard/dashboards/project/floating_ips/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c93686eaef243a7e66cf0b36dd32e24f69f6780c","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        self.mock_floating_ip_associate.return_value \u003d None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        form_data \u003d {\u0027port_id\u0027: port_target_id,"},{"line_number":143,"context_line":"                     \u0027ip_id\u0027: floating_ip.id}"},{"line_number":144,"context_line":"        url \u003d reverse(\u0027%s:associate\u0027 % NAMESPACE)"},{"line_number":145,"context_line":"        res \u003d self.client.post(url, form_data)"},{"line_number":146,"context_line":"        self.assertRedirectsNoFollow(res, INDEX_URL)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3687c5dc_cf4b1c2f","line":143,"updated":"2021-03-17 23:39:29.000000000","message":"Don\u0027t we need instance_id you added?\nI believe it should match the form?","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"b980ec6473bc2a315fb3ed759957c4c76781a3e8","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        self.mock_floating_ip_associate.return_value \u003d None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        form_data \u003d {\u0027port_id\u0027: port_target_id,"},{"line_number":143,"context_line":"                     \u0027ip_id\u0027: floating_ip.id}"},{"line_number":144,"context_line":"        url \u003d reverse(\u0027%s:associate\u0027 % NAMESPACE)"},{"line_number":145,"context_line":"        res \u003d self.client.post(url, form_data)"},{"line_number":146,"context_line":"        self.assertRedirectsNoFollow(res, INDEX_URL)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f82f3c57_7e4cff87","line":143,"in_reply_to":"3687c5dc_cf4b1c2f","updated":"2021-03-18 08:35:54.000000000","message":"No, because instance_id is optional, and only needed when you want to limit the port_id to a single instance.","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"3c256bcdf786afee05b911c84801653af1458800","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        self.mock_floating_ip_associate.return_value \u003d None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        form_data \u003d {\u0027port_id\u0027: port_target_id,"},{"line_number":143,"context_line":"                     \u0027ip_id\u0027: floating_ip.id}"},{"line_number":144,"context_line":"        url \u003d reverse(\u0027%s:associate\u0027 % NAMESPACE)"},{"line_number":145,"context_line":"        res \u003d self.client.post(url, form_data)"},{"line_number":146,"context_line":"        self.assertRedirectsNoFollow(res, INDEX_URL)"}],"source_content_type":"text/x-python","patch_set":4,"id":"04eedb58_d36c8d19","line":143,"in_reply_to":"84f89e39_1880b628","updated":"2021-03-18 11:41:54.000000000","message":"There is test_associate_with_instance_id test that covers that case.","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4242b0e81134ceea2618371dc052ed85a24cf047","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        self.mock_floating_ip_associate.return_value \u003d None"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        form_data \u003d {\u0027port_id\u0027: port_target_id,"},{"line_number":143,"context_line":"                     \u0027ip_id\u0027: floating_ip.id}"},{"line_number":144,"context_line":"        url \u003d reverse(\u0027%s:associate\u0027 % NAMESPACE)"},{"line_number":145,"context_line":"        res \u003d self.client.post(url, form_data)"},{"line_number":146,"context_line":"        self.assertRedirectsNoFollow(res, INDEX_URL)"}],"source_content_type":"text/x-python","patch_set":4,"id":"84f89e39_1880b628","line":143,"in_reply_to":"f82f3c57_7e4cff87","updated":"2021-03-18 10:18:18.000000000","message":"Okay, though I am worring uncovered code is increasing....","commit_id":"7620a4eb4c744d136bec31bc1984db8c7d264534"}]}