)]}'
{"openstack_dashboard/conf/default_policies/cinder.yaml":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"927ab312644ffac6cab61dc0833cd39af4e9edfe","unresolved":true,"context_lines":[{"line_number":542,"context_line":"    path: /os-quota-sets/{project_id}"},{"line_number":543,"context_line":"  scope_types: null"},{"line_number":544,"context_line":"- check_str: rule:admin_api"},{"line_number":545,"context_line":"  description: Validate setup for nested quota."},{"line_number":546,"context_line":"  name: volume_extension:quota_classes:validate_setup_for_nested_quota_use"},{"line_number":547,"context_line":"  operations:"},{"line_number":548,"context_line":"  - method: GET"},{"line_number":549,"context_line":"    path: /os-quota-sets/validate_setup_for_nested_quota_use"},{"line_number":550,"context_line":"  scope_types: null"},{"line_number":551,"context_line":"- check_str: rule:admin_api"},{"line_number":552,"context_line":"  description: Show backend capabilities."},{"line_number":553,"context_line":"  name: volume_extension:capabilities"},{"line_number":554,"context_line":"  operations:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b06b7852_3fba0f71","side":"PARENT","line":551,"range":{"start_line":545,"start_character":1,"end_line":551,"end_character":27},"updated":"2021-03-30 11:54:35.000000000","message":"Don\u0027t we need to remove it from \u0027\u0027cinder_policy.yaml\u0027\u0027 ?","commit_id":"28e3fa5bee525a16da8bd44800605ec1f5df991a"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"927ab312644ffac6cab61dc0833cd39af4e9edfe","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  name: admin_api"},{"line_number":14,"context_line":"  operations: []"},{"line_number":15,"context_line":"  scope_types: null"},{"line_number":16,"context_line":"- check_str: (role:admin and system_scope:all) or (role:admin and domain_id:%(domain_id)s)"},{"line_number":17,"context_line":"    or (role:admin and project_id:%(project_id)s)"},{"line_number":18,"context_line":"  description: Default rule for admins of cloud, domain or a project."},{"line_number":19,"context_line":"  name: system_or_domain_or_project_admin"},{"line_number":20,"context_line":"  operations: []"},{"line_number":21,"context_line":"  scope_types: null"},{"line_number":22,"context_line":"- check_str: \u0027\u0027"},{"line_number":23,"context_line":"  description: Create attachment."},{"line_number":24,"context_line":"  name: volume:attachment_create"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e741fbde_e2e88c45","line":21,"range":{"start_line":16,"start_character":0,"end_line":21,"end_character":19},"updated":"2021-03-30 11:54:35.000000000","message":"You have just added these new policy rules in \u0027\u0027openstack_dashboard/conf/default_policies/cinder.yaml\u0027\u0027\nbut what about \u0027\u0027openstack_dashboard/conf/cinder_policy.yaml\u0027\u0027\n\nDon\u0027t we need to add/remove same rules to cinder_policy.yaml as well?\nThis comments applies to other files as well.","commit_id":"586b0db681551b3dce58ada395ddd9b629506cea"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e1dc1597cc44b29f5cc4f7f51f811d9b2627f97f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  name: admin_api"},{"line_number":14,"context_line":"  operations: []"},{"line_number":15,"context_line":"  scope_types: null"},{"line_number":16,"context_line":"- check_str: (role:admin and system_scope:all) or (role:admin and domain_id:%(domain_id)s)"},{"line_number":17,"context_line":"    or (role:admin and project_id:%(project_id)s)"},{"line_number":18,"context_line":"  description: Default rule for admins of cloud, domain or a project."},{"line_number":19,"context_line":"  name: system_or_domain_or_project_admin"},{"line_number":20,"context_line":"  operations: []"},{"line_number":21,"context_line":"  scope_types: null"},{"line_number":22,"context_line":"- check_str: \u0027\u0027"},{"line_number":23,"context_line":"  description: Create attachment."},{"line_number":24,"context_line":"  name: volume:attachment_create"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"23107d6d_e48f7cad","line":21,"range":{"start_line":16,"start_character":0,"end_line":21,"end_character":19},"in_reply_to":"e741fbde_e2e88c45","updated":"2021-04-01 03:08:29.000000000","message":"Good point. I totally forgot to update them. Patch set 2 addresses this.","commit_id":"586b0db681551b3dce58ada395ddd9b629506cea"}],"openstack_dashboard/conf/neutron_policy.yaml":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"897b337e6240016ebd74c0c80254c02147888776","unresolved":true,"context_lines":[{"line_number":404,"context_line":"# Create a floating IP"},{"line_number":405,"context_line":"# POST  /floatingips"},{"line_number":406,"context_line":"# Intended scope(s): project"},{"line_number":407,"context_line":"#\"create_floatingip\": \"role:member and project_id:%(project_id)s\""},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"# DEPRECATED"},{"line_number":410,"context_line":"# \"create_floatingip\":\"rule:regular_user\" has been deprecated since W"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d05ac2ee_1029be2d","line":407,"range":{"start_line":407,"start_character":22,"end_line":407,"end_character":65},"updated":"2021-04-07 04:16:33.000000000","message":"Why you didn\u0027t added system scope policy here like:\n(role:admin and system_scope:all)\n\nDoesn\u0027t it needs to be like below?\n\"create_floatingip\": \"(role:admin and system_scope:all) or (role:member and project_id:%(project_id)s)\"","commit_id":"b2fe1450422d25fac0420ff507dfbd57d26954e3"}]}
