)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"98aa5627986d686ca66c0b90ed35939fa7d3c679","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5456fc90_65ebd601","updated":"2022-06-28 09:18:01.000000000","message":"Considering the bug report on DoS with many many containers, the ideal solution would be to implement the pagination in the swift panel. If we go to the route to full_listing\u003dTrue, it would contain a potential regresionn that all containers/objects are not necessarily listed and it should be mentioned clearly because users would expect all containers are listed unless pagination is supported.","commit_id":"facea055ce8ff1f105762fcfa3acf6ede9e2dfb0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1ea0a656e4b7af36c5cb457e127f2523ad84337a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3799c89_a4e02686","updated":"2022-06-28 09:24:44.000000000","message":"weak -1 as I think we need more discussion on the direction.","commit_id":"facea055ce8ff1f105762fcfa3acf6ede9e2dfb0"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"0109f8f291321cd5fc5096d05fd5653dec0d977a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b8d78050_5d136d64","updated":"2025-05-20 15:26:43.000000000","message":"@openstack@dopieralski.pl hello, I think we can merge this.","commit_id":"c271ce85826a4ef189b8a6dd9cbeb18d2762d4e2"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aee8c6bb2d8882f9d81fdbf9b82e6076d709408f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"97bde46e_0a288abe","updated":"2025-05-21 07:38:28.000000000","message":"I\u0027ve proposed something similar due to an issue we have, see my long commit message in https://review.opendev.org/c/openstack/horizon/+/927478 but I did receive a -1 feedback on it.\n\nUnfortunately the Swift part in Horizon is client-side pagination so changing this has a limiting factor in that it will only support up to 1000 containers/objects being listed but we are having issues with Horizon dying instead which is worse imo.","commit_id":"c271ce85826a4ef189b8a6dd9cbeb18d2762d4e2"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"748426aa3cf25927fd0e84217a67905939f13d88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7638e46_dc680a46","in_reply_to":"97bde46e_0a288abe","updated":"2025-05-21 09:03:36.000000000","message":"@tobias.urdin@binero.com I think we can rise up this topic in today\u0027s Horizon irc.","commit_id":"c271ce85826a4ef189b8a6dd9cbeb18d2762d4e2"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"ca41bed39ed6652e0039773e8dc397b678c94217","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92225ebe_13459a14","in_reply_to":"d7638e46_dc680a46","updated":"2025-05-21 22:16:28.000000000","message":"@tobias.urdin@binero.com I found this MR about too:\nhttps://review.opendev.org/c/openstack/horizon/+/88246","commit_id":"c271ce85826a4ef189b8a6dd9cbeb18d2762d4e2"}],"openstack_dashboard/api/swift.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a1200a962cdf9648a066a28ee742b94bcdf17bbb","unresolved":true,"context_lines":[{"line_number":167,"context_line":"    headers, containers \u003d swift_api(request).get_account(limit\u003dlimit + 1,"},{"line_number":168,"context_line":"                                                         marker\u003dmarker,"},{"line_number":169,"context_line":"                                                         prefix\u003dprefix,"},{"line_number":170,"context_line":"                                                         full_listing\u003dFalse)"},{"line_number":171,"context_line":"    container_objs \u003d [Container(c) for c in containers]"},{"line_number":172,"context_line":"    if(len(container_objs) \u003e limit):"},{"line_number":173,"context_line":"        return (container_objs[0:-1], True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd1723cf_5b616d7e","line":170,"updated":"2022-06-28 09:13:45.000000000","message":"Looking at openstack_dashboard/api/rest/swift.py, no pagination support is implemented. Is it okay not to use full_listing? I know if full_listing\u003dTrue is specified swiftclient calls get_account() API (with pagination) multiple times to retrieve the full list of containers. What is the problem we would like to fix *in horizon* and what is the expected behavior from *horizon* perspetive.","commit_id":"facea055ce8ff1f105762fcfa3acf6ede9e2dfb0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a1200a962cdf9648a066a28ee742b94bcdf17bbb","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                  marker\u003dmarker,"},{"line_number":264,"context_line":"                  limit\u003dlimit + 1,"},{"line_number":265,"context_line":"                  delimiter\u003dFOLDER_DELIMITER,"},{"line_number":266,"context_line":"                  full_listing\u003dFalse)"},{"line_number":267,"context_line":"    headers, objects \u003d swift_api(request).get_container(container_name,"},{"line_number":268,"context_line":"                                                        **kwargs)"},{"line_number":269,"context_line":"    object_objs \u003d _objectify(objects, container_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a9632d64_00431e70","line":266,"updated":"2022-06-28 09:13:45.000000000","message":"Same question as for the above.","commit_id":"facea055ce8ff1f105762fcfa3acf6ede9e2dfb0"}]}