)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3750eeebf6856cdb321fc3b50564d63b63e744fd","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Changes:"},{"line_number":12,"context_line":"Define a new Keypair regex"},{"line_number":13,"context_line":"change Keypair Name from CharField to RegexField"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0a20712759359d5cba052f701c51081eee3ca002"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2FGuA%3D","line":13,"updated":"2014-03-09 17:39:36.000000000","message":"Please follow the convention of git commit message: summary in the first line, a blank line and the details later.\nhttps://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes\n\nThe bug should be the following form: \"Closes-Bug: #1288583\".\nThe URL is not needed.\n\nIn this case, I would suggest the following for example:\n\n    Change keypair name validation to allow a name with a space\n\n    This commit defines a new keypair regex.\n    Keypair name form is changed to CharField to RegexField.\n\n    Closes-Bug: #1288583","commit_id":"cf9517e3f3651418079409af783861f1f5d5fc37"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"3ecef828206b04d3d28729aa06e3123f929a8bfd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Space is not allowed while creating Key Pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ref bug:"},{"line_number":10,"context_line":"https://launchpad.net/horizon/+bug/1288583"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"modify the test_import_keypair_invalid_key"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"AAAAWH%2F%2F6U0%3D","line":9,"updated":"2014-03-13 00:41:27.000000000","message":"Change for Closes-Bug: #id\nreference at https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"8fc4ee501e6080ab7181858e43978bce5b1e980d"}],"openstack_dashboard/dashboards/project/access_and_security/keypairs/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3750eeebf6856cdb321fc3b50564d63b63e744fd","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NEW_LINES \u003d re.compile(r\"\\r|\\n\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_keypair_name_regex \u003d re.compile(r\"^[\\w\\.\\- ]+$\", re.UNICODE)"},{"line_number":36,"context_line":"KEYPAIR_ERROR_MESSAGES \u003d {\u0027invalid\u0027: _(\u0027Keypair Name may only contain letters, \u0027"},{"line_number":37,"context_line":"                            \u0027numbers, underscores, periods, \u0027"},{"line_number":38,"context_line":"                            \u0027spaces and hyphens.\u0027)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FGtk%3D","line":35,"updated":"2014-03-09 17:39:36.000000000","message":"Does this regular expression match nova validation? We would like to know it matches nova\u0027 one to avoid unnecessary change later.\n\nCould you use upper case constant name? It is consistent with L.33 and L.36.","commit_id":"cf9517e3f3651418079409af783861f1f5d5fc37"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3750eeebf6856cdb321fc3b50564d63b63e744fd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"_keypair_name_regex \u003d re.compile(r\"^[\\w\\.\\- ]+$\", re.UNICODE)"},{"line_number":36,"context_line":"KEYPAIR_ERROR_MESSAGES \u003d {\u0027invalid\u0027: _(\u0027Keypair Name may only contain letters, \u0027"},{"line_number":37,"context_line":"                            \u0027numbers, underscores, periods, \u0027"},{"line_number":38,"context_line":"                            \u0027spaces and hyphens.\u0027)}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CreateKeypair(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FGt8%3D","line":38,"updated":"2014-03-09 17:39:36.000000000","message":"Please align L.37-38 to \u0027Keypair ...\u0027 because they are inside _().","commit_id":"cf9517e3f3651418079409af783861f1f5d5fc37"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3750eeebf6856cdb321fc3b50564d63b63e744fd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            exceptions.handle(request, ignore\u003dTrue)"},{"line_number":72,"context_line":"            self.api_error(_(\u0027Unable to import key pair.\u0027))"},{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FGtc%3D","line":74,"updated":"2014-03-09 17:39:36.000000000","message":"It is unnecessary.","commit_id":"cf9517e3f3651418079409af783861f1f5d5fc37"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"83c7b3606b007289e9d5ea31f7a3cb06c99cecce","unresolved":false,"context_lines":[{"line_number":32,"context_line":"NEW_LINES \u003d re.compile(r\"\\r|\\n\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_keypair_name_regex \u003d re.compile(r\"^[\\w\\.\\- ]+$\", re.UNICODE)"},{"line_number":35,"context_line":"KEYPAIR_ERROR_MESSAGES \u003d {\u0027invalid\u0027: _(\u0027Keypair Name may only contain letters, \u0027"},{"line_number":36,"context_line":"                            \u0027numbers, underscores, periods, spaces and hyphens.\u0027)}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAVn%2F%2FBe4%3D","line":35,"updated":"2014-03-10 16:29:17.000000000","message":"Make \"Keypair\" --\u003e \"Key pair\"","commit_id":"42a1e1ae35b014cae0578061516d671df8138948"},{"author":{"_account_id":9498,"name":"Vahid Hashemian","email":"vahidhashemian@us.ibm.com","username":"vahidhashemian"},"change_message_id":"d5e58dbc5e082b40382e47bae89ddda78caecf6d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"NEW_LINES \u003d re.compile(r\"\\r|\\n\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_keypair_name_regex \u003d re.compile(r\"^[\\w\\.\\- ]+$\", re.UNICODE)"},{"line_number":35,"context_line":"KEYPAIR_ERROR_MESSAGES \u003d {\u0027invalid\u0027: _(\u0027Key pair Name may \u0027"},{"line_number":36,"context_line":"            \u0027only contain letters, \u0027"},{"line_number":37,"context_line":"            \u0027numbers, underscores, \u0027"},{"line_number":38,"context_line":"            \u0027periods, spaces and hyphens.\u0027)}"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAVn%2F%2BzwA%3D","line":35,"updated":"2014-03-12 01:38:50.000000000","message":"Could you please update to \"Key Pair Name\" to match cases on the field? Thanks.","commit_id":"3c8215c8e468cbdd0b925a1e43eebdc8718e9f84"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"725d4eb21ca4cdba60c7b4dbf04250bc28ca4161","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"NEW_LINES \u003d re.compile(r\"\\r|\\n\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_keypair_name_regex \u003d re.compile(r\"^[\\w\\- ]+$\", re.UNICODE)"},{"line_number":35,"context_line":"KEYPAIR_ERROR_MESSAGES \u003d {\u0027invalid\u0027: _(\u0027Key pair Name may \u0027"},{"line_number":36,"context_line":"            \u0027only contain letters, \u0027"},{"line_number":37,"context_line":"            \u0027numbers, underscores, \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAVn%2F%2ByTk%3D","line":34,"updated":"2014-03-12 06:30:38.000000000","message":"Nitpick: We usually name global constants like this ALL_UPPERCASE.","commit_id":"776ecc20285d9cae6402cfb3a37beb22d6209861"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fe111044ae9bfa46db3af4f5f5ea53375d9913a6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"KEYPAIR_ERROR_MESSAGES \u003d {\u0027invalid\u0027: _(\u0027Key pair name may \u0027"},{"line_number":36,"context_line":"            \u0027only contain letters, \u0027"},{"line_number":37,"context_line":"            \u0027numbers, underscores, \u0027"},{"line_number":38,"context_line":"            \u0027spaces and hyphens.\u0027)}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CreateKeypair(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAWH%2F%2F4C8%3D","line":38,"updated":"2014-03-13 08:15:00.000000000","message":"Indentation level of L.36-38 should be aligned with \"_(\" at L.35\nor insert a new line before \u0027invalid\u0027.","commit_id":"b2ace446da868824a7d1efcf36d2eea5de51db03"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fe111044ae9bfa46db3af4f5f5ea53375d9913a6","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CreateKeypair(forms.SelfHandlingForm):"},{"line_number":42,"context_line":"    name \u003d forms.RegexField(max_length\u003d\"255\","},{"line_number":43,"context_line":"                           label\u003d_(\"Key Pair Name\"),"},{"line_number":44,"context_line":"                           required\u003dTrue,"},{"line_number":45,"context_line":"                           regex\u003dKEYPAIR_NAME_REGEX,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAWH%2F%2F4Co%3D","line":42,"updated":"2014-03-13 08:15:00.000000000","message":"Shouldn\u0027t \"255\" be an integer?","commit_id":"b2ace446da868824a7d1efcf36d2eea5de51db03"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fe111044ae9bfa46db3af4f5f5ea53375d9913a6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class CreateKeypair(forms.SelfHandlingForm):"},{"line_number":42,"context_line":"    name \u003d forms.RegexField(max_length\u003d\"255\","},{"line_number":43,"context_line":"                           label\u003d_(\"Key Pair Name\"),"},{"line_number":44,"context_line":"                           required\u003dTrue,"},{"line_number":45,"context_line":"                           regex\u003dKEYPAIR_NAME_REGEX,"},{"line_number":46,"context_line":"                           error_messages\u003dKEYPAIR_ERROR_MESSAGES)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAWH%2F%2F4C0%3D","line":44,"updated":"2014-03-13 08:15:00.000000000","message":"Nit: required\u003dTrue is default and unnecessary.","commit_id":"b2ace446da868824a7d1efcf36d2eea5de51db03"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fe111044ae9bfa46db3af4f5f5ea53375d9913a6","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class ImportKeypair(forms.SelfHandlingForm):"},{"line_number":53,"context_line":"    name \u003d forms.RegexField(max_length\u003d\"255\","},{"line_number":54,"context_line":"                           label\u003d_(\"Key Pair Name\"),"},{"line_number":55,"context_line":"                           required\u003dTrue,"},{"line_number":56,"context_line":"                           regex\u003dKEYPAIR_NAME_REGEX,"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAWH%2F%2F4Cg%3D","line":53,"updated":"2014-03-13 08:15:00.000000000","message":"ditto","commit_id":"b2ace446da868824a7d1efcf36d2eea5de51db03"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8335d464c0256677e2f4fe59946d9e5448a2438","unresolved":false,"context_lines":[{"line_number":35,"context_line":"KEYPAIR_ERROR_MESSAGES \u003d {\u0027invalid\u0027: _(\u0027Key pair name may \u0027"},{"line_number":36,"context_line":"            \u0027only contain letters, \u0027"},{"line_number":37,"context_line":"            \u0027numbers, underscores, \u0027"},{"line_number":38,"context_line":"            \u0027spaces and hyphens.\u0027)}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CreateKeypair(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAWH%2F%2Ftwo%3D","line":38,"updated":"2014-03-14 09:26:06.000000000","message":"Indentation level of L.36-38 should be aligned with \"_(\" at L.35 or insert a new line before \u0027invalid\u0027.","commit_id":"595743fdc7c4b6afbaf37b23d36890351c9f81fd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8335d464c0256677e2f4fe59946d9e5448a2438","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CreateKeypair(forms.SelfHandlingForm):"},{"line_number":42,"context_line":"    name \u003d forms.RegexField(max_length\u003d\"255\","},{"line_number":43,"context_line":"                           label\u003d_(\"Key Pair Name\"),"},{"line_number":44,"context_line":"                           required\u003dTrue,"},{"line_number":45,"context_line":"                           regex\u003dKEYPAIR_NAME_REGEX,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAWH%2F%2FtwI%3D","line":42,"updated":"2014-03-14 09:26:06.000000000","message":"Shouldn\u0027t \"255\" be an integer?","commit_id":"595743fdc7c4b6afbaf37b23d36890351c9f81fd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8335d464c0256677e2f4fe59946d9e5448a2438","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class ImportKeypair(forms.SelfHandlingForm):"},{"line_number":53,"context_line":"    name \u003d forms.RegexField(max_length\u003d\"255\","},{"line_number":54,"context_line":"                           label\u003d_(\"Key Pair Name\"),"},{"line_number":55,"context_line":"                           required\u003dTrue,"},{"line_number":56,"context_line":"                           regex\u003dKEYPAIR_NAME_REGEX,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAWH%2F%2Ftv8%3D","line":53,"updated":"2014-03-14 09:26:06.000000000","message":"Shouldn\u0027t \"255\" be an integer?","commit_id":"595743fdc7c4b6afbaf37b23d36890351c9f81fd"}],"openstack_dashboard/dashboards/project/access_and_security/keypairs/tests.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"725d4eb21ca4cdba60c7b4dbf04250bc28ca4161","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                      kwargs\u003d{\u0027keypair_name\u0027: keypair_name})"},{"line_number":201,"context_line":"        res \u003d self.client.get(url, context)"},{"line_number":202,"context_line":"        self.assertTemplateUsed("},{"line_number":203,"context_line":"            res, \u0027project/access_and_security/keypairs/download.html\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAVn%2F%2ByUE%3D","line":203,"updated":"2014-03-12 06:30:38.000000000","message":"Can you also add a test where it fails validation? You know, the case that you are actually fixing.","commit_id":"776ecc20285d9cae6402cfb3a37beb22d6209861"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"3ecef828206b04d3d28729aa06e3123f929a8bfd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def test_create_keypair_with_regex_name_get(self):"},{"line_number":179,"context_line":"        keypair \u003d self.keypairs.first()"},{"line_number":180,"context_line":"        keypair.private_key \u003d \"secret\""},{"line_number":181,"context_line":"        keypair_name \u003d \"key-space pair-regex_name-0123456789\""},{"line_number":182,"context_line":"        keypair.name \u003d keypair_name"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027keypair_create\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAWH%2F%2F6Tw%3D","line":181,"updated":"2014-03-13 00:41:27.000000000","message":"probably just keypair.name \u003d , will be enough, since keypair_name is not used elsewhere and is the same length as keypair_name. ( no too long line warning )","commit_id":"8fc4ee501e6080ab7181858e43978bce5b1e980d"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"972f2158a03a97233a94c119caa9c017dc40e91a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            res, \u0027project/access_and_security/keypairs/download.html\u0027)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_download_with_invalid_keypair_name_get(self):"},{"line_number":205,"context_line":"        keypair_name \u003d \"invalid#key?name\u003d!down.load\""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        context \u003d {\u0027keypair_name\u0027: keypair_name}"},{"line_number":208,"context_line":"        url \u003d reverse(\u0027horizon:project:access_and_security:keypairs:download\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAWH%2F%2F5n4%3D","line":205,"updated":"2014-03-13 02:56:12.000000000","message":"what\u0027s the purpose of this test? IMO, you should add a test to create keypair with this invalid name and assertFormError with \u0027Key pair name may only contain letters, numbers, underscores, spaces and hyphens.\u0027","commit_id":"916945f76f53767bdcfec0245f3b0348db662f04"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fe111044ae9bfa46db3af4f5f5ea53375d9913a6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        keypair.name \u003d \"key-space pair-regex_name-0123456789\""},{"line_number":181,"context_line":"        keypair.private_key \u003d \"secret\""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027keypair_create\u0027)"},{"line_number":184,"context_line":"        api.nova.keypair_create(IsA(http.HttpRequest),"},{"line_number":185,"context_line":"                                keypair.name).AndReturn(keypair)"},{"line_number":186,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAWH%2F%2F4Bc%3D","line":183,"updated":"2014-03-13 08:15:00.000000000","message":"Why don\u0027t you use create_stub decorator?","commit_id":"b2ace446da868824a7d1efcf36d2eea5de51db03"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fe111044ae9bfa46db3af4f5f5ea53375d9913a6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        keypair \u003d self.keypairs.first()"},{"line_number":206,"context_line":"        keypair.name \u003d \"invalid#key?name\u003d!create\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027keypair_create\u0027)"},{"line_number":209,"context_line":"        api.nova.keypair_create(IsA(http.HttpRequest), keypair.name) \\"},{"line_number":210,"context_line":"                        .AndRaise(self.exceptions.nova)"},{"line_number":211,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAWH%2F%2F4BU%3D","line":208,"updated":"2014-03-13 08:15:00.000000000","message":"Why don\u0027t you use create_stub decorator?","commit_id":"b2ace446da868824a7d1efcf36d2eea5de51db03"}]}
