)]}'
{"openstack_dashboard/dashboards/admin/instances/tables.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"dde8f221f0ebe90c146fac64a51ddf03e88de59c","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    # user \u003d tables.Column(\"user_id\", verbose_name\u003d_(\"User\"))"},{"line_number":150,"context_line":"    host \u003d tables.Column(\"OS-EXT-SRV-ATTR:host\","},{"line_number":151,"context_line":"                         verbose_name\u003d_(\"Host\"),"},{"line_number":152,"context_line":"                         classes\u003d(\u0027nowrap-col\u0027,))"},{"line_number":153,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":154,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":155,"context_line":"                                 verbose_name\u003d_(\"Name\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af08b01_386cc2f3","side":"PARENT","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":49},"updated":"2021-06-21 07:10:13.000000000","message":"If I look at git blame for this line, looks like it is kept intentionally [1].\nCould you explain with any example, why should we remove it now.\n\n\n[1] https://review.opendev.org/c/openstack/horizon/+/5831","commit_id":"647c2b7530f81c4a534ef1d403aa3d90ae608442"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"217cd96417d9fe6356e83e7fabe10249422f2fab","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    # user \u003d tables.Column(\"user_id\", verbose_name\u003d_(\"User\"))"},{"line_number":150,"context_line":"    host \u003d tables.Column(\"OS-EXT-SRV-ATTR:host\","},{"line_number":151,"context_line":"                         verbose_name\u003d_(\"Host\"),"},{"line_number":152,"context_line":"                         classes\u003d(\u0027nowrap-col\u0027,))"},{"line_number":153,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":154,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":155,"context_line":"                                 verbose_name\u003d_(\"Name\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"90afea4b_8f117136","side":"PARENT","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":49},"in_reply_to":"73df0297_72aee0f3","updated":"2021-06-24 16:40:03.000000000","message":"ok fair enough. IMO it is better to add that info. about why we need to word wrapping here in commit msg as well.","commit_id":"647c2b7530f81c4a534ef1d403aa3d90ae608442"},{"author":{"_account_id":27838,"name":"Vadym Markov","email":"vmarkov@mirantis.com","username":"vmarkov"},"change_message_id":"5cf61e3dd8bd1a99a05a4c47af6b9a42b80d46a9","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    # user \u003d tables.Column(\"user_id\", verbose_name\u003d_(\"User\"))"},{"line_number":150,"context_line":"    host \u003d tables.Column(\"OS-EXT-SRV-ATTR:host\","},{"line_number":151,"context_line":"                         verbose_name\u003d_(\"Host\"),"},{"line_number":152,"context_line":"                         classes\u003d(\u0027nowrap-col\u0027,))"},{"line_number":153,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":154,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":155,"context_line":"                                 verbose_name\u003d_(\"Name\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"73df0297_72aee0f3","side":"PARENT","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":49},"in_reply_to":"7af08b01_386cc2f3","updated":"2021-06-22 14:33:40.000000000","message":"Currently, all potentially long names like instance and image name are wrapped. Ellipsis might be a good idea, but it is not implemented. Patch [1] just turns off wrapping for size (which is reasonable, it is short in most cases) and hostname (might be very long in prod environment, because in some cases backend generate some random name for compute VM)","commit_id":"647c2b7530f81c4a534ef1d403aa3d90ae608442"},{"author":{"_account_id":27838,"name":"Vadym Markov","email":"vmarkov@mirantis.com","username":"vmarkov"},"change_message_id":"2a40a350cbfda185ee85be06a3c006efe1ce1cb6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    # user \u003d tables.Column(\"user_id\", verbose_name\u003d_(\"User\"))"},{"line_number":150,"context_line":"    host \u003d tables.Column(\"OS-EXT-SRV-ATTR:host\","},{"line_number":151,"context_line":"                         verbose_name\u003d_(\"Host\"),"},{"line_number":152,"context_line":"                         classes\u003d(\u0027nowrap-col\u0027,))"},{"line_number":153,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":154,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":155,"context_line":"                                 verbose_name\u003d_(\"Name\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5a8ce2d_17dbf3c4","side":"PARENT","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":49},"in_reply_to":"90afea4b_8f117136","updated":"2021-06-25 12:06:55.000000000","message":"Fixed","commit_id":"647c2b7530f81c4a534ef1d403aa3d90ae608442"},{"author":{"_account_id":27838,"name":"Vadym Markov","email":"vmarkov@mirantis.com","username":"vmarkov"},"change_message_id":"5cf61e3dd8bd1a99a05a4c47af6b9a42b80d46a9","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    # returned in a practical manner by the API."},{"line_number":149,"context_line":"    # user \u003d tables.Column(\"user_id\", verbose_name\u003d_(\"User\"))"},{"line_number":150,"context_line":"    host \u003d tables.WrappingColumn(\"OS-EXT-SRV-ATTR:host\","},{"line_number":151,"context_line":"                         verbose_name\u003d_(\"Host\"))"},{"line_number":152,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":153,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":154,"context_line":"                                 verbose_name\u003d_(\"Name\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8db387c_d4f2af25","line":151,"in_reply_to":"908dec2a_3660d2d1","updated":"2021-06-22 14:33:40.000000000","message":"Fixed","commit_id":"14afbd45d2063dd5c4d2250cc2613e1e4ca88562"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"dde8f221f0ebe90c146fac64a51ddf03e88de59c","unresolved":true,"context_lines":[{"line_number":148,"context_line":"    # returned in a practical manner by the API."},{"line_number":149,"context_line":"    # user \u003d tables.Column(\"user_id\", verbose_name\u003d_(\"User\"))"},{"line_number":150,"context_line":"    host \u003d tables.WrappingColumn(\"OS-EXT-SRV-ATTR:host\","},{"line_number":151,"context_line":"                         verbose_name\u003d_(\"Host\"))"},{"line_number":152,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":153,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":154,"context_line":"                                 verbose_name\u003d_(\"Name\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"908dec2a_3660d2d1","line":151,"in_reply_to":"ad93ef31_6aa67b37","updated":"2021-06-21 07:10:13.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.","commit_id":"14afbd45d2063dd5c4d2250cc2613e1e4ca88562"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"dde8f221f0ebe90c146fac64a51ddf03e88de59c","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":153,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":154,"context_line":"                                 verbose_name\u003d_(\"Name\"))"},{"line_number":155,"context_line":"    image_name \u003d tables.WrappingColumn(\"image_name\","},{"line_number":156,"context_line":"                               verbose_name\u003d_(\"Image Name\"))"},{"line_number":157,"context_line":"    ip \u003d tables.Column(project_tables.get_ips,"},{"line_number":158,"context_line":"                       verbose_name\u003d_(\"IP Address\"),"},{"line_number":159,"context_line":"                       attrs\u003d{\u0027data-type\u0027: \"ip\"})"}],"source_content_type":"text/x-python","patch_set":1,"id":"0afef358_71997822","line":156,"range":{"start_line":155,"start_character":4,"end_line":156,"end_character":60},"updated":"2021-06-21 07:10:13.000000000","message":"Please fix pep8 error.\nimage_name \u003d tables.WrappingColumn(\"image_name\",\n                                    verbose_name\u003d_(\"Image Name\"))","commit_id":"14afbd45d2063dd5c4d2250cc2613e1e4ca88562"},{"author":{"_account_id":27838,"name":"Vadym Markov","email":"vmarkov@mirantis.com","username":"vmarkov"},"change_message_id":"5cf61e3dd8bd1a99a05a4c47af6b9a42b80d46a9","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    name \u003d tables.WrappingColumn(\"name\","},{"line_number":153,"context_line":"                                 link\u003dget_server_detail_link,"},{"line_number":154,"context_line":"                                 verbose_name\u003d_(\"Name\"))"},{"line_number":155,"context_line":"    image_name \u003d tables.WrappingColumn(\"image_name\","},{"line_number":156,"context_line":"                               verbose_name\u003d_(\"Image Name\"))"},{"line_number":157,"context_line":"    ip \u003d tables.Column(project_tables.get_ips,"},{"line_number":158,"context_line":"                       verbose_name\u003d_(\"IP Address\"),"},{"line_number":159,"context_line":"                       attrs\u003d{\u0027data-type\u0027: \"ip\"})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f84b6d3_945a1e90","line":156,"range":{"start_line":155,"start_character":4,"end_line":156,"end_character":60},"in_reply_to":"0afef358_71997822","updated":"2021-06-22 14:33:40.000000000","message":"Fixed","commit_id":"14afbd45d2063dd5c4d2250cc2613e1e4ca88562"}]}