)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65c5311c761e56a12362135ce841c1cda79c5a17","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As it is said on the bug description the fix was already available on"},{"line_number":10,"context_line":"a Github repo, I wrote the author and we agreed on submit a new"},{"line_number":11,"context_line":"patch in here with this change. I just did an small refactoring"},{"line_number":12,"context_line":"regarding to PEP8, and adapting the algorithm to Python 3."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If20e19c5d89ef4c28983471822a19a4f17400062"},{"line_number":15,"context_line":"Closes-Bug: #1234950"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"baada198_04851e58","line":12,"updated":"2014-08-03 17:07:54.000000000","message":"As Ana commented, it is better to mention what this commit changes in the commit message rather than its process. Could you improve the commit message?\n\nI think it is better this kind of information is added in the bug comment. It helps us to track how this bug is dealt with.","commit_id":"3a89b708d3ae174da8b8730c25cbdf893db6a22a"}],"openstack_dashboard/dashboards/project/network_topology/views.py":[{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"00401ae128625a5162ef2be92d40d8ea178ce156","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        routers_with_gateways \u003d \\"},{"line_number":199,"context_line":"            dict([(i[\u0027id\u0027], 1) for i in data[\u0027routers\u0027]"},{"line_number":200,"context_line":"                if \u0027external_gateway_info\u0027 in i"},{"line_number":201,"context_line":"                and i[\u0027external_gateway_info\u0027]"},{"line_number":202,"context_line":"                and \u0027network_id\u0027 in i[\u0027external_gateway_info\u0027]])"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        network_ids_with_gatewayed_routers \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAV3%2F%2F%2F5k%3D","line":201,"updated":"2014-03-12 12:56:39.000000000","message":"Those two lines can be replaced by if i.get(\u0027external_gateway_info\u0027)","commit_id":"71c9ec2d592c4b08b73f39a5fa1e172cce7f6730"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"2b6bc7fbb6ab6e74c03f84bec2876b65987e8f8e","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        routers_with_gateways \u003d \\"},{"line_number":199,"context_line":"            dict([(i[\u0027id\u0027], 1) for i in data[\u0027routers\u0027]"},{"line_number":200,"context_line":"                if \u0027external_gateway_info\u0027 in i"},{"line_number":201,"context_line":"                and i[\u0027external_gateway_info\u0027]"},{"line_number":202,"context_line":"                and \u0027network_id\u0027 in i[\u0027external_gateway_info\u0027]])"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        network_ids_with_gatewayed_routers \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FtI%3D","line":201,"in_reply_to":"AAAAV3%2F%2F%2F5k%3D","updated":"2014-03-12 13:44:04.000000000","message":"Done","commit_id":"71c9ec2d592c4b08b73f39a5fa1e172cce7f6730"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"00401ae128625a5162ef2be92d40d8ea178ce156","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            if yext:"},{"line_number":217,"context_line":"                return 1"},{"line_number":218,"context_line":"            xr \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":219,"context_line":"            yr \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":220,"context_line":"            if xr and yr:"},{"line_number":221,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":222,"context_line":"            if xr:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2F7c%3D","line":219,"updated":"2014-03-12 12:56:39.000000000","message":"Below this lines, it\u0027s exactly the same sort.\nYou may add this lines before if xext and yext.\n\nif not ( xext or yext):\n   xext \u003d x.get(\u0027id\u0027) in ....\n   yext \u003d y.get(\u0027id\u0027) in ...","commit_id":"71c9ec2d592c4b08b73f39a5fa1e172cce7f6730"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"2b6bc7fbb6ab6e74c03f84bec2876b65987e8f8e","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            if yext:"},{"line_number":217,"context_line":"                return 1"},{"line_number":218,"context_line":"            xr \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":219,"context_line":"            yr \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":220,"context_line":"            if xr and yr:"},{"line_number":221,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":222,"context_line":"            if xr:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Fn0%3D","line":219,"in_reply_to":"AAAAWH%2F%2F%2F7c%3D","updated":"2014-03-12 13:44:04.000000000","message":"Done","commit_id":"71c9ec2d592c4b08b73f39a5fa1e172cce7f6730"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"00401ae128625a5162ef2be92d40d8ea178ce156","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                return 1"},{"line_number":226,"context_line":"            return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        data[\u0027networks\u0027] \u003d sorted(networks, cmp\u003dmycmp)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # user can\u0027t see port on external network. so we are"},{"line_number":231,"context_line":"        # adding fake port based on router information"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2F7M%3D","line":228,"updated":"2014-03-12 12:56:39.000000000","message":"py33 gate is not enabled so it\u0027s ok, but you may consider in the future use  sorted(networks, key\u003ditertools.cmp_to_key(mycmp)) when the py33 is active.","commit_id":"71c9ec2d592c4b08b73f39a5fa1e172cce7f6730"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"2b6bc7fbb6ab6e74c03f84bec2876b65987e8f8e","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                return 1"},{"line_number":226,"context_line":"            return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        data[\u0027networks\u0027] \u003d sorted(networks, cmp\u003dmycmp)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # user can\u0027t see port on external network. so we are"},{"line_number":231,"context_line":"        # adding fake port based on router information"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FnE%3D","line":228,"in_reply_to":"AAAAWH%2F%2F%2F7M%3D","updated":"2014-03-12 13:44:04.000000000","message":"Good point. Do you know when it will be activated?","commit_id":"71c9ec2d592c4b08b73f39a5fa1e172cce7f6730"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"f0dff274ce8fb497ea7170827f28dbbccc7b5c03","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            yext \u003d y.get(\u0027router:external\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if not xext and not yext:"},{"line_number":213,"context_line":"                xr \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":214,"context_line":"                yr \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"            if xext and yext:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F6og%3D","line":213,"updated":"2014-03-12 23:53:46.000000000","message":"replace xr for xext","commit_id":"82622345d85252db2f9f6af944a324bf6a576c67"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"d720032983100bb918dc85b658526e0e6fad03d2","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            yext \u003d y.get(\u0027router:external\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if not xext and not yext:"},{"line_number":213,"context_line":"                xr \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":214,"context_line":"                yr \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"            if xext and yext:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F1qo%3D","line":213,"in_reply_to":"AAAAWH%2F%2F6og%3D","updated":"2014-03-13 13:42:50.000000000","message":"Done","commit_id":"82622345d85252db2f9f6af944a324bf6a576c67"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"f0dff274ce8fb497ea7170827f28dbbccc7b5c03","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if not xext and not yext:"},{"line_number":213,"context_line":"                xr \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":214,"context_line":"                yr \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"            if xext and yext:"},{"line_number":217,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F6oU%3D","line":214,"updated":"2014-03-12 23:53:46.000000000","message":"replace yr for yext \u003d","commit_id":"82622345d85252db2f9f6af944a324bf6a576c67"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"d720032983100bb918dc85b658526e0e6fad03d2","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if not xext and not yext:"},{"line_number":213,"context_line":"                xr \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":214,"context_line":"                yr \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"            if xext and yext:"},{"line_number":217,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F1qc%3D","line":214,"in_reply_to":"AAAAWH%2F%2F6oU%3D","updated":"2014-03-13 13:42:50.000000000","message":"Done","commit_id":"82622345d85252db2f9f6af944a324bf6a576c67"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"f0dff274ce8fb497ea7170827f28dbbccc7b5c03","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            if yext:"},{"line_number":221,"context_line":"                return 1"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            if xr and yr:"},{"line_number":224,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":225,"context_line":"            if xr:"},{"line_number":226,"context_line":"                return -1"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F6oM%3D","line":223,"updated":"2014-03-12 23:53:46.000000000","message":"After replacing xr \u0026 yr for xext \u0026 yext youcan remove lines 216-224","commit_id":"82622345d85252db2f9f6af944a324bf6a576c67"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"d720032983100bb918dc85b658526e0e6fad03d2","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            if yext:"},{"line_number":221,"context_line":"                return 1"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            if xr and yr:"},{"line_number":224,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":225,"context_line":"            if xr:"},{"line_number":226,"context_line":"                return -1"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F1p0%3D","line":223,"in_reply_to":"AAAAWH%2F%2F6nE%3D","updated":"2014-03-13 13:42:50.000000000","message":"Done","commit_id":"82622345d85252db2f9f6af944a324bf6a576c67"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"56268b8011b0de6555dc2793b40b2c4e4837f748","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            if yext:"},{"line_number":221,"context_line":"                return 1"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            if xr and yr:"},{"line_number":224,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":225,"context_line":"            if xr:"},{"line_number":226,"context_line":"                return -1"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2F6nE%3D","line":223,"in_reply_to":"AAAAWH%2F%2F6oM%3D","updated":"2014-03-12 23:54:56.000000000","message":"sorry, lines 223-228","commit_id":"82622345d85252db2f9f6af944a324bf6a576c67"},{"author":{"_account_id":10849,"name":"Kevin Fox","email":"Kevin.Fox@pnnl.gov","username":"kfox"},"change_message_id":"bb54331d3b0e1a555c7ea0fe679b4af46f977d56","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    views as r_views"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class NTCreateRouterView (r_views.CreateView):"},{"line_number":52,"context_line":"    template_name \u003d \u0027project/network_topology/create_router.html\u0027"},{"line_number":53,"context_line":"    success_url \u003d reverse_lazy(\"horizon:project:network_topology:index\")"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FUlM%3D","side":"PARENT","line":51,"updated":"2014-03-18 16:39:06.000000000","message":"It looks like this patch includes a lot of white space reformatting. Maybe an overly \"helpful\" IDE?\n\nPlease resubmit without the white space changes. Its much harder to review like this.","commit_id":"6de70303cf2cab4d6c03676b1e5dddfd763d1169"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"61c194b4267965a96764a43abd070a8ca84f7ffc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    views as r_views"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class NTCreateRouterView (r_views.CreateView):"},{"line_number":52,"context_line":"    template_name \u003d \u0027project/network_topology/create_router.html\u0027"},{"line_number":53,"context_line":"    success_url \u003d reverse_lazy(\"horizon:project:network_topology:index\")"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FTzM%3D","side":"PARENT","line":51,"in_reply_to":"AAAAWH%2F%2FUlM%3D","updated":"2014-03-18 17:53:55.000000000","message":"Yes, Sorry. PyCharm did this. I will fix it.","commit_id":"6de70303cf2cab4d6c03676b1e5dddfd763d1169"},{"author":{"_account_id":10849,"name":"Kevin Fox","email":"Kevin.Fox@pnnl.gov","username":"kfox"},"change_message_id":"bb54331d3b0e1a555c7ea0fe679b4af46f977d56","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                \u0027status\u0027: router.status,"},{"line_number":195,"context_line":"                \u0027external_gateway_info\u0027: router.external_gateway_info}"},{"line_number":196,"context_line":"            for router in neutron_routers]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        routers_with_gateways \u003d \\"},{"line_number":199,"context_line":"            dict([(i[\u0027id\u0027], 1) for i in data[\u0027routers\u0027]"},{"line_number":200,"context_line":"                if i.get(\u0027external_gateway_info\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FUiw%3D","line":197,"updated":"2014-03-18 16:39:06.000000000","message":"This code block looks good. Thanks for cleaning it up.","commit_id":"d48a87c951c579814910f4a8c9da4b36db8b27da"},{"author":{"_account_id":10849,"name":"Kevin Fox","email":"Kevin.Fox@pnnl.gov","username":"kfox"},"change_message_id":"3ec2c79105e75f907f3f1615bf530b799701e951","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \u0027name\u0027: publicnet.name,"},{"line_number":175,"context_line":"                    \u0027id\u0027: publicnet.id,"},{"line_number":176,"context_line":"                    \u0027subnets\u0027: subnets,"},{"line_number":177,"context_line":"                    \u0027router:external\u0027: publicnet[\u0027router:external\u0027]})"},{"line_number":178,"context_line":"        data[\u0027networks\u0027] \u003d sorted(networks,"},{"line_number":179,"context_line":"                                  key\u003dlambda x: x.get(\u0027router:external\u0027),"},{"line_number":180,"context_line":"                                  reverse\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FTg8%3D","line":177,"updated":"2014-03-18 18:26:45.000000000","message":"I\u0027d drop out this assignment too, since it is happening down below.","commit_id":"9b6a640e7ccbd4be63e9e7416dd3dddf14e65b73"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"30e19aa0c30c234fb3b889a95dda3561ac88d309","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \u0027name\u0027: publicnet.name,"},{"line_number":175,"context_line":"                    \u0027id\u0027: publicnet.id,"},{"line_number":176,"context_line":"                    \u0027subnets\u0027: subnets,"},{"line_number":177,"context_line":"                    \u0027router:external\u0027: publicnet[\u0027router:external\u0027]})"},{"line_number":178,"context_line":"        data[\u0027networks\u0027] \u003d sorted(networks,"},{"line_number":179,"context_line":"                                  key\u003dlambda x: x.get(\u0027router:external\u0027),"},{"line_number":180,"context_line":"                                  reverse\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2FTck%3D","line":177,"in_reply_to":"AAAAWH%2F%2FTg8%3D","updated":"2014-03-18 18:33:47.000000000","message":"You are right, sorry. I will upload a new change.","commit_id":"9b6a640e7ccbd4be63e9e7416dd3dddf14e65b73"},{"author":{"_account_id":10849,"name":"Kevin Fox","email":"Kevin.Fox@pnnl.gov","username":"kfox"},"change_message_id":"c7e4d56d6812d1b2b94e2f6bc3404218b1230445","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                xext \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":213,"context_line":"                yext \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            if xext and yext:"},{"line_number":216,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":217,"context_line":"            if xext:"},{"line_number":218,"context_line":"                return -1"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FTTM%3D","line":215,"updated":"2014-03-18 18:51:50.000000000","message":"Could drop this if block out entirely if the next couple of changes happen, causing two more lines to get eliminated.","commit_id":"5880dd378b74b25de5942c5be21600cfcdd9b22e"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"2d573ef014b57dd6f4fa77fb077b45b351a000ab","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                xext \u003d x.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":213,"context_line":"                yext \u003d y.get(\u0027id\u0027) in network_ids_with_gatewayed_routers"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            if xext and yext:"},{"line_number":216,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":217,"context_line":"            if xext:"},{"line_number":218,"context_line":"                return -1"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FTKs%3D","line":215,"in_reply_to":"AAAAWH%2F%2FTTM%3D","updated":"2014-03-18 19:07:32.000000000","message":"Done","commit_id":"5880dd378b74b25de5942c5be21600cfcdd9b22e"},{"author":{"_account_id":10849,"name":"Kevin Fox","email":"Kevin.Fox@pnnl.gov","username":"kfox"},"change_message_id":"c7e4d56d6812d1b2b94e2f6bc3404218b1230445","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            if xext and yext:"},{"line_number":216,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":217,"context_line":"            if xext:"},{"line_number":218,"context_line":"                return -1"},{"line_number":219,"context_line":"            if yext:"},{"line_number":220,"context_line":"                return 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FTT0%3D","line":217,"updated":"2014-03-18 18:51:50.000000000","message":"Could change this to:\nif xext and not yext:","commit_id":"5880dd378b74b25de5942c5be21600cfcdd9b22e"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"2d573ef014b57dd6f4fa77fb077b45b351a000ab","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            if xext and yext:"},{"line_number":216,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":217,"context_line":"            if xext:"},{"line_number":218,"context_line":"                return -1"},{"line_number":219,"context_line":"            if yext:"},{"line_number":220,"context_line":"                return 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FTKo%3D","line":217,"in_reply_to":"AAAAWH%2F%2FTT0%3D","updated":"2014-03-18 19:07:32.000000000","message":"Done","commit_id":"5880dd378b74b25de5942c5be21600cfcdd9b22e"},{"author":{"_account_id":10849,"name":"Kevin Fox","email":"Kevin.Fox@pnnl.gov","username":"kfox"},"change_message_id":"c7e4d56d6812d1b2b94e2f6bc3404218b1230445","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":217,"context_line":"            if xext:"},{"line_number":218,"context_line":"                return -1"},{"line_number":219,"context_line":"            if yext:"},{"line_number":220,"context_line":"                return 1"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"            return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FTTk%3D","line":219,"updated":"2014-03-18 18:51:50.000000000","message":"Could change this to: if yext and not xext:","commit_id":"5880dd378b74b25de5942c5be21600cfcdd9b22e"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"2d573ef014b57dd6f4fa77fb077b45b351a000ab","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"},{"line_number":217,"context_line":"            if xext:"},{"line_number":218,"context_line":"                return -1"},{"line_number":219,"context_line":"            if yext:"},{"line_number":220,"context_line":"                return 1"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"            return cmp(x[\u0027name\u0027], y[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2FTKk%3D","line":219,"in_reply_to":"AAAAWH%2F%2FTTk%3D","updated":"2014-03-18 19:07:32.000000000","message":"Done","commit_id":"5880dd378b74b25de5942c5be21600cfcdd9b22e"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"8d01d47c9c2fd01833d85cb0ee7c09860877b748","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                if i.get(\u0027device_owner\u0027) \u003d\u003d \u0027network:router_interface\u0027"},{"line_number":205,"context_line":"                and i[\u0027device_id\u0027] in routers_with_gateways])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        def mycmp(x, y):"},{"line_number":208,"context_line":"            xext \u003d x.get(\u0027router:external\u0027)"},{"line_number":209,"context_line":"            yext \u003d y.get(\u0027router:external\u0027)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FTDw%3D","line":207,"updated":"2014-03-18 19:23:06.000000000","message":"I think you could use a better method name, something like network_id_cmp for example","commit_id":"80a31572e25bd91c3a357a29d12d79a315512fea"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"d766aa829a64b2383f9d55d84158543eaa658430","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                if i.get(\u0027device_owner\u0027) \u003d\u003d \u0027network:router_interface\u0027"},{"line_number":205,"context_line":"                and i[\u0027device_id\u0027] in routers_with_gateways])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        def mycmp(x, y):"},{"line_number":208,"context_line":"            xext \u003d x.get(\u0027router:external\u0027)"},{"line_number":209,"context_line":"            yext \u003d y.get(\u0027router:external\u0027)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAWH%2F%2FSO0%3D","line":207,"in_reply_to":"AAAAWH%2F%2FTDw%3D","updated":"2014-03-18 21:38:31.000000000","message":"Done","commit_id":"80a31572e25bd91c3a357a29d12d79a315512fea"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65c5311c761e56a12362135ce841c1cda79c5a17","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        routers_with_gateways \u003d \\"},{"line_number":198,"context_line":"            dict([(i[\u0027id\u0027], 1) for i in data[\u0027routers\u0027]"},{"line_number":199,"context_line":"                if i.get(\u0027external_gateway_info\u0027)"},{"line_number":200,"context_line":"                and \u0027network_id\u0027 in i[\u0027external_gateway_info\u0027]])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        network_ids_with_gatewayed_routers \u003d \\"},{"line_number":203,"context_line":"            dict([(i[\u0027network_id\u0027], 1) for i in data[\u0027ports\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_4b6d7366","line":200,"updated":"2014-08-03 17:07:54.000000000","message":"We can write the logic as:\n\n  if \u0027network_id\u0027 in i.get(\u0027external_gateway_info\u0027, {})","commit_id":"3a89b708d3ae174da8b8730c25cbdf893db6a22a"}]}
