)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9a5b5962ced04b71bf42901e83170b0fb2f0a2c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Santiago Baldassin \u003csantiago.b.baldassin@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-13 08:47:03 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Init the extend vol form with the current vol size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Initialize the extend volume form with the current"},{"line_number":10,"context_line":"volume size"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2FsFM%3D","line":7,"updated":"2014-03-14 13:47:24.000000000","message":"Please update the message or change your code to init with the current vol_size,","commit_id":"19f283af57d6fe98d5e57f012842e0acb70f5d84"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"c4256f760204f613863c3ec12bcc17d57653d147","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Santiago Baldassin \u003csantiago.b.baldassin@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-13 08:47:03 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Init the extend vol form with the current vol size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Initialize the extend volume form with the current"},{"line_number":10,"context_line":"volume size"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2FrkA%3D","line":7,"in_reply_to":"AAAAWH%2F%2FsFM%3D","updated":"2014-03-14 14:34:10.000000000","message":"Done","commit_id":"19f283af57d6fe98d5e57f012842e0acb70f5d84"}],"openstack_dashboard/dashboards/project/volumes/volumes/forms.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6d25dd64f2d803f6944044ec2f59a14ae1d15078","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                           widget\u003dforms.TextInput("},{"line_number":496,"context_line":"                               attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}"},{"line_number":497,"context_line":"                           ))"},{"line_number":498,"context_line":"    size \u003d forms.IntegerField(min_value\u003d1, label\u003d_(\"Size (GB)\"))"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def clean(self):"},{"line_number":501,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F5Do%3D","line":498,"updated":"2014-03-13 05:46:21.000000000","message":"seems \u0027min_value\u003d1\u0027 not needed here.","commit_id":"f961cbd806a725023dbad014d19e04ce514ab79e"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"b3531c5ee853927a03f51bcf42bdb45d577f67f7","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                           widget\u003dforms.TextInput("},{"line_number":496,"context_line":"                               attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}"},{"line_number":497,"context_line":"                           ))"},{"line_number":498,"context_line":"    size \u003d forms.IntegerField(min_value\u003d1, label\u003d_(\"Size (GB)\"))"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def clean(self):"},{"line_number":501,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F2Zs%3D","line":498,"in_reply_to":"AAAAWH%2F%2F5Do%3D","updated":"2014-03-13 11:47:00.000000000","message":"Done","commit_id":"f961cbd806a725023dbad014d19e04ce514ab79e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e9a5fc460743d9f872ed0294d9f90679902ac0c","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                           widget\u003dforms.TextInput("},{"line_number":496,"context_line":"                               attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}"},{"line_number":497,"context_line":"                           ))"},{"line_number":498,"context_line":"    size \u003d forms.IntegerField(label\u003d_(\"Size (GB)\"))"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def clean(self):"},{"line_number":501,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F2CU%3D","line":498,"updated":"2014-03-13 12:35:31.000000000","message":"I am not sure why we need to change the field name. It seems unrelated to this change.","commit_id":"19f283af57d6fe98d5e57f012842e0acb70f5d84"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"fae7c6068a95b88f2d4168cce534c797f98c114e","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                           widget\u003dforms.TextInput("},{"line_number":496,"context_line":"                               attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}"},{"line_number":497,"context_line":"                           ))"},{"line_number":498,"context_line":"    size \u003d forms.IntegerField(label\u003d_(\"Size (GB)\"))"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def clean(self):"},{"line_number":501,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F194%3D","line":498,"in_reply_to":"AAAAWH%2F%2F2CU%3D","updated":"2014-03-13 12:44:13.000000000","message":"The field name has to match the one set in the view in order to be pre-populated. Either we change the view or we change the form","commit_id":"19f283af57d6fe98d5e57f012842e0acb70f5d84"}],"openstack_dashboard/dashboards/project/volumes/volumes/tests.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6d25dd64f2d803f6944044ec2f59a14ae1d15078","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                       \u0027volumesUsed\u0027: len(self.cinder_volumes.list()),"},{"line_number":1010,"context_line":"                       \u0027maxTotalVolumes\u0027: 6}"},{"line_number":1011,"context_line":"        formData \u003d {\u0027name\u0027: u\u0027A Volume I Am Making\u0027,"},{"line_number":1012,"context_line":"                    \u0027orig_size\u0027: volume.size,"},{"line_number":1013,"context_line":"                    \u0027new_size\u0027: 10}"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"        cinder.volume_get(IsA(http.HttpRequest), volume.id).\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F5Cc%3D","line":1012,"updated":"2014-03-13 05:46:21.000000000","message":"new_size -\u003e size.","commit_id":"f961cbd806a725023dbad014d19e04ce514ab79e"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"b3531c5ee853927a03f51bcf42bdb45d577f67f7","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                       \u0027volumesUsed\u0027: len(self.cinder_volumes.list()),"},{"line_number":1010,"context_line":"                       \u0027maxTotalVolumes\u0027: 6}"},{"line_number":1011,"context_line":"        formData \u003d {\u0027name\u0027: u\u0027A Volume I Am Making\u0027,"},{"line_number":1012,"context_line":"                    \u0027orig_size\u0027: volume.size,"},{"line_number":1013,"context_line":"                    \u0027new_size\u0027: 10}"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"        cinder.volume_get(IsA(http.HttpRequest), volume.id).\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F2aI%3D","line":1012,"in_reply_to":"AAAAWH%2F%2F5Cc%3D","updated":"2014-03-13 11:47:00.000000000","message":"Done","commit_id":"f961cbd806a725023dbad014d19e04ce514ab79e"}],"openstack_dashboard/dashboards/project/volumes/volumes/views.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6d25dd64f2d803f6944044ec2f59a14ae1d15078","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                \u0027name\u0027: volume.name,"},{"line_number":119,"context_line":"                #initialize the size field incrementing the current"},{"line_number":120,"context_line":"                #size by one since the current size is being extended"},{"line_number":121,"context_line":"                \u0027orig_size\u0027: volume.size,"},{"line_number":122,"context_line":"                \u0027size\u0027: volume.size + 1}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F5BQ%3D","line":121,"updated":"2014-03-13 05:46:21.000000000","message":"move comment lines next to  \u0027size\u0027: volume.size + 1 ?","commit_id":"f961cbd806a725023dbad014d19e04ce514ab79e"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"b3531c5ee853927a03f51bcf42bdb45d577f67f7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                \u0027name\u0027: volume.name,"},{"line_number":119,"context_line":"                #initialize the size field incrementing the current"},{"line_number":120,"context_line":"                #size by one since the current size is being extended"},{"line_number":121,"context_line":"                \u0027orig_size\u0027: volume.size,"},{"line_number":122,"context_line":"                \u0027size\u0027: volume.size + 1}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F2aQ%3D","line":121,"in_reply_to":"AAAAWH%2F%2F5BQ%3D","updated":"2014-03-13 11:47:00.000000000","message":"Done","commit_id":"f961cbd806a725023dbad014d19e04ce514ab79e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e9a5fc460743d9f872ed0294d9f90679902ac0c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        return {\u0027id\u0027: self.kwargs[\u0027volume_id\u0027],"},{"line_number":120,"context_line":"                \u0027name\u0027: volume.name,"},{"line_number":121,"context_line":"                \u0027orig_size\u0027: volume.size,"},{"line_number":122,"context_line":"                \u0027size\u0027: volume.size + 1}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class CreateSnapshotView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F2D8%3D","line":122,"updated":"2014-03-13 12:35:31.000000000","message":"How about setting the same value as orig_size?\n\nI am not sure +1GB is a reasonable initial value or not. If we use the same value, we can avoid a situation where a volume is extended by clicking or hitting return key by accident.","commit_id":"19f283af57d6fe98d5e57f012842e0acb70f5d84"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"fae7c6068a95b88f2d4168cce534c797f98c114e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        return {\u0027id\u0027: self.kwargs[\u0027volume_id\u0027],"},{"line_number":120,"context_line":"                \u0027name\u0027: volume.name,"},{"line_number":121,"context_line":"                \u0027orig_size\u0027: volume.size,"},{"line_number":122,"context_line":"                \u0027size\u0027: volume.size + 1}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class CreateSnapshotView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F174%3D","line":122,"in_reply_to":"AAAAWH%2F%2F2D8%3D","updated":"2014-03-13 12:44:13.000000000","message":"That was the original implementation. It was requested in patch set 1 to increment the pre-populated value by 1 to avoid another kind of accident where the user tries to extend and do not update the size. I think that since you are trying to extend, the best option is to pre-populate with the original size + 1","commit_id":"19f283af57d6fe98d5e57f012842e0acb70f5d84"}]}