)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Enabled Network QoS panel and added a button for"},{"line_number":10,"context_line":"creating a new network qos policy with parameters"},{"line_number":11,"context_line":"name, description, and shared (checkbox)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifabfac7553ddbb65fe387187da5dd2fafad31351"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"0e123261_f1a19f2e","line":12,"updated":"2021-08-02 12:02:41.000000000","message":"Could you please add the bp link in commit message like below:\n\nPartially-Implements https://blueprints.launchpad.net/horizon/+spec/network-bandwidth-limiting-qos","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"}],"openstack_dashboard/enabled/_1510_project_network_qos_panel.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"932179c1deec4de8a142282f7d191f1582967ca2","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Will default to disabled until the feature is completed."},{"line_number":13,"context_line":"#DISABLED \u003d True"},{"line_number":14,"context_line":"DISABLED \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"a6537681_9d45d943","line":14,"updated":"2021-07-06 12:53:22.000000000","message":"DISABLED \u003d False is the default.\nPlease drop L.12-13 (or keep it as-is if the feature is not completed).","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"62e3d12aac1634f268db54abde1444c1a941ed17","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Will default to disabled until the feature is completed."},{"line_number":13,"context_line":"#DISABLED \u003d True"},{"line_number":14,"context_line":"DISABLED \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc0cf962_3f6d3053","line":14,"in_reply_to":"a6537681_9d45d943","updated":"2021-07-07 10:35:17.000000000","message":"Done","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e2230a82d032e4f6c33b8741adecbe1fb0bad911","unresolved":true,"context_lines":[{"line_number":9,"context_line":"ADD_PANEL \u003d (\u0027openstack_dashboard.dashboards.project.network_qos\u0027"},{"line_number":10,"context_line":"             \u0027.panel.NetworkQoS\u0027)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DISABLED \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"fac6a93b_acccb598","line":12,"updated":"2021-07-15 16:04:47.000000000","message":"False is the default value. Let\u0027s drop it.","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"2b68fe2db694898ea765d12bcb7543b6488ebabb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ADD_PANEL \u003d (\u0027openstack_dashboard.dashboards.project.network_qos\u0027"},{"line_number":10,"context_line":"             \u0027.panel.NetworkQoS\u0027)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DISABLED \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"ac4a0a91_48f6e541","line":12,"in_reply_to":"fac6a93b_acccb598","updated":"2021-07-20 11:55:57.000000000","message":"Done","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"}],"openstack_dashboard/static/app/core/network_qos/actions/actions.module.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e2230a82d032e4f6c33b8741adecbe1fb0bad911","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"      }"},{"line_number":56,"context_line":"    );"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    qosResourceType.itemActions"},{"line_number":59,"context_line":"      .append({"},{"line_number":60,"context_line":"        id: \u0027deletePolicyAction\u0027,"}],"source_content_type":"text/javascript","patch_set":12,"id":"feb951f8_72948b27","line":57,"updated":"2021-07-15 16:04:47.000000000","message":"UT (spec.js) corresponding to the new code is also needed.","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"2b68fe2db694898ea765d12bcb7543b6488ebabb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"      }"},{"line_number":56,"context_line":"    );"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    qosResourceType.itemActions"},{"line_number":59,"context_line":"      .append({"},{"line_number":60,"context_line":"        id: \u0027deletePolicyAction\u0027,"}],"source_content_type":"text/javascript","patch_set":12,"id":"f73ce564_602a2cec","line":57,"in_reply_to":"feb951f8_72948b27","updated":"2021-07-20 11:55:57.000000000","message":"Done","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        id: \u0027createPolicyAction\u0027,"},{"line_number":50,"context_line":"        service: createService,"},{"line_number":51,"context_line":"        template: {"},{"line_number":52,"context_line":"          text: gettext(\u0027Create Policy\u0027),"},{"line_number":53,"context_line":"          type: \u0027create\u0027"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":17,"id":"ce1bf80f_76ab5990","line":52,"updated":"2021-08-02 12:02:41.000000000","message":"IMO \u0027Create Qos Policy\u0027 looks better.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"90d4616f874207dbba493a0331350c7e00931d47","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        id: \u0027createPolicyAction\u0027,"},{"line_number":50,"context_line":"        service: createService,"},{"line_number":51,"context_line":"        template: {"},{"line_number":52,"context_line":"          text: gettext(\u0027Create Policy\u0027),"},{"line_number":53,"context_line":"          type: \u0027create\u0027"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":17,"id":"e5eded5c_3c50f639","line":52,"in_reply_to":"21859cab_fdec5711","updated":"2021-08-04 12:30:31.000000000","message":"+1. Let\u0027s update it to all places in a separate patch.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0c9c69782a566f1a1c1e3040b92f8adb266f96a4","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        id: \u0027createPolicyAction\u0027,"},{"line_number":50,"context_line":"        service: createService,"},{"line_number":51,"context_line":"        template: {"},{"line_number":52,"context_line":"          text: gettext(\u0027Create Policy\u0027),"},{"line_number":53,"context_line":"          type: \u0027create\u0027"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":17,"id":"21859cab_fdec5711","line":52,"in_reply_to":"ce1bf80f_76ab5990","updated":"2021-08-03 12:19:09.000000000","message":"This is part of QoS panel, so I think \"Create Policy\" is no problem.\n\nI think it is better to keep the consistency.\nIf we should use \"QoS Policy\" over \"Policy\" here, let\u0027s do it together.\nMy suggestion is to use \"Create Policy\" in this commit and to propose another patch to use \"QoS Policy\" everywhere instead of \"Policy\".","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"}],"openstack_dashboard/static/app/core/network_qos/actions/actions.module.spec.js":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"334892a12a7ad0f4de0fb0e4b0fcb0a01cffdfd9","unresolved":true,"context_lines":[{"line_number":23,"context_line":"      registry \u003d $injector.get(\u0027horizon.framework.conf.resource-type-registry.service\u0027);"},{"line_number":24,"context_line":"    }));"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    it(\u0027registers Create Policy as an global action\u0027, function() {"},{"line_number":27,"context_line":"      var actions \u003d registry.getResourceType(\u0027OS::Neutron::QoSPolicy\u0027).globalActions;"},{"line_number":28,"context_line":"      expect(actionHasId(actions, \u0027createPolicyAction\u0027)).toBe(true);"},{"line_number":29,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":14,"id":"d3836181_17c5b6eb","line":26,"range":{"start_line":26,"start_character":35,"end_line":26,"end_character":37},"updated":"2021-07-28 09:31:16.000000000","message":"nit: s/an/a/","commit_id":"1be10af868b26cb2cb2f4419da323cce6ffc7ae6"}],"openstack_dashboard/static/app/core/network_qos/actions/create.action.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"932179c1deec4de8a142282f7d191f1582967ca2","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    function submit(context) {"},{"line_number":75,"context_line":"      var data \u003d {name: context.model.name};"},{"line_number":76,"context_line":"      data.description \u003d context.model.description;"},{"line_number":77,"context_line":"      data.shared \u003d context.model.shared;"},{"line_number":78,"context_line":"      return neutronAPI.createNetworkQoSPolicy(data).then(oncreateNetworkQoSPolicy);"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"226bc31d_119239c2","line":77,"range":{"start_line":75,"start_character":6,"end_line":77,"end_character":41},"updated":"2021-07-06 12:53:22.000000000","message":"Why don\u0027t you assing these in a single operation?","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"62e3d12aac1634f268db54abde1444c1a941ed17","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    function submit(context) {"},{"line_number":75,"context_line":"      var data \u003d {name: context.model.name};"},{"line_number":76,"context_line":"      data.description \u003d context.model.description;"},{"line_number":77,"context_line":"      data.shared \u003d context.model.shared;"},{"line_number":78,"context_line":"      return neutronAPI.createNetworkQoSPolicy(data).then(oncreateNetworkQoSPolicy);"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"0dd6f3c7_e483f747","line":77,"range":{"start_line":75,"start_character":6,"end_line":77,"end_character":41},"in_reply_to":"226bc31d_119239c2","updated":"2021-07-07 10:35:17.000000000","message":"Done","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e2230a82d032e4f6c33b8741adecbe1fb0bad911","unresolved":true,"context_lines":[{"line_number":76,"context_line":"      return neutronAPI.createNetworkQoSPolicy(data).then(oncreateNetworkQoSPolicy);"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    function oncreateNetworkQoSPolicy(response) {"},{"line_number":80,"context_line":"      var qospolicy \u003d response.data;"},{"line_number":81,"context_line":"      toast.add(\u0027success\u0027, interpolate("},{"line_number":82,"context_line":"        gettext(\u0027QoS Policy %s was successfully created.\u0027), [qospolicy.name]));"}],"source_content_type":"text/javascript","patch_set":12,"id":"ea17ca51_6eb625f6","line":79,"range":{"start_line":79,"start_character":13,"end_line":79,"end_character":21},"updated":"2021-07-15 16:04:47.000000000","message":"super it: oncreate -\u003e onCreate (per the camelcase nameing)","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"2b68fe2db694898ea765d12bcb7543b6488ebabb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"      return neutronAPI.createNetworkQoSPolicy(data).then(oncreateNetworkQoSPolicy);"},{"line_number":77,"context_line":"    }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    function oncreateNetworkQoSPolicy(response) {"},{"line_number":80,"context_line":"      var qospolicy \u003d response.data;"},{"line_number":81,"context_line":"      toast.add(\u0027success\u0027, interpolate("},{"line_number":82,"context_line":"        gettext(\u0027QoS Policy %s was successfully created.\u0027), [qospolicy.name]));"}],"source_content_type":"text/javascript","patch_set":12,"id":"5fd5f08a_39f3f28a","line":79,"range":{"start_line":79,"start_character":13,"end_line":79,"end_character":21},"in_reply_to":"ea17ca51_6eb625f6","updated":"2021-07-20 11:55:57.000000000","message":"Done","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"}],"openstack_dashboard/static/app/core/network_qos/actions/workflow/workflow.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e2230a82d032e4f6c33b8741adecbe1fb0bad911","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"36ae62ce_ce577914","updated":"2021-07-15 16:04:47.000000000","message":"UT (spec.js) corresponding to this file is also needed.","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"2b68fe2db694898ea765d12bcb7543b6488ebabb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7ecf7a20_f0a32eba","in_reply_to":"36ae62ce_ce577914","updated":"2021-07-20 11:55:57.000000000","message":"Done","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":45,"context_line":"          description: {"},{"line_number":46,"context_line":"            title: gettext(\u0027Description\u0027),"},{"line_number":47,"context_line":"            type: \u0027string\u0027,"},{"line_number":48,"context_line":"            maxLength: 30"},{"line_number":49,"context_line":"          },"},{"line_number":50,"context_line":"          shared: {"},{"line_number":51,"context_line":"            title: gettext(\u0027Shared\u0027),"}],"source_content_type":"text/javascript","patch_set":17,"id":"c7d42f9e_841fb04a","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":25},"updated":"2021-08-02 12:02:41.000000000","message":"why you set maximum length for \u0027Description\u0027 to 30 ?","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0c9c69782a566f1a1c1e3040b92f8adb266f96a4","unresolved":true,"context_lines":[{"line_number":45,"context_line":"          description: {"},{"line_number":46,"context_line":"            title: gettext(\u0027Description\u0027),"},{"line_number":47,"context_line":"            type: \u0027string\u0027,"},{"line_number":48,"context_line":"            maxLength: 30"},{"line_number":49,"context_line":"          },"},{"line_number":50,"context_line":"          shared: {"},{"line_number":51,"context_line":"            title: gettext(\u0027Shared\u0027),"}],"source_content_type":"text/javascript","patch_set":17,"id":"70832e55_760407c6","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":25},"in_reply_to":"c7d42f9e_841fb04a","updated":"2021-08-03 12:19:09.000000000","message":"In the neutron API definition, the max length of description field is 255.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":50,"context_line":"          shared: {"},{"line_number":51,"context_line":"            title: gettext(\u0027Shared\u0027),"},{"line_number":52,"context_line":"            type: \u0027boolean\u0027"},{"line_number":53,"context_line":"          }"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"        required: [\u0027name\u0027]"},{"line_number":56,"context_line":"      };"}],"source_content_type":"text/javascript","patch_set":17,"id":"500245cb_6fa35f7f","line":53,"updated":"2021-08-02 12:02:41.000000000","message":"you can also set shared default value here like below:\ndefault: false,","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"}],"openstack_dashboard/static/app/core/network_qos/actions/workflow/workflow.service.spec.js":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ce27e943c66ac51bca3823ef14357291c8fdb2fb","unresolved":true,"context_lines":[{"line_number":44,"context_line":"      return config;"},{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    it(\u0027should be create workflow config for creation\u0027, function() {"},{"line_number":48,"context_line":"      testInitWorkflow();"},{"line_number":49,"context_line":"    });"},{"line_number":50,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":16,"id":"4b3adb47_594725d0","line":47,"range":{"start_line":47,"start_character":15,"end_line":47,"end_character":17},"updated":"2021-08-02 07:49:59.000000000","message":"+1","commit_id":"1fec6e239af37565fc999f9cb7e8839456ea4fce"}],"openstack_dashboard/static/app/core/openstack-service-api/neutron.service.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"932179c1deec4de8a142282f7d191f1582967ca2","unresolved":true,"context_lines":[{"line_number":45,"context_line":"      getExtensions: getExtensions,"},{"line_number":46,"context_line":"      getNetworks: getNetworks,"},{"line_number":47,"context_line":"      getPorts: getPorts,"},{"line_number":48,"context_line":"      createNetworkQoSPolicy: createNetworkQoSPolicy,"},{"line_number":49,"context_line":"      getQosPolicy: getQosPolicy,"},{"line_number":50,"context_line":"      getQoSPolicies: getQoSPolicies,"},{"line_number":51,"context_line":"      getSubnets: getSubnets,"}],"source_content_type":"text/javascript","patch_set":4,"id":"63db1910_7414930e","line":48,"updated":"2021-07-06 12:53:22.000000000","message":"Looking at other entries here, it looks better to move to around L.38-40.","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"62e3d12aac1634f268db54abde1444c1a941ed17","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      getExtensions: getExtensions,"},{"line_number":46,"context_line":"      getNetworks: getNetworks,"},{"line_number":47,"context_line":"      getPorts: getPorts,"},{"line_number":48,"context_line":"      createNetworkQoSPolicy: createNetworkQoSPolicy,"},{"line_number":49,"context_line":"      getQosPolicy: getQosPolicy,"},{"line_number":50,"context_line":"      getQoSPolicies: getQoSPolicies,"},{"line_number":51,"context_line":"      getSubnets: getSubnets,"}],"source_content_type":"text/javascript","patch_set":4,"id":"d7f6b546_0c7b80ab","line":48,"in_reply_to":"63db1910_7414930e","updated":"2021-07-07 10:35:17.000000000","message":"Done","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"932179c1deec4de8a142282f7d191f1582967ca2","unresolved":true,"context_lines":[{"line_number":396,"context_line":"     * @name createNetworkQoSPolicy"},{"line_number":397,"context_line":"     * @description"},{"line_number":398,"context_line":"     * Create a single neutron qos policy."},{"line_number":399,"context_line":"     */"},{"line_number":400,"context_line":"    function createNetworkQoSPolicy(newQosPolicy) {"},{"line_number":401,"context_line":"      return apiService.post(\u0027/api/neutron/qos_policies/\u0027, newQosPolicy)"},{"line_number":402,"context_line":"        .error(function () {"}],"source_content_type":"text/javascript","patch_set":4,"id":"f7a220e4_d05f8377","line":399,"updated":"2021-07-06 12:53:22.000000000","message":"Could you add more infomration on parameters.\nSee createNetwork() above for more detail.","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"62e3d12aac1634f268db54abde1444c1a941ed17","unresolved":false,"context_lines":[{"line_number":396,"context_line":"     * @name createNetworkQoSPolicy"},{"line_number":397,"context_line":"     * @description"},{"line_number":398,"context_line":"     * Create a single neutron qos policy."},{"line_number":399,"context_line":"     */"},{"line_number":400,"context_line":"    function createNetworkQoSPolicy(newQosPolicy) {"},{"line_number":401,"context_line":"      return apiService.post(\u0027/api/neutron/qos_policies/\u0027, newQosPolicy)"},{"line_number":402,"context_line":"        .error(function () {"}],"source_content_type":"text/javascript","patch_set":4,"id":"811c7baa_d8d7fdda","line":399,"in_reply_to":"f7a220e4_d05f8377","updated":"2021-07-07 10:35:17.000000000","message":"Done","commit_id":"e472297c9a4c4f10050956c6f96372cfd2b82908"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e2230a82d032e4f6c33b8741adecbe1fb0bad911","unresolved":true,"context_lines":[{"line_number":427,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to create the qos policy.\u0027));"},{"line_number":428,"context_line":"        });"},{"line_number":429,"context_line":"    }"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    /**"},{"line_number":432,"context_line":"     * @name deletePolicy"},{"line_number":433,"context_line":"     * @description"}],"source_content_type":"text/javascript","patch_set":12,"id":"e21073ab_6cedd901","line":430,"updated":"2021-07-15 16:04:47.000000000","message":"UT (spec.js) corresponding to the new code is also needed.","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":33643,"name":"Nitish Venkata Patcherla","display_name":"Nitish","email":"nitish.patcherla@est.tech","username":"zitptan"},"change_message_id":"2b68fe2db694898ea765d12bcb7543b6488ebabb","unresolved":false,"context_lines":[{"line_number":427,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to create the qos policy.\u0027));"},{"line_number":428,"context_line":"        });"},{"line_number":429,"context_line":"    }"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    /**"},{"line_number":432,"context_line":"     * @name deletePolicy"},{"line_number":433,"context_line":"     * @description"}],"source_content_type":"text/javascript","patch_set":12,"id":"02bbc42c_0ec48a1b","line":430,"in_reply_to":"e21073ab_6cedd901","updated":"2021-07-20 11:55:57.000000000","message":"Done","commit_id":"f5ddb6e6c419bc6f4f73d891bc7ecc811c121534"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":424,"context_line":"    function createNetworkQoSPolicy(newQosPolicy) {"},{"line_number":425,"context_line":"      return apiService.post(\u0027/api/neutron/qos_policies/\u0027, newQosPolicy)"},{"line_number":426,"context_line":"        .error(function () {"},{"line_number":427,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to create the qos policy.\u0027));"},{"line_number":428,"context_line":"        });"},{"line_number":429,"context_line":"    }"},{"line_number":430,"context_line":""}],"source_content_type":"text/javascript","patch_set":17,"id":"bf003fcc_b6deb63a","line":427,"range":{"start_line":427,"start_character":45,"end_line":427,"end_character":76},"updated":"2021-08-02 12:02:41.000000000","message":"IMO \u0027Unable to create the Network qos policy\u0027 looks better.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"}],"openstack_dashboard/static/app/core/openstack-service-api/neutron.service.spec.js":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":316,"context_line":"        \"method\": \"post\","},{"line_number":317,"context_line":"        \"path\": \"/api/neutron/qos_policies/\","},{"line_number":318,"context_line":"        \"data\": \"new network qos policy\","},{"line_number":319,"context_line":"        \"error\": \"Unable to create the qos policy.\","},{"line_number":320,"context_line":"        \"testInput\": ["},{"line_number":321,"context_line":"          \"new network qos policy\""},{"line_number":322,"context_line":"        ]"}],"source_content_type":"text/javascript","patch_set":17,"id":"396d8470_f5fd7e79","line":319,"range":{"start_line":319,"start_character":18,"end_line":319,"end_character":49},"updated":"2021-08-02 12:02:41.000000000","message":"IMO \"Unable to create the Network qos policy\" looks better.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"}],"releasenotes/notes/network_qos-ee068d073e86de76.yaml":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added Network QoS Policy Panel."},{"line_number":5,"context_line":"    Network QoS Panel consists two operations"},{"line_number":6,"context_line":"    * Create QoS Policy"},{"line_number":7,"context_line":"    * Delete QoS Policy"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ebeb065b_401a68b2","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":34},"updated":"2021-08-02 12:02:41.000000000","message":"It is already done by https://review.opendev.org/c/openstack/horizon/+/418828.\nBefore you patch default Network Qos Panel is disabled and your patch changes the default value.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Added Network QoS Policy Panel."},{"line_number":5,"context_line":"    Network QoS Panel consists two operations"},{"line_number":6,"context_line":"    * Create QoS Policy"},{"line_number":7,"context_line":"    * Delete QoS Policy"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"93322109_d48905d3","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":23},"updated":"2021-08-02 12:02:41.000000000","message":"It is already done by https://review.opendev.org/c/openstack/horizon/+/487140.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0c9c69782a566f1a1c1e3040b92f8adb266f96a4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Added Network QoS Policy Panel."},{"line_number":5,"context_line":"    Network QoS Panel consists two operations"},{"line_number":6,"context_line":"    * Create QoS Policy"},{"line_number":7,"context_line":"    * Delete QoS Policy"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"56ce8f1b_f8b6b065","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":23},"in_reply_to":"93322109_d48905d3","updated":"2021-08-03 12:19:09.000000000","message":"Is this comment about L.7 only?\nTwo overlapping highlights are confusing, so I am asking.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1902f93ddb82ea2f2c22e72b8946e619905c4c9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ca97390e_23b432cc","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":0},"updated":"2021-08-02 12:02:41.000000000","message":"maybe you can change the releasenote to Add \"Create Qos Policy\" button to QoS Policies panel.","commit_id":"3aeb514328a002f55542b25f3d031a0699a8e169"}]}