)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"961708b2098f7faf220a74e8bf45ac3d74aaae25","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the instances pagination integration tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like the popup that comes up afteer creating instances is no"},{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"c7eb9950_3795be0b","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":41},"updated":"2021-07-21 08:53:04.000000000","message":"typo: afteer -\u003e after.","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"81c31e563bef0944da75c00849a01dd67574956d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the instances pagination integration tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like the popup that comes up afteer creating instances is no"},{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"76344a7d_a87e8f36","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":41},"in_reply_to":"c7eb9950_3795be0b","updated":"2021-07-21 13:29:10.000000000","message":"Done","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"961708b2098f7faf220a74e8bf45ac3d74aaae25","unresolved":true,"context_lines":[{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"},{"line_number":13,"context_line":"Closes-bug: #1774697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ad6af241_b81eaf2e","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"updated":"2021-07-21 08:53:04.000000000","message":"IMO we should use either Related or Partial Bug tag here because this patch only fixes instances pagination/filter related integration tests","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"81c31e563bef0944da75c00849a01dd67574956d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"},{"line_number":13,"context_line":"Closes-bug: #1774697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"60022f03_c324c21e","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":6},"in_reply_to":"ad6af241_b81eaf2e","updated":"2021-07-21 13:29:10.000000000","message":"Thanks for your review! Yeah, I forgot to mark it as WIP, I am still working on the rest of the skipped tests.","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"4222c6727e0d68fc68c0820872c14dad54a24785","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tatiana Ovchinnikova \u003ct.v.ovtchinnikova@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-26 08:48:43 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the instances pagination integration tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like the popup that comes up after creating instances is no"},{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"},{"line_number":13,"context_line":"Closes-bug: #1774697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"2daafa22_689278e0","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":40},"updated":"2021-07-28 18:14:31.000000000","message":"Now commit msg needs to be update, as it is fixes more than instances pagination integration tests.","commit_id":"311f65b4ae396b9100cbe44a089e284617d0d603"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"629a3d7979f81ab5714743deb0479b5368d3b503","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tatiana Ovchinnikova \u003ct.v.ovtchinnikova@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-26 08:48:43 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the instances pagination integration tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like the popup that comes up after creating instances is no"},{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"},{"line_number":13,"context_line":"Closes-bug: #1774697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"af7464d3_695a51fe","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":40},"in_reply_to":"2daafa22_689278e0","updated":"2021-07-28 20:33:06.000000000","message":"Thanks, will do.","commit_id":"311f65b4ae396b9100cbe44a089e284617d0d603"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"4222c6727e0d68fc68c0820872c14dad54a24785","unresolved":true,"context_lines":[{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"},{"line_number":13,"context_line":"Closes-bug: #1774697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"422aa9c4_31f72980","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2021-07-28 18:14:31.000000000","message":"Could you use Related/Partial as this patch fixes only few skipped integration test.","commit_id":"311f65b4ae396b9100cbe44a089e284617d0d603"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"629a3d7979f81ab5714743deb0479b5368d3b503","unresolved":true,"context_lines":[{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0e2976b56513df3cb45ea00e0f9f05603a8743a8"},{"line_number":13,"context_line":"Closes-bug: #1774697"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"66053012_0a2970a1","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"in_reply_to":"422aa9c4_31f72980","updated":"2021-07-28 20:33:06.000000000","message":"I\u0027d rather leave it as it is. I have looked through all the tests which were marked as skipped with \"Bug 1774697\" reason, and either fixed them by replacing \"SUCCESS\" with \"INFO\" or confirmed that there is another failure reason. So we don\u0027t have tests skipped with \"Bug 1774697\" anymore and can close this bug. Other skipped tests should be fixed separately.","commit_id":"311f65b4ae396b9100cbe44a089e284617d0d603"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"fea95405c25206a902ba47baf19068090fad4362","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like the popup that comes up after creating instances is no"},{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixes integration tests which were using the incorrect"},{"line_number":13,"context_line":"message class and revisits all other tests skipped with the same"},{"line_number":14,"context_line":"bug number reason."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"d38bbe67_8064826e","line":11,"updated":"2021-09-22 14:23:58.000000000","message":"It would be good to add a link to the patch which did that","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b68e928ed4e92876724edf42c27b9a58263792fc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like the popup that comes up after creating instances is no"},{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixes integration tests which were using the incorrect"},{"line_number":13,"context_line":"message class and revisits all other tests skipped with the same"},{"line_number":14,"context_line":"bug number reason."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa44eab4_6571140b","line":11,"in_reply_to":"4c9594d3_225c05e8","updated":"2021-12-01 15:40:03.000000000","message":"Ack","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b2d6c5a56fb22912cf31b0b4977ebb23ec1fc5b2","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Looks like the popup that comes up after creating instances is no"},{"line_number":10,"context_line":"longer a SUCCESS, but instead it\u0027s INFO."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixes integration tests which were using the incorrect"},{"line_number":13,"context_line":"message class and revisits all other tests skipped with the same"},{"line_number":14,"context_line":"bug number reason."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"4c9594d3_225c05e8","line":11,"in_reply_to":"d38bbe67_8064826e","updated":"2021-09-22 19:33:15.000000000","message":"They were skipped for years, so it\u0027s not easy to find out why it was \"SUCCESS\" in the first place. There\u0027s similar fixes here: https://review.opendev.org/c/openstack/horizon/+/688196 also without pointing a cause.","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8875803e29a1ecc36d5d7c55f18a6e1045d3d999","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4bc90247_a8332049","updated":"2021-12-01 17:18:12.000000000","message":"recheck","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"21c0deea559cbad261bce69400a03ddc18cc219c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5ebab931_5ca1e151","updated":"2021-12-02 17:58:42.000000000","message":"recheck","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"9980fe8e29710ddd458abd49591166708d88dd38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c3a02f6b_727a5f8a","updated":"2021-12-03 01:31:21.000000000","message":"recheck","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"bde8adfeb24014cbeb337f71432024fd14a5449f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c3b1e27c_9ba59386","updated":"2021-12-03 04:45:04.000000000","message":"recheck","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"c9719af27ed7aabb222e5b466b0ae8896ffc105b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f65ef892_e88a079c","updated":"2021-12-02 23:15:20.000000000","message":"recheck","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"bab3e12efff2cf9ff99f3b8fff839cfcd82135bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fcd4b261_ff9adfdf","updated":"2021-12-02 15:32:13.000000000","message":"recheck","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"e889e8d11bdcb21f737886cc6f41866e0f0087d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4027244c_1d1577ac","updated":"2021-12-02 04:51:35.000000000","message":"recheck, random test failure.","commit_id":"e53c4d8ca06fcaa4935ccad619bef8b7e3162590"}],"openstack_dashboard/test/integration_tests/tests/test_instances.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"961708b2098f7faf220a74e8bf45ac3d74aaae25","unresolved":true,"context_lines":[{"line_number":250,"context_line":"        return \u0027Name\u0027"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_instances_pagination(self):"},{"line_number":253,"context_line":"        \"\"\"This test checks instance pagination"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        Steps:"},{"line_number":256,"context_line":"        1) Login to Horizon Dashboard as admin"},{"line_number":257,"context_line":"        2) Navigate to user settings page"},{"line_number":258,"context_line":"        3) Change \u0027Items Per Page\u0027 value to 1"},{"line_number":259,"context_line":"        4) Go to Project \u003e Compute \u003e Instances page"},{"line_number":260,"context_line":"        5) Create 2 instances"},{"line_number":261,"context_line":"        6) Go to Admin \u003e Compute \u003e Instances page"},{"line_number":262,"context_line":"        7) Check that only \u0027Next\u0027 link is available, only one instance is"},{"line_number":263,"context_line":"           available (and it has correct name) on the first page"},{"line_number":264,"context_line":"        8) Click \u0027Next\u0027 and check that on the second page only one instance is"},{"line_number":265,"context_line":"           available (and it has correct name), there is no \u0027Next\u0027 link on page"},{"line_number":266,"context_line":"        9) Go to user settings page and restore \u0027Items Per Page\u0027"},{"line_number":267,"context_line":"        10) Delete created instances via proper page"},{"line_number":268,"context_line":"        \"\"\""},{"line_number":269,"context_line":"        items_per_page \u003d 1"},{"line_number":270,"context_line":"        instance_count \u003d 2"},{"line_number":271,"context_line":"        instance_list \u003d [\"{0}-{1}\".format(self.INSTANCE_NAME, item)"},{"line_number":272,"context_line":"                         for item in range(1, instance_count + 1)]"},{"line_number":273,"context_line":"        first_page_definition \u003d {\u0027Next\u0027: True, \u0027Prev\u0027: False,"},{"line_number":274,"context_line":"                                 \u0027Count\u0027: items_per_page,"},{"line_number":275,"context_line":"                                 \u0027Names\u0027: [instance_list[1]]}"},{"line_number":276,"context_line":"        second_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: True,"},{"line_number":277,"context_line":"                                  \u0027Count\u0027: items_per_page,"},{"line_number":278,"context_line":"                                  \u0027Names\u0027: [instance_list[0]]}"},{"line_number":279,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":280,"context_line":"        settings_page.change_pagesize(items_per_page)"},{"line_number":281,"context_line":"        self.assertTrue("},{"line_number":282,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        instances_page \u003d self.home_pg.go_to_project_compute_instancespage()"},{"line_number":285,"context_line":"        instances_page.create_instance(self.INSTANCE_NAME,"},{"line_number":286,"context_line":"                                       instance_count\u003dinstance_count)"},{"line_number":287,"context_line":"        self.assertTrue("},{"line_number":288,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":289,"context_line":"        self.assertTrue(instances_page.is_instance_active(instance_list[1]))"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":292,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":293,"context_line":"            first_page_definition, sorting\u003dTrue)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        instances_page.instances_table.turn_next_page()"},{"line_number":296,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":297,"context_line":"            second_page_definition, sorting\u003dTrue)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":300,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":301,"context_line":"            first_page_definition, sorting\u003dTrue)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":304,"context_line":"        settings_page.change_pagesize()"},{"line_number":305,"context_line":"        self.assertTrue("},{"line_number":306,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":309,"context_line":"        instances_page.delete_instances(instance_list)"},{"line_number":310,"context_line":"        self.assertTrue("},{"line_number":311,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":312,"context_line":"        self.assertTrue(instances_page.are_instances_deleted(instance_list))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_instances_pagination_and_filtration(self):"},{"line_number":315,"context_line":"        \"\"\"This test checks instance pagination and filtration"}],"source_content_type":"text/x-python","patch_set":9,"id":"faaf23f9_fdfa20f1","line":312,"range":{"start_line":253,"start_character":8,"end_line":312,"end_character":76},"updated":"2021-07-21 08:53:04.000000000","message":"rather than duplicating the same code can\u0027t we use \"super().test_instances_pagination()\" here?","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"81c31e563bef0944da75c00849a01dd67574956d","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        return \u0027Name\u0027"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_instances_pagination(self):"},{"line_number":253,"context_line":"        \"\"\"This test checks instance pagination"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        Steps:"},{"line_number":256,"context_line":"        1) Login to Horizon Dashboard as admin"},{"line_number":257,"context_line":"        2) Navigate to user settings page"},{"line_number":258,"context_line":"        3) Change \u0027Items Per Page\u0027 value to 1"},{"line_number":259,"context_line":"        4) Go to Project \u003e Compute \u003e Instances page"},{"line_number":260,"context_line":"        5) Create 2 instances"},{"line_number":261,"context_line":"        6) Go to Admin \u003e Compute \u003e Instances page"},{"line_number":262,"context_line":"        7) Check that only \u0027Next\u0027 link is available, only one instance is"},{"line_number":263,"context_line":"           available (and it has correct name) on the first page"},{"line_number":264,"context_line":"        8) Click \u0027Next\u0027 and check that on the second page only one instance is"},{"line_number":265,"context_line":"           available (and it has correct name), there is no \u0027Next\u0027 link on page"},{"line_number":266,"context_line":"        9) Go to user settings page and restore \u0027Items Per Page\u0027"},{"line_number":267,"context_line":"        10) Delete created instances via proper page"},{"line_number":268,"context_line":"        \"\"\""},{"line_number":269,"context_line":"        items_per_page \u003d 1"},{"line_number":270,"context_line":"        instance_count \u003d 2"},{"line_number":271,"context_line":"        instance_list \u003d [\"{0}-{1}\".format(self.INSTANCE_NAME, item)"},{"line_number":272,"context_line":"                         for item in range(1, instance_count + 1)]"},{"line_number":273,"context_line":"        first_page_definition \u003d {\u0027Next\u0027: True, \u0027Prev\u0027: False,"},{"line_number":274,"context_line":"                                 \u0027Count\u0027: items_per_page,"},{"line_number":275,"context_line":"                                 \u0027Names\u0027: [instance_list[1]]}"},{"line_number":276,"context_line":"        second_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: True,"},{"line_number":277,"context_line":"                                  \u0027Count\u0027: items_per_page,"},{"line_number":278,"context_line":"                                  \u0027Names\u0027: [instance_list[0]]}"},{"line_number":279,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":280,"context_line":"        settings_page.change_pagesize(items_per_page)"},{"line_number":281,"context_line":"        self.assertTrue("},{"line_number":282,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        instances_page \u003d self.home_pg.go_to_project_compute_instancespage()"},{"line_number":285,"context_line":"        instances_page.create_instance(self.INSTANCE_NAME,"},{"line_number":286,"context_line":"                                       instance_count\u003dinstance_count)"},{"line_number":287,"context_line":"        self.assertTrue("},{"line_number":288,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":289,"context_line":"        self.assertTrue(instances_page.is_instance_active(instance_list[1]))"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":292,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":293,"context_line":"            first_page_definition, sorting\u003dTrue)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        instances_page.instances_table.turn_next_page()"},{"line_number":296,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":297,"context_line":"            second_page_definition, sorting\u003dTrue)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":300,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":301,"context_line":"            first_page_definition, sorting\u003dTrue)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":304,"context_line":"        settings_page.change_pagesize()"},{"line_number":305,"context_line":"        self.assertTrue("},{"line_number":306,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":309,"context_line":"        instances_page.delete_instances(instance_list)"},{"line_number":310,"context_line":"        self.assertTrue("},{"line_number":311,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":312,"context_line":"        self.assertTrue(instances_page.are_instances_deleted(instance_list))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_instances_pagination_and_filtration(self):"},{"line_number":315,"context_line":"        \"\"\"This test checks instance pagination and filtration"}],"source_content_type":"text/x-python","patch_set":9,"id":"6cd9cc00_6b48e0c9","line":312,"range":{"start_line":253,"start_character":8,"end_line":312,"end_character":76},"in_reply_to":"faaf23f9_fdfa20f1","updated":"2021-07-21 13:29:10.000000000","message":"It\u0027s not the same, there are specific differences in instances_page.instances_table.assert_definition at L#292, L#296 and L#300. It cannot be simply reused since the pages themselves are different for admin/compute/instances and project/compute/instances.","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"961708b2098f7faf220a74e8bf45ac3d74aaae25","unresolved":true,"context_lines":[{"line_number":312,"context_line":"        self.assertTrue(instances_page.are_instances_deleted(instance_list))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_instances_pagination_and_filtration(self):"},{"line_number":315,"context_line":"        \"\"\"This test checks instance pagination and filtration"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        Steps:"},{"line_number":318,"context_line":"        1) Login to Horizon Dashboard as admin"},{"line_number":319,"context_line":"        2) Go to to user settings page"},{"line_number":320,"context_line":"        3) Change \u0027Items Per Page\u0027 value to 1"},{"line_number":321,"context_line":"        4) Go to Project \u003e Compute \u003e Instances page"},{"line_number":322,"context_line":"        5) Create 2 instances"},{"line_number":323,"context_line":"        6) Go to Admin \u003e Compute \u003e Instances page"},{"line_number":324,"context_line":"        7) Check filter by Name of the first and the second instance in order"},{"line_number":325,"context_line":"           to have one instance in the list (and it should have correct name)"},{"line_number":326,"context_line":"           and no \u0027Next\u0027 link is available"},{"line_number":327,"context_line":"        8) Check filter by common part of Name of in order to have one instance"},{"line_number":328,"context_line":"           in the list (and it should have correct name) and \u0027Next\u0027 link is"},{"line_number":329,"context_line":"           available on the first page and is not available on the second page"},{"line_number":330,"context_line":"        9) Go to user settings page and restore \u0027Items Per Page\u0027"},{"line_number":331,"context_line":"        10) Delete created instances via proper page"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        items_per_page \u003d 1"},{"line_number":335,"context_line":"        instance_count \u003d 2"},{"line_number":336,"context_line":"        instance_list \u003d [\"{0}-{1}\".format(self.INSTANCE_NAME, item)"},{"line_number":337,"context_line":"                         for item in range(1, instance_count + 1)]"},{"line_number":338,"context_line":"        first_page_definition \u003d {\u0027Next\u0027: True, \u0027Prev\u0027: False,"},{"line_number":339,"context_line":"                                 \u0027Count\u0027: items_per_page,"},{"line_number":340,"context_line":"                                 \u0027Names\u0027: [instance_list[1]]}"},{"line_number":341,"context_line":"        second_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: False,"},{"line_number":342,"context_line":"                                  \u0027Count\u0027: items_per_page,"},{"line_number":343,"context_line":"                                  \u0027Names\u0027: [instance_list[0]]}"},{"line_number":344,"context_line":"        filter_first_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: False,"},{"line_number":345,"context_line":"                                        \u0027Count\u0027: items_per_page,"},{"line_number":346,"context_line":"                                        \u0027Names\u0027: [instance_list[1]]}"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":349,"context_line":"        settings_page.change_pagesize(items_per_page)"},{"line_number":350,"context_line":"        self.assertTrue("},{"line_number":351,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        instances_page \u003d self.home_pg.go_to_project_compute_instancespage()"},{"line_number":354,"context_line":"        instances_page.create_instance(self.INSTANCE_NAME,"},{"line_number":355,"context_line":"                                       instance_count\u003dinstance_count)"},{"line_number":356,"context_line":"        self.assertTrue("},{"line_number":357,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":358,"context_line":"        self.assertTrue(instances_page.is_instance_active(instance_list[1]))"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":361,"context_line":"        instances_page.instances_table.set_filter_value(\u0027name\u0027)"},{"line_number":362,"context_line":"        instances_page.instances_table.filter(instance_list[1])"},{"line_number":363,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":364,"context_line":"            filter_first_page_definition, sorting\u003dTrue)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        instances_page.instances_table.filter(instance_list[0])"},{"line_number":367,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":368,"context_line":"            second_page_definition, sorting\u003dTrue)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        instances_page.instances_table.filter(self.INSTANCE_NAME)"},{"line_number":371,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":372,"context_line":"            first_page_definition, sorting\u003dTrue)"},{"line_number":373,"context_line":"        instances_page.instances_table.filter(\u0027\u0027)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":376,"context_line":"        settings_page.change_pagesize()"},{"line_number":377,"context_line":"        self.assertTrue("},{"line_number":378,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":381,"context_line":"        instances_page.delete_instances(instance_list)"},{"line_number":382,"context_line":"        self.assertTrue("},{"line_number":383,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":384,"context_line":"        self.assertTrue(instances_page.are_instances_deleted(instance_list))"}],"source_content_type":"text/x-python","patch_set":9,"id":"26516e5e_2c9676e4","line":384,"range":{"start_line":315,"start_character":8,"end_line":384,"end_character":76},"updated":"2021-07-21 08:53:04.000000000","message":"ditto.","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"81c31e563bef0944da75c00849a01dd67574956d","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        self.assertTrue(instances_page.are_instances_deleted(instance_list))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_instances_pagination_and_filtration(self):"},{"line_number":315,"context_line":"        \"\"\"This test checks instance pagination and filtration"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        Steps:"},{"line_number":318,"context_line":"        1) Login to Horizon Dashboard as admin"},{"line_number":319,"context_line":"        2) Go to to user settings page"},{"line_number":320,"context_line":"        3) Change \u0027Items Per Page\u0027 value to 1"},{"line_number":321,"context_line":"        4) Go to Project \u003e Compute \u003e Instances page"},{"line_number":322,"context_line":"        5) Create 2 instances"},{"line_number":323,"context_line":"        6) Go to Admin \u003e Compute \u003e Instances page"},{"line_number":324,"context_line":"        7) Check filter by Name of the first and the second instance in order"},{"line_number":325,"context_line":"           to have one instance in the list (and it should have correct name)"},{"line_number":326,"context_line":"           and no \u0027Next\u0027 link is available"},{"line_number":327,"context_line":"        8) Check filter by common part of Name of in order to have one instance"},{"line_number":328,"context_line":"           in the list (and it should have correct name) and \u0027Next\u0027 link is"},{"line_number":329,"context_line":"           available on the first page and is not available on the second page"},{"line_number":330,"context_line":"        9) Go to user settings page and restore \u0027Items Per Page\u0027"},{"line_number":331,"context_line":"        10) Delete created instances via proper page"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":"        items_per_page \u003d 1"},{"line_number":335,"context_line":"        instance_count \u003d 2"},{"line_number":336,"context_line":"        instance_list \u003d [\"{0}-{1}\".format(self.INSTANCE_NAME, item)"},{"line_number":337,"context_line":"                         for item in range(1, instance_count + 1)]"},{"line_number":338,"context_line":"        first_page_definition \u003d {\u0027Next\u0027: True, \u0027Prev\u0027: False,"},{"line_number":339,"context_line":"                                 \u0027Count\u0027: items_per_page,"},{"line_number":340,"context_line":"                                 \u0027Names\u0027: [instance_list[1]]}"},{"line_number":341,"context_line":"        second_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: False,"},{"line_number":342,"context_line":"                                  \u0027Count\u0027: items_per_page,"},{"line_number":343,"context_line":"                                  \u0027Names\u0027: [instance_list[0]]}"},{"line_number":344,"context_line":"        filter_first_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: False,"},{"line_number":345,"context_line":"                                        \u0027Count\u0027: items_per_page,"},{"line_number":346,"context_line":"                                        \u0027Names\u0027: [instance_list[1]]}"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":349,"context_line":"        settings_page.change_pagesize(items_per_page)"},{"line_number":350,"context_line":"        self.assertTrue("},{"line_number":351,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        instances_page \u003d self.home_pg.go_to_project_compute_instancespage()"},{"line_number":354,"context_line":"        instances_page.create_instance(self.INSTANCE_NAME,"},{"line_number":355,"context_line":"                                       instance_count\u003dinstance_count)"},{"line_number":356,"context_line":"        self.assertTrue("},{"line_number":357,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":358,"context_line":"        self.assertTrue(instances_page.is_instance_active(instance_list[1]))"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":361,"context_line":"        instances_page.instances_table.set_filter_value(\u0027name\u0027)"},{"line_number":362,"context_line":"        instances_page.instances_table.filter(instance_list[1])"},{"line_number":363,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":364,"context_line":"            filter_first_page_definition, sorting\u003dTrue)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        instances_page.instances_table.filter(instance_list[0])"},{"line_number":367,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":368,"context_line":"            second_page_definition, sorting\u003dTrue)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        instances_page.instances_table.filter(self.INSTANCE_NAME)"},{"line_number":371,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":372,"context_line":"            first_page_definition, sorting\u003dTrue)"},{"line_number":373,"context_line":"        instances_page.instances_table.filter(\u0027\u0027)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        settings_page \u003d self.home_pg.go_to_settings_usersettingspage()"},{"line_number":376,"context_line":"        settings_page.change_pagesize()"},{"line_number":377,"context_line":"        self.assertTrue("},{"line_number":378,"context_line":"            settings_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        instances_page \u003d self.instances_page"},{"line_number":381,"context_line":"        instances_page.delete_instances(instance_list)"},{"line_number":382,"context_line":"        self.assertTrue("},{"line_number":383,"context_line":"            instances_page.find_message_and_dismiss(messages.INFO))"},{"line_number":384,"context_line":"        self.assertTrue(instances_page.are_instances_deleted(instance_list))"}],"source_content_type":"text/x-python","patch_set":9,"id":"d7b85c90_8ec6ee8c","line":384,"range":{"start_line":315,"start_character":8,"end_line":384,"end_character":76},"in_reply_to":"26516e5e_2c9676e4","updated":"2021-07-21 13:29:10.000000000","message":"Same here","commit_id":"cec1c1020d697466521d56aeddafd9dce9b24d53"}]}