)]}'
{"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d9b1648f24cb5d173875a438ba45cd0c82adf105","unresolved":true,"context_lines":[{"line_number":1045,"context_line":"def is_volume_service_enabled(request):"},{"line_number":1046,"context_line":"    return bool("},{"line_number":1047,"context_line":"        base.is_service_enabled(request, \u0027volumev3\u0027) or"},{"line_number":1048,"context_line":"        base.is_service_enabled(request, \u0027volumev2\u0027) or"},{"line_number":1049,"context_line":"        base.is_service_enabled(request, \u0027volume\u0027)"},{"line_number":1050,"context_line":"    )"},{"line_number":1051,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"6966345a_db578812","line":1048,"range":{"start_line":1048,"start_character":8,"end_line":1048,"end_character":52},"updated":"2021-07-16 05:50:52.000000000","message":"Do we need to remove this as well?","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fb94d67003ea3c3b78ced368e980429de4db2fec","unresolved":true,"context_lines":[{"line_number":721,"context_line":""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"@profiler.trace"},{"line_number":724,"context_line":"def tenant_quota_get(request, tenant_id):"},{"line_number":725,"context_line":"    c_client \u003d cinderclient(request)"},{"line_number":726,"context_line":"    if c_client is None:"},{"line_number":727,"context_line":"        return base.QuotaSet()"},{"line_number":728,"context_line":"    return base.QuotaSet(c_client.quotas.get(tenant_id))"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"@profiler.trace"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a7a536b_e763806e","line":728,"range":{"start_line":724,"start_character":0,"end_line":728,"end_character":56},"updated":"2021-07-19 12:00:29.000000000","message":"Just want to verify that I understand this correctly.  We don\u0027t need the workaround here for the missing cinderclient.v3.QuotaSet that we added to the test_data/cinder_data.py file because we\u0027re using the openstack_dashboard.api.base.QuotaSet class to handle the JSON coming back from cinder (that is, we aren\u0027t using the cinderclient class at all here).","commit_id":"52e4ea1363c274a2b5ca4695efd9ade5e51fe639"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f220992b1076e70420044d04160d31c45385f6db","unresolved":true,"context_lines":[{"line_number":721,"context_line":""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"@profiler.trace"},{"line_number":724,"context_line":"def tenant_quota_get(request, tenant_id):"},{"line_number":725,"context_line":"    c_client \u003d cinderclient(request)"},{"line_number":726,"context_line":"    if c_client is None:"},{"line_number":727,"context_line":"        return base.QuotaSet()"},{"line_number":728,"context_line":"    return base.QuotaSet(c_client.quotas.get(tenant_id))"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"@profiler.trace"}],"source_content_type":"text/x-python","patch_set":12,"id":"e3061058_fe455f12","line":728,"range":{"start_line":724,"start_character":0,"end_line":728,"end_character":56},"updated":"2021-07-19 12:02:57.000000000","message":"Just want to verify that I understand this correctly.  We don\u0027t need the workaround here for the missing cinderclient.v3.QuotaSet that we added to the test_data/cinder_data.py file because we\u0027re using the openstack_dashboard.api.base.QuotaSet class to handle the JSON coming back from cinder (that is, we aren\u0027t using the cinderclient class at all here).","commit_id":"b58ac2894b9b901d6ed433fb049502d988222ceb"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"e29ce13cee6516649cbdd2cac1cb71768736c14c","unresolved":true,"context_lines":[{"line_number":721,"context_line":""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"@profiler.trace"},{"line_number":724,"context_line":"def tenant_quota_get(request, tenant_id):"},{"line_number":725,"context_line":"    c_client \u003d cinderclient(request)"},{"line_number":726,"context_line":"    if c_client is None:"},{"line_number":727,"context_line":"        return base.QuotaSet()"},{"line_number":728,"context_line":"    return base.QuotaSet(c_client.quotas.get(tenant_id))"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"@profiler.trace"}],"source_content_type":"text/x-python","patch_set":12,"id":"ae7c36bd_76a8c986","line":728,"range":{"start_line":724,"start_character":0,"end_line":728,"end_character":56},"in_reply_to":"e3061058_fe455f12","updated":"2021-07-20 08:22:26.000000000","message":"make sense, there is no dependency of quota class with cinderclient so we don\u0027t need a workaround here.","commit_id":"b58ac2894b9b901d6ed433fb049502d988222ceb"}],"releasenotes/notes/cinderclient-v3-only-daae11ff71a26ba7.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"45b6cbf2d8fb284a5148372a6f9df07db0ad899c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Cinder project has removed Block Storage API v2 support from the"},{"line_number":5,"context_line":"    python-cinderclient library.  This will not impact Horizon functionality"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"02d1dc10_5cabefa1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2021-07-16 06:29:37.000000000","message":"I don\u0027t think \"issue\" is the right catagory. We can cover \"the removal of the Cinder v2 API\" in the \"upgrade\" section.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"f25d27842e98bb4c5c17d61517957739f0c7dee4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Cinder project has removed Block Storage API v2 support from the"},{"line_number":5,"context_line":"    python-cinderclient library.  This will not impact Horizon functionality"},{"line_number":6,"context_line":"    given that we have been using Block Storage API v3 by default since"},{"line_number":7,"context_line":"    the Queens release.  However, this Horizon release requires"},{"line_number":8,"context_line":"    python-cinderclient version 8.0.0 or greater."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"683ba944_89c0156b","line":8,"range":{"start_line":7,"start_character":25,"end_line":8,"end_character":48},"updated":"2021-07-15 18:58:49.000000000","message":"Shouldn\u0027t we update minimum python-cinderclient version in horizon requirement.txt [1].\nlooking at zuul logs right now it is using \"python-cinderclient\u003d\u003d7.4.0\" version\nor we can update it later once you release latest version?\n\n\n[1] https://github.com/openstack/horizon/blob/master/requirements.txt#L33","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a64fe4a21deff48b4e911f2e42e6a59bd508ae06","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Cinder project has removed Block Storage API v2 support from the"},{"line_number":5,"context_line":"    python-cinderclient library.  This will not impact Horizon functionality"},{"line_number":6,"context_line":"    given that we have been using Block Storage API v3 by default since"},{"line_number":7,"context_line":"    the Queens release.  However, this Horizon release requires"},{"line_number":8,"context_line":"    python-cinderclient version 8.0.0 or greater."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"01bb9382_6bbbe264","line":8,"range":{"start_line":7,"start_character":25,"end_line":8,"end_character":48},"in_reply_to":"2c0ba04a_dd5c2868","updated":"2021-07-16 09:03:01.000000000","message":"The Block Storage API v2 was marked deprecated in version 11.0.0 (Pike) by change I913c44799cddc37c3342729ec0ef34068db5b2d4 (https://review.opendev.org/c/openstack/cinder/+/438195).","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"45b6cbf2d8fb284a5148372a6f9df07db0ad899c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Cinder project has removed Block Storage API v2 support from the"},{"line_number":5,"context_line":"    python-cinderclient library.  This will not impact Horizon functionality"},{"line_number":6,"context_line":"    given that we have been using Block Storage API v3 by default since"},{"line_number":7,"context_line":"    the Queens release.  However, this Horizon release requires"},{"line_number":8,"context_line":"    python-cinderclient version 8.0.0 or greater."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2c0ba04a_dd5c2868","line":8,"range":{"start_line":7,"start_character":25,"end_line":8,"end_character":48},"in_reply_to":"4b2226ff_4228ce39","updated":"2021-07-16 06:29:37.000000000","message":"IMHO the horizon release note does not need to explain the detail context like cinderclient. I think what we need to describe here is just \"horizon drops the support of the cinder v2 API which is marked as deprecated along with the drop of the cinder v2 API support in python-cinderclient\". I don\u0027t think python-cinderclient version needs to be covered here.\n\nOne question to improve my idea above.\n- Since when is the cinder v2 API marked as deprecated? since queens?","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b86d1ddab90c851204a51ac0975c58e3b4cdd8b5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Cinder project has removed Block Storage API v2 support from the"},{"line_number":5,"context_line":"    python-cinderclient library.  This will not impact Horizon functionality"},{"line_number":6,"context_line":"    given that we have been using Block Storage API v3 by default since"},{"line_number":7,"context_line":"    the Queens release.  However, this Horizon release requires"},{"line_number":8,"context_line":"    python-cinderclient version 8.0.0 or greater."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"87f92820_928db811","line":8,"range":{"start_line":7,"start_character":25,"end_line":8,"end_character":48},"in_reply_to":"683ba944_89c0156b","updated":"2021-07-15 20:15:13.000000000","message":"This release note is forward-looking to the Xena release, when the new cinderclient will be available.  Right now we\u0027re using 7.4.0 because that\u0027s the most recent release.  Version 8.0.0 won\u0027t be available until after this patch merges, because 8.0.0 won\u0027t contain any cinderclient.v2 classes.\n\nI could remove mention of 8.0.0 from the note and add it back after cinderclient 8.0.0 is released (I\u0027m planning to do a followup patch in Horizon to remove the workaround and update requirements.txt), if the Horizon team thinks that would be better.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d9b1648f24cb5d173875a438ba45cd0c82adf105","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The Cinder project has removed Block Storage API v2 support from the"},{"line_number":5,"context_line":"    python-cinderclient library.  This will not impact Horizon functionality"},{"line_number":6,"context_line":"    given that we have been using Block Storage API v3 by default since"},{"line_number":7,"context_line":"    the Queens release.  However, this Horizon release requires"},{"line_number":8,"context_line":"    python-cinderclient version 8.0.0 or greater."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4b2226ff_4228ce39","line":8,"range":{"start_line":7,"start_character":25,"end_line":8,"end_character":48},"in_reply_to":"87f92820_928db811","updated":"2021-07-16 05:50:52.000000000","message":"ok gotcha, let it be as it is fine for me.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"f25d27842e98bb4c5c17d61517957739f0c7dee4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"},{"line_number":12,"context_line":"    8.0.0 or greater."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2ca343f6_3ddf1c02","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":9},"updated":"2021-07-15 18:58:49.000000000","message":"Also, python-cinderclient 7.5.0 version will be next version which removes v2 support then why horizon requires 8.0.0 or greater version? Am I missing something here.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d9b1648f24cb5d173875a438ba45cd0c82adf105","unresolved":true,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"},{"line_number":12,"context_line":"    8.0.0 or greater."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a89bd3b1_0a8e1cc3","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":9},"in_reply_to":"1cfe0285_664a74e2","updated":"2021-07-16 05:50:52.000000000","message":"ok, thanks for clarifying.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b86d1ddab90c851204a51ac0975c58e3b4cdd8b5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"},{"line_number":12,"context_line":"    8.0.0 or greater."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1cfe0285_664a74e2","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":9},"in_reply_to":"2ca343f6_3ddf1c02","updated":"2021-07-15 20:15:13.000000000","message":"Because removing the cinderclient.v2 classes is a breaking change, the version that does that will require a change in the major number from 7 to 8.  The 7.x series is tied to stable/wallaby and will continue to contain the v2 classes.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a64fe4a21deff48b4e911f2e42e6a59bd508ae06","unresolved":true,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"},{"line_number":12,"context_line":"    8.0.0 or greater."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b1b229ad_6e54599f","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":9},"in_reply_to":"4c0d8154_91fe309b","updated":"2021-07-16 09:03:01.000000000","message":"OK, how is this:\n\n  The Cinder project deprecated the Block Storage API v2 in the Pike release, and Horizon has been using the Block Storage API v3 by default since Queens.  With this release, Horizon uses only the Block Storage API v3.\n\nYou are correct that the changes to support the upcoming cinderclient release are implementation details that don\u0027t impact operators, so I agree that we don\u0027t need to call them out in the release note.  And I am fine with just having this in the \"upgrade\" section.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"45b6cbf2d8fb284a5148372a6f9df07db0ad899c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - |"},{"line_number":11,"context_line":"    This release should only be used with python-cinderclient version"},{"line_number":12,"context_line":"    8.0.0 or greater."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4c0d8154_91fe309b","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":9},"in_reply_to":"a89bd3b1_0a8e1cc3","updated":"2021-07-16 06:29:37.000000000","message":"IMHO we don\u0027t need this in the release note as we maintain our dependencies in requirements file. Perhaps we will bump the min version of python-cinderclient to \u003e\u003d8.0.0 but this commit does not necessarily mean that horizon must bump the min version of python-cinderclient. I think the point of this commit is to make horizon work with the latest python-cinderclient.","commit_id":"b39b935fa2e1de500804f69ab1f767a9863f7520"}]}