)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"056c4c984a52e61a331a4a30a4fb736288bd2137","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tatiana Ovchinnikova \u003ct.v.ovtchinnikova@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-19 13:40:37 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Proper title for Disk Format column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At Launch Instance dialog, Source tab, for boot sources Image and"},{"line_number":10,"context_line":"Instance Snapshot there\u0027s Format table column. However the title for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b0f02e6c_ed58c037","line":7,"updated":"2021-08-19 19:14:20.000000000","message":"\"Disk Format\" is not introduced by this change. Does \"disk format\" in the commit message still work?","commit_id":"45e8d914a758685c062bfec50680c3ab645c6682"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ccee7dc05883ffd163cc3ccb29dd40e47d2ed897","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tatiana Ovchinnikova \u003ct.v.ovtchinnikova@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-19 13:40:37 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Proper title for Disk Format column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At Launch Instance dialog, Source tab, for boot sources Image and"},{"line_number":10,"context_line":"Instance Snapshot there\u0027s Format table column. However the title for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"de23c209_61961e12","line":7,"in_reply_to":"b0f02e6c_ed58c037","updated":"2021-08-20 14:06:36.000000000","message":"Done","commit_id":"45e8d914a758685c062bfec50680c3ab645c6682"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e94b918aa83279ce825b9a57643f02c3bd457be0","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        { id: \u0027name_or_id\u0027, title: gettext(\u0027Name\u0027), priority: 1 },"},{"line_number":169,"context_line":"        { id: \u0027updated_at\u0027, title: gettext(\u0027Updated\u0027), filters: [\u0027simpleDate\u0027], priority: 2 },"},{"line_number":170,"context_line":"        { id: \u0027size\u0027, title: gettext(\u0027Size\u0027), filters: [\u0027bytes\u0027], priority: 2 },"},{"line_number":171,"context_line":"        { id: \u0027disk_format\u0027, title: gettext(\u0027Disk Format\u0027),"},{"line_number":172,"context_line":"          filters: [getImageDiskFormat], priority: 2 },"},{"line_number":173,"context_line":"        { id: \u0027visibility\u0027, title: gettext(\u0027Visibility\u0027), filters: [getVisibility], priority: 2 }"},{"line_number":174,"context_line":"      ],"}],"source_content_type":"text/javascript","patch_set":3,"id":"9169ef8b_c916355a","line":171,"range":{"start_line":171,"start_character":45,"end_line":171,"end_character":56},"updated":"2021-08-16 15:52:00.000000000","message":"Why doesn\u0027t \"Format\" work?\n\nLooking at diskFormat defined at L.121, the list looks specific to horizon.\n\"Dcoker\" is not a disk format in glance. It is a container format in glance.\nFrom the same reason I explained in a past patch set, I do not like \"Disk Format\" here.","commit_id":"1ff6071b8425e1c99ec6d3913eedc8677504e294"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"18e8e7b8a505fd6ab84974a139487547fa81d493","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        { id: \u0027name_or_id\u0027, title: gettext(\u0027Name\u0027), priority: 1 },"},{"line_number":169,"context_line":"        { id: \u0027updated_at\u0027, title: gettext(\u0027Updated\u0027), filters: [\u0027simpleDate\u0027], priority: 2 },"},{"line_number":170,"context_line":"        { id: \u0027size\u0027, title: gettext(\u0027Size\u0027), filters: [\u0027bytes\u0027], priority: 2 },"},{"line_number":171,"context_line":"        { id: \u0027disk_format\u0027, title: gettext(\u0027Disk Format\u0027),"},{"line_number":172,"context_line":"          filters: [getImageDiskFormat], priority: 2 },"},{"line_number":173,"context_line":"        { id: \u0027visibility\u0027, title: gettext(\u0027Visibility\u0027), filters: [getVisibility], priority: 2 }"},{"line_number":174,"context_line":"      ],"}],"source_content_type":"text/javascript","patch_set":3,"id":"4505b82b_ce0dd15c","line":171,"range":{"start_line":171,"start_character":45,"end_line":171,"end_character":56},"in_reply_to":"9169ef8b_c916355a","updated":"2021-08-19 18:43:01.000000000","message":"Done","commit_id":"1ff6071b8425e1c99ec6d3913eedc8677504e294"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"86eb6ce9fddbdd5c717e2e9ba15cffc3936e6887","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        ]"},{"line_number":165,"context_line":"      })"},{"line_number":166,"context_line":"      .append({"},{"line_number":167,"context_line":"        label: gettext(\u0027Disk Format\u0027),"},{"line_number":168,"context_line":"        name: \u0027disk_format\u0027,"},{"line_number":169,"context_line":"        isServer: true,"},{"line_number":170,"context_line":"        singleton: true,"}],"source_content_type":"text/javascript","patch_set":2,"id":"619aa440_a21e83c1","line":167,"updated":"2021-08-05 08:07:57.000000000","message":"The reason we use \"Format\" in horizon is because \"format\" in horizon is a combination of \"disk format\" and \"container format\" and horizon selects appropriate disk_format and container_format depending on a \"format\" specified.\n\nThe detail list of available disk_format and container_format is found at [1].\n\nFor example, \"docker\" and \"ova\" are not a disk format but a container format.\n\n[1] https://docs.openstack.org/api-ref/image/v2/index.html?expanded\u003dcreate-image-detail#create-image","commit_id":"a5f57e6eef9d52f294e48eacea118f22cf3a49b8"}]}
