)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5d87b88f3c817bb0aa7db5ffae2e27b78fe948db","unresolved":true,"context_lines":[{"line_number":12,"context_line":"deleted only when \u0027force\u0027 flag is specified."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://opendev.org/openstack/cinder/src/commit/ae5fd170f0a51306cc9ba44ba9d5fe4169fed239/cinder/volume/api.py#L480-L481"},{"line_number":15,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003ddelete-a-volume-detail#delete-a-volume"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Akihiro Motoki \u003camotoki@gmail.com\u003e"},{"line_number":18,"context_line":"Change-Id: I4a4f3fed1c8e02245573512a1e43749b03890324"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ec847e1a_5a6c3330","line":15,"updated":"2022-02-04 05:16:49.000000000","message":"Super nit: you forgot to add [2] here.","commit_id":"8fa8bd37271d5911d2e7a322a3399c52a72072cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"40ab661ad525506019c1c5d33acb5d4ee00e355a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"deleted only when \u0027force\u0027 flag is specified."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://opendev.org/openstack/cinder/src/commit/ae5fd170f0a51306cc9ba44ba9d5fe4169fed239/cinder/volume/api.py#L480-L481"},{"line_number":15,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003ddelete-a-volume-detail#delete-a-volume"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: Akihiro Motoki \u003camotoki@gmail.com\u003e"},{"line_number":18,"context_line":"Change-Id: I4a4f3fed1c8e02245573512a1e43749b03890324"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"48901462_0b6fff89","line":15,"in_reply_to":"ec847e1a_5a6c3330","updated":"2022-02-08 22:23:07.000000000","message":"I will update it if I have a chance to update the change.","commit_id":"8fa8bd37271d5911d2e7a322a3399c52a72072cd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1e67debb885849c2ff58757b16adddb38a2463bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c154da41_8a8e391c","updated":"2021-12-07 06:49:19.000000000","message":"Thanks for the patch, Please find one comment inline.","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"b0374ffafd35ea8896244683d76848c4fd943c2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4fd76d90_65bbb07d","updated":"2022-09-19 16:46:24.000000000","message":"Considering amotoki +1 as +2 as he is co-author in this patch.\napproving it.","commit_id":"8fa8bd37271d5911d2e7a322a3399c52a72072cd"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5d87b88f3c817bb0aa7db5ffae2e27b78fe948db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f74aeac2_e8ccd4fe","updated":"2022-02-04 05:16:49.000000000","message":"Thanks amotoki for updating the patch.\nLGTM, now.","commit_id":"8fa8bd37271d5911d2e7a322a3399c52a72072cd"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"3d00fd04d84d2c74a9f1f05a6d9a29ea927ea80e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a851c801_969b1f51","updated":"2022-08-31 14:38:35.000000000","message":"adding review priority on this patch to get some more attentions.","commit_id":"8fa8bd37271d5911d2e7a322a3399c52a72072cd"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"68c2f040ea45b241a8a034e01dd18b108a0a356b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9005b1df_0e0022fa","updated":"2022-02-07 17:48:49.000000000","message":"recheck","commit_id":"8fa8bd37271d5911d2e7a322a3399c52a72072cd"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"aff784ec4d97b8988363b380e9d2bd9e8130fc2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf8112f0_a8088543","updated":"2022-09-19 20:11:51.000000000","message":"recheck, random test failed.","commit_id":"8fa8bd37271d5911d2e7a322a3399c52a72072cd"}],"openstack_dashboard/dashboards/project/volumes/tables.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"1e67debb885849c2ff58757b16adddb38a2463bb","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7723c68_c520696f","line":38,"updated":"2021-12-07 06:49:19.000000000","message":"What about the other states like \u0027error_deleting\u0027, \u0027error_managing\u0027, \u0027error_backing-up\u0027 ?\nDo we need to add the above state as well?","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"46129b779fa6cc94b7b28391b4c02c3122e356b6","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e0ffd6b_87a4ba2b","line":38,"in_reply_to":"410bddca_f426a4a9","updated":"2022-01-18 22:05:56.000000000","message":"You\u0027re making it hard to contribute, please rethink this stance. We should be encouraging people not making it harder. I\u0027ll try find some time to test the other states but this really is good to go.","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"da6347179e1938bcd669a31541babfef88b65c03","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0303897_0f0bf111","line":38,"in_reply_to":"96adb282_967ec0f4","updated":"2022-02-04 03:36:07.000000000","message":"Sorry I\u0027m not familiar with the other states but feel free to take over this review if you are going to be like this. I don\u0027t have time for this kind of stuff, makes me less excited to contribute to this project","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"b1a43c29529a3efb0de4b7b0a1b7730b98e9aa5a","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"96adb282_967ec0f4","line":38,"in_reply_to":"9e0ffd6b_87a4ba2b","updated":"2022-01-19 04:13:30.000000000","message":"How hard it is to add 3 more volume states here, you just have to do the same thing you have already done for error_restoring and then we are good to go here. Also, don\u0027t forget to update the commit-msg if you add more volume states here.","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"aab9333eb0bbb86c4e4af9d3967b75a6dcc2b292","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f0c3407a_c88f15ac","line":38,"in_reply_to":"a7723c68_c520696f","updated":"2021-12-21 22:00:34.000000000","message":"Yes maybe but that could be done in a different review? Would rather not block something that is good to go by asking to add more stuff?","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aca332b2a84b851fb3687cb7212c144c3d2cf6c5","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed9a5169_75703290","line":38,"in_reply_to":"c0303897_0f0bf111","updated":"2022-02-04 04:25:10.000000000","message":"I will update the list of deletable statuses.\nThe source information is found at https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003ddelete-a-volume-detail#delete-a-volume.","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9738dd013c5ee4aec390780d128535473f349c53","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d379753e_f55316b6","line":38,"in_reply_to":"ed9a5169_75703290","updated":"2022-02-04 05:08:29.000000000","message":"Done","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"3d0bbc430f598b647261f33a91a6e2fa54b4d404","unresolved":true,"context_lines":[{"line_number":35,"context_line":"from openstack_dashboard import policy"},{"line_number":36,"context_line":"from openstack_dashboard.usage import quotas"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DELETABLE_STATES \u003d (\"available\", \"error\", \"error_extending\", \"error_restoring\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumePolicyTargetMixin(policy.PolicyTargetMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"410bddca_f426a4a9","line":38,"in_reply_to":"f0c3407a_c88f15ac","updated":"2021-12-23 04:03:48.000000000","message":"IMHO, it is better to do similar type of changes in a single patch rather than pushing multiple\npatches for similar changes.","commit_id":"a3b529b3defff946107e89acb5fb122cd002e5b4"}]}