)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"a9ead604401119e7c26f9c6d310cda9f07f60b0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d767e914_a7835c3b","updated":"2021-11-23 12:09:05.000000000","message":"Thanks For the patch, please find below some feedback:\n\n• Documentation for this feature is missing.\n\n• Can we add some configuration for this feature in the horizon so that if operators enable system_scope in configuration, only then the \u0027System_Scope\u0027 menu is visible?\n\n• Release note is missing for this feature.\n\n• Unit tests are missing for this change.\n\n• Flavor panel is completely broken after switching to the system scope.\n\n• Most of the nova features stop working, with the error msg \"Policy doesn\u0027t allow\".\n\n• Volume Panel is completely missing after switching to system scope.\n\n• Glance features like creating images stop working after switching to system scope.\n","commit_id":"50e43f7bc72cb2809b94fa82a4887cc91b664a9b"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"272afb1c05845d7b0426cb6db4bfd592967812aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9060f571_213f2d39","updated":"2021-11-19 10:40:57.000000000","message":"recheck again a timeout,the first test failed, all the others passed","commit_id":"50e43f7bc72cb2809b94fa82a4887cc91b664a9b"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"be4eba5f61c77170d7b6a6aa7c6c6d6d3c003b1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"47083b1b_8ba14a13","updated":"2021-11-18 14:00:31.000000000","message":"recheck looks like some timeout in integration tests","commit_id":"50e43f7bc72cb2809b94fa82a4887cc91b664a9b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"95945c1c76f34e32373f16012749598b81f69cc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"156f2713_e64c8026","in_reply_to":"1a69c869_6ff4ed17","updated":"2021-11-30 11:20:57.000000000","message":"ack.","commit_id":"50e43f7bc72cb2809b94fa82a4887cc91b664a9b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d6be34b1560a7002c1542d47a55ec41f5b5491d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d7bbd16a_a5905549","in_reply_to":"2e54331b_3762fa7a","updated":"2021-11-25 05:06:04.000000000","message":"• Do you remember when we discuss System Scope support during ptg we decided to add a new setting \u0027ENABLE_SYSTEM_SCOPE\u0027 see https://etherpad.opendev.org/p/xena-ptg-horizon-planning (at line 108). I was thinking if we should add a new setting like \u0027ENABLE_SYSTEM_SCOPE\u0027 for now if the operators enable this setting only then the system scope menu is visible.\n\n• About documentation is general documentation we add when introducing a new setting.\n\n• Other than the Unit tests We can also add an integration test for this feature which tries to switch to the system scope menu and try to do some system user tasks but we can add that later.","commit_id":"50e43f7bc72cb2809b94fa82a4887cc91b664a9b"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"43a4e6d54ad64141b671e474334b9a3fae4f69ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2e54331b_3762fa7a","in_reply_to":"d767e914_a7835c3b","updated":"2021-11-24 09:10:09.000000000","message":"* What kind of documentaition do you have in mind exactly?\n\n* The system scope option is only visible in the menu when the user has access to the system scope. If the system scope is not supported or the user wasn\u0027t granted access to it, the menu item will not appear. What additional configuration do you think is needed?\n\n* I will add a release note.\n\n* I will look if we can add any non-trivial tests to this, but most of the time we would just be testing that mock works.\n\n* That is not a Horizon issue.\n\n* That is not a Horizon issue.\n\n* That is not a Horizon issue.\n\n* That is not a Horizon issue.","commit_id":"50e43f7bc72cb2809b94fa82a4887cc91b664a9b"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"3060447735c27c0e397001f3aade311092f8500b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1a69c869_6ff4ed17","in_reply_to":"d7bbd16a_a5905549","updated":"2021-11-26 13:10:25.000000000","message":"I am working on a separate patch for the ENFORCE_SYSTEM_SCOPE setting: https://review.opendev.org/c/openstack/horizon/+/818763\n\nOur quality engineer will work on integration tests for this, but that will be a separate patch later.","commit_id":"50e43f7bc72cb2809b94fa82a4887cc91b664a9b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"95945c1c76f34e32373f16012749598b81f69cc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dd9d6d10_f24c0c75","updated":"2021-11-30 11:20:57.000000000","message":"LGTM, This patch adds system scope to the context switcher menu.\nWe can decide later to display which panel or operation to the system\nuser on horizon dashboard once all backend services add system scope support.\n","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"153aac2d0bb252324881da074ae0e1e8edeb414b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"062bf708_8f23bb95","updated":"2022-01-03 12:41:18.000000000","message":"recheck","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ddfcf563416481ba6b7c352f46a74c516dd9a246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9fa7d405_b3bcbfe1","updated":"2022-01-03 16:47:04.000000000","message":"recheck","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"e93a1fa1fe6724efb8b381e627fe8e5e51fe3fb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a1e76e49_d4228e19","updated":"2022-01-06 09:46:12.000000000","message":"recheck","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"c7a09dc71e218ae914274efc40a74dbecbfe6ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d0db6e5c_5c5399ba","updated":"2022-01-05 18:11:28.000000000","message":"recheck","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"bdb3deac6f3656f639e9380b532c99e1c05fb6a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d68cd392_a965f8a4","updated":"2022-01-13 07:34:27.000000000","message":"recheck","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ef66abefd0395c0a46ebb7e779541323c7d9de14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f189b2af_7dfc5853","updated":"2022-01-15 09:07:10.000000000","message":"recheck","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"622e6e4792dddd06bc60cb0de685ee8c47e6f037","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f89b5ce3_44fce0b2","updated":"2022-01-11 05:31:30.000000000","message":"recheck","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"a3f5310951fe1ca36e4e5211c4f78b2a90e6f11a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"10018014_de0f754e","updated":"2021-11-30 11:10:32.000000000","message":"recheck, random integration test failing.","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"f4307fb09695040c7485fd8430af3f25e7e98905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"410460ee_822cdb16","updated":"2021-11-30 04:13:42.000000000","message":"recheck.","commit_id":"34a0159d1a65dbf8dd3ff3bc2cb156bdcf37a814"}]}