)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"fe2f88393866b0a884dc4cc63b87558a1aa30d6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"726a6b87_9ddc6e34","updated":"2022-03-04 21:47:10.000000000","message":"I still need to add documentation and release notes about this.","commit_id":"062b666c022e5dc43a6522bde9e29a262b1a4ed4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69940491ef5153a4ed4e3e0b412c3c8e87757ddd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"681f465a_75851c25","updated":"2022-03-24 09:01:12.000000000","message":"I confirmed it works. I needed time to test it as horizon does not work with the default devstack configuration.","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"138ed38dda256cf81839c2ad3f6795a3797890c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4d7178e8_1b7da899","updated":"2022-03-11 16:35:43.000000000","message":"LGTM, tested with devstack.","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2f587a2b211e661f7e470e4a61161474317d8ca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"74ef00e5_508e9709","updated":"2022-03-11 11:33:14.000000000","message":"Thanks For the Patch, Overall LGTM.\nPlease find one comment inline.","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"94bdf3c50ca7acb1c024058798d155702820e0b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"91c59953_3e9d8309","updated":"2022-03-22 15:05:31.000000000","message":"This patch already have one +2 and considering tatina +1 as +2.\nI have approved it.","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5396c575e9645dbea42d64d1c3bfe8bd0ddc6cae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"735aac65_19c713f7","updated":"2022-03-22 15:04:19.000000000","message":"approving it, if anyone sees any issue in this patch. please let us know.\nWe can fix those in a follow-up.","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"875343a23d24a534f805938e5f8142423999cc6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f52e4eb6_e3427530","updated":"2022-03-14 13:03:21.000000000","message":"ping core reviewer, Can we have quick reviews on this patch.\nSo I can cut a final release of horizon for yoga cycle whic\ncan be used to create stable/yoga branch [1] .\nThanks.\n\n[1] https://review.opendev.org/c/openstack/releases/+/833603","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"9a0c9c1b21419bb0679950311dfb9bdb52388d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19f23140_ea158167","updated":"2022-03-21 04:56:33.000000000","message":"ping, waiting for review from other cores.\nI have to cut a final release for Yoga cycle,\nwould be nice if can include this one as well.","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ad1c0f5fc6d01040578d0bc4e1a463e2905c897e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"02afc3bd_eb620565","updated":"2022-03-23 01:39:35.000000000","message":"recheck","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"18b5f154cbb25da1a818f1c24949af25cf14f821","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3825319b_ca947f5e","updated":"2022-03-23 05:42:25.000000000","message":"recheck","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"adcc3161bc8e8d23c7c2248adfb161d40cb767b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4410412e_af051939","updated":"2022-03-23 09:50:20.000000000","message":"recheck","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"7af90c6a59fca2af6d1479c1ff577806c1d84698","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"58dcb2b6_95d37ead","updated":"2022-03-22 17:14:00.000000000","message":"recheck","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"e755ed704dca9ae3a4d8ff36eb642791a08b4ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5ec31976_f4fbbae3","updated":"2022-03-24 06:25:26.000000000","message":"recheck","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"87790b96b9dd3ef41ab0730fda4c709d08af97f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7372412a_d348b25a","updated":"2022-03-22 19:03:05.000000000","message":"recheck","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"dfeed2ad7692942bdd1cd2e6692890958576b849","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7a1f92de_eca540a5","updated":"2022-03-23 14:05:32.000000000","message":"recheck","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"}],"openstack_dashboard/dashboards/admin/aggregates/panel.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69940491ef5153a4ed4e3e0b412c3c8e87757ddd","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def allowed(self, context):"},{"line_number":31,"context_line":"        if ((\u0027compute\u0027 in settings.SYSTEM_SCOPE_SERVICES) !\u003d"},{"line_number":32,"context_line":"                bool(context[\u0027request\u0027].user.system_scoped)):"},{"line_number":33,"context_line":"            return False"},{"line_number":34,"context_line":"        return super().allowed(context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"eda48d3d_b352e101","line":32,"updated":"2022-03-24 09:01:12.000000000","message":"(just a comment)\nThis condition works, but it took for me to understand the logic.\nPerhaps the following is easier to understand.\n\n  system_scope_enabled \u003d \u0027compute\u0027 in settings.SYSTEM_SCOPE_SERVICES\n  system_scoped \u003d context[\u0027request\u0027].user.system_scoped\n  if system_scope_enabled and not system_scoped:\n      return False\n  if not system_scope_enabled and system_scoped:\n      return False","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"}],"openstack_dashboard/defaults.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2f587a2b211e661f7e470e4a61161474317d8ca5","unresolved":true,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"# Services may require a System Scope token for certain operations. This"},{"line_number":557,"context_line":"# settings enables the use of the system scope token on per-service basis."},{"line_number":558,"context_line":"SYSTEM_SCOPE_SERVICES \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"62615620_057c49d4","line":558,"range":{"start_line":558,"start_character":0,"end_line":558,"end_character":26},"updated":"2022-03-11 11:33:14.000000000","message":"One question here: right now If I add identity here like SYSTEM_SCOPE_SERVICES \u003d [\u0027identity\u0027] then I can see \"system scope\" option in the switching menu but I can\u0027t see Identity dashboard anymore. Don\u0027t you think it\u0027s wrong? See [1]\n\n[1] https://pasteboard.co/hc0evHr4RcBg.png","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"138ed38dda256cf81839c2ad3f6795a3797890c2","unresolved":false,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"# Services may require a System Scope token for certain operations. This"},{"line_number":557,"context_line":"# settings enables the use of the system scope token on per-service basis."},{"line_number":558,"context_line":"SYSTEM_SCOPE_SERVICES \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"b4191895_be759b4e","line":558,"range":{"start_line":558,"start_character":0,"end_line":558,"end_character":26},"in_reply_to":"62615620_057c49d4","updated":"2022-03-11 16:35:43.000000000","message":"Looks like I hit this issue due to browser Cache.\nPlease Ignore this comment.","commit_id":"6c814b241d7465113a6edfc023fa6ef9314f4591"}]}