)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"282609001b86c73dd612721396672383099e6d64","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\u003e RecursionError: maximum recursion depth exceeded in __instancecheck__"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: https://bugs.launchpad.net/horizon/+bug/1955773"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2724f07339134b3e06b7ea925939bf7072162106"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"92764abd_b151f15b","line":14,"updated":"2022-01-07 08:17:38.000000000","message":"nit: Could you use\n\n Closes-Bug: #1955773\n\nIt seems the OpenStack infra does not recognize the URL with Closes-Bug.\nUsing the number only triggers the update of the launchpad bug.","commit_id":"12830112b97204eabc634f3ead8a3b4558962d75"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0f6bf19406b0e3778eb774b002fa15dbaab1b53a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\u003e RecursionError: maximum recursion depth exceeded in __instancecheck__"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: https://bugs.launchpad.net/horizon/+bug/1955773"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2724f07339134b3e06b7ea925939bf7072162106"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8fe11580_5f7c9042","line":14,"in_reply_to":"92764abd_b151f15b","updated":"2022-01-07 23:09:34.000000000","message":"Ack","commit_id":"12830112b97204eabc634f3ead8a3b4558962d75"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"dac285b9101f9f78c6b328f854315f46f4a3c53d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"432c55b0_636f7b46","updated":"2021-12-23 09:38:58.000000000","message":"Hi, thanks for looking into the issue, but I can see doc [1] job\nstill fail after this patch.\n\n[1] https://review.opendev.org/c/openstack/senlin-dashboard/+/822777","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"b28bf36061958c7c3071c40514186f4f7e832100","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a18c745b_6472f850","updated":"2021-12-18 08:40:34.000000000","message":"I dug deep but wasn\u0027t able to fully understand why we get stuck in this endless loop, but seems bad that it is even possible.\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_67b/787090/1/gate/openstack-tox-docs/67b6ffd/job-output.txt","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ffb9c2c580ca20239b40ecb582d92ece71c12264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5d9ca43_94427171","updated":"2021-12-18 06:27:09.000000000","message":"recheck","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"4181145af815202c3ec5d9c0d7c6302dead028c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f1d62f9_bad868fd","in_reply_to":"091107e6_1d5842b4","updated":"2021-12-24 00:55:08.000000000","message":"It should be saying something like, so it just isn\u0027t working with depends-on\n\u003e horizon 20.2.1.dev6 /local/path\n\nInstead just running it locally with my patch is the best way to test it\n\u003e git clone https://github.com/openstack/senlin-dashboard.git\n\u003e cd senlin-dashboard\n\u003e pip install -r doc-requirements.txt\n\u003e cd ..\n\u003e git clone https://github.com/openstack/horizon.git\n\u003e cd horizon\n\u003e git fetch https://review.opendev.org/openstack/horizon refs/changes/12/822212/1 \u0026\u0026 git cherry-pick FETCH_HEAD\n\u003e pip install -e .\n\u003e cd ../senlin-dashboard\n\u003e sphinx-build -W -b html doc/source doc/build/html","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a2457d2141beb1e84e8705dbc3a692f3ab002a67","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65187296_2af10459","in_reply_to":"432c55b0_636f7b46","updated":"2021-12-23 23:40:17.000000000","message":"Hey Vishal. I looked at that I honestly just assumed that it didn\u0027t properly install it locally during the test (and/or overwrote it). This patch fixed it every time when I ran it locally. If you have time, could you confirm?","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"8aec2f87bb2654c287b9018f09c5cbbbf0a1aea2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"091107e6_1d5842b4","in_reply_to":"65187296_2af10459","updated":"2021-12-24 00:26:21.000000000","message":"Actually yea pretty confident it just does not work to depends-on for that docs job. If you look at the logs it says:\n\u003e docs installed .... horizon\u003d\u003d20.2.0 ...","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"691af3b3418c1a0c75ee3099f9fed41337d6ff76","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac781729_2c8821e1","in_reply_to":"8f1d62f9_bad868fd","updated":"2021-12-24 07:57:41.000000000","message":"yes if I apply this patch and run \"docs-local\" job in senlin-dashboard then docs build scuessfully.","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e3fd71a3fa730473fa3f8be8f0bddccbb19ed07c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3b25694_bf4a1446","in_reply_to":"ac781729_2c8821e1","updated":"2022-01-02 04:17:52.000000000","message":"Ack","commit_id":"a4d8a654153df9feb4637bb9d4f1272adb71bed1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"76bd53802670a80e5a90c068302c3791cbd42462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11fb59bb_2af7e733","updated":"2021-12-27 04:59:20.000000000","message":"recheck","commit_id":"12830112b97204eabc634f3ead8a3b4558962d75"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0f6bf19406b0e3778eb774b002fa15dbaab1b53a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a87b8c7b_c6d99cf1","updated":"2022-01-07 23:09:34.000000000","message":"+1 to mark that I am perfectly fine with the additional changes","commit_id":"b8cc0043d46318c7e11952109450587bee9567ab"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"37ba83974e9d193f93235542c759902aaa3a2b0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b14180c9_013a7976","updated":"2022-01-07 08:26:36.000000000","message":"I updated the code and the commit message. Hope you are okay with this.","commit_id":"b8cc0043d46318c7e11952109450587bee9567ab"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5a29f07e5362d2569c9d256c5671322b896bfa3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99f6f3f9_43d2d315","updated":"2022-01-07 09:05:28.000000000","message":"Thanks. LGTM tested in my local env. and senlin-dashboard job runs fine after applying this patch.","commit_id":"b8cc0043d46318c7e11952109450587bee9567ab"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25d6b0472211312ea777b3e9a7088a1443e71dc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c83c063_2aac2cc9","updated":"2022-01-18 02:08:27.000000000","message":"We got ack from Erik, so let\u0027s merge this.","commit_id":"b8cc0043d46318c7e11952109450587bee9567ab"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"25255fff78ae1016920f4cffce068008553f843d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"77b798c2_f7bfe7e0","in_reply_to":"b14180c9_013a7976","updated":"2022-01-07 21:32:05.000000000","message":"Not at all. I appreciate the help.","commit_id":"b8cc0043d46318c7e11952109450587bee9567ab"}],"horizon/tables/actions.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"82d380d0f90da6766c10bfa4f0d735c59e59fbca","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                options \u003d base_options"},{"line_number":70,"context_line":"        # Saving all options to class attribute, this will be used for"},{"line_number":71,"context_line":"        # instantiating of the specific Action."},{"line_number":72,"context_line":"        attrs[\u0027base_options\u0027] \u003d dict(options)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return type.__new__(cls, name, bases, attrs)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8d877237_170322e6","line":72,"updated":"2022-01-07 08:15:41.000000000","message":"I investigated the error in detail. The error happens when a base class does not have \"base_options\" attribute. For such case, it leads to:\n\n  attrs[\u0027base_options\u0027] \u003d attrs\n\nThis casuse a circulated reference and sphinx hits the error.\n\nI agree that the proposed code works, but I think it is better to change L.55 to\n\n options \u003d dict(attrs)\n\nIt is a bit cleaer than doing it at last. L.55 is the only case where \"options\" dict is not a separate dict object than \"attrs\" passed as an argument of __new__.\nFor other cases (L.53 and L.69) \"options\" dict is newly created, so I think it is better to ensure \"options\" is a new dict when prepared at L.55 too.","commit_id":"12830112b97204eabc634f3ead8a3b4558962d75"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0f6bf19406b0e3778eb774b002fa15dbaab1b53a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                options \u003d base_options"},{"line_number":70,"context_line":"        # Saving all options to class attribute, this will be used for"},{"line_number":71,"context_line":"        # instantiating of the specific Action."},{"line_number":72,"context_line":"        attrs[\u0027base_options\u0027] \u003d dict(options)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return type.__new__(cls, name, bases, attrs)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7c4fbe71_850f3a29","line":72,"in_reply_to":"8d877237_170322e6","updated":"2022-01-07 23:09:34.000000000","message":"Ack","commit_id":"12830112b97204eabc634f3ead8a3b4558962d75"}]}