)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb8e269a4febf44cc5b6dc9d4dd14038335d0e77","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow port_get to fail when listing all floating ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow port_get to fail when listing all floating ips as not all users"},{"line_number":10,"context_line":"are allowed to get ports from all other users such as admin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieeddc2451adb79405fe3ac72fdf5900ca7c5f628"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a5775c8_940daba7","line":10,"updated":"2022-02-04 06:46:12.000000000","message":"Question on the background of the issue: When does this situation happens? A port needs to be visible when associating the port to a floating IP, so I am wondering what kind of operations leads to such situation.","commit_id":"56c031689311941b4d7f71815bdec70f05e32826"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f0db350c7caa6bc96bf888fd648eb13d6b9fbff","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow port_get to fail when listing all floating ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow port_get to fail when listing all floating ips as not all users"},{"line_number":10,"context_line":"are allowed to get ports from all other users such as admin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieeddc2451adb79405fe3ac72fdf5900ca7c5f628"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"42952f88_abae8cae","line":10,"in_reply_to":"04395528_ce3a7929","updated":"2022-02-09 12:14:25.000000000","message":"I still wonder how such floating IP associations were created. When associating an internal port with a floating IP, a tenant needs to see the internal port to be associated. This means that a port associated with a floating IP of tenant A needs to be visible to tenant A, but what you explained is totally different. In my understanding, only exception is that admin associated FIP with an internal port.\n\nI am not necessarily against adding a workaround but I would like to clarify how such situation happens to maintain the code.","commit_id":"56c031689311941b4d7f71815bdec70f05e32826"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"86b0ab8e761cb9334f76c7924e9e5a4c76a4725d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow port_get to fail when listing all floating ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow port_get to fail when listing all floating ips as not all users"},{"line_number":10,"context_line":"are allowed to get ports from all other users such as admin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieeddc2451adb79405fe3ac72fdf5900ca7c5f628"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"04395528_ce3a7929","line":10,"in_reply_to":"3a5775c8_940daba7","updated":"2022-02-04 14:50:03.000000000","message":"In this case, the customer had a bunch of floating IPs that were assigned to some fixed ip ports owned by another tenant so iterating over the floating ips works but getting the details of which instance ID it\u0027s attached to is unavailable and returns a \"no such ports found\" ... as admin, we see all fixed ips as well as which instance those IPs are bound to but not all users can see all ports/vms so this breaks in horizon but not in neutron CLI.","commit_id":"56c031689311941b4d7f71815bdec70f05e32826"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"cd67630909242538c2400f9a98567df18337ba1e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow port_get to fail when listing all floating ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow port_get to fail when listing all floating ips as not all users"},{"line_number":10,"context_line":"are allowed to get ports from all other users such as admin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieeddc2451adb79405fe3ac72fdf5900ca7c5f628"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8f91b8e4_e57430e6","line":10,"in_reply_to":"42952f88_abae8cae","updated":"2022-02-09 13:33:46.000000000","message":"No that works as expected but if the floating IP is from ANOTHER tenant , it won\u0027t be able to show the port information because neutron retourns a 404.     This happens probably if you have a shared floating IP network with multiple tenant able to assign a public IP to a fixed IP.  Tenant A can\u0027t list Tenant B ... this is expected.","commit_id":"56c031689311941b4d7f71815bdec70f05e32826"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fc5f431165596369d2a36025edc8c5d9c721b245","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow port_get to fail when listing all floating ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow port_get to fail when listing all floating ips as not all users"},{"line_number":10,"context_line":"are allowed to get ports from all other users such as admin."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieeddc2451adb79405fe3ac72fdf5900ca7c5f628"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ff902d7_08560095","line":10,"in_reply_to":"8f91b8e4_e57430e6","updated":"2023-02-09 09:07:03.000000000","message":"\u003e if the floating IP is from ANOTHER tenant,\n\nI am confused with this clause.\nThe logic you touch is part of FloatingIPManager. _set_instance_info() method is called from list(), get(), and allocate() methods. Floating IPs are only visible from a same tenant (or a superuser like \"admin\" role), If a floating IP is from another´tenant, the floating IP is not visible to the current tenant.\nneutron does not provide a way to share a floating IP to another tenant.\n\nIn addition, when a port is associated with a floating IP, the port associated needs to be visible to a tenant who owns the floating IP.\n\nConsidering the above two, I am still not sure why the case you mention happens.","commit_id":"56c031689311941b4d7f71815bdec70f05e32826"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"85268ca6ca95a3d33c2aecc7a294ec13516f3bf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f989bd40_ecfb12f7","updated":"2023-06-05 15:23:32.000000000","message":"Do we still need this or should we abandon this change ?","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"2ac1921be56d444ec515a2e2d42e44c7bed37b55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00138ec2_44f9b15c","updated":"2023-02-08 15:54:55.000000000","message":"I just fixed the indentation.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"22c2c5fd489201e7bbf216008a23a076171ce8e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"79cae733_bfe55de8","updated":"2023-06-06 11:54:51.000000000","message":"I think we do.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cff04d48d2abf4462c45e851fa888db231544548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"96812cc3_885f5786","updated":"2023-02-09 08:43:30.000000000","message":"I would like to understand how this happens. In neutron, a user needs to have a permission to get a port to associate the port with a floating IP. My question is how you associated such port with a floating IP.\nDid you associate a port with a floating IP using more powerful user permission like admin?","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ff9b0f8c156689bf29690b6252dd180b7dc88099","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"63493207_47fdd3e8","in_reply_to":"46339fa2_e7a23bab","updated":"2023-02-10 05:33:20.000000000","message":"A floating IP cannot be assocaited with an unaccessable port unless admin does it.\nThat\u0027s the reason I would like to clarify the situation. I am afraid there is a bug in neutron as a corner case and horizon hides it.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7b4e6a2b4d8d5f0c26397ffba53db40d89458f75","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e687303b_7e9b0975","in_reply_to":"63493207_47fdd3e8","updated":"2023-02-10 08:53:58.000000000","message":"There many other possibilities. This is not static system. The port might have been accessible at the moment of assigning, but since then the policies might have been changed, for example. Or it could have been modified otherwise. Even if admin did it, that is still a valid case that we should handle. Horizon\u0027s responsibility is not to be a validator for Neutron\u0027s database. There is a separate Validations project that could handle this.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"117a9a1971bb0e7dd2c529228237ac80ad9ccd2f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"46339fa2_e7a23bab","in_reply_to":"8b9813a1_5ca836c0","updated":"2023-02-09 09:18:51.000000000","message":"Whether the situation is \"normal\" or not, what else would you propose we do when this error happens? Skipping the port we don\u0027t have access to seems to be the best possibility, surely better than failing altogether.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c4f3dabd4dcac5fff8c657b302a5995a9576a5d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8b9813a1_5ca836c0","in_reply_to":"96812cc3_885f5786","updated":"2023-02-09 08:54:57.000000000","message":"\u003e I would like to understand how this happens. In neutron, a user needs to have a permission to get a port to associate the port with a floating IP. My question is how you associated such port with a floating IP.\n\u003e Did you associate a port with a floating IP using more powerful user permission like admin?\n\nIt seems I repeated the same discussion. I will try to check the detail but it takes time. I don\u0027t have full confidence that it happens in normal situations and hesitate to vote +2. I would like to defer the final decision to other core reviewers at the moment. I hope they undersntad the sitaution with the full context.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"656eff7e612537ff99d20cd4b3a559ad24ac2cf5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ae6f21b0_4db21a79","in_reply_to":"e687303b_7e9b0975","updated":"2023-02-10 13:40:56.000000000","message":"Thanks. I got it. I overlooked what happens.\nI am okay with the direction.\nI still think the logging message added should include FIP ID and port ID, so I don\u0027t vote now.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"2d897b72e784e6f0bfa588d32458937299e16292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2dd0e4b6_7986ebcf","updated":"2024-05-06 16:32:56.000000000","message":"LGTM","commit_id":"f20d18637e048251451ea5e33384b5dd2e3c3a5e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1d2f884100a0365f1a4a38ebab0b5adbec889022","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"19e5caa6_1669d0fc","updated":"2024-06-05 10:26:20.000000000","message":"Since the original reviewer doesn\u0027t seem interested in this issue anymore, I\u0027m going to go ahead and merge it.","commit_id":"f20d18637e048251451ea5e33384b5dd2e3c3a5e"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"07a03536d8c66fd519c5b078f303a5a5e8152b65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5795af17_5dd0927e","updated":"2024-04-08 10:45:10.000000000","message":"recheck random failure","commit_id":"f20d18637e048251451ea5e33384b5dd2e3c3a5e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"3c9a347333c9869eae5c84fa36727db454bf7577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36717998_95cb76d8","updated":"2024-06-05 14:44:04.000000000","message":"recheck, random failure","commit_id":"f20d18637e048251451ea5e33384b5dd2e3c3a5e"}],"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ea7c3e8ddd763fb7421266e680d7105f2d50be4a","unresolved":true,"context_lines":[{"line_number":592,"context_line":"            fip[\u0027instance_type\u0027] \u003d self._get_instance_type_from_device_owner("},{"line_number":593,"context_line":"                port.device_owner)"},{"line_number":594,"context_line":"        except neutronclient.common.exceptions.PortNotFoundClient:"},{"line_number":595,"context_line":"            LOG.debug(\"failed to get port details, perhaps permission issue\")"},{"line_number":596,"context_line":"            fip[\u0027instance_id\u0027] \u003d None"},{"line_number":597,"context_line":"            fip[\u0027instance_type\u0027] \u003d None"},{"line_number":598,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"f64278a7_39228150","line":595,"updated":"2023-02-09 08:44:51.000000000","message":"I think this should include ID of a floating IP and a port involved.\nOtherwise, operators cannot check what happens.","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"de454465357ee46ec2b6b907d2a1b4f90a3d1be5","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            fip[\u0027instance_type\u0027] \u003d self._get_instance_type_from_device_owner("},{"line_number":593,"context_line":"                port.device_owner)"},{"line_number":594,"context_line":"        except neutronclient.common.exceptions.PortNotFoundClient:"},{"line_number":595,"context_line":"            LOG.debug(\"failed to get port details, perhaps permission issue\")"},{"line_number":596,"context_line":"            fip[\u0027instance_id\u0027] \u003d None"},{"line_number":597,"context_line":"            fip[\u0027instance_type\u0027] \u003d None"},{"line_number":598,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"78c93788_338b4c1c","line":595,"in_reply_to":"f64278a7_39228150","updated":"2024-05-06 14:15:40.000000000","message":"Done","commit_id":"03170ad398af076eaf6c08a114600af6e5333327"}]}