)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"3b9af99c8e7dfd5a95e5206aa95dfc8df6cb6c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"96ae770b_6a64b8fd","updated":"2022-03-04 03:12:57.000000000","message":"LGTM!","commit_id":"2001386951674395236799785a249bcb9a674f45"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a8ae1565a1bdc192e62b4fe3ee9c507d82f1f6e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"579dac0d_45002dbd","updated":"2022-02-24 01:59:40.000000000","message":"recheck","commit_id":"2001386951674395236799785a249bcb9a674f45"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b4e7b72e4d04b4535a2ce533a6ff8aa63ed718ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1ea3d76_33fb192a","updated":"2022-02-23 19:44:38.000000000","message":"recheck","commit_id":"2001386951674395236799785a249bcb9a674f45"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"6b9765a1d5e3a025edacd523f3e55173f60bfc1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d6a11b0_801c84e0","updated":"2022-03-04 19:31:25.000000000","message":"Thank you!","commit_id":"362a77a451bf67a3263dd0e5224ad68da1cb0af1"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"493aa807f17ed3532024646826bea3b95f0398e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"463e4406_e138855c","updated":"2022-03-04 22:02:51.000000000","message":"recheck","commit_id":"a7956cd0043e6c58d121e536ed8ace0abd0e2522"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65784b5496fc0df2cefe4b057f349b6af471464a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f01c3af1_455b5d8d","updated":"2022-03-05 09:52:33.000000000","message":"recheck","commit_id":"a7956cd0043e6c58d121e536ed8ace0abd0e2522"}],"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"61eb269c8450c79de81c8a9a715793e4dbecd426","unresolved":true,"context_lines":[{"line_number":580,"context_line":"        return context"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    @memoized.memoized_method"},{"line_number":583,"context_line":"    def get_object(self, flavors):"},{"line_number":584,"context_line":"        instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":585,"context_line":"        try:"},{"line_number":586,"context_line":"            instance \u003d api.nova.server_get(self.request, instance_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fbaf87a7_18428a53","line":583,"updated":"2022-03-04 18:15:05.000000000","message":"I don\u0027t like the fact that we are memoizing the flavors here a second time.\nI wonder if we could either pass the flavors as an object attribute instead, or divide this into two parts, to only memoize the api call?\n\nBy the way, two calls to get_flavors are not costly when it\u0027s memoized.","commit_id":"2001386951674395236799785a249bcb9a674f45"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"6b9765a1d5e3a025edacd523f3e55173f60bfc1c","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        return context"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    @memoized.memoized_method"},{"line_number":583,"context_line":"    def get_object(self, flavors):"},{"line_number":584,"context_line":"        instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":585,"context_line":"        try:"},{"line_number":586,"context_line":"            instance \u003d api.nova.server_get(self.request, instance_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3cfcd064_daf1ec19","line":583,"in_reply_to":"52e2f901_c2b0792d","updated":"2022-03-04 19:31:25.000000000","message":"Done","commit_id":"2001386951674395236799785a249bcb9a674f45"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1feb1957f13f69e8dafd89c40f5fecc7b9cd53e","unresolved":true,"context_lines":[{"line_number":580,"context_line":"        return context"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    @memoized.memoized_method"},{"line_number":583,"context_line":"    def get_object(self, flavors):"},{"line_number":584,"context_line":"        instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":585,"context_line":"        try:"},{"line_number":586,"context_line":"            instance \u003d api.nova.server_get(self.request, instance_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"52e2f901_c2b0792d","line":583,"in_reply_to":"fbaf87a7_18428a53","updated":"2022-03-04 18:52:05.000000000","message":"Thanks for catching this. I will update the code not to pass flavors as arguments and call get_flavors() in get_object(). It is what our code did before the resize server fix.","commit_id":"2001386951674395236799785a249bcb9a674f45"}]}
