)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"eea7c5cbfd7a098e9ae78258c62ff5b93007ed02","unresolved":false,"context_lines":[{"line_number":10,"context_line":"there are no more availables, the error message was changed. On"},{"line_number":11,"context_line":"the bug description said that the button label should also be"},{"line_number":12,"context_line":"changed from [+] to [Reserve], but I am not sure how to"},{"line_number":13,"context_line":"accomplish this change."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I46a9c5ec14eea4ac27cb7f717a9e81506c808d8d"},{"line_number":16,"context_line":"Closes-Bug: #1294042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2BMEo%3D","line":13,"updated":"2014-03-28 14:48:31.000000000","message":"The plus-sign you\u0027re looking for is added here: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.forms.js#L87 though I am not sure it should be replaced with anything other than \u0027+\u0027 - because \u0027+\u0027 button is as almost well-known as \u0027Submit\u0027 button, while e.g. \u0027Reserve\u0027 button is not and could confuse users (i.e. it could break conventional UX patterns).","commit_id":"dfc8451953524782831fb809623fe9f9f9688705"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"92400b995af5d355a7e40a7d00bf1c746582e4b7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"there are no more availables, the error message was changed. On"},{"line_number":11,"context_line":"the bug description said that the button label should also be"},{"line_number":12,"context_line":"changed from [+] to [Reserve], but I am not sure how to"},{"line_number":13,"context_line":"accomplish this change."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I46a9c5ec14eea4ac27cb7f717a9e81506c808d8d"},{"line_number":16,"context_line":"Closes-Bug: #1294042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2BK3w%3D","line":13,"in_reply_to":"AAAAWH%2F%2BMEo%3D","updated":"2014-03-28 16:52:56.000000000","message":"I agree with you on this. \nThe thing is the usage of [+] was on the bug description, I was just clarifying.","commit_id":"dfc8451953524782831fb809623fe9f9f9688705"}],"openstack_dashboard/dashboards/project/access_and_security/floating_ips/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee15e80c21902eedae881c0f859e0157fd1b02f1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if options:"},{"line_number":74,"context_line":"            options.insert(0, (\"\", _(\"Select an IP address\")))"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            options \u003d [(\"\", _(\"No IP addresses reserved\"))]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return options"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BK5c%3D","line":76,"updated":"2014-03-28 16:48:33.000000000","message":"We have four operations for floating IPs now: Allocate, Associate, Disassociate, Release.\nDoesn\u0027t \"Reserve\" introduce another confusion? Doesn\u0027t \"Allocate\" work?","commit_id":"dfc8451953524782831fb809623fe9f9f9688705"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ce2516d48270dc8640cbeca9a4f7d1633370ef6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if options:"},{"line_number":74,"context_line":"            options.insert(0, (\"\", _(\"Select an IP address\")))"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            options \u003d [(\"\", _(\"No IP addresses reserved\"))]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return options"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BKLo%3D","line":76,"in_reply_to":"AAAAWH%2F%2BK2w%3D","updated":"2014-03-28 18:09:02.000000000","message":"It sounds good to me. \"No floatoing IP addresses allocated\" or \"No allocated floating IP addresses\" looks better.","commit_id":"dfc8451953524782831fb809623fe9f9f9688705"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"92400b995af5d355a7e40a7d00bf1c746582e4b7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if options:"},{"line_number":74,"context_line":"            options.insert(0, (\"\", _(\"Select an IP address\")))"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            options \u003d [(\"\", _(\"No IP addresses reserved\"))]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return options"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BK2w%3D","line":76,"in_reply_to":"AAAAWH%2F%2BK5c%3D","updated":"2014-03-28 16:52:56.000000000","message":"Yeah, definitively you got a point.\nDoes : \u0027No IP addresses allocated\u0027 sounds good for you!?","commit_id":"dfc8451953524782831fb809623fe9f9f9688705"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"b6ba49889440ac12b8c4f676c98fecb38f69dcc3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if options:"},{"line_number":74,"context_line":"            options.insert(0, (\"\", _(\"Select an IP address\")))"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            options \u003d [(\"\", _(\"No IP addresses reserved\"))]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return options"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BJXk%3D","line":76,"in_reply_to":"AAAAWH%2F%2BKLo%3D","updated":"2014-03-28 19:52:56.000000000","message":"Done","commit_id":"dfc8451953524782831fb809623fe9f9f9688705"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"e72b0e056fb8e178e8ff7365d4cb05221ccec819","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if options:"},{"line_number":74,"context_line":"            options.insert(0, (\"\", _(\"Select an IP address\")))"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            options \u003d [(\"\", _(\"No allocated floating IP addresses\"))]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return options"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9%2FnE%3D","line":76,"updated":"2014-03-31 17:32:57.000000000","message":"This is still somewhat confusing to an end user. I prefer \"No floating IP addresses allocated\"","commit_id":"646e33801c7868f8e931d83955fed006f7da1866"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dafe531110bd553938db1e08a0b1b5c08508bbc4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if options:"},{"line_number":74,"context_line":"            options.insert(0, (\"\", _(\"Select an IP address\")))"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            options \u003d [(\"\", _(\"No allocated floating IP addresses\"))]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return options"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9mQY%3D","line":76,"in_reply_to":"AAAAWH%2F9%2FnE%3D","updated":"2014-04-03 13:05:14.000000000","message":"+1","commit_id":"646e33801c7868f8e931d83955fed006f7da1866"},{"author":{"_account_id":10179,"name":"Facundo Farias","email":"facundo.farias@intel.com","username":"ffarias"},"change_message_id":"4f1082c5c828f5c98221fddc7fb4aa817ab1507a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        if options:"},{"line_number":74,"context_line":"            options.insert(0, (\"\", _(\"Select an IP address\")))"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            options \u003d [(\"\", _(\"No allocated floating IP addresses\"))]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return options"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F9ltA%3D","line":76,"in_reply_to":"AAAAWH%2F9mQY%3D","updated":"2014-04-03 14:19:38.000000000","message":"I will change it, and I will wait for your +2, Hahah :)","commit_id":"646e33801c7868f8e931d83955fed006f7da1866"}]}
