)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58dc7b3e934896d0bb8881860a721fcf78739e0d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Update OPENSTACK_ENDPOINT_TYPE documentation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The [1] change updated the behavior but the doc was"},{"line_number":10,"context_line":"never updated so it\u0027s no longer valid."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://review.opendev.org/c/openstack/horizon/+/730781"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"022a390c_9fb55ee7","line":10,"updated":"2022-07-13 04:28:07.000000000","message":"Precisely speaking, [1] just resolved the inconsistency for identity endpoint lookup (some code honored OPENSTACK_ENDPOINT_YPE and some uses the hardcoded endpoint type).\n\nAnyway the default value of OPENSTACK_ENDPOINT_TYPE for identity is \"public\" (and it was true even when [1] was merged), so the current description is wrong as it says \u0027internal\u0027 is the default value for keystone.","commit_id":"36c91fd50df37e40975e0b08e71e57f48604ef33"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"21b62e0c09cd72c24c7883dce63f5c960a1acf01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b28e2d52_3cdd88ba","updated":"2022-07-04 16:46:22.000000000","message":"Thanks for the patch, Please find one comment inline.\nAlso, it is better to squash this patch with the parent patch https://review.opendev.org/c/openstack/horizon/+/844574/6\n\nAny specific reason to push documentation change as a separate patch?","commit_id":"36c91fd50df37e40975e0b08e71e57f48604ef33"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5e3e1df75b28190e66c562de6d74f2a5aaf1657b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"772f2a1e_47738dc0","in_reply_to":"83cf7744_35ca2ead","updated":"2022-07-14 05:28:58.000000000","message":"ack.","commit_id":"36c91fd50df37e40975e0b08e71e57f48604ef33"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79430ff1f1cf67526bf2625462ce98c0f347afbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83cf7744_35ca2ead","in_reply_to":"b28e2d52_3cdd88ba","updated":"2022-07-13 04:12:17.000000000","message":"I think there is no need to squash these two changes. The other patch you mentioned introduces a new config option and this updates the document to match the current code.","commit_id":"36c91fd50df37e40975e0b08e71e57f48604ef33"}],"doc/source/configuration/settings.rst":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"21b62e0c09cd72c24c7883dce63f5c960a1acf01","unresolved":true,"context_lines":[{"line_number":592,"context_line":""},{"line_number":593,"context_line":"Default: ``\"publicURL\"``"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"A string which specifies the endpoint type to use for the endpoints in the"},{"line_number":596,"context_line":"Keystone service catalog. The default value for all services except for"},{"line_number":597,"context_line":"identity is ``\"publicURL\"`` . The default value for the identity service is"},{"line_number":598,"context_line":"``\"internalURL\"``."},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"OPENSTACK_HOST"},{"line_number":601,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"49f1ac4e_b1ff6f83","side":"PARENT","line":598,"range":{"start_line":595,"start_character":0,"end_line":598,"end_character":18},"updated":"2022-07-04 16:46:22.000000000","message":"You don\u0027t need to remove the original description added by the patch which introduces this configuration. What you can do is add version change here like done in [1].\n\n[1] https://review.opendev.org/c/openstack/horizon/+/824432/3/doc/source/configuration/settings.rst#1408","commit_id":"8d45a9f94140a8428de8d53067c39db8adf4d08c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79430ff1f1cf67526bf2625462ce98c0f347afbc","unresolved":true,"context_lines":[{"line_number":592,"context_line":""},{"line_number":593,"context_line":"Default: ``\"publicURL\"``"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"A string which specifies the endpoint type to use for the endpoints in the"},{"line_number":596,"context_line":"Keystone service catalog. The default value for all services except for"},{"line_number":597,"context_line":"identity is ``\"publicURL\"`` . The default value for the identity service is"},{"line_number":598,"context_line":"``\"internalURL\"``."},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"OPENSTACK_HOST"},{"line_number":601,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9cffe1b6_a1222cc7","side":"PARENT","line":598,"range":{"start_line":595,"start_character":0,"end_line":598,"end_character":18},"in_reply_to":"49f1ac4e_b1ff6f83","updated":"2022-07-13 04:12:17.000000000","message":"+1\n\nI will update the document to use the \"versionchanged\" directive.","commit_id":"8d45a9f94140a8428de8d53067c39db8adf4d08c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"52666660332c2f2d47bd87014e649ff9cd78f008","unresolved":true,"context_lines":[{"line_number":592,"context_line":""},{"line_number":593,"context_line":"Default: ``\"publicURL\"``"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"A string which specifies the endpoint type to use for the endpoints in the"},{"line_number":596,"context_line":"Keystone service catalog. The default value for all services except for"},{"line_number":597,"context_line":"identity is ``\"publicURL\"`` . The default value for the identity service is"},{"line_number":598,"context_line":"``\"internalURL\"``."},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"OPENSTACK_HOST"},{"line_number":601,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e623b52b_13ab1a45","side":"PARENT","line":598,"range":{"start_line":595,"start_character":0,"end_line":598,"end_character":18},"in_reply_to":"9cffe1b6_a1222cc7","updated":"2022-07-13 04:25:17.000000000","message":"I checked the situation in detail. Before [1], the endpoint type for keystone was inconsistent. It was hardcoded to \u0027internal\u0027 in openstack_dashboard/api/keystone.py, but the similar code in openstack_auth/backend.py uses OPENSTACK_ENDPOINT_TYPE setting. The patch [1] resolved this inconsistency. I think there is no need to add \"versionchanged\" directive as this is not a change in the setting.\n\nThe current proposed change looks good too.\n\n[1] https://review.opendev.org/c/openstack/horizon/+/730781","commit_id":"8d45a9f94140a8428de8d53067c39db8adf4d08c"}]}