)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"56fa16eee9b166fdb1e10de8fa2dcc6ee64e6ab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9d5e997_751d398f","updated":"2022-06-04 08:15:58.000000000","message":"recheck","commit_id":"500c4203eb725a5477e4961809941c28ce0f8a48"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5b89501849b339207382c6509c853c7803994435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e1a6fea2_8242dda5","updated":"2022-06-29 19:27:24.000000000","message":"Thanks for the patch. Please find one comment inline.\nOtherwise LGTM.","commit_id":"0cdb195a357d5adb228430222c89a90ed81264ad"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b76f352c05460d1aea197e595885e0c3000ff01d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7741bd4e_e52f245b","updated":"2022-07-15 17:11:24.000000000","message":"-1 due to my comment in openstack_dashboard/api/keystone.py. It needs to be fixed apparently.\n\nRegarding my question on the motivation of this patch, I would like to clarify it before I vote.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2b23c4d996ebfeb3a268db47281f9511c7354a77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"db4378a2_869232f0","updated":"2022-07-15 17:08:38.000000000","message":"Can I ask a very basic question before moving this forward?\nWhat kind of deployments need horizon uses a different endpoint type ONLY for keystone? (for example, \"internal\" for keystone only and \"public\" for others)\n\n- If users of your OpenStack cloud is allowed to use OpenStack APIs, all services provided including keystone requires \"public\" endpoint. If so, there is no need for horizon to use \"internal\" endpoint type for keystone.\n- If users of your OpenStack cloud is not allowed to use OpenStack API directly and need to use horizon to access the cloud, there is no need for \"public\" and it would be enough to set OPENSTACXK_ENDPOINT_TYPE to \"internal\" in horizon (Or you can still use \"public\" endpoint in a private network segment).\n\nI am wondering why you need to use a different endpoint type only for keystone and would like to understand the detail reason on why your patch is needed.\n\nP.S. https://review.opendev.org/c/openstack/horizon/+/730781 you mentioned in the commit message did not intend the removal of \"internal\" endpoint usage for keystone. Before that, the situation was worse. some code referred to OPENSTACK_ENDPOINT_TYPE (which defaults to \"public\") and some other code (you touched in this patch) referred to the hardcoded \"internal\" endpoint type, so as a result both of \"internal\" and \"public\" were required when the default setting was used. If you would like to use \"internal\" endpoint for keystone completely, you needed to set OPENSTACK_ENDPOINT_TYPE to \"internal\".\n","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9e8258cdf89df5df1a17ed4eb3894b66bdaaa3d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3be4759e_71f3ff52","updated":"2022-07-15 17:34:23.000000000","message":"Even after I agree with the motivation, I still have several comments.\n\n- KeystoneBackend.authenticate() in openstack_auth/backend.py refers to OPENSTACK_ENDPOINT_TYPE. Doesn\u0027t it need to refer to the new setting?\n- user_verify_admin_password() in openstack_dashboard/api/keystone.py uses a hardcoded \"publicURL\" endpoint type. Don\u0027t you need to use the new setting?\n- I personally prefer to changing OPENSTACK_ENDPOINT_TYPE to accept the following dict like below in addition to the string version currently used. It allows us to keep the code handling OPENSTACK_ENDPOINT_TYPE in a single place (using a function).\n\n  OPENSTACK_ENDPOINT_TYPE \u003d {\n    \u0027identity\u0027: \u0027internal\u0027,\n    \u0027default\u0027: \u0027public\u0027,\n  }\n","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"b33cad7816bbf31040b3ae06391536c717cedc3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a08b2f8_1d64d46d","updated":"2022-06-30 03:48:38.000000000","message":"Thanks, LGTM","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6fb7804559f7aa07f6acfff6a8a1e388d606870d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cb2bdddb_2d4eff06","in_reply_to":"3be4759e_71f3ff52","updated":"2022-08-01 08:14:33.000000000","message":"1. Fixed\n2. Fixed\n3. That could be done, but to respect deployment tooling I\u0027d rather add a config option than change the formatting of an existing one from string to dict.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6fb7804559f7aa07f6acfff6a8a1e388d606870d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"580c17db_b96cd3ae","in_reply_to":"7741bd4e_e52f245b","updated":"2022-08-01 08:14:33.000000000","message":"Fixed, see comment below.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"3468b8e1336bdc3fbea8a5ed8a2318deea5938c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b50f1f9b_74a8ceb3","in_reply_to":"a0cf37c5_eddb5204","updated":"2022-08-01 08:27:13.000000000","message":"We have a very strict networking design that has Horizon and Keystone into it\u0027s own \"trusted zone\" that is isolated from other zones containing a region.\n\nA trusted zone that contains a region is only allowed to talk to Keystone through the public endpoint into the trusted zone where Keystone is located and cannot talk to any internal or admin endpoint.\n\nCustomers access Horizon through the public endpoint into the trusted zone where Horizon (and Keystone) is located. Inside the trusted zone you don\u0027t have access to talk to the public endpoint, that means services inside the trusted zone can only talk to each other on an internal or admin endpoint.\n\nThe public endpoint in our case is working as an application firewall and due to that and network design the public endpoint is not accessible internally in a trusted zone.\n\nBecause of above, we need Horizon to talk to Keystone on an internal endpoint but talk to public endpoint for other services in a region since that would traverse to a different trusted zone where the same logic is applied.\n\nBased on what you wrote in your P.S this also means Horizon has had more than one place where the logic has been hardcoded and is thus a reason why we\u0027ve had to workaround that issue by whitelisting a recirculating pattern in the application firewall to make it work.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6fb7804559f7aa07f6acfff6a8a1e388d606870d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0cf37c5_eddb5204","in_reply_to":"db4378a2_869232f0","updated":"2022-08-01 08:14:33.000000000","message":"I will write down a more complete explaination on why we need this.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ada1079b050c17c90f9690f906c344911b524ac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"451ba14e_e3f90546","updated":"2022-09-29 11:39:11.000000000","message":"LGTM","commit_id":"c3adff0a106d70ce89cbd612eab06d01aefa6c60"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2716c3c85d887d947b975463c26e57c2ba4cf6cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3c0b8a59_07829b44","updated":"2022-09-29 11:47:02.000000000","message":"LGTM, Please find one comment inline.\nI am fine with accepting this patch.","commit_id":"c3adff0a106d70ce89cbd612eab06d01aefa6c60"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"61ef5e5b8e6a221df89de0c2df37e8b05df21b04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"638ec68b_d341ee9a","updated":"2022-08-31 14:41:06.000000000","message":"adding review priority on this patch to get some more attentions.","commit_id":"c3adff0a106d70ce89cbd612eab06d01aefa6c60"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5678a1d29731b7ed0e1e70ac2ffef4c499292df8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8b36927d_a2b5cba2","updated":"2022-08-08 08:16:47.000000000","message":"recheck unrelated error","commit_id":"c3adff0a106d70ce89cbd612eab06d01aefa6c60"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8e86993f192c6a2f256681a24295b9c459df3bee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f0af1724_3f6948d4","updated":"2022-08-16 13:55:52.000000000","message":"recheck unrelated error","commit_id":"c3adff0a106d70ce89cbd612eab06d01aefa6c60"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"944e87e7f992ad51cf65c27ed7620e1c380a07f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"06feea0b_cc5d7350","updated":"2022-12-12 15:57:42.000000000","message":"Hi, Can anyone take a look at this patch, been waiting for a second review for a while?","commit_id":"b22a6d65f7722eca9f6c264ee4b4a65ed2f0d031"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a76628a57720a4482602f6c4934330ede0f1c632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eed64031_cbd1875e","updated":"2023-08-11 12:11:02.000000000","message":"Just acking so I can get it out of my gerrit dashboard, sorry for noice.","commit_id":"b22a6d65f7722eca9f6c264ee4b4a65ed2f0d031"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"143e3516aa73d6ca2d96c019ad33bad8d7152bdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b8ed3356_f9755a04","updated":"2022-09-29 15:44:06.000000000","message":"recheck flaky","commit_id":"b22a6d65f7722eca9f6c264ee4b4a65ed2f0d031"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"041603e1a5e3e8c1f9badde9734034d3259248ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a6fa30f9_ba274928","updated":"2022-12-15 04:47:04.000000000","message":"recheck, random failure.","commit_id":"b22a6d65f7722eca9f6c264ee4b4a65ed2f0d031"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"9c560554ea448234470c6904922a870f5e96bb35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9c9de16d_6838aaad","updated":"2022-12-15 14:37:42.000000000","message":"recheck, random failure.\n","commit_id":"b22a6d65f7722eca9f6c264ee4b4a65ed2f0d031"}],"doc/source/configuration/settings.rst":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5b89501849b339207382c6509c853c7803994435","unresolved":true,"context_lines":[{"line_number":598,"context_line":"OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":599,"context_line":"--------------------------------"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":".. versionadded:: 22.0.0(Zed)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"Default: ``\"publicURL\"``"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"88337833_6198e56d","line":601,"range":{"start_line":601,"start_character":18,"end_line":601,"end_character":24},"updated":"2022-06-29 19:27:24.000000000","message":"nit: version needs to be 22.3.0\n\nHorizon Zed cycle previous release version is \"22.2.0\" [1].\nSo the next release version going to be \"22.3.0\"\n[1] https://github.com/openstack/releases/blob/master/deliverables/zed/horizon.yaml","commit_id":"0cdb195a357d5adb228430222c89a90ed81264ad"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b5a8f5be76094254eaf4ba9f5d55f5f8714009c6","unresolved":false,"context_lines":[{"line_number":598,"context_line":"OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":599,"context_line":"--------------------------------"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":".. versionadded:: 22.0.0(Zed)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"Default: ``\"publicURL\"``"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"81634965_20e04fc0","line":601,"range":{"start_line":601,"start_character":18,"end_line":601,"end_character":24},"in_reply_to":"88337833_6198e56d","updated":"2022-06-29 23:52:20.000000000","message":"Done","commit_id":"0cdb195a357d5adb228430222c89a90ed81264ad"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2716c3c85d887d947b975463c26e57c2ba4cf6cb","unresolved":true,"context_lines":[{"line_number":598,"context_line":"OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":599,"context_line":"--------------------------------"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":".. versionadded:: 22.3.0(Zed)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"Default: ``\"publicURL\"``"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"2370f01b_e80cb6d6","line":601,"range":{"start_line":601,"start_character":18,"end_line":601,"end_character":24},"updated":"2022-09-29 11:47:02.000000000","message":"It needs to be updated now as it going to merge in antelope(2023.1).\nI will suggest using 23.1.0 version here.","commit_id":"c3adff0a106d70ce89cbd612eab06d01aefa6c60"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"57e27a10d434913e34fd08b0081f2344a97e144f","unresolved":true,"context_lines":[{"line_number":598,"context_line":"OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":599,"context_line":"--------------------------------"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":".. versionadded:: 22.3.0(Zed)"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"Default: ``\"publicURL\"``"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ce9d3956_314ff2bd","line":601,"range":{"start_line":601,"start_character":18,"end_line":601,"end_character":24},"in_reply_to":"2370f01b_e80cb6d6","updated":"2022-09-29 13:24:14.000000000","message":"Thanks, this is done.","commit_id":"c3adff0a106d70ce89cbd612eab06d01aefa6c60"}],"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9e8258cdf89df5df1a17ed4eb3894b66bdaaa3d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"94618898_9a07c539","updated":"2022-07-15 17:34:23.000000000","message":"Looking through this file, OPENSTACK_ENDPOINT_TYPE is still used.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6fb7804559f7aa07f6acfff6a8a1e388d606870d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"89757362_d0381ef5","in_reply_to":"94618898_9a07c539","updated":"2022-08-01 08:14:33.000000000","message":"Yes, because the Service class is a base class used by other services so it needs to be there for other types than identity.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2b23c4d996ebfeb3a268db47281f9511c7354a77","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        self.public_url \u003d base.get_url_for_service(service, region,"},{"line_number":79,"context_line":"                                                   \u0027publicURL\u0027)"},{"line_number":80,"context_line":"        if (service and \u0027type\u0027 in service and service[\u0027type\u0027] \u003d\u003d \u0027identity\u0027):"},{"line_number":81,"context_line":"            endpoint_type \u003d settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            endpoint_type \u003d settings.OPENSTACK_ENDPOINT_TYPE"},{"line_number":84,"context_line":"        self.url \u003d base.get_url_for_service(service, region, endpoint_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"330b5402_65b5b6b6","line":81,"updated":"2022-07-15 17:08:38.000000000","message":"This is not backward-compatible because OPENSTACK_ENDPOINT_TYPE is never referred for identity. Assume a case where OPENSTACK_KEYSTONE_ENDPOINT_TYPE is not configured (i.e. \u0027publicURL\u0027) and OPENSTACK_ENDPOINT_TYPE is configured to \u0027internalURL\u0027. In this case, settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE is still \u0027publicURL\u0027 and endpoint_type will be \u0027publicURL\u0027 instead of \u0027internalURL\u0027 configured in OPENSTACK_ENDPOINT_TYPE.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c90b23d73d18ea332049cec657a653a3e63f3d80","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        self.public_url \u003d base.get_url_for_service(service, region,"},{"line_number":79,"context_line":"                                                   \u0027publicURL\u0027)"},{"line_number":80,"context_line":"        if (service and \u0027type\u0027 in service and service[\u0027type\u0027] \u003d\u003d \u0027identity\u0027):"},{"line_number":81,"context_line":"            endpoint_type \u003d settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            endpoint_type \u003d settings.OPENSTACK_ENDPOINT_TYPE"},{"line_number":84,"context_line":"        self.url \u003d base.get_url_for_service(service, region, endpoint_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"49b8e75e_b63fecd5","line":81,"in_reply_to":"29cfc424_7c26f561","updated":"2022-12-19 08:07:43.000000000","message":"I\u0027m wondering whether https://review.opendev.org/c/openstack/horizon/+/868060 can address the concern regarding the backward-incomatibility.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6fb7804559f7aa07f6acfff6a8a1e388d606870d","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        self.public_url \u003d base.get_url_for_service(service, region,"},{"line_number":79,"context_line":"                                                   \u0027publicURL\u0027)"},{"line_number":80,"context_line":"        if (service and \u0027type\u0027 in service and service[\u0027type\u0027] \u003d\u003d \u0027identity\u0027):"},{"line_number":81,"context_line":"            endpoint_type \u003d settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            endpoint_type \u003d settings.OPENSTACK_ENDPOINT_TYPE"},{"line_number":84,"context_line":"        self.url \u003d base.get_url_for_service(service, region, endpoint_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"29cfc424_7c26f561","line":81,"in_reply_to":"330b5402_65b5b6b6","updated":"2022-08-01 08:14:33.000000000","message":"Correct, hence the release note stating that, cannot be backward compatible there.","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a76628a57720a4482602f6c4934330ede0f1c632","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.public_url \u003d base.get_url_for_service(service, region,"},{"line_number":79,"context_line":"                                                   \u0027publicURL\u0027)"},{"line_number":80,"context_line":"        if (service and \u0027type\u0027 in service and service[\u0027type\u0027] \u003d\u003d \u0027identity\u0027):"},{"line_number":81,"context_line":"            endpoint_type \u003d settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            endpoint_type \u003d settings.OPENSTACK_ENDPOINT_TYPE"},{"line_number":84,"context_line":"        self.url \u003d base.get_url_for_service(service, region, endpoint_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4bc601ba_aacb45d0","line":81,"in_reply_to":"49b8e75e_b63fecd5","updated":"2023-08-11 12:11:02.000000000","message":"Ack","commit_id":"68de7007141119664ba28817d8d4a0173e2dd814"}],"releasenotes/notes/keystone-endpoint-type-ab4151eca35e04c0.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c90b23d73d18ea332049cec657a653a3e63f3d80","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new setting ``OPENSTACK_KEYSTONE_ENDPOINT_TYPE`` that can be used to"},{"line_number":5,"context_line":"    specify the endpoint type to use when talking to the identity API. The default"},{"line_number":6,"context_line":"    is set to the value of ``OPENSTACK_ENDPOINT_TYPE`` for backward compatibility."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    If you are setting ``OPENSTACK_ENDPOINT_TYPE`` to change the default endpoint type"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cb1d7769_f82b70a6","line":6,"range":{"start_line":5,"start_character":71,"end_line":6,"end_character":82},"updated":"2022-12-19 08:07:43.000000000","message":"this is not really true because OPENSTACK_KEYSTONE_ENDPOINT_TYPE can be different if OPENSTACK_ENDPOINT_TYPE is set to non-default. We should state the default values for these two parameters are same.","commit_id":"b22a6d65f7722eca9f6c264ee4b4a65ed2f0d031"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a76628a57720a4482602f6c4934330ede0f1c632","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added new setting ``OPENSTACK_KEYSTONE_ENDPOINT_TYPE`` that can be used to"},{"line_number":5,"context_line":"    specify the endpoint type to use when talking to the identity API. The default"},{"line_number":6,"context_line":"    is set to the value of ``OPENSTACK_ENDPOINT_TYPE`` for backward compatibility."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    If you are setting ``OPENSTACK_ENDPOINT_TYPE`` to change the default endpoint type"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"789dc4d0_e2c517a4","line":6,"range":{"start_line":5,"start_character":71,"end_line":6,"end_character":82},"in_reply_to":"cb1d7769_f82b70a6","updated":"2023-08-11 12:11:02.000000000","message":"Ack","commit_id":"b22a6d65f7722eca9f6c264ee4b4a65ed2f0d031"}]}