)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"d6708398092b50c9540e35ab8721af7176981234","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b7063c41_fa045892","updated":"2022-08-10 16:03:57.000000000","message":"recheck","commit_id":"018ff433c0d3904d41aaf962deeeff376bb57abd"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7410f2e374bc8653afab01a6cd43127329e8cb46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"024bc789_57d81d59","updated":"2025-05-07 11:45:57.000000000","message":"@victor.coutellier@gmail.com hello, your planned continue work for this MR?","commit_id":"c7b7549b4c982edf59d93b17af85ed3eb21e1b65"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"bebd19b35cd0d0261b7d6fdd0a23516eee42f316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"73080f6a_28f2bf9f","updated":"2025-05-07 11:09:34.000000000","message":"I think this is a great change, but it may require a little bit more work.\n\nIf it completely removes the setting, then we should also remove it from the documentation, defaults and examples. There is a deprecation process for this,\nso it would probably need to take two releases to do this, with the first marking the setting as deprecated, and the second removing it.\n\nI also see that it\u0027s adding a use of the neutron API. How does this interact with the effort to move to use of OpenStackSDK for the neutron API? Are we adding one more place that will need to be changed? Could we make the change already in one patch instead?","commit_id":"c7b7549b4c982edf59d93b17af85ed3eb21e1b65"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7660e558d6b1a46283c90afe946b209bb9bb859b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1366ee09_29b1d324","in_reply_to":"024bc789_57d81d59","updated":"2025-05-14 15:57:01.000000000","message":"I think you can safely assume no, they haven\u0027t been active since 2022.","commit_id":"c7b7549b4c982edf59d93b17af85ed3eb21e1b65"}],"openstack_dashboard/dashboards/admin/floating_ips/panel.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"bebd19b35cd0d0261b7d6fdd0a23516eee42f316","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                neutron.is_router_enabled(request) and"},{"line_number":42,"context_line":"                super().allowed(context)"},{"line_number":43,"context_line":"            )"},{"line_number":44,"context_line":"        except Exception:"},{"line_number":45,"context_line":"            LOG.error(\"Call to list enabled services failed. This is likely \""},{"line_number":46,"context_line":"                      \"due to a problem communicating with the Neutron \""},{"line_number":47,"context_line":"                      \"endpoint. Neutron FIP panel will not be displayed.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"7d076c62_3fe9afe0","line":44,"updated":"2025-05-07 11:09:34.000000000","message":"nitpick: I don\u0027t like how we are here catching any potential exception from super().allowed and displaying a wrong error message for it. I think I would prefer this to be separated into multiple conditions, each with its own return, to make the flow easier to control. Something like:\n\ntry:\n    if not neutron.is_router_enabled(context[\u0027request\u0027]):\n        return False\nexcept Exception:\n    ...\nreturn super().allowed(context)\n    \nAlso, can we be more specific about the exceptions we are expecting here?","commit_id":"c7b7549b4c982edf59d93b17af85ed3eb21e1b65"}]}