)]}'
{"openstack_dashboard/test/integration_tests/base.py":[{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"99a386028b3a5c045b9cf46b8ee2ddd558bbfa07","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.home_pg \u003d login_pg.login()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def tearDown(self):"},{"line_number":27,"context_line":"        self.home_pg \u003d basepage.BasePage(self.driver, self.conf)"},{"line_number":28,"context_line":"        self.home_pg.go_to_home_page()"},{"line_number":29,"context_line":"        self.home_pg.log_out()"},{"line_number":30,"context_line":"        super(TestCase, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fx9s%3D","line":27,"updated":"2014-04-17 14:10:51.000000000","message":"I admit that the usage of BasePage here feels a little weird to me, since BasePage feels abstract in that it doesn\u0027t represent a specific page, unlike LoginPage.  But on the other hand, I don\u0027t see why this *wouldn\u0027t* work, so maybe it\u0027s just my own bias to get over?\n\nThe commit message also specifically mentions that tearDown goes to the home page; should I assume that a BasePage is that home page?","commit_id":"49601ca8d0ca495d095ec633f6861340f938787a"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"52446d5c4d080cc576a4eba7f6615afc4846188c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.home_pg \u003d login_pg.login()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def tearDown(self):"},{"line_number":27,"context_line":"        self.home_pg \u003d basepage.BasePage(self.driver, self.conf)"},{"line_number":28,"context_line":"        self.home_pg.go_to_home_page()"},{"line_number":29,"context_line":"        self.home_pg.log_out()"},{"line_number":30,"context_line":"        super(TestCase, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2Fy2U%3D","line":27,"in_reply_to":"AAAAXH%2F%2Fw%2FA%3D","updated":"2014-04-27 07:49:33.000000000","message":"I agree.\nThanks for the comment, I\u0027ll submit a new patch with this change.","commit_id":"49601ca8d0ca495d095ec633f6861340f938787a"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"d544628dc08e39e985149a32bfe8345d31d75d16","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.home_pg \u003d login_pg.login()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def tearDown(self):"},{"line_number":27,"context_line":"        self.home_pg \u003d basepage.BasePage(self.driver, self.conf)"},{"line_number":28,"context_line":"        self.home_pg.go_to_home_page()"},{"line_number":29,"context_line":"        self.home_pg.log_out()"},{"line_number":30,"context_line":"        super(TestCase, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fxwo%3D","line":27,"in_reply_to":"AAAAXH%2F%2Fx9s%3D","updated":"2014-04-17 14:33:56.000000000","message":"I used the BasePage in this case rather than ProjectPage (for regular users) / AdminPage to make it compatible with both cases.\nThe idea behind BasePage is indeed abstract, as most pages share the same elements, such as the top bar menu, the accordion navigation and several other functions which I think can come in handy.\n\nAfter the instantiation of a general page, the next line (28) performs the go_to_home_page action. It\u0027s not really needed cause I think one can logout from every page, so I put it here for cosmetics (when you look at the selenium).","commit_id":"49601ca8d0ca495d095ec633f6861340f938787a"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"a62a3e46552d47c16a853690cecb3ec1045587f9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.home_pg \u003d login_pg.login()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def tearDown(self):"},{"line_number":27,"context_line":"        self.home_pg \u003d basepage.BasePage(self.driver, self.conf)"},{"line_number":28,"context_line":"        self.home_pg.go_to_home_page()"},{"line_number":29,"context_line":"        self.home_pg.log_out()"},{"line_number":30,"context_line":"        super(TestCase, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fw%2FA%3D","line":27,"in_reply_to":"AAAAXH%2F%2Fxwo%3D","updated":"2014-04-17 15:59:14.000000000","message":"Your argument is valid, but why override the self.home_pg variable? From what I see, it should contain a valid page. And if it does not, it is perfectly ok for the teardown to fail.","commit_id":"49601ca8d0ca495d095ec633f6861340f938787a"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"c932645257b5b94dcccac22195e5c26c8e7c286a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack_dashboard.test.integration_tests.pages import loginpage"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class TestCase(helpers.BaseTestCase):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def setUp(self):"},{"line_number":20,"context_line":"        super(TestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_913564f9","line":17,"updated":"2014-05-02 13:26:40.000000000","message":"This looks good to me, although I think the TestCase should also live in the helpers file. This is consistent with the horizon and openstack_dashboard tests, which have their main TestCase() classes that all the tests extend defined in helpers.py as well.\n\nhttps://github.com/openstack/horizon/blob/master/horizon/test/helpers.py#L77\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/test/helpers.py#L106","commit_id":"9184e13ddd1be1ca00b41654c83a57ab72e99dfe"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"74159b3f9f8de19a96e95d3ecff17d09a561f812","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack_dashboard.test.integration_tests.pages import loginpage"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class TestCase(helpers.BaseTestCase):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def setUp(self):"},{"line_number":20,"context_line":"        super(TestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_b391749b","line":17,"in_reply_to":"9ad9bd40_913564f9","updated":"2014-05-03 16:42:16.000000000","message":"It makes sense but there\u0027s one issue I\u0027m not sure how to deal with:\nThe login tests (there\u0027s only one now but will be more) can\u0027t inherit from this class, as it performs the login action causing all tests to start from the dashboard home page.\n\nAny idea how to solve this?","commit_id":"9184e13ddd1be1ca00b41654c83a57ab72e99dfe"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"0c2ca0ddad6e15ab50ab3ed03c8d3cf43d475d7e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack_dashboard.test.integration_tests.pages import loginpage"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class TestCase(helpers.BaseTestCase):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def setUp(self):"},{"line_number":20,"context_line":"        super(TestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_3686fc13","line":17,"in_reply_to":"9ad9bd40_b391749b","updated":"2014-05-06 09:16:53.000000000","message":"I\u0027m simply suggesting to move this TestCase class, as it currently is, to the helpers.py file (so there\u0027d be 2 classes in that other file). The class names are different so I don\u0027t think there\u0027ll be any conflict. Does that make sense?","commit_id":"9184e13ddd1be1ca00b41654c83a57ab72e99dfe"}]}