)]}'
{"horizon/tables/base.py":[{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"d7b0f198d39fc1225330af6efa7acfaed476879b","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        A dict of HTML attribute strings which should be added when the"},{"line_number":179,"context_line":"        column\u0027s text is displayed as a link."},{"line_number":180,"context_line":"        Example: ``attrs\u003d{\"data-foo\": \"bar\"}``."},{"line_number":181,"context_line":"        Defaults to ``None``."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    .. attribute:: wrap_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F4dg%3D","line":180,"updated":"2014-04-09 17:54:40.000000000","message":"Should this be \u0027link_attrs\u003d...\u0027 ?","commit_id":"fa8dfa99c8ebc62f3b93b6b05d2e94b5d22818ec"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"6f0f10e3e450ac522d5da7b657dcaec0df287d9e","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        if self.url:"},{"line_number":684,"context_line":"            link_classes \u003d \u0027 \u0027.join(self.column.link_classes)"},{"line_number":685,"context_line":"            link_attrs \u003d self.column.link_attrs.items()"},{"line_number":686,"context_line":"            lattrs \u003d \u0027 \u0027.join([(k + \u0027\u003d\"\u0027 + v + \u0027\"\u0027) for k, v in link_attrs])"},{"line_number":687,"context_line":"            # Escape the data inside while allowing our HTML to render"},{"line_number":688,"context_line":"            data \u003d mark_safe(\u0027\u003ca href\u003d\"%s\" class\u003d\"%s\" %s\u003e%s\u003c/a\u003e\u0027 %"},{"line_number":689,"context_line":"                             (self.url, link_classes,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_c872cc7b","line":686,"updated":"2014-05-02 22:36:11.000000000","message":"would changing this to:  \u0027%s\u003d\"%s\"\u0027 % (k,v) make it easier to read?","commit_id":"4e873e2b98f8d6d907f631f7bc3c0de79630e598"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"db11b1957ba947bc3cbbed5d8f6a2705720522ba","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        if self.url:"},{"line_number":684,"context_line":"            link_classes \u003d \u0027 \u0027.join(self.column.link_classes)"},{"line_number":685,"context_line":"            link_attrs \u003d self.column.link_attrs.items()"},{"line_number":686,"context_line":"            lattrs \u003d \u0027 \u0027.join([(k + \u0027\u003d\"\u0027 + v + \u0027\"\u0027) for k, v in link_attrs])"},{"line_number":687,"context_line":"            # Escape the data inside while allowing our HTML to render"},{"line_number":688,"context_line":"            data \u003d mark_safe(\u0027\u003ca href\u003d\"%s\" class\u003d\"%s\" %s\u003e%s\u003c/a\u003e\u0027 %"},{"line_number":689,"context_line":"                             (self.url, link_classes,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_a8d588ba","line":686,"in_reply_to":"9ad9bd40_c872cc7b","updated":"2014-05-02 23:31:41.000000000","message":"Good suggestion. Done!","commit_id":"4e873e2b98f8d6d907f631f7bc3c0de79630e598"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"b3d04688e71c072ea51329c6571c772397664b69","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        truncated data."},{"line_number":167,"context_line":"        Defaults to ``None``."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    .. attribute:: link_classes"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        An iterable of CSS classes which will be added when the column\u0027s text"},{"line_number":172,"context_line":"        is displayed as a link."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_644dee3a","line":169,"updated":"2014-06-20 09:17:37.000000000","message":"This should be marked as deprecated. See below.","commit_id":"be23f62cf47d5801a58e97fab146bdc638cfc7d2"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e9e01bebf2a748c55b3e69a1de50ddf6762a5412","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        if self.url:"},{"line_number":684,"context_line":"            link_classes \u003d \u0027 \u0027.join(self.column.link_classes)"},{"line_number":685,"context_line":"            link_attrs \u003d self.column.link_attrs.items()"},{"line_number":686,"context_line":"            lattrs \u003d \u0027 \u0027.join([(\u0027%s\u003d\"%s\"\u0027 % (k, v)) for k, v in link_attrs])"},{"line_number":687,"context_line":"            # Escape the data inside while allowing our HTML to render"},{"line_number":688,"context_line":"            data \u003d mark_safe(\u0027\u003ca href\u003d\"%s\" class\u003d\"%s\" %s\u003e%s\u003c/a\u003e\u0027 %"},{"line_number":689,"context_line":"                             (self.url, link_classes,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_34a75d51","line":686,"updated":"2014-05-07 20:16:43.000000000","message":"sorry missed this on the first patch,  should we also escape the value here?\n\nThis is in case the value comes from backend-data that we don\u0027t control.\n\nCode something like:\n    .. % (k, escape(v))","commit_id":"be23f62cf47d5801a58e97fab146bdc638cfc7d2"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"068eccd0d2486b77f994773ad8bb0ebd5ea7d1a2","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        if self.url:"},{"line_number":684,"context_line":"            link_classes \u003d \u0027 \u0027.join(self.column.link_classes)"},{"line_number":685,"context_line":"            link_attrs \u003d self.column.link_attrs.items()"},{"line_number":686,"context_line":"            lattrs \u003d \u0027 \u0027.join([(\u0027%s\u003d\"%s\"\u0027 % (k, v)) for k, v in link_attrs])"},{"line_number":687,"context_line":"            # Escape the data inside while allowing our HTML to render"},{"line_number":688,"context_line":"            data \u003d mark_safe(\u0027\u003ca href\u003d\"%s\" class\u003d\"%s\" %s\u003e%s\u003c/a\u003e\u0027 %"},{"line_number":689,"context_line":"                             (self.url, link_classes,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_2c3471dd","line":686,"in_reply_to":"7adec928_34a75d51","updated":"2014-05-07 21:49:07.000000000","message":"I assume that attributes are manually set, so the values is something we do control. I suppose it doesn\u0027t hurt to be extra careful, but I\u0027m wondering if this is overkill? if we escape v, why not k as well?","commit_id":"be23f62cf47d5801a58e97fab146bdc638cfc7d2"},{"author":{"_account_id":6550,"name":"Davide Guerri","email":"davide.guerri@gmail.com","username":"davide-guerri"},"change_message_id":"b3d04688e71c072ea51329c6571c772397664b69","unresolved":false,"context_lines":[{"line_number":685,"context_line":"            link_attrs \u003d self.column.link_attrs.items()"},{"line_number":686,"context_line":"            lattrs \u003d \u0027 \u0027.join([(\u0027%s\u003d\"%s\"\u0027 % (k, v)) for k, v in link_attrs])"},{"line_number":687,"context_line":"            # Escape the data inside while allowing our HTML to render"},{"line_number":688,"context_line":"            data \u003d mark_safe(\u0027\u003ca href\u003d\"%s\" class\u003d\"%s\" %s\u003e%s\u003c/a\u003e\u0027 %"},{"line_number":689,"context_line":"                             (self.url, link_classes,"},{"line_number":690,"context_line":"                              lattrs, escape(unicode(data))))"},{"line_number":691,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_044c2a41","line":688,"updated":"2014-06-20 09:17:37.000000000","message":"The class attribute should be a subset of of link_attributes.\nWe should leave link_classes for backward compatibility but it would be better to mark it as \"deprecated\".\nPlease see: https://review.openstack.org/101208 (duplicate of this patchset)","commit_id":"be23f62cf47d5801a58e97fab146bdc638cfc7d2"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a51e08582121d3b60710b1ec1264aa9b1378f099","unresolved":false,"context_lines":[{"line_number":685,"context_line":"            link_attrs \u003d self.column.link_attrs.items()"},{"line_number":686,"context_line":"            lattrs \u003d \u0027 \u0027.join([(\u0027%s\u003d\"%s\"\u0027 % (k, v)) for k, v in link_attrs])"},{"line_number":687,"context_line":"            # Escape the data inside while allowing our HTML to render"},{"line_number":688,"context_line":"            data \u003d mark_safe(\u0027\u003ca href\u003d\"%s\" class\u003d\"%s\" %s\u003e%s\u003c/a\u003e\u0027 %"},{"line_number":689,"context_line":"                             (self.url, link_classes,"},{"line_number":690,"context_line":"                              lattrs, escape(unicode(data))))"},{"line_number":691,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_fefd39b3","line":688,"in_reply_to":"1ae5cdf2_04218a4c","updated":"2014-06-26 18:16:56.000000000","message":"While classes are technically attributes, I think for legacy reason, we should keep them around. Internally, we can change their behavior so that classes are appended to attrs, but that would be beyond the scope of this patch.","commit_id":"be23f62cf47d5801a58e97fab146bdc638cfc7d2"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"2c340c0151d3b36d037a735df587bf05f81ef2d2","unresolved":false,"context_lines":[{"line_number":685,"context_line":"            link_attrs \u003d self.column.link_attrs.items()"},{"line_number":686,"context_line":"            lattrs \u003d \u0027 \u0027.join([(\u0027%s\u003d\"%s\"\u0027 % (k, v)) for k, v in link_attrs])"},{"line_number":687,"context_line":"            # Escape the data inside while allowing our HTML to render"},{"line_number":688,"context_line":"            data \u003d mark_safe(\u0027\u003ca href\u003d\"%s\" class\u003d\"%s\" %s\u003e%s\u003c/a\u003e\u0027 %"},{"line_number":689,"context_line":"                             (self.url, link_classes,"},{"line_number":690,"context_line":"                              lattrs, escape(unicode(data))))"},{"line_number":691,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_04218a4c","line":688,"in_reply_to":"1ae5cdf2_044c2a41","updated":"2014-06-20 09:26:20.000000000","message":"Since classes are also attributes, it really seems redundant to have link_classes and link_attrs. I\u0027d second Davide\u0027s comment that we need to keep the link_attrs only and either deprecate link_classes, or remove them completely.","commit_id":"be23f62cf47d5801a58e97fab146bdc638cfc7d2"}]}
