)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8d7a451e89feed167939e19ed36f0bcfca330cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7ec6fa7_6e25b598","updated":"2022-11-01 05:40:19.000000000","message":"Could you describe why this change is needed?\nThe commit message just says \"Revemo it\".","commit_id":"1ad406c526a522155c03e5fdb8e3c1ee90ebbbab"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"914cc3f297f2dfd74a574986bd89eee36af2bd85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"628f7959_e11035ee","in_reply_to":"f7ec6fa7_6e25b598","updated":"2022-11-02 08:47:11.000000000","message":"Added description in commit message","commit_id":"1ad406c526a522155c03e5fdb8e3c1ee90ebbbab"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d536cbfb198aaec0840fa13f84c79ec29b06f495","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb991f11_6994405a","updated":"2022-11-04 15:29:09.000000000","message":"Thanks, LGTM.","commit_id":"ee92961fe5275f85779634aad637d00c15802b49"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cb0addaa02368cd99f28e69daf301422a490c2a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b8696338_1c896a2f","updated":"2023-01-25 13:53:39.000000000","message":"This commit itself looks good, but I see a point to be clean up around server_*_console().\n\nLooking at the codes which refer to get_mks_console, all server_*_console() variants are called with the same arguments [1][2]. Thus, all of these variants should have the same arguments. I think other server_*_console() should be same.\nI will send a follow-up cleanup.\n\n[1] https://opendev.org/openstack/horizon/src/commit/193320f64ebbe7501a93e053387247ce95b399e5/openstack_dashboard/dashboards/project/instances/console.py#L27-L31\n[2] https://opendev.org/openstack/horizon/src/commit/193320f64ebbe7501a93e053387247ce95b399e5/openstack_dashboard/api/rest/nova.py#L249-L253\n","commit_id":"ee92961fe5275f85779634aad637d00c15802b49"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"62c0df044fef58b08c1857f12bc34ff2ec6888a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ebcbc84_5eb303ea","in_reply_to":"b8696338_1c896a2f","updated":"2023-01-26 05:51:19.000000000","message":"\u003e Looking at the codes which refer to get_mks_console, all server_*_console() variants are called with the same arguments [1][2]. Thus, all of these variants should have the same arguments. I think other server_*_console() should be same.\n\u003e I will send a follow-up cleanup.\n\nFor other server_*_console() variants, the corresponding novaclient methods accept \"console_type\" argument. I guess this is the reason that these methods have \"console_type\" argument regardless of that horizon does not provide a way to specify a console type even if there are multiple console types are available (for example, VNC accepts two types).\n\nConsidering this, I think there is no **strong** need to clean them up.\n\nThanks,","commit_id":"ee92961fe5275f85779634aad637d00c15802b49"}]}