)]}'
{"openstack_dashboard/dashboards/admin/networks/ports/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3731a941910e71634c99c306163f15febb029357","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        project_id \u003d None"},{"line_number":40,"context_line":"        if datum:"},{"line_number":41,"context_line":"            project_id \u003d getattr(datum, \u0027tenant_id\u0027, None)"},{"line_number":42,"context_line":"        return {\"project_id\": project_id}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def delete(self, request, obj_id):"},{"line_number":45,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_ef1254b3","line":42,"updated":"2014-05-28 11:27:31.000000000","message":"I see too many same get_policy_target. Can\u0027t we use mixin style or prepare a base class which inherits DeleteAction/LinkAction?\nI don\u0027t want to see copy-and-paste style like this.","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"}],"openstack_dashboard/dashboards/admin/networks/subnets/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3731a941910e71634c99c306163f15febb029357","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        project_id \u003d None"},{"line_number":39,"context_line":"        if datum:"},{"line_number":40,"context_line":"            project_id \u003d getattr(datum, \u0027tenant_id\u0027, None)"},{"line_number":41,"context_line":"        return {\"network:project_id\": project_id}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def delete(self, request, obj_id):"},{"line_number":44,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_af204cf8","line":41,"updated":"2014-05-28 11:27:31.000000000","message":"Could you clarify the reason why we need to use \u0027network:project_id\u0027 here? I see \u0027network:project_id\u0027 only in subnets/tables. Perhaps I don\u0027t understand the detail of the policy mechanism in horizon.","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"084a209a8cfc906d823e9a26760729241f720b06","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        project_id \u003d None"},{"line_number":39,"context_line":"        if datum:"},{"line_number":40,"context_line":"            project_id \u003d getattr(datum, \u0027tenant_id\u0027, None)"},{"line_number":41,"context_line":"        return {\"network:project_id\": project_id}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def delete(self, request, obj_id):"},{"line_number":44,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_0cebe313","line":41,"in_reply_to":"3ae8d1ca_012d6cfe","updated":"2014-05-29 11:04:45.000000000","message":"I see. This is a very tricky case.\n\nIf I remember correctly, the rule in neutron policy.json means that an owner of a network which a subnet belongs to can delete the subnet. This is because a subnet is deleted in cascade when deleting a network and \nowners of a network and a subnet can be different. There is a case a network cannot be deleted without this rule. But it seems better that such special case should be handled in neutron code to avoid confusion.\n\nOn the other hand, the above method extracts project_id of a subnet, so I think precisely speaking the logic is not correct. It can be fixed later.","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ba20b13ca3ee54921ed6a924d67f4bb114bb89dc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        project_id \u003d None"},{"line_number":39,"context_line":"        if datum:"},{"line_number":40,"context_line":"            project_id \u003d getattr(datum, \u0027tenant_id\u0027, None)"},{"line_number":41,"context_line":"        return {\"network:project_id\": project_id}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def delete(self, request, obj_id):"},{"line_number":44,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_7036eae8","line":41,"in_reply_to":"3ae8d1ca_0cebe313","updated":"2014-05-29 17:22:57.000000000","message":"Opened https://bugs.launchpad.net/horizon/+bug/1324635 to track this issue","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"d71c782883b55b264607cc46d4d1f7dffb040200","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        project_id \u003d None"},{"line_number":39,"context_line":"        if datum:"},{"line_number":40,"context_line":"            project_id \u003d getattr(datum, \u0027tenant_id\u0027, None)"},{"line_number":41,"context_line":"        return {\"network:project_id\": project_id}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def delete(self, request, obj_id):"},{"line_number":44,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_012d6cfe","line":41,"in_reply_to":"3ae8d1ca_af204cf8","updated":"2014-05-29 10:42:33.000000000","message":"The policy rule for \"delete_subnet\" is set to \"rule:admin_or_network_owner\" that expects a variable named network:project_id:\n\n    \"admin_or_network_owner\": \"rule:context_is_admin or project_id:%(network:project_id)s\",\n\nI wonder if this kind of detail will hurt us if the deployer changes the rule to e.g. admin_or_owner or something even more customised in the future, but probably like the other (valid) comments about copy-pasting this is best handled in a separate patch as it covers more than just the network policy.","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"}],"openstack_dashboard/dashboards/project/loadbalancers/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3731a941910e71634c99c306163f15febb029357","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    action_past \u003d _(\"Scheduled deletion of %(data_type)s\")"},{"line_number":74,"context_line":"    data_type_singular \u003d _(\"VIP\")"},{"line_number":75,"context_line":"    data_type_plural \u003d _(\"VIPs\")"},{"line_number":76,"context_line":"    policy_rules \u003d ((\"network\", \"delete_vip\"),)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":79,"context_line":"        if datum and not datum.vip_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_6f02c43f","line":76,"updated":"2014-05-28 11:27:31.000000000","message":"I am not sure why get_policy_target() is unnecessary for LBaaS actions. Let me ask.","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f8757a0fd789fec15e5b351f042e9959bb69bd1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    action_past \u003d _(\"Scheduled deletion of %(data_type)s\")"},{"line_number":74,"context_line":"    data_type_singular \u003d _(\"VIP\")"},{"line_number":75,"context_line":"    data_type_plural \u003d _(\"VIPs\")"},{"line_number":76,"context_line":"    policy_rules \u003d ((\"network\", \"delete_vip\"),)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":79,"context_line":"        if datum and not datum.vip_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_2d724fe5","line":76,"in_reply_to":"3ae8d1ca_4adce1e4","updated":"2014-05-29 17:19:47.000000000","message":"Logged bug: https://bugs.launchpad.net/horizon/+bug/1324630","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"45cc79ca85dbc985563fc8b94436a07f25a0c9fc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    action_past \u003d _(\"Scheduled deletion of %(data_type)s\")"},{"line_number":74,"context_line":"    data_type_singular \u003d _(\"VIP\")"},{"line_number":75,"context_line":"    data_type_plural \u003d _(\"VIPs\")"},{"line_number":76,"context_line":"    policy_rules \u003d ((\"network\", \"delete_vip\"),)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def allowed(self, request, datum\u003dNone):"},{"line_number":79,"context_line":"        if datum and not datum.vip_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ae8d1ca_4adce1e4","line":76,"in_reply_to":"3ae8d1ca_6f02c43f","updated":"2014-05-29 16:46:34.000000000","message":"good catch, the policy checks for admin_or_owner too. I\u0027ll open a separate bug for this.","commit_id":"d93722d379c503f16239dbf345b341c679c7210f"}]}
