)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"14cc8e9ba4b1c525f7b57cd86bd155773d1a8e0b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gabriel Luong \u003cgabriel.luong@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-10 14:30:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug 1306216 - In ToggleSuspend, return False if instance is None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iad67cc61954f57c4260467d3f827a51b932b74b9"},{"line_number":10,"context_line":"Closes-Bug: #1306216"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FqXs%3D","line":7,"updated":"2014-04-11 10:32:21.000000000","message":"Please remove the bug number from commit summary. It\u0027s already included in the bottom.\n\nIt should merely read:\nIn ToggleSuspend, return False if instance is None","commit_id":"a9afb340dd27758ef5494bf23a327ca08074b3f3"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"change_message_id":"ac05800b950d5a1848c60186dd116e1342ea9934","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            return False"},{"line_number":187,"context_line":"        self.suspended \u003d False"},{"line_number":188,"context_line":"        if not instance:"},{"line_number":189,"context_line":"            return self.suspended"},{"line_number":190,"context_line":"        self.suspended \u003d instance.status \u003d\u003d \"SUSPENDED\""},{"line_number":191,"context_line":"        if self.suspended:"},{"line_number":192,"context_line":"            self.current_present_action \u003d RESUME"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FpvA%3D","line":189,"updated":"2014-04-11 12:13:06.000000000","message":"I think you could simply write \u0027return False\u0027","commit_id":"2681a3dc01bb5af3fdb5f0212b481d7886a56bad"},{"author":{"_account_id":7386,"name":"Tzu-Mainn Chen","email":"tzumainn@redhat.com","username":"tzumainn"},"change_message_id":"a98f5713045fe299ee292cb4ca1716c6432f949c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            return False"},{"line_number":187,"context_line":"        self.suspended \u003d False"},{"line_number":188,"context_line":"        if not instance:"},{"line_number":189,"context_line":"            return self.suspended"},{"line_number":190,"context_line":"        self.suspended \u003d instance.status \u003d\u003d \"SUSPENDED\""},{"line_number":191,"context_line":"        if self.suspended:"},{"line_number":192,"context_line":"            self.current_present_action \u003d RESUME"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2Fm8s%3D","line":189,"in_reply_to":"AAAAW3%2F%2FoPA%3D","updated":"2014-04-11 19:16:10.000000000","message":"I think I agree with @pbelanyi; simply returning False clarifies the intended logic.","commit_id":"2681a3dc01bb5af3fdb5f0212b481d7886a56bad"},{"author":{"_account_id":10005,"name":"Gabriel Luong","email":"gabriel.luong@gmail.com","username":"gluong"},"change_message_id":"95dca0a4e3fce675f9ce06a2275772bfc57039e4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            return False"},{"line_number":187,"context_line":"        self.suspended \u003d False"},{"line_number":188,"context_line":"        if not instance:"},{"line_number":189,"context_line":"            return self.suspended"},{"line_number":190,"context_line":"        self.suspended \u003d instance.status \u003d\u003d \"SUSPENDED\""},{"line_number":191,"context_line":"        if self.suspended:"},{"line_number":192,"context_line":"            self.current_present_action \u003d RESUME"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FoPA%3D","line":189,"in_reply_to":"AAAAW3%2F%2FpvA%3D","updated":"2014-04-11 16:58:52.000000000","message":"This would be inconsistent with TogglePause() (line 147). I could change the returns for both if \u0027return False\u0027 will simplify the understanding of the code in both of these functions.","commit_id":"2681a3dc01bb5af3fdb5f0212b481d7886a56bad"},{"author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"change_message_id":"f1896836c391e211cc936aa4b47c88f08b4cdef8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        if not api.nova.extension_supported(\u0027AdminActions\u0027,"},{"line_number":143,"context_line":"                                            request):"},{"line_number":144,"context_line":"            return False"},{"line_number":145,"context_line":"        self.paused \u003d False"},{"line_number":146,"context_line":"        if not instance:"},{"line_number":147,"context_line":"            return False"},{"line_number":148,"context_line":"        self.paused \u003d instance.status \u003d\u003d \"PAUSED\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FepU%3D","line":145,"updated":"2014-04-14 10:53:04.000000000","message":"Sorry, some more nitpicking: this line is unnecessary. self.paused is not used until line 148, where it gets updated.","commit_id":"3062f641935af7f1b81c4247a927d4c2cf5bb571"},{"author":{"_account_id":9552,"name":"Peter Belanyi","email":"peter.belanyi@gmail.com","username":"pbelanyi"},"change_message_id":"f1896836c391e211cc936aa4b47c88f08b4cdef8","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        if not api.nova.extension_supported(\u0027AdminActions\u0027,"},{"line_number":185,"context_line":"                                            request):"},{"line_number":186,"context_line":"            return False"},{"line_number":187,"context_line":"        self.suspended \u003d False"},{"line_number":188,"context_line":"        if not instance:"},{"line_number":189,"context_line":"            return False"},{"line_number":190,"context_line":"        self.suspended \u003d instance.status \u003d\u003d \"SUSPENDED\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2Feo4%3D","line":187,"updated":"2014-04-14 10:53:04.000000000","message":"This line could be deleted as well, with the same logic. self.suspended is not used until line 190, where it is updated.","commit_id":"3062f641935af7f1b81c4247a927d4c2cf5bb571"}]}
