)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e1f972c06d41656d1307affa5681e43f5613c93f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is follow-up of I8438bedaf7cead452fc499e484d23690b48894d9 and"},{"line_number":10,"context_line":"ensures the OPENSTACK_ENDPOINT_TYPE parameter is used when"},{"line_number":11,"context_line":"OPENSTACK_KEYSTONE_ENDPOINT_TYPE is not unset. This avoids backward-"},{"line_number":12,"context_line":"incompatible change which affects deployments with endpoint type set"},{"line_number":13,"context_line":"to non-default values."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3b92542e_c679145f","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":45},"updated":"2022-12-22 09:44:20.000000000","message":"\"is not set\"?","commit_id":"6e555a76ec3d56e8f0709585682337b312014d80"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de22470215251bb4e79665e9fe92a1736103d67c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is follow-up of I8438bedaf7cead452fc499e484d23690b48894d9 and"},{"line_number":10,"context_line":"ensures the OPENSTACK_ENDPOINT_TYPE parameter is used when"},{"line_number":11,"context_line":"OPENSTACK_KEYSTONE_ENDPOINT_TYPE is not unset. This avoids backward-"},{"line_number":12,"context_line":"incompatible change which affects deployments with endpoint type set"},{"line_number":13,"context_line":"to non-default values."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e43db9cd_17a79a14","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":45},"in_reply_to":"3b92542e_c679145f","updated":"2022-12-22 10:00:59.000000000","message":"Indeed ! fixed.","commit_id":"6e555a76ec3d56e8f0709585682337b312014d80"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ad0815fb9861c7bf02885862f7325657c864f92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4125a22f_2023cf85","updated":"2022-12-22 08:21:53.000000000","message":"Hoenestly I am surprised that such backward-incompatible change was merged.\n-1 is because the original commit should be adjusted to a backeward-compatible one and this commit should be a place to do it (as it is a follow-up patch).\n\nMy suggestion is as follows:\n\n- OPENSTACK_KEYSTONE_ENDPOINT_TYPE accepts None (or an empty string) which means a value specified in OPENSTACK_ENDPOINT_TYPE is used.\n- Change the default value of OPENSTACK_KEYSTONE_ENDPOINT_TYPE to None (mentioned above) to keep the backward-compatibility\n\nopenstack_auth/backend.py and openstack_dashboard/api/keystone.py are affected.\n\n\nThe proposed change is still not sufficient because it just syncs the default values in openstack_auth/defaults.py and openstack_dashboard/defaults.py.\nIf an operator specified only OPENSTACK_KEYSTONE_ENDPOINT_TYPE in local_settings.py, OPENSTACK_KEYSTONE_ENDPOINT_TYPE will still be the default value. This is not backward compat.","commit_id":"518039da3a40b6842f3cb2931dcdaa5eabdf11c5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e1f972c06d41656d1307affa5681e43f5613c93f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af4ca1f6_a4c1bfc4","updated":"2022-12-22 09:44:20.000000000","message":"Thanks. doc/configuration/settings.rst also needs to be updated.","commit_id":"6e555a76ec3d56e8f0709585682337b312014d80"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"de22470215251bb4e79665e9fe92a1736103d67c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79421f88_0e074eee","in_reply_to":"af4ca1f6_a4c1bfc4","updated":"2022-12-22 10:00:59.000000000","message":"Done. Hope the update makes sense to you.","commit_id":"6e555a76ec3d56e8f0709585682337b312014d80"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23ea27a0ab4800b5d6d3c1a56bc4cd21f900dd8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"afc4c0a8_a2d2960f","updated":"2022-12-23 18:27:50.000000000","message":"I see possible minor improvements.\n\nI already have the updated version. Let me push a new patch set.","commit_id":"788596f3b63d7f1ff9276a112c68ee03fdcef015"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"195f0bd5b90c00a73994eaf0410887ee752df38e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"09dd90f7_084edb15","updated":"2023-01-05 14:16:29.000000000","message":"I believe it is ready to go, but I uploaded the last patch set. I would like to wait for ack from tkajinam.","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f1d48b9f8223ec30cc2e8181460d2b0a3c4ebbae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f5548aa1_9b6119b3","updated":"2023-01-02 13:56:05.000000000","message":"Thanks, this default value I guess makes more sense. I guess there was a logic flaw in my release note as well, I mean the \"same value as\" and not the \"value of\" for the default value.","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9686d656e4b883bae0ee3e684860b266d1972e9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"28bd3c49_abf49b04","updated":"2023-01-05 15:11:52.000000000","message":"The modification looks good to me. Thank you, Motoki-san !","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"08b5d360472fd0597ec6d941cf5efc07eccfbb0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f62e3f22_634aa6f0","updated":"2023-01-11 12:54:06.000000000","message":"looks, we have rebase this patch on master.","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"99e81b948072d291513c5dded9a6d47be2d3ea52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"409e9d06_cad874cb","updated":"2022-12-30 09:46:35.000000000","message":"recheck","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0d81e9773fab71db9bab7e0f1900641b67c02278","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b76199ca_7edd1f87","updated":"2023-01-16 13:26:45.000000000","message":"recheck TestDownloadRCFile.test_download_rc_v3_file failed on gate job","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4b664b72545cd30461b991eee8e1b63eee3a768","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b795cafc_020163a4","updated":"2023-01-17 01:59:07.000000000","message":"recheck failure is not consistent and looks intermittent.","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a5c31759f23a507699c89e622dd28323ce02255f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"da49a4d3_626f374f","updated":"2023-01-17 08:51:10.000000000","message":"recheck horizon-integration-tests once passed. seems flaky.","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b33d217ab30f83f3a7f1a37e8cd70ecbe4ecb0d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f7fdfde6_d57941f5","updated":"2023-01-16 04:51:40.000000000","message":"recheck https://review.opendev.org/c/openstack/horizon/+/869889 was merged.","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f70d369bcf60fa05c0808d2bb3cc3fe030db3500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"efe62bcf_90da3256","updated":"2023-01-16 06:49:45.000000000","message":"recheck tox could not open requirements file, perhaps it failed to download","commit_id":"9fa98969e728b94899de113a5174a955bbc70bd1"}],"doc/source/configuration/settings.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23ea27a0ab4800b5d6d3c1a56bc4cd21f900dd8f","unresolved":true,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"A string which specifies the endpoint type to use for the Keystone (identity)"},{"line_number":606,"context_line":"endpoint when looking it up in the service catalog. This overrides"},{"line_number":607,"context_line":"the ``OPENSTACK_ENDPOINT_TYPE`` parameter."},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"OPENSTACK_HOST"},{"line_number":610,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bc6e3679_e743ffeb","line":607,"updated":"2022-12-23 18:27:50.000000000","message":"I think we need to explain what None means.","commit_id":"788596f3b63d7f1ff9276a112c68ee03fdcef015"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d70699c732b55f58ffa54ed4edda5e04959799ac","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"A string which specifies the endpoint type to use for the Keystone (identity)"},{"line_number":606,"context_line":"endpoint when looking it up in the service catalog. This overrides"},{"line_number":607,"context_line":"the ``OPENSTACK_ENDPOINT_TYPE`` parameter."},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"OPENSTACK_HOST"},{"line_number":610,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"96c224bc_6555d186","line":607,"in_reply_to":"bc6e3679_e743ffeb","updated":"2022-12-23 18:30:00.000000000","message":"Done","commit_id":"788596f3b63d7f1ff9276a112c68ee03fdcef015"}],"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23ea27a0ab4800b5d6d3c1a56bc4cd21f900dd8f","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        super().__init__(service, *args, **kwargs)"},{"line_number":78,"context_line":"        self.public_url \u003d base.get_url_for_service(service, region,"},{"line_number":79,"context_line":"                                                   \u0027publicURL\u0027)"},{"line_number":80,"context_line":"        if (service and \u0027type\u0027 in service and service[\u0027type\u0027] \u003d\u003d \u0027identity\u0027 and"},{"line_number":81,"context_line":"                settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE):"},{"line_number":82,"context_line":"            endpoint_type \u003d settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":83,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"c3fbfde0_ed6bb516","line":80,"updated":"2022-12-23 18:27:50.000000000","message":"In other places in horizon, \"service\" is assumed as dict, so we can simplify the condition like:\n\n  service.get(\u0027type\u0027) \u003d\u003d \u0027identity\u0027\n\nI believe it improves the readability too.","commit_id":"788596f3b63d7f1ff9276a112c68ee03fdcef015"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d70699c732b55f58ffa54ed4edda5e04959799ac","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        super().__init__(service, *args, **kwargs)"},{"line_number":78,"context_line":"        self.public_url \u003d base.get_url_for_service(service, region,"},{"line_number":79,"context_line":"                                                   \u0027publicURL\u0027)"},{"line_number":80,"context_line":"        if (service and \u0027type\u0027 in service and service[\u0027type\u0027] \u003d\u003d \u0027identity\u0027 and"},{"line_number":81,"context_line":"                settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE):"},{"line_number":82,"context_line":"            endpoint_type \u003d settings.OPENSTACK_KEYSTONE_ENDPOINT_TYPE"},{"line_number":83,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e3ec4381_5cc50a2d","line":80,"in_reply_to":"c3fbfde0_ed6bb516","updated":"2022-12-23 18:30:00.000000000","message":"Done","commit_id":"788596f3b63d7f1ff9276a112c68ee03fdcef015"}],"releasenotes/notes/keystone-endpoint-type-ab4151eca35e04c0.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"23ea27a0ab4800b5d6d3c1a56bc4cd21f900dd8f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"997ebe16_e28e312d","line":7,"range":{"start_line":5,"start_character":71,"end_line":7,"end_character":0},"updated":"2022-12-23 18:27:50.000000000","message":"I think we also need to update this sentence to match the latest patch set.\nIn the latest patch set, we introduced a value to use OPENSTACK_ENDPOINT_TYPE and it is the default. Perhaps it is better to mention that the original behavior is kept.","commit_id":"788596f3b63d7f1ff9276a112c68ee03fdcef015"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d70699c732b55f58ffa54ed4edda5e04959799ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"77b5bbc4_9d600cd4","line":7,"range":{"start_line":5,"start_character":71,"end_line":7,"end_character":0},"in_reply_to":"997ebe16_e28e312d","updated":"2022-12-23 18:30:00.000000000","message":"Done","commit_id":"788596f3b63d7f1ff9276a112c68ee03fdcef015"}]}