)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30609,"name":"Stanislav Dmitriev","email":"sdmitriev1@gmail.com","username":"sdmitriev"},"change_message_id":"59fd8d8186b98245088e6f06fc4516b244ad01a5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"584645a3_d0b59925","updated":"2023-01-06 17:39:53.000000000","message":"You\u0027re absolutely right, I completely mixed up resource and filter_string. Fixing it now","commit_id":"d0820f133a01a81ad53dcc3578cbe6cd72e11415"},{"author":{"_account_id":30609,"name":"Stanislav Dmitriev","email":"sdmitriev1@gmail.com","username":"sdmitriev"},"change_message_id":"0a3491c167eb6f70d7308d0737e818a05a3d507f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ce75107_7951828f","in_reply_to":"584645a3_d0b59925","updated":"2023-01-11 21:15:13.000000000","message":"Done","commit_id":"d0820f133a01a81ad53dcc3578cbe6cd72e11415"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"0a5d67c1554a3c2f4b0c9b5a8114babec4aa5ea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7e34193_a88a1432","updated":"2023-01-11 10:03:59.000000000","message":"Hi thanks for the patch, I have dropped some comments at launchpad bug.\nPlease take a look.\nAlso unit test are failing, needs to be fixed.","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"},{"author":{"_account_id":30609,"name":"Stanislav Dmitriev","email":"sdmitriev1@gmail.com","username":"sdmitriev"},"change_message_id":"0a3491c167eb6f70d7308d0737e818a05a3d507f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"769f92b9_c286a72a","updated":"2023-01-11 21:15:13.000000000","message":"I answered the questions at the launchpad.\nCould you pls point me where do you see failing unittests? I do not see any , all I see is there is an error when tox setting the env up but that\u0027s definitely out of the scope of this bugfix ","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8cda90b5ecd48112f7198ac43d8d1c44a724e36d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5dcfa35_691d475b","updated":"2023-01-17 13:11:21.000000000","message":"I think it is ready to go. AFAIC, UT coverage for this change is not so easy, so I am okay with the current version.","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ec600cdbd54b5dff0542082eaf010e64073f7e66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab89f65a_ef3d4971","updated":"2023-01-18 06:16:50.000000000","message":"Thanks, LGTM.\nTested with devstack.","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"42ab2030cac563211fc2d28f59196d692464f2d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b430bf7a_f6310793","updated":"2023-01-12 09:36:06.000000000","message":"as amotoki confirmed that he is able to reproduce the bug.\nSo removing my -1.\nwill review it again and add my vote here.","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"},{"author":{"_account_id":30609,"name":"Stanislav Dmitriev","email":"sdmitriev1@gmail.com","username":"sdmitriev"},"change_message_id":"193c329a33e1178fbbd4210bc825f69b308130f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e88928a4_a267ac9d","updated":"2023-01-17 20:17:48.000000000","message":"recheck","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"3a695afc8a0dad5d1d9b1a74e053060211fb491c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5a49491_4a2969f3","updated":"2023-01-16 06:57:57.000000000","message":"recheck, gate is fixed now.","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ac9a6b6c141b29370637f54be7e3de024e2de673","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"efdda8a4_5feebe19","in_reply_to":"d7e34193_a88a1432","updated":"2023-01-12 09:30:01.000000000","message":"I could reproduce and confirm the bug. Perhaps a testing method you used was not expected.\n\nI think unit test failures is not related to this patch. Let\u0027s see how it goes after the general UT failure due to tox version.","commit_id":"827d453d7a2e7301da3cabbc34307a765ef3726d"}],"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3cc42c36fda918332deb998bcf688189a14d3cd5","unresolved":true,"context_lines":[{"line_number":253,"context_line":"        return True"},{"line_number":254,"context_line":"    filter_string \u003d search_opts[fake_field]"},{"line_number":255,"context_line":"    matched \u003d [resource for resource in resources"},{"line_number":256,"context_line":"               if resource.name.lower() \u003d\u003d (filter_string or \u0027\u0027).lower()]"},{"line_number":257,"context_line":"    if not matched:"},{"line_number":258,"context_line":"        return False"},{"line_number":259,"context_line":"    search_opts[real_field] \u003d matched[0].id"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5977998_3849c20c","line":256,"updated":"2023-01-06 05:32:18.000000000","message":"According to the bug report, the bug happens if there is an image without a name (i.e. image.name \u003d\u003d None).\nThis line takes care a case where \"filter_string\" is empty and I don\u0027t think it handles a case reported in the bug report.\n\nIf you would like to check \"name\" attribute is None, consider:\n\n  if (resource.name is not None and\n      resource.name.lower() \u003d\u003d filter_string().lower())\n\nI did not check it works but perhaps it works if resource.name field exists.\n\nP.S.\nPlease add a unit test to cever it.","commit_id":"d0820f133a01a81ad53dcc3578cbe6cd72e11415"},{"author":{"_account_id":30609,"name":"Stanislav Dmitriev","email":"sdmitriev1@gmail.com","username":"sdmitriev"},"change_message_id":"0a3491c167eb6f70d7308d0737e818a05a3d507f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        return True"},{"line_number":254,"context_line":"    filter_string \u003d search_opts[fake_field]"},{"line_number":255,"context_line":"    matched \u003d [resource for resource in resources"},{"line_number":256,"context_line":"               if resource.name.lower() \u003d\u003d (filter_string or \u0027\u0027).lower()]"},{"line_number":257,"context_line":"    if not matched:"},{"line_number":258,"context_line":"        return False"},{"line_number":259,"context_line":"    search_opts[real_field] \u003d matched[0].id"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e7aff7d_3a6d712e","line":256,"in_reply_to":"f5977998_3849c20c","updated":"2023-01-11 21:15:13.000000000","message":"Done","commit_id":"d0820f133a01a81ad53dcc3578cbe6cd72e11415"}]}