)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"db9ff2abfd8ef8971aca4a40b1c51a2b0e2161c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"128484a8_fca8e812","updated":"2023-02-17 18:00:20.000000000","message":"Hi, thanks for the patch. Please find one comment inline.\nAlso, about \"test_volumes_pagination\" integration test failing in stable branches\nwe have already fixed this in the master branch https://review.opendev.org/c/openstack/horizon/+/847985\nand planning to backport it in stable branches.","commit_id":"997db50d9d800e57280137f2b14a071c1bbd562f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7f649d0d0a70944ed6903b232e34f88d6c2a5d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b771b1be_52682fb5","in_reply_to":"128484a8_fca8e812","updated":"2023-02-17 20:48:41.000000000","message":"Ok, I didn\u0027t know this change had merged, I was only going on the stable branch info I had. Let me know if you just want me to abandon this change and close the bug.","commit_id":"997db50d9d800e57280137f2b14a071c1bbd562f"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"628582346a08883b78233a41a4bf89d128ea639e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"edcde512_62d56303","in_reply_to":"b771b1be_52682fb5","updated":"2023-02-20 04:34:38.000000000","message":"yeah, let\u0027s abandon and close this bug.","commit_id":"997db50d9d800e57280137f2b14a071c1bbd562f"}],"openstack_dashboard/test/integration_tests/tests/test_volumes.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"db9ff2abfd8ef8971aca4a40b1c51a2b0e2161c5","unresolved":true,"context_lines":[{"line_number":79,"context_line":"            form \u003d volumes_page.volumes_table.create_volume()"},{"line_number":80,"context_line":"            form.cancel()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.skip_unstable(\"bug 2007437\")"},{"line_number":83,"context_line":"    def test_volumes_pagination(self):"},{"line_number":84,"context_line":"        \"\"\"This test checks volumes pagination"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f9957ee5_46c2a402","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":44},"updated":"2023-02-17 18:00:20.000000000","message":"Hi Brian, Why do you need a new decorator here?\npytest already provide @pytest.mark.skip to skip any unittest[1].\nwe use the same function in the horizon to skip any unit test[2].\n\n[1] https://docs.pytest.org/en/7.1.x/how-to/skipping.html#skipping-test-functions\n[2] https://github.com/openstack/horizon/search?q\u003d%40pytest.mark.skip","commit_id":"997db50d9d800e57280137f2b14a071c1bbd562f"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"628582346a08883b78233a41a4bf89d128ea639e","unresolved":true,"context_lines":[{"line_number":79,"context_line":"            form \u003d volumes_page.volumes_table.create_volume()"},{"line_number":80,"context_line":"            form.cancel()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.skip_unstable(\"bug 2007437\")"},{"line_number":83,"context_line":"    def test_volumes_pagination(self):"},{"line_number":84,"context_line":"        \"\"\"This test checks volumes pagination"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ecf96fc_ba3ae840","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":44},"in_reply_to":"ba20cc71_8290945f","updated":"2023-02-20 04:34:38.000000000","message":"ack, thanks.","commit_id":"997db50d9d800e57280137f2b14a071c1bbd562f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f7f649d0d0a70944ed6903b232e34f88d6c2a5d2","unresolved":true,"context_lines":[{"line_number":79,"context_line":"            form \u003d volumes_page.volumes_table.create_volume()"},{"line_number":80,"context_line":"            form.cancel()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @decorators.skip_unstable(\"bug 2007437\")"},{"line_number":83,"context_line":"    def test_volumes_pagination(self):"},{"line_number":84,"context_line":"        \"\"\"This test checks volumes pagination"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba20cc71_8290945f","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":44},"in_reply_to":"f9957ee5_46c2a402","updated":"2023-02-17 20:48:41.000000000","message":"Hi Vishal,\n\nI think the difference is that this decorator will run the test but ignore the outcome if it fails, instead of just not running it. Helps save on rechecks when there is a race condition for example.","commit_id":"997db50d9d800e57280137f2b14a071c1bbd562f"}]}