)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ae0692a018506ac6c751215cfd8b77e621f5b53b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e34f1943_8eb469c4","updated":"2023-03-15 12:13:03.000000000","message":"recheck, not getting this issue in local env.","commit_id":"b256691eed92145ed4064fc70f4279dd9739c8f5"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"689933941355d9afbc385047b04905937a67face","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b287bc1_a500aa33","updated":"2023-03-09 18:55:22.000000000","message":"recheck, random failure.","commit_id":"b256691eed92145ed4064fc70f4279dd9739c8f5"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"0ea56a3c3898a57556b60ede8e00e7fd2ad21541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b7189fc_ef3f61cb","updated":"2023-03-10 05:49:37.000000000","message":"recheck, random failure.","commit_id":"b256691eed92145ed4064fc70f4279dd9739c8f5"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f6bf520313b80af5a593575120c46ecf448e515b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"048f987f_e585ca81","updated":"2023-04-06 20:40:29.000000000","message":"Nevermind, it\u0027s \"Unable to retrieve limits information. Details\n\u0027trunk\u0027 \" and there\u0027s no trunks in my env. But do we have them in our test env?","commit_id":"2bcc384ba3cdabba00145b7e42d04d5a24dcc22b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"dc965487995caa6d1d42f65046afe9a3b2d07a51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a1290a4_8c78c037","updated":"2023-04-06 20:34:14.000000000","message":"The test failure is valid. There\u0027s the message \"Unable to retrieve limits information\" on overview page.","commit_id":"2bcc384ba3cdabba00145b7e42d04d5a24dcc22b"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"e7dbe873ae6ff2527f3e90cc62565ebd7ca826dc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"462c60c6_52ca3383","in_reply_to":"048f987f_e585ca81","updated":"2023-04-10 04:35:00.000000000","message":"yeah, this patch adds \u0027trunks\u0027 information[1] but don\u0027t know where should I do changes to fix this integration test.\n[1] https://review.opendev.org/c/openstack/horizon/+/877004/2/openstack_dashboard/usage/views.py#144","commit_id":"2bcc384ba3cdabba00145b7e42d04d5a24dcc22b"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"188e3a9d1d078ac0d067c4b1918bd6cd28fd5e75","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b80892a5_a87afcb3","in_reply_to":"462c60c6_52ca3383","updated":"2023-04-14 18:55:34.000000000","message":"It looks like the env here has the same problem: \"Unable to retrieve limits information\", according to the video. And we don\u0027t have integration tests for trunks page, so I\u0027d assume this env simply doesn\u0027t have trunks deployed. It would be nice to make the limits display optional for this case.","commit_id":"2bcc384ba3cdabba00145b7e42d04d5a24dcc22b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b939e569bef93ec76a66b8538d821a811f69781","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71c21364_36a27293","in_reply_to":"b80892a5_a87afcb3","updated":"2023-04-19 16:23:17.000000000","message":"trunk feature in neutron is optional, so horizon should not assume trunk feature is always available. I think the best way is to check if the corresponding feature is available by checking the network extension list.\n\nThe same thing is applied to other quotas added in this patch (subnet pools and RBAC policies). They are more fundamental features than \"trunk\" so we might assume these features are always available, but I am not 100% sure, so it is better to check the availablity of these features based on the network extension list.","commit_id":"2bcc384ba3cdabba00145b7e42d04d5a24dcc22b"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"4271fb8d8ec5cd61fbc3dab724c6d9b6a8dcfac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f8cdd73_564bd6e7","updated":"2025-05-22 11:14:29.000000000","message":"@jjasek@redhat.com hello, please close this MR.","commit_id":"c736e24528b12c6d57e9d50a252c7f733c714ff3"}],"openstack_dashboard/usage/quotas.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5c8d49a6ec9dd2a75797cf3b01006bdbff60efb1","unresolved":true,"context_lines":[{"line_number":286,"context_line":"                                                   \u0027security-group\u0027) and"},{"line_number":287,"context_line":"                not neutron.is_extension_supported(request, \u0027trunks\u0027)):"},{"line_number":288,"context_line":"            disabled_quotas.update([\u0027security_group\u0027, \u0027security_group_rule\u0027,"},{"line_number":289,"context_line":"                                    \u0027trunk\u0027])"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if ({\u0027router\u0027, \u0027floatingip\u0027} \u0026 candidates and"},{"line_number":292,"context_line":"                not neutron.is_router_enabled(request)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fa7315f_dfa437cc","line":289,"updated":"2023-04-19 16:29:46.000000000","message":"Is the current logic correct? I think that the check for the security group extension and the trunk extension should be done separately.\n\nAccording to the proposed logic, even if the trunk extension is not available, if the security group extension is avaiable,\n\n \"not neutron.is_extension_supported(request, \u0027security-group\u0027)\n \nwill be False and L.288 will not be executed.","commit_id":"c736e24528b12c6d57e9d50a252c7f733c714ff3"}]}