)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"6d73b7eb07ac74467403df3f55eb9b769f3a99d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3e47b879_42836d42","updated":"2023-03-22 14:14:53.000000000","message":"LGTM","commit_id":"c88583e33a2b3175c6befed16ecacfe66a04ff91"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"da7409235512dbb6aeeef180388b8cc830414023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c3cdb51_fbe5288a","updated":"2023-03-17 13:39:34.000000000","message":"recheck random failure","commit_id":"c88583e33a2b3175c6befed16ecacfe66a04ff91"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"e85aeb4f965f76a95dadbe774b92e8ee37a042a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"77d55592_6a7a71a0","updated":"2023-03-22 15:51:26.000000000","message":"recheck random failure","commit_id":"c88583e33a2b3175c6befed16ecacfe66a04ff91"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"78caba8aa0b4595cc33c9d33dee9aea2b1769a33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1bf9a1d_136b07c9","updated":"2023-03-17 14:52:40.000000000","message":"recheck random failure","commit_id":"c88583e33a2b3175c6befed16ecacfe66a04ff91"}],"openstack_dashboard/test/integration_tests/horizon.conf":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"25526dc67296f7c0189d484ee319410fa50d8090","unresolved":true,"context_lines":[{"line_number":12,"context_line":"[selenium]"},{"line_number":13,"context_line":"# Timeout in seconds to wait for message confirmation modal"},{"line_number":14,"context_line":"# (float value)"},{"line_number":15,"context_line":"message_implicit_wait\u003d3"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Timeout in seconds to wait for a page to become available"},{"line_number":18,"context_line":"# (integer value)"}],"source_content_type":"text/plain","patch_set":2,"id":"1e3d9ba6_684716be","line":15,"updated":"2023-03-17 10:08:19.000000000","message":"I think this change is by mistake?","commit_id":"658b9313b68bb8ab6aefb8869750d3e9fd3e20f3"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"b9f1532b1e05f5cc49c251a5cc2d5431a80014e1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"[selenium]"},{"line_number":13,"context_line":"# Timeout in seconds to wait for message confirmation modal"},{"line_number":14,"context_line":"# (float value)"},{"line_number":15,"context_line":"message_implicit_wait\u003d3"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Timeout in seconds to wait for a page to become available"},{"line_number":18,"context_line":"# (integer value)"}],"source_content_type":"text/plain","patch_set":2,"id":"c743a646_64459d16","line":15,"in_reply_to":"1e3d9ba6_684716be","updated":"2023-03-17 10:23:41.000000000","message":"No, this variable is used only for the messages. Now if we check all the messages in one step. Not Success, Error, Info each one separately then there can not happen that we find \"AssertTrue\" Success and then we wait (for a time period message_implicit_wait) to check \"AssertFalse\" Error although Error message is not there. In that case the time of test is increased (unnecessarily).\nSo the increasing of this time now does not bring any potential unnecessarily time increase of tests. But prevent from server time response that can be longer (usually for Glance API calls) and the message can appear little later (in that case the test is evaluated as FAIL although the message appears for example 500ms later).","commit_id":"658b9313b68bb8ab6aefb8869750d3e9fd3e20f3"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"f1fffe85f5c5d633c16e877bfb20f2105797e28a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"[selenium]"},{"line_number":13,"context_line":"# Timeout in seconds to wait for message confirmation modal"},{"line_number":14,"context_line":"# (float value)"},{"line_number":15,"context_line":"message_implicit_wait\u003d3"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Timeout in seconds to wait for a page to become available"},{"line_number":18,"context_line":"# (integer value)"}],"source_content_type":"text/plain","patch_set":2,"id":"8a09ea83_63af3cc8","line":15,"in_reply_to":"c743a646_64459d16","updated":"2023-03-20 08:45:01.000000000","message":"Done","commit_id":"658b9313b68bb8ab6aefb8869750d3e9fd3e20f3"}],"openstack_dashboard/test/integration_tests/pages/basepage.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"25526dc67296f7c0189d484ee319410fa50d8090","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            self._turn_on_implicit_wait()"},{"line_number":73,"context_line":"            return msg_elements"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def find_message_and_dismiss(self):"},{"line_number":76,"context_line":"        messages_level_present \u003d set()"},{"line_number":77,"context_line":"        for message_element in self.find_all_messages():"},{"line_number":78,"context_line":"            message \u003d messages.MessageRegion("}],"source_content_type":"text/x-python","patch_set":2,"id":"bcbdf48b_b7a9aee8","line":75,"updated":"2023-03-17 10:08:19.000000000","message":"I would call this \"find_messages_and_dismiss\" \nto emphasize that it finds all messages now","commit_id":"658b9313b68bb8ab6aefb8869750d3e9fd3e20f3"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"b9f1532b1e05f5cc49c251a5cc2d5431a80014e1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._turn_on_implicit_wait()"},{"line_number":73,"context_line":"            return msg_elements"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def find_message_and_dismiss(self):"},{"line_number":76,"context_line":"        messages_level_present \u003d set()"},{"line_number":77,"context_line":"        for message_element in self.find_all_messages():"},{"line_number":78,"context_line":"            message \u003d messages.MessageRegion("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad15def_559085a4","line":75,"in_reply_to":"bcbdf48b_b7a9aee8","updated":"2023-03-17 10:23:41.000000000","message":"Good point. Thank you!","commit_id":"658b9313b68bb8ab6aefb8869750d3e9fd3e20f3"}]}