)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"edd7b6c801d0b0f47686cd335cfe73c7c61182f2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"native javaScript select() method to fix the"},{"line_number":11,"context_line":"\u0027jQuery.fn.select() event shorthand is deprecated\u0027 warning."},{"line_number":12,"context_line":"You will get this deprecation warning while creating a keypair"},{"line_number":13,"context_line":"in launch instance workflow."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf0d2020b295108a354d62e1068c4532f12cc103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"eb77fbb0_4c2715fa","line":13,"updated":"2023-05-20 20:38:54.000000000","message":"Is there any information on the deprecation?","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee977bdc69772e930ab00bc84743a4e5c736d341","unresolved":true,"context_lines":[{"line_number":10,"context_line":"native javaScript select() method to fix the"},{"line_number":11,"context_line":"\u0027jQuery.fn.select() event shorthand is deprecated\u0027 warning."},{"line_number":12,"context_line":"You will get this deprecation warning while creating a keypair"},{"line_number":13,"context_line":"in launch instance workflow."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf0d2020b295108a354d62e1068c4532f12cc103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"36e2636b_2775cdfa","line":13,"in_reply_to":"10172903_d3d6a42b","updated":"2023-05-24 13:44:47.000000000","message":"The jquery document suggests to use .trigger(\"select\"), but you use the different approach. I understand what you are doing but it would be nice to mention the reason.","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"4476bde2bbb20b48e706c68ca353643557718466","unresolved":false,"context_lines":[{"line_number":10,"context_line":"native javaScript select() method to fix the"},{"line_number":11,"context_line":"\u0027jQuery.fn.select() event shorthand is deprecated\u0027 warning."},{"line_number":12,"context_line":"You will get this deprecation warning while creating a keypair"},{"line_number":13,"context_line":"in launch instance workflow."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf0d2020b295108a354d62e1068c4532f12cc103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"caa1bba2_c10dc0fc","line":13,"in_reply_to":"36e2636b_2775cdfa","updated":"2023-05-25 06:27:33.000000000","message":"I have updated the code as recommended in the jQuery doc and added the reference in commit-msg.","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d487f37340a9dab08f7a83ec6415e3bdf278be9b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"native javaScript select() method to fix the"},{"line_number":11,"context_line":"\u0027jQuery.fn.select() event shorthand is deprecated\u0027 warning."},{"line_number":12,"context_line":"You will get this deprecation warning while creating a keypair"},{"line_number":13,"context_line":"in launch instance workflow."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf0d2020b295108a354d62e1068c4532f12cc103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"10172903_d3d6a42b","line":13,"in_reply_to":"eb77fbb0_4c2715fa","updated":"2023-05-22 06:23:28.000000000","message":"you can find some info about this deprecation here [1].\n\n[1] https://api.jquery.com/select-shorthand/","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"33e1f5f1f9e8837da9502c5bb487e5a785f6afc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"442b9be5_7d2864bb","updated":"2023-05-18 01:19:46.000000000","message":"recheck, random failure.","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"e54d1bad3edf744801a09a35aff1f16fbe27fed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77be3da3_6cabd713","updated":"2023-05-18 11:01:24.000000000","message":"recheck, random failure.","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"4fbe02b06b74734c3a4179f0832dbe7ede6d2811","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a645cff1_a7623f57","updated":"2023-05-17 17:23:03.000000000","message":"recheck, random failure.","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6f53e0a0502ebca1fce3c45bec1b20c6dfd32fdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e45b68b_e64bcb33","updated":"2023-05-25 07:51:51.000000000","message":"Thanks for the update. I think the new version is more straight-forward and explicit. I confirmed the new version works properly with Chrome and Firefox on MacOS.","commit_id":"190d38b55f51862b67c441f82fa2021916d2b9ef"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5966833329a2722cd828e517a7eb4545e40afcf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edf239b7_c3b0a860","updated":"2023-05-25 09:22:12.000000000","message":"recheck, \u0027test_floatingip_associate_disassociate\u0027 is failing and not related to this patch and added this test entry in etherpad https://etherpad.opendev.org/p/random-failed-horizon-integration-tests","commit_id":"190d38b55f51862b67c441f82fa2021916d2b9ef"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2a8f4a59d94cdcc79db4b2bd1ba31ad86205c234","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29728fbf_5a7fb58b","updated":"2023-05-27 07:29:19.000000000","message":"recheck, random failure added in etherpad.","commit_id":"190d38b55f51862b67c441f82fa2021916d2b9ef"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"db38f14b2321f366940baaec1099a1110ad0ecc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"878fe793_69e262b0","updated":"2023-05-29 09:04:49.000000000","message":"recheck, random failure.","commit_id":"190d38b55f51862b67c441f82fa2021916d2b9ef"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"7ad3f79aa306cf983561f57635fd55f074a2a7c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dffe185f_f18d8dde","updated":"2023-07-20 18:18:39.000000000","message":"recheck, see latest CI result.","commit_id":"190d38b55f51862b67c441f82fa2021916d2b9ef"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"75ddd1fbd0aa7f54170fbc1f49856936e3bd8980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"846223fa_6ff3bf1b","updated":"2023-05-25 16:26:06.000000000","message":"recheck, test_floatingip_associate_disassociate test failing which is not related with this patch.","commit_id":"190d38b55f51862b67c441f82fa2021916d2b9ef"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/create-keypair.controller.js":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d8473ab35e256c6c1f419ee7dfb4eaa383d1c5dc","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function copyPrivateKey() {"},{"line_number":82,"context_line":"      angular.element(\u0027textarea\u0027);"},{"line_number":83,"context_line":"      textarea.select();"},{"line_number":84,"context_line":"      document.execCommand(\u0027copy\u0027);"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"a49190da_f70d7af0","line":83,"updated":"2023-05-20 20:38:13.000000000","message":"It may be a stupid question, but let me ask.\n\nWhere is \"textarea\" here defined?\nL.82 looks up for a textarea, but the result is not stored in any variable.\nI wonder how L.82 and 83 are linked.","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"4476bde2bbb20b48e706c68ca353643557718466","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function copyPrivateKey() {"},{"line_number":82,"context_line":"      angular.element(\u0027textarea\u0027);"},{"line_number":83,"context_line":"      textarea.select();"},{"line_number":84,"context_line":"      document.execCommand(\u0027copy\u0027);"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"dea7cb8c_0cfb70cf","line":83,"in_reply_to":"041fd7b7_9c8172a4","updated":"2023-05-25 06:27:33.000000000","message":"yes, but I have updated the code as per jQuery doc https://api.jquery.com/select-shorthand/","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee977bdc69772e930ab00bc84743a4e5c736d341","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function copyPrivateKey() {"},{"line_number":82,"context_line":"      angular.element(\u0027textarea\u0027);"},{"line_number":83,"context_line":"      textarea.select();"},{"line_number":84,"context_line":"      document.execCommand(\u0027copy\u0027);"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"041fd7b7_9c8172a4","line":83,"in_reply_to":"7368b407_1399bac2","updated":"2023-05-24 13:44:47.000000000","message":"IMHO it is better to select the textarea more explicitly. In my understanding, when we use Javascript select() against a textarea, we usually find a textarea element first and call select() against the element found.\nIs the current way common in JS world?\nThought?","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d487f37340a9dab08f7a83ec6415e3bdf278be9b","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function copyPrivateKey() {"},{"line_number":82,"context_line":"      angular.element(\u0027textarea\u0027);"},{"line_number":83,"context_line":"      textarea.select();"},{"line_number":84,"context_line":"      document.execCommand(\u0027copy\u0027);"},{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"7368b407_1399bac2","line":83,"in_reply_to":"a49190da_f70d7af0","updated":"2023-05-22 06:23:28.000000000","message":"\"textarea\" is not defined anywhere.\nwhen L.82 is called, which selects all the \u003ctextarea\u003e elements in the DOM.\n\nL.83  \"textarea.select()\" is called, which is used to select the text inside the \u003ctextarea\u003e element. By calling select() on the selected \u003ctextarea\u003e element, the text inside it is highlighted or selected.","commit_id":"ff882b7fd771ea6a94e70d7f7e9c46624d2ef506"}]}