)]}'
{"openstack_dashboard/test/integration_tests/helpers.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5c909621ffd8db6f70c04aa0409566b238bdd94a","unresolved":true,"context_lines":[{"line_number":182,"context_line":"            opts \u003d selenium.webdriver.ChromeOptions()"},{"line_number":183,"context_line":"            opts.add_experimental_option(\u0027prefs\u0027, {"},{"line_number":184,"context_line":"                \u0027safebrowsing.enabled\u0027: True,"},{"line_number":185,"context_line":"                \"download.default_directory\": firefox_binary.WebDriver.TEMPDIR,"},{"line_number":186,"context_line":"            })"},{"line_number":187,"context_line":"            opts.add_argument(\u0027--safebrowsing-disable-download-protection\u0027)"},{"line_number":188,"context_line":"            self.driver \u003d webdriver.WebDriverWrapper("}],"source_content_type":"text/x-python","patch_set":1,"id":"256fa5dd_5e0881a2","line":185,"updated":"2023-06-19 08:47:36.000000000","message":"At a glance, it looks trikcy to use a variable from firefox binary for a chrome driver. It looks like that horizon/test/webdriver.py tries to handlee differences among webdrivers.\nI am not sure this is the right place for the workaround.","commit_id":"9952123ff6b6f35c0479b9b3e056bbe66854cf75"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"cbfc4456b4acd34b7178bbb357d5982311bee4aa","unresolved":true,"context_lines":[{"line_number":182,"context_line":"            opts \u003d selenium.webdriver.ChromeOptions()"},{"line_number":183,"context_line":"            opts.add_experimental_option(\u0027prefs\u0027, {"},{"line_number":184,"context_line":"                \u0027safebrowsing.enabled\u0027: True,"},{"line_number":185,"context_line":"                \"download.default_directory\": firefox_binary.WebDriver.TEMPDIR,"},{"line_number":186,"context_line":"            })"},{"line_number":187,"context_line":"            opts.add_argument(\u0027--safebrowsing-disable-download-protection\u0027)"},{"line_number":188,"context_line":"            self.driver \u003d webdriver.WebDriverWrapper("}],"source_content_type":"text/x-python","patch_set":1,"id":"b12de35b_170a9238","line":185,"in_reply_to":"256fa5dd_5e0881a2","updated":"2023-06-19 09:31:10.000000000","message":"I completely agree, however, that is where the test it taking it from. Changing this to make it cleaner would require refactoring both the helpers.py and the firefox_binary.py files (and the test in question). I thought I would first submit the minimal change that makes things work before doing a large refactoring.","commit_id":"9952123ff6b6f35c0479b9b3e056bbe66854cf75"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"124ef58e7079a650dce4c25e3e8fb9004ce60f22","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            opts \u003d selenium.webdriver.ChromeOptions()"},{"line_number":183,"context_line":"            opts.add_experimental_option(\u0027prefs\u0027, {"},{"line_number":184,"context_line":"                \u0027safebrowsing.enabled\u0027: True,"},{"line_number":185,"context_line":"                \"download.default_directory\": firefox_binary.WebDriver.TEMPDIR,"},{"line_number":186,"context_line":"            })"},{"line_number":187,"context_line":"            opts.add_argument(\u0027--safebrowsing-disable-download-protection\u0027)"},{"line_number":188,"context_line":"            self.driver \u003d webdriver.WebDriverWrapper("}],"source_content_type":"text/x-python","patch_set":1,"id":"3e83d2cb_2daa648e","line":185,"in_reply_to":"b12de35b_170a9238","updated":"2023-08-08 09:49:11.000000000","message":"Done","commit_id":"9952123ff6b6f35c0479b9b3e056bbe66854cf75"}]}