)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"99f66d6e7e49c40fefb7347b5c669f901dd638d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2423c2af_bb0e4481","updated":"2023-08-02 10:15:07.000000000","message":"recheck random failure","commit_id":"669fd61fa2a6224efccb8d09ca6243d17ff8df91"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"9c0259ec3065481ab3f5b3e4aacda38a7caa62e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e3513198_b359d079","updated":"2023-08-08 10:03:01.000000000","message":"Nice Work, LGTM.\nIt would be nice if you could mention in the commit-msg that these newly added tests are not running as of now, will make them run in follow-up patches, add more tests, and any other info. you think we should here and also link the etherpad https://etherpad.opendev.org/p/horizon-pytest for anyone seeing this patch inthe  future.","commit_id":"86b17b4c5d53614ad3f644176b263eddc48288c4"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7fab486afc4fd44d9ced1f4e79a05df0a2ac669a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9fb15f22_17641956","updated":"2023-08-02 14:49:53.000000000","message":"recheck timed out","commit_id":"86b17b4c5d53614ad3f644176b263eddc48288c4"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"ebaba9c64dcaff7c570cc5fef12a3ef28e5f3626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"46179f91_dbdc910b","in_reply_to":"e3513198_b359d079","updated":"2023-08-08 11:45:41.000000000","message":"Done.","commit_id":"86b17b4c5d53614ad3f644176b263eddc48288c4"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"401f11278da8126798cc328f1bf99166bbb0ed0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"13522cf3_34898657","updated":"2023-08-09 04:35:43.000000000","message":"Previous P.S. already have two +2, only commit-msg is updated in current P.S.\nSo approving it.","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"96317ee3fe24c4f1d623332468ea9df8aef1c143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"498fc6ff_20705fc8","updated":"2023-08-09 16:22:30.000000000","message":"recheck timeout","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"cd9bb9ac4d205dd048f4bee1c68aeb2af1ac47b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"90b9618f_990e86cd","updated":"2023-08-09 13:13:30.000000000","message":"recheck timeout","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"d5daeeca48586d21ba7dc27b06d80af9351728f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c9327bc7_9f92323b","updated":"2023-08-09 09:14:03.000000000","message":"recheck timeout","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"692929649c9bad16193794b5409d8f96d574d7e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9e33fdc8_effd06f0","updated":"2023-08-14 07:11:06.000000000","message":"recheck, random failure","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"6da5eed1ca0d774c94c59c990e423a5109c3bf69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ea7422a5_8ad8659f","updated":"2023-08-11 15:40:58.000000000","message":"recheck, random failure","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"fd39f667d746d1c06c7ffa2d929f2da8d599fa79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3d781160_5e1c3651","updated":"2023-08-09 05:32:05.000000000","message":"recheck, random failure.","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"62f2e94edffa2e05da717cc7150b7eaa2594e0c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1bfc117b_d18881d4","updated":"2023-08-10 16:30:06.000000000","message":"recheck, random test failure.","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"9ce1c4b8fa0f4c1337ed20d4e01f041cea3d2b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"65631766_90c5cd2d","updated":"2023-08-11 00:30:41.000000000","message":"recheck, random test failure.","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"0526422166c517b92960f660b70fa57319eb6ca2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"52dc8898_0b240f6a","updated":"2023-08-10 06:15:35.000000000","message":"recheck,random failure","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"b2fd69d19e6799a46c565532e0db954e3d797639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7c35dcfa_1447c8ca","updated":"2023-08-11 09:52:49.000000000","message":"recheck,random failure.","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"9d15a5a410dca773ca0cc3d8eef10a0f3ff80a0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b96dda44_67eae98b","updated":"2023-08-11 12:24:47.000000000","message":"recheck,random failure.","commit_id":"36536272ff6e1f191cf150892af814a6d41ba0ae"}],"openstack_dashboard/test/selenium/integration/test_instances.py":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"a363eb4efa5a11819d6ebb77b2833a8bcd763327","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    instance \u003d openstack_demo.create_server("},{"line_number":33,"context_line":"        instance_name,"},{"line_number":34,"context_line":"        image\u003dconfig.image.images_list[0],"},{"line_number":35,"context_line":"        flavor\u003dconfig.launch_instances.flavor,"},{"line_number":36,"context_line":"        availability_zone\u003dconfig.launch_instances.available_zone,"},{"line_number":37,"context_line":"        network\u003dconfig.network.external_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dc6792bf_4afe06c7","line":34,"range":{"start_line":34,"start_character":27,"end_line":34,"end_character":41},"updated":"2023-08-02 00:06:10.000000000","message":"Is there any relevant reason why the \"config.image.images_list\" is a list data type? It is not big deal to specify everywhere where it is needed [0] to choose first element from list but in this list is one element all the time (at least since I work here).","commit_id":"2a75cfb55a1e04eee39559604304a6156a4bb97c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"99f66d6e7e49c40fefb7347b5c669f901dd638d6","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    instance \u003d openstack_demo.create_server("},{"line_number":33,"context_line":"        instance_name,"},{"line_number":34,"context_line":"        image\u003dconfig.image.images_list[0],"},{"line_number":35,"context_line":"        flavor\u003dconfig.launch_instances.flavor,"},{"line_number":36,"context_line":"        availability_zone\u003dconfig.launch_instances.available_zone,"},{"line_number":37,"context_line":"        network\u003dconfig.network.external_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"99e76ec4_16bd99db","line":34,"range":{"start_line":34,"start_character":27,"end_line":34,"end_character":41},"in_reply_to":"dc6792bf_4afe06c7","updated":"2023-08-02 10:15:07.000000000","message":"Done","commit_id":"2a75cfb55a1e04eee39559604304a6156a4bb97c"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"a363eb4efa5a11819d6ebb77b2833a8bcd763327","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    yield None"},{"line_number":62,"context_line":"    openstack_demo.delete_server("},{"line_number":63,"context_line":"        instance_name,"},{"line_number":64,"context_line":"        wait\u003dTrue,"},{"line_number":65,"context_line":"    )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"add0b132_7708e7b1","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":17},"updated":"2023-08-02 00:06:10.000000000","message":"wait\u003dTrue is needed (at least for delete server fixture). In otherwise the tests that combines fixtures for volumes and instances end up as Error. OpenstackSDK delete instance, then trying to delete volume, that can not be delete earlier than instance to which it is attached. If wait\u003dFalse then instance at this moment is in state \"Active\", task \"Deleting\" but still exist - volume delete fail. For fast environment it can work but it is just a lottery.\nI prefer to use wait\u003dTrue for all fixtures. For slower environment it can increase every test duration by few seconds but we know what is going on.","commit_id":"2a75cfb55a1e04eee39559604304a6156a4bb97c"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"99f66d6e7e49c40fefb7347b5c669f901dd638d6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    yield None"},{"line_number":62,"context_line":"    openstack_demo.delete_server("},{"line_number":63,"context_line":"        instance_name,"},{"line_number":64,"context_line":"        wait\u003dTrue,"},{"line_number":65,"context_line":"    )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a86222a_f9b7250d","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":17},"in_reply_to":"add0b132_7708e7b1","updated":"2023-08-02 10:15:07.000000000","message":"Done","commit_id":"2a75cfb55a1e04eee39559604304a6156a4bb97c"}]}
