)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2a2aed437fb601d82ad851b48021c9dd19af9949","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SDK for Neutron networks and subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check if integration test test_create_delete_instance"},{"line_number":10,"context_line":"passes with network\u003dprivate."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1999774"},{"line_number":13,"context_line":"Change-Id: Ic454dcb06b9efe2a4735637bd804d8a337c394cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"6b9cd3ca_3ac0e182","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":28},"updated":"2024-01-11 15:36:57.000000000","message":"strange that I can\u0027t reproduce the issue, from the logs an screenshot it seems shared net is not visible on the wizard, but locally I see it. Strange is that network create shared is not visible in the logs...","commit_id":"eb7e5910d5ff30710371b207801ca8336b3bdcf7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0b3b23a79e488fa2ca3360bd61dab218e4f71514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a07e219a_ace12ac8","updated":"2023-08-25 13:06:40.000000000","message":"1 step forward, please check the direction.\nNetwork and subnet tables are something to check (and the details pages for these), but for example network.shared is yes on the table for me even if on the API it is False, so I still have to dig into the depths of Horizon.","commit_id":"460972ba99122c714fe3886ea7e55346436e34bb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ce0e4252073406d3eaba00d3df2433335e9cb41c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1f968aa3_081dacf3","updated":"2023-12-14 15:02:58.000000000","message":"recheck\nintegration test failure seems to be not related to my patch","commit_id":"022d16a0d8c8e379767ac88ae6456bd4e4a3ac7b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bc081733679d8a915cf605b3d3ec3e0a4214d0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5ffdda7e_c6b6f883","updated":"2024-01-12 12:10:34.000000000","message":"recheck\nwith these settings (use private as default net instead of shared) the failures seems irrelevant, lets see if I am right","commit_id":"eb7e5910d5ff30710371b207801ca8336b3bdcf7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7d320bc9edd1b46c53ea61f1378ea3723ec3bd86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"60c52486_eda9f266","updated":"2024-01-16 12:47:56.000000000","message":"recheck\ntest_create_delete_instance failure seems not related (after launch instance no active vm is visible in the list...)","commit_id":"c473901b9003792ceefd6e3d8eef65653f349029"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"80aa1de252bcf87477cde68a008db6492079dbc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"01abc967_e2411a55","updated":"2024-01-19 15:32:04.000000000","message":"recheck, unrelated failure","commit_id":"4e2e88da2b38af2a73564109f675d4cdc83cd6e9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"39ca2b532b84443227b9615ada17365a0941f1b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3b1cb356_5ce2756e","updated":"2024-02-01 07:38:47.000000000","message":"recheck\nUnrelated failure (test_filter_instances )","commit_id":"8dabb32637c690cd8f9e733e3d7322c509d5af12"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ae2388cda642a70aa1b8de37a4b858b087a52cf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"223d8dff_05af18e1","updated":"2024-02-05 10:29:44.000000000","message":"ok, now this failure seems relevant I check it","commit_id":"db29ab7be5057f3cf8ef57d6345617fb5613e119"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"647bae61ea7979b6340f7b41d8d7d314d7b8a491","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ad3e7d99_9c579005","updated":"2024-02-06 14:41:51.000000000","message":"recheck\ninstance pagination is not related","commit_id":"db29ab7be5057f3cf8ef57d6345617fb5613e119"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"5ef6b4e3b21c237f21d058d7840a30d2f01cf910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"93ff1812_60e0d787","updated":"2024-02-02 16:24:17.000000000","message":"recheck, unrelated failure","commit_id":"db29ab7be5057f3cf8ef57d6345617fb5613e119"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d784a2c57097c4338354c0d12cbc30f75dfd60dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e1b4baec_09e3cf31","in_reply_to":"223d8dff_05af18e1","updated":"2024-02-05 16:00:56.000000000","message":"the strange that I can\u0027t reproduce this issue locally.....","commit_id":"db29ab7be5057f3cf8ef57d6345617fb5613e119"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"583e866db9d458ac4547b0f7b58876fa098a78f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"1b7dee88_79312c22","updated":"2024-02-07 10:53:19.000000000","message":"recheck\n.test_networks_pagination failure with SSLError(SSLError(1, \u0027[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1123)\u0027","commit_id":"40e815dae11244e3d492a76489fae530795c5efc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"55432ded7da4f5567578005a9d94995772c52fe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0a8887bd_c755914c","updated":"2024-02-23 17:15:10.000000000","message":"Thanks for taking care, the following patch in SDK is necessary (to be released): https://review.opendev.org/c/909656","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"101fe6b73688986994d504b1ff8c8d8e0b6a9766","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"22e8b9cc_57cf31fb","updated":"2024-04-05 10:41:49.000000000","message":"recheck random failure","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"9c492ddfa1c6137883f3ba2c228198495c98ace1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"38fcdb2e_df92939f","updated":"2024-04-05 09:08:40.000000000","message":"recheck random failure","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"6f23d935800e5dda5837a9da86fc35868bcdf257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"cbf2f741_9521d918","updated":"2024-02-21 15:10:33.000000000","message":"recheck random timeout","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a733ade4a9dbf924c5b37274b41036017ed27c76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"9bc590d5_cb5e2294","updated":"2024-02-22 00:11:55.000000000","message":"recheck, random failure","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"3cbab602dd3b8e7b1c9fecdaed92d84596bcf5e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"1c1edcb4_be7bdb0c","updated":"2024-02-22 12:26:51.000000000","message":"recheck, random failure.","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"38c30d3740569844f96f385048df5ec477270fd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"940ecda5_59817ea3","updated":"2024-02-21 16:24:20.000000000","message":"recheck, random failure.","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b3467efa6cd876f21f485b7190a2b46c5b011ec6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"bf8f4c1a_b6ecc093","updated":"2024-04-04 20:32:12.000000000","message":"recheck, the openstacksdk patch is merged","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1b2283bd0d5a135f7c8f02f366437bebc230d50b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"56cc3e93_9f000276","in_reply_to":"bf8f4c1a_b6ecc093","updated":"2024-04-08 11:59:54.000000000","message":"We need that to be released (and updated the req repo with it) I think","commit_id":"88c50d6f6fd7fa0df7fd36eca4a8050e4c02180a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"df0afca166d3932d7b9aad6b7374ab48794d28a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"9cddb84d_2cea3713","updated":"2024-04-17 18:29:03.000000000","message":"new SDK is out: https://review.opendev.org/c/openstack/requirements/+/916051","commit_id":"527ec4432f25348f948ebb46b3d9f185ddfd4189"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ed11890f812b4c9dffda317f8ce68c28dbfd7485","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"bbc89d82_7ac65a8b","updated":"2024-06-04 15:47:40.000000000","message":"recheck\nfailure seems not related (like timeout in the tests?)","commit_id":"76aa5e9d11b5d093f177cdb684bddb72bc28fc79"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ee0045f63e52027bba56d6ed214974507ec6363d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"dde43564_af37a649","updated":"2024-06-04 14:05:54.000000000","message":"recheck\nfailure seems not related (like timeout in the tests?)","commit_id":"76aa5e9d11b5d093f177cdb684bddb72bc28fc79"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"8f03b08aaa33dd039e7673e8320e53867c661dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"818cbf74_ada9fbbd","updated":"2024-06-11 16:04:38.000000000","message":"I executed the tests (old integration tests also new pytest tests) on the devstack deployment with this patch. All passed.\nI also tried it with network\u003dprivate as it is mentioned in description. test_create_delete_instance (for demo user who can see private network) passed.\nBut of course this test failed for admin user (because admin user can not see the private network as it is created only for demo project).\n\nSo I would like to ask what is the point of testing with network\u003dprivate regarding to this specific patch. Thank you!","commit_id":"2b9bd1ca5ec4b39591084f072f2f5cec43463526"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"87f5ecddee5b2718ca7e96fa12f0a19485e2d3f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":34,"id":"f6b0ca07_6ffdeded","in_reply_to":"55a1e827_2bb47c08","updated":"2024-06-14 15:48:48.000000000","message":"thanks for checking, I checked again, and I remember as that is a leftover from a state when the integration tests failed.\nYour comment is true, as I remember I added that line when I had issues with the logic for fetching networks with pagination + non-admin user.","commit_id":"2b9bd1ca5ec4b39591084f072f2f5cec43463526"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"4793be6ce5167c62594b88022710d5dbf8f79c37","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":34,"id":"55a1e827_2bb47c08","in_reply_to":"818cbf74_ada9fbbd","updated":"2024-06-11 16:07:56.000000000","message":"@katonalala@gmail.com","commit_id":"2b9bd1ca5ec4b39591084f072f2f5cec43463526"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ed27119ee80acae93700c1bccd82f72d1e998656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"a3fe541b_bba28696","updated":"2024-06-14 20:12:58.000000000","message":"LGTM, thank you!","commit_id":"a2d84f10e09baaec844386b4fb204b8bfe75ffd0"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"46d283e3f494ff3287685b2a0a157c4a492ffd6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"ba64b1c2_5ed801f1","updated":"2024-06-17 06:19:26.000000000","message":"LGTM, thanks!","commit_id":"a2d84f10e09baaec844386b4fb204b8bfe75ffd0"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"5c166fcf8a04abd2d0f1271a3261b883ac6e6da4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"89d8cb3b_db9774c2","updated":"2024-06-14 18:04:55.000000000","message":"recheck, unrelated failure","commit_id":"a2d84f10e09baaec844386b4fb204b8bfe75ffd0"}],"horizon/tables/base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6b1f3aa77876a989bdecb1edf439a9000cf17d28","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                    data_lower \u003d (data or \u0027\u0027).lower()"},{"line_number":433,"context_line":"                except AttributeError:"},{"line_number":434,"context_line":"                    continue"},{"line_number":435,"context_line":"                if value.lower() \u003d\u003d data_lower:"},{"line_number":436,"context_line":"                    display_value.append(display)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        if display_value:"},{"line_number":439,"context_line":"            data \u003d display_value[0]"}],"source_content_type":"text/x-python","patch_set":29,"id":"cd95b428_02857a79","line":436,"range":{"start_line":435,"start_character":16,"end_line":436,"end_character":49},"updated":"2024-04-26 01:29:11.000000000","message":"nit: this could also be all inside the try: block","commit_id":"bdea6dd4ea5a8b9600f5a69b70e29cff66996a66"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"28b159bd029f07723a0cd5f163dc76c283e8c7ca","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                    data_lower \u003d (data or \u0027\u0027).lower()"},{"line_number":433,"context_line":"                except AttributeError:"},{"line_number":434,"context_line":"                    continue"},{"line_number":435,"context_line":"                if value.lower() \u003d\u003d data_lower:"},{"line_number":436,"context_line":"                    display_value.append(display)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        if display_value:"},{"line_number":439,"context_line":"            data \u003d display_value[0]"}],"source_content_type":"text/x-python","patch_set":29,"id":"600249cf_53590c83","line":436,"range":{"start_line":435,"start_character":16,"end_line":436,"end_character":49},"in_reply_to":"cd95b428_02857a79","updated":"2024-04-30 14:44:19.000000000","message":"thanks","commit_id":"bdea6dd4ea5a8b9600f5a69b70e29cff66996a66"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a3ac11f2255a826cbf54538dbf9a0cb1333ef84b","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                    data_lower \u003d (data or \u0027\u0027).lower()"},{"line_number":433,"context_line":"                except AttributeError:"},{"line_number":434,"context_line":"                    if value.lower() \u003d\u003d data_lower:"},{"line_number":435,"context_line":"                        display_value.append(display)"},{"line_number":436,"context_line":"                    continue"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        if display_value:"}],"source_content_type":"text/x-python","patch_set":31,"id":"c2574dbd_5082cd11","line":435,"updated":"2024-04-30 19:15:09.000000000","message":"I meant under the try:","commit_id":"b965f8a5dc9c5e94299f1755255ce78fe4d747d9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"88e00df4c1c8e9971a0c5df8fb26e492a573e3fb","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                    data_lower \u003d (data or \u0027\u0027).lower()"},{"line_number":433,"context_line":"                except AttributeError:"},{"line_number":434,"context_line":"                    if value.lower() \u003d\u003d data_lower:"},{"line_number":435,"context_line":"                        display_value.append(display)"},{"line_number":436,"context_line":"                    continue"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        if display_value:"}],"source_content_type":"text/x-python","patch_set":31,"id":"91b24292_b3066747","line":435,"in_reply_to":"c2574dbd_5082cd11","updated":"2024-05-02 09:07:01.000000000","message":"thanks, so long time ago when I touched this code, more concentration, more concentration....","commit_id":"b965f8a5dc9c5e94299f1755255ce78fe4d747d9"}],"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8ce7c670a76fd4c779bc3814d81492769551023a","unresolved":true,"context_lines":[{"line_number":938,"context_line":"def networkclient(request):"},{"line_number":939,"context_line":"    token_id, neutron_url, auth_url \u003d get_auth_params_from_request(request)"},{"line_number":940,"context_line":"    # TODO(lajoskatona): How to pass cacert to connect? How to fetch"},{"line_number":941,"context_line":"    # password from request object?"},{"line_number":942,"context_line":"    # insecure \u003d settings.OPENSTACK_SSL_NO_VERIFY"},{"line_number":943,"context_line":"    # cacert \u003d settings.OPENSTACK_SSL_CACERT"},{"line_number":944,"context_line":"    c \u003d openstack.connect("}],"source_content_type":"text/x-python","patch_set":1,"id":"8f90cf34_8b8b32d5","line":941,"updated":"2023-08-14 11:21:30.000000000","message":"we don\u0027t store passwords in the session","commit_id":"83633fae5d1c74637c688ff6215d02d175057e72"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0b3b23a79e488fa2ca3360bd61dab218e4f71514","unresolved":false,"context_lines":[{"line_number":938,"context_line":"def networkclient(request):"},{"line_number":939,"context_line":"    token_id, neutron_url, auth_url \u003d get_auth_params_from_request(request)"},{"line_number":940,"context_line":"    # TODO(lajoskatona): How to pass cacert to connect? How to fetch"},{"line_number":941,"context_line":"    # password from request object?"},{"line_number":942,"context_line":"    # insecure \u003d settings.OPENSTACK_SSL_NO_VERIFY"},{"line_number":943,"context_line":"    # cacert \u003d settings.OPENSTACK_SSL_CACERT"},{"line_number":944,"context_line":"    c \u003d openstack.connect("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf2daafe_807cd19b","line":941,"in_reply_to":"8f90cf34_8b8b32d5","updated":"2023-08-25 13:06:40.000000000","message":"Ack\nIt is now token-\u003esession-\u003econnection\nWhat was a surprise for me that the session stored in the request is a django session, and not a keystoneauth like session which openstacksdk could consume.","commit_id":"83633fae5d1c74637c688ff6215d02d175057e72"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8ce7c670a76fd4c779bc3814d81492769551023a","unresolved":true,"context_lines":[{"line_number":951,"context_line":"        project_domain_name\u003drequest.user.user_domain_name,"},{"line_number":952,"context_line":"        app_name\u003d\u0027horizon\u0027,"},{"line_number":953,"context_line":"        app_version\u003d\u00271.0\u0027,"},{"line_number":954,"context_line":"    )"},{"line_number":955,"context_line":"    return c.network"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"89c8ef77_1fc04b90","line":954,"updated":"2023-08-14 11:21:30.000000000","message":"We want to connect using an existing session object, see https://docs.openstack.org/openstacksdk/latest/user/connection.html#openstack.connection.Connection","commit_id":"83633fae5d1c74637c688ff6215d02d175057e72"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a2183c1c96d378232be58bb92c6c1eb2b96078f4","unresolved":true,"context_lines":[{"line_number":951,"context_line":"        project_domain_name\u003drequest.user.user_domain_name,"},{"line_number":952,"context_line":"        app_name\u003d\u0027horizon\u0027,"},{"line_number":953,"context_line":"        app_version\u003d\u00271.0\u0027,"},{"line_number":954,"context_line":"    )"},{"line_number":955,"context_line":"    return c.network"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"278075c3_92ee0598","line":954,"in_reply_to":"5c9f2804_5d7122e2","updated":"2023-08-14 16:11:27.000000000","message":"I think you can reuse the same keystoneauth session for multiple openstack sdk clients if you want to, but you can also create a separate one from the token. We could even use the same openstack sdk client for all the apis – nova, neutron, glance, etc.","commit_id":"83633fae5d1c74637c688ff6215d02d175057e72"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0b4a7f52f04f48da92dfa1a9c4ee4bf625cf8707","unresolved":true,"context_lines":[{"line_number":951,"context_line":"        project_domain_name\u003drequest.user.user_domain_name,"},{"line_number":952,"context_line":"        app_name\u003d\u0027horizon\u0027,"},{"line_number":953,"context_line":"        app_version\u003d\u00271.0\u0027,"},{"line_number":954,"context_line":"    )"},{"line_number":955,"context_line":"    return c.network"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5c9f2804_5d7122e2","line":954,"in_reply_to":"89c8ef77_1fc04b90","updated":"2023-08-14 14:32:37.000000000","message":"So it could be one session for networking, one for compute etc?","commit_id":"83633fae5d1c74637c688ff6215d02d175057e72"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8ce7c670a76fd4c779bc3814d81492769551023a","unresolved":true,"context_lines":[{"line_number":1185,"context_line":"        # is in sync with the network data."},{"line_number":1186,"context_line":"        n[\u0027subnets\u0027] \u003d [subnet_dict[s] for s in n.get(\u0027subnets\u0027, []) if"},{"line_number":1187,"context_line":"                        s in subnet_dict]"},{"line_number":1188,"context_line":"        networks_list.append(n)"},{"line_number":1189,"context_line":"    ret_val \u003d [Network(n) for n in networks_list]"},{"line_number":1190,"context_line":"    return ret_val"},{"line_number":1191,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9b99b91d_cac9c2c5","line":1188,"updated":"2023-08-14 11:21:30.000000000","message":"you can just do networks \u003d list(networks) to unpack the iterator into a list, and then leave the rest of code as it was","commit_id":"83633fae5d1c74637c688ff6215d02d175057e72"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0b3b23a79e488fa2ca3360bd61dab218e4f71514","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"        # is in sync with the network data."},{"line_number":1186,"context_line":"        n[\u0027subnets\u0027] \u003d [subnet_dict[s] for s in n.get(\u0027subnets\u0027, []) if"},{"line_number":1187,"context_line":"                        s in subnet_dict]"},{"line_number":1188,"context_line":"        networks_list.append(n)"},{"line_number":1189,"context_line":"    ret_val \u003d [Network(n) for n in networks_list]"},{"line_number":1190,"context_line":"    return ret_val"},{"line_number":1191,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c605453d_f0e52b45","line":1188,"in_reply_to":"9b99b91d_cac9c2c5","updated":"2023-08-25 13:06:40.000000000","message":"Done","commit_id":"83633fae5d1c74637c688ff6215d02d175057e72"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0b3b23a79e488fa2ca3360bd61dab218e4f71514","unresolved":true,"context_lines":[{"line_number":1175,"context_line":"    LOG.debug(\"network_list(): params\u003d%s\", params)"},{"line_number":1176,"context_line":"    if single_page is True:"},{"line_number":1177,"context_line":"        params[\u0027retrieve_all\u0027] \u003d False"},{"line_number":1178,"context_line":"    result \u003d [n.to_dict() for n in networkclient("},{"line_number":1179,"context_line":"        request).networks(**params)]"},{"line_number":1180,"context_line":"    # TODO(lajoskatona): This is something to check"},{"line_number":1181,"context_line":"    # if single_page is True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb44813b_967e70d2","line":1178,"range":{"start_line":1178,"start_character":16,"end_line":1178,"end_character":23},"updated":"2023-08-25 13:06:40.000000000","message":"here (and below) the SDK object is changed to dict, and that is used to manipulate it as Horizon likes it, and that is converted to the Horizon wrapper class.\nAnyway the issue is that SDK changes the API field like router:external to is_router_external, and those must be find in all the templates.","commit_id":"460972ba99122c714fe3886ea7e55346436e34bb"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"937a0b74436e7702a248a19ed7dbf13a4f450317","unresolved":true,"context_lines":[{"line_number":1181,"context_line":"@profiler.trace"},{"line_number":1182,"context_line":"def network_list(request, single_page\u003dFalse, **params):"},{"line_number":1183,"context_line":"    LOG.debug(\"network_list(): params\u003d%s\", params)"},{"line_number":1184,"context_line":"    for key, value in params.items():"},{"line_number":1185,"context_line":"        if isinstance(value, frozenset):"},{"line_number":1186,"context_line":"            params[key] \u003d list(value)[0]"},{"line_number":1187,"context_line":"        if isinstance(value, list):"},{"line_number":1188,"context_line":"            params[key] \u003d value[0]"},{"line_number":1189,"context_line":"    if single_page is True:"},{"line_number":1190,"context_line":"        params[\u0027retrieve_all\u0027] \u003d False"},{"line_number":1191,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"af620020_ba3c5c43","line":1188,"range":{"start_line":1184,"start_character":0,"end_line":1188,"end_character":34},"updated":"2023-12-08 14:49:45.000000000","message":"I have to revisit this stuff, on the instances tables there are places where frozenset or list is given as param but SDK cant\u0027 handle those.","commit_id":"6088ab71a1f02bd21e3ff74f665824d2de8ad2bb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6b1f3aa77876a989bdecb1edf439a9000cf17d28","unresolved":true,"context_lines":[{"line_number":1200,"context_line":"    networks \u003d []"},{"line_number":1201,"context_line":"    if \u0027tenant_id\u0027 in params:"},{"line_number":1202,"context_line":"        params[\u0027project_id\u0027] \u003d params.pop(\u0027tenant_id\u0027)"},{"line_number":1203,"context_line":"    LOG.debug(\u0027AAAAAA0   params\u003d%s \u0027, params)"},{"line_number":1204,"context_line":"    for value in list_values:"},{"line_number":1205,"context_line":"        params[\u0027id\u0027] \u003d value"},{"line_number":1206,"context_line":"        for net in networkclient(request).networks(**params):"}],"source_content_type":"text/x-python","patch_set":29,"id":"c4226c44_3857b629","line":1203,"updated":"2024-04-26 01:29:11.000000000","message":"remove debug?","commit_id":"bdea6dd4ea5a8b9600f5a69b70e29cff66996a66"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"28b159bd029f07723a0cd5f163dc76c283e8c7ca","unresolved":true,"context_lines":[{"line_number":1200,"context_line":"    networks \u003d []"},{"line_number":1201,"context_line":"    if \u0027tenant_id\u0027 in params:"},{"line_number":1202,"context_line":"        params[\u0027project_id\u0027] \u003d params.pop(\u0027tenant_id\u0027)"},{"line_number":1203,"context_line":"    LOG.debug(\u0027AAAAAA0   params\u003d%s \u0027, params)"},{"line_number":1204,"context_line":"    for value in list_values:"},{"line_number":1205,"context_line":"        params[\u0027id\u0027] \u003d value"},{"line_number":1206,"context_line":"        for net in networkclient(request).networks(**params):"}],"source_content_type":"text/x-python","patch_set":29,"id":"eb5cbc98_b809310f","line":1203,"in_reply_to":"c4226c44_3857b629","updated":"2024-04-30 14:44:19.000000000","message":"uhh, thanks","commit_id":"bdea6dd4ea5a8b9600f5a69b70e29cff66996a66"}],"openstack_dashboard/dashboards/project/networks/templates/networks/_detail_overview.html":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"79a873d6086261f8b3adfa53c723b0269e62c665","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    \u003cdt title\u003d\"{% trans \u0027Shared\u0027 %}\"\u003e{% trans \"Shared\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"    \u003cdd\u003e{{ network.is_shared }}\u003c/dd\u003e"},{"line_number":17,"context_line":"    \u003cdt title\u003d\"{% trans \u0027External Network\u0027 %}\"\u003e{% trans \"External Network\" %}\u003c/dt\u003e"},{"line_number":18,"context_line":"    \u003cdd\u003e{{ network.is_router_external }}\u003c/dd\u003e"},{"line_number":19,"context_line":"    \u003cdt title\u003d\"{% trans \u0027MTU\u0027 %}\"\u003e{% trans \"MTU\" %}\u003c/dt\u003e"},{"line_number":20,"context_line":"    \u003cdd\u003e{{ network.mtu|default:_(\"Unknown\") }}\u003c/dd\u003e"},{"line_number":21,"context_line":"    {% if network.provider__network_type %}"}],"source_content_type":"text/html","patch_set":4,"id":"0eb5bd24_df8ec8d5","line":18,"updated":"2023-11-17 17:45:38.000000000","message":"here |yesno just translates False to yes, if anybody has idea what is going on in here don\u0027t hesitate :-)","commit_id":"d13c039958c18cb6658de811fddb8872fca6b266"}]}