)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e42092989aafd463c519fb688dc03af359b9c45","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Without this patch, running unit tests in Debian fails, as we\u0027re"},{"line_number":10,"context_line":"comparing bananas with apples. Using repr() fixes this, converting"},{"line_number":11,"context_line":"the object references into strings. I\u0027m not sure how this even"},{"line_number":12,"context_line":"worked before, and what broke it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This has been tested with Django 3 and 4, and with Python 11"},{"line_number":15,"context_line":"(ie: in Debian Unstable and Bookworm)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"36b57b1e_c3b9a901","line":12,"range":{"start_line":11,"start_character":36,"end_line":12,"end_character":33},"updated":"2023-10-19 10:30:58.000000000","message":"Previously \"repr\" is implicitly applied to the first argument (if \"transform\" argument is not passed). This behavior was deprecated in Django 3.2 [1] and dropped in Django 4.1 (this version is the planned version to drop it). This is the background of this behavior change.\n\nI would suggest to mention the Django deprecation I mention here instead of \"I\u0027m not sure ...\".\n\n[1] https://docs.djangoproject.com/en/3.2/topics/testing/tools/#django.test.TransactionTestCase.assertQuerysetEqual","commit_id":"51897e31c3b1cfaf4deaa13444e73f2ec3ef69e3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e3b471902013966188f1131c381185cd05ea75e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Without this patch, running unit tests in Debian fails, as we\u0027re"},{"line_number":10,"context_line":"comparing bananas with apples. Using repr() fixes this, converting"},{"line_number":11,"context_line":"the object references into strings. I\u0027m not sure how this even"},{"line_number":12,"context_line":"worked before, and what broke it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This has been tested with Django 3 and 4, and with Python 11"},{"line_number":15,"context_line":"(ie: in Debian Unstable and Bookworm)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"01e3966a_fa2bd3f0","line":12,"range":{"start_line":11,"start_character":36,"end_line":12,"end_character":33},"in_reply_to":"36b57b1e_c3b9a901","updated":"2023-10-23 05:24:11.000000000","message":"Done","commit_id":"51897e31c3b1cfaf4deaa13444e73f2ec3ef69e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"40e07a1ffc5e3f1257744a168f10adb61f302693","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da93e57c_e773d5ff","updated":"2023-10-17 11:40:29.000000000","message":"Thanks, LGTM.","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5ccfd6989069d4b4b096537fd29204121a64628d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4df448e2_6022bf1a","updated":"2023-10-18 10:37:03.000000000","message":"Thanks, for the patch. Please Find some comments inline.","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"ea74249ec7b91a00388c9309e82c258644a8115e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bddcc7d4_a6e42ca2","updated":"2023-10-19 09:28:36.000000000","message":"These 2 failed unit tests can be fixed in follow-up patches.","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1d67e15aebdf0254219d7966ea2562dba8173634","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a421998_8129334b","updated":"2023-10-19 10:26:48.000000000","message":"I would suggest to use \"transform\u003drepr\" rather than list(map(repr, ...)).\nLooking at Django 3.2 document [1], the failure here is caused by a deprecation of implicit transform\u003drepr which was dropped in Django 4.1.\nThe doc suggests to set transform to repr explicitly.\n\n[1] https://docs.djangoproject.com/en/3.2/topics/testing/tools/#django.test.TransactionTestCase.assertQuerysetEqual","commit_id":"51897e31c3b1cfaf4deaa13444e73f2ec3ef69e3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f955ebeae311881b93ec48e0c9d858a48ba38879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2b1e63e2_85bc098e","updated":"2023-10-21 06:51:05.000000000","message":"recheck django42 job has been added","commit_id":"51897e31c3b1cfaf4deaa13444e73f2ec3ef69e3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3e3b471902013966188f1131c381185cd05ea75e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"daf37f31_02d3a69d","in_reply_to":"8a421998_8129334b","updated":"2023-10-23 05:24:11.000000000","message":"Updated all cases with transform\u003drepr and also updated the commit message.","commit_id":"51897e31c3b1cfaf4deaa13444e73f2ec3ef69e3"}],"horizon/test/unit/test_base.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5ccfd6989069d4b4b096537fd29204121a64628d","unresolved":true,"context_lines":[{"line_number":542,"context_line":"            for panel in self._discovered_panels[dash]:"},{"line_number":543,"context_line":"                dash.register(panel)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def test_rbac_panels(self):"},{"line_number":546,"context_line":"        context \u003d {\u0027request\u0027: self.request}"},{"line_number":547,"context_line":"        cats \u003d horizon.get_dashboard(\"cats\")"},{"line_number":548,"context_line":"        self.assertEqual(cats._registered_with, base.Horizon)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3bef2474_1171390c","line":545,"range":{"start_line":545,"start_character":4,"end_line":545,"end_character":31},"updated":"2023-10-18 10:37:03.000000000","message":"This test also fails for Django 4.2 version and needs to be fixed see [1].\nDoes that test pass in your env.?\n[1] https://zuul.opendev.org/t/openstack/build/2b2cf8974891413091929f214a05970e/log/job-output.txt#38236-38243","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"8b76a6af0fdd56cc46d284043ca721dd6b69c017","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            for panel in self._discovered_panels[dash]:"},{"line_number":543,"context_line":"                dash.register(panel)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def test_rbac_panels(self):"},{"line_number":546,"context_line":"        context \u003d {\u0027request\u0027: self.request}"},{"line_number":547,"context_line":"        cats \u003d horizon.get_dashboard(\"cats\")"},{"line_number":548,"context_line":"        self.assertEqual(cats._registered_with, base.Horizon)"}],"source_content_type":"text/x-python","patch_set":3,"id":"488f2668_6e8b862b","line":545,"range":{"start_line":545,"start_character":4,"end_line":545,"end_character":31},"in_reply_to":"3bef2474_1171390c","updated":"2023-10-19 09:35:01.000000000","message":"Done","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"}],"openstack_dashboard/dashboards/project/instances/tests.py":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"5ccfd6989069d4b4b096537fd29204121a64628d","unresolved":true,"context_lines":[{"line_number":1429,"context_line":"            helpers.IsHttpRequest(), \u0027mac-learning\u0027)"},{"line_number":1430,"context_line":""},{"line_number":1431,"context_line":"    @helpers.create_mocks({api.neutron: [\u0027is_extension_supported\u0027]})"},{"line_number":1432,"context_line":"    def test_instance_details_metadata(self):"},{"line_number":1433,"context_line":"        server \u003d self.servers.first()"},{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"        self.mock_is_extension_supported.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2b81ead_48a02df5","line":1432,"range":{"start_line":1432,"start_character":4,"end_line":1432,"end_character":45},"updated":"2023-10-18 10:37:03.000000000","message":"This test is also failing for Django 4.2 version see [2].\n\n[2] https://zuul.opendev.org/t/openstack/build/2b2cf8974891413091929f214a05970e/log/job-output.txt#39829-39850","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ed6e878c67051e769f003416a29a26213d201cf8","unresolved":true,"context_lines":[{"line_number":1429,"context_line":"            helpers.IsHttpRequest(), \u0027mac-learning\u0027)"},{"line_number":1430,"context_line":""},{"line_number":1431,"context_line":"    @helpers.create_mocks({api.neutron: [\u0027is_extension_supported\u0027]})"},{"line_number":1432,"context_line":"    def test_instance_details_metadata(self):"},{"line_number":1433,"context_line":"        server \u003d self.servers.first()"},{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"        self.mock_is_extension_supported.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0a89a8f_f9ff1f75","line":1432,"range":{"start_line":1432,"start_character":4,"end_line":1432,"end_character":45},"in_reply_to":"a3d515cd_3c01da6a","updated":"2023-10-23 05:39:55.000000000","message":"Yes, this is another issue and the only remaining failure once this change is merged. I filed https://bugs.launchpad.net/horizon/+bug/2040129 and try to fix it though it may take some time. Feel free to take it over.","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e64e460a5c37568285a62eb983ee89d0652b8848","unresolved":false,"context_lines":[{"line_number":1429,"context_line":"            helpers.IsHttpRequest(), \u0027mac-learning\u0027)"},{"line_number":1430,"context_line":""},{"line_number":1431,"context_line":"    @helpers.create_mocks({api.neutron: [\u0027is_extension_supported\u0027]})"},{"line_number":1432,"context_line":"    def test_instance_details_metadata(self):"},{"line_number":1433,"context_line":"        server \u003d self.servers.first()"},{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"        self.mock_is_extension_supported.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"b75ac346_b73e73c6","line":1432,"range":{"start_line":1432,"start_character":4,"end_line":1432,"end_character":45},"in_reply_to":"c0a89a8f_f9ff1f75","updated":"2023-10-23 07:20:25.000000000","message":"I proposed a fix for the other failure in https://review.opendev.org/c/openstack/horizon/+/899021","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"8b76a6af0fdd56cc46d284043ca721dd6b69c017","unresolved":true,"context_lines":[{"line_number":1429,"context_line":"            helpers.IsHttpRequest(), \u0027mac-learning\u0027)"},{"line_number":1430,"context_line":""},{"line_number":1431,"context_line":"    @helpers.create_mocks({api.neutron: [\u0027is_extension_supported\u0027]})"},{"line_number":1432,"context_line":"    def test_instance_details_metadata(self):"},{"line_number":1433,"context_line":"        server \u003d self.servers.first()"},{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"        self.mock_is_extension_supported.return_value \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"a3d515cd_3c01da6a","line":1432,"range":{"start_line":1432,"start_character":4,"end_line":1432,"end_character":45},"in_reply_to":"d2b81ead_48a02df5","updated":"2023-10-19 09:35:01.000000000","message":"Not sure how ti fix that one, which I blacklisted in my Debian packaging. Please help, and possibly, fix it in another patch.","commit_id":"99dcdc8222d885066ebbc59f445bce795cb2c749"}]}