)]}'
{".zuul.d/nodejs-jobs.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4797022f8f6d42a6268e8f190f4842d7220acd4a","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    required-projects:"},{"line_number":26,"context_line":"      - openstack/horizon"},{"line_number":27,"context_line":"      - openstack/requirements"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: horizon-nodejs18-run-test"},{"line_number":31,"context_line":"    parent: nodejs-run-test-browser"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bcf1d971_c67f8c0e","line":28,"updated":"2023-11-15 15:56:58.000000000","message":"the only difference looks node_version. How about defining the common pieces as horizon-nodejs-run-lint and set node_version in child job definitions?\nI am not a fan of copy-copy-copy strategy :-(\n\nThe same applies to nodejs-run-test.\n\nI know we cannot have a common defintion for nodejs-run-lint and -run as they inherit nodejs-run-lint/test from zuul-jobs repo but it is better to minimize copying stuffs in horizon repo.","commit_id":"13910d7ad05552d545aa98c2410b0fecdc1077ce"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4797022f8f6d42a6268e8f190f4842d7220acd4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1acf0c7f_fc197683","updated":"2023-11-15 15:56:58.000000000","message":"The change itself is okay.\nI am okay either to update this patch or refactor it as a follow-up.\nThus, no vote from me at the moment.","commit_id":"13910d7ad05552d545aa98c2410b0fecdc1077ce"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"e8662dd905d6c70d96b28094c2cb1ee7411be576","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8e857ea_22a18637","in_reply_to":"1acf0c7f_fc197683","updated":"2023-11-17 07:15:51.000000000","message":"ack, I will try to fix this comment in a follow-up patch.","commit_id":"13910d7ad05552d545aa98c2410b0fecdc1077ce"}]}
