)]}'
{"openstack_dashboard/test/selenium/integration/test_routers.py":[{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"15f46183426d62b4e256c09d87546d2d4ebb5fba","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from openstack_dashboard.test.selenium import widgets"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Imported fixtures"},{"line_number":20,"context_line":"subnet_name \u003d test_networks.subnet_name"},{"line_number":21,"context_line":"network_name \u003d test_networks.network_name"},{"line_number":22,"context_line":"new_subnet_demo \u003d test_networks.new_subnet_demo"},{"line_number":23,"context_line":"new_network_demo \u003d test_networks.new_network_demo"}],"source_content_type":"text/x-python","patch_set":1,"id":"0dae6de5_bfed4afd","line":20,"updated":"2023-12-04 17:11:28.000000000","message":"Fixture Imported but not being used anywhere , do we need it here?","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"100920f59c8c9ecddc93917732fd01e4b8ac99d8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from openstack_dashboard.test.selenium import widgets"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Imported fixtures"},{"line_number":20,"context_line":"subnet_name \u003d test_networks.subnet_name"},{"line_number":21,"context_line":"network_name \u003d test_networks.network_name"},{"line_number":22,"context_line":"new_subnet_demo \u003d test_networks.new_subnet_demo"},{"line_number":23,"context_line":"new_network_demo \u003d test_networks.new_network_demo"}],"source_content_type":"text/x-python","patch_set":1,"id":"61112421_318ed3d0","line":20,"in_reply_to":"0dae6de5_bfed4afd","updated":"2023-12-04 17:46:45.000000000","message":"No. It has to be here. Fixtures call each other. Specifically here the fixture \"subnet_name\" is called inside the fixture \"new_subnet_demo\". It would work in situation when the both fixtures are defined in file conftest.py, then they are shared among all the tests. But now when it will not be defined like it is now then the function new_subnet_demo is trying to find the function subnet_name here, inside of the test_routers.py but the fixture is not here, the fixture is defined in test_networks. So we need to import it too.\n\nMaybe it looks little tricky when you see handling with Fixtures out of conftest.py for the first time (because you are right, the import is here but practically the \"subnet_name\" is not used in the code) but in reality it is called inside of the another fixture :-)).","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"b10f0d24b452531a43923d3a65a28416a2d9c702","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from openstack_dashboard.test.selenium import widgets"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Imported fixtures"},{"line_number":20,"context_line":"subnet_name \u003d test_networks.subnet_name"},{"line_number":21,"context_line":"network_name \u003d test_networks.network_name"},{"line_number":22,"context_line":"new_subnet_demo \u003d test_networks.new_subnet_demo"},{"line_number":23,"context_line":"new_network_demo \u003d test_networks.new_network_demo"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7d1669e_f9832b47","line":20,"in_reply_to":"4dcf9567_c4819962","updated":"2023-12-04 17:56:09.000000000","message":"Done","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"fae91e68abddd078a5f7b0635338f1dc46c4660b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from openstack_dashboard.test.selenium import widgets"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Imported fixtures"},{"line_number":20,"context_line":"subnet_name \u003d test_networks.subnet_name"},{"line_number":21,"context_line":"network_name \u003d test_networks.network_name"},{"line_number":22,"context_line":"new_subnet_demo \u003d test_networks.new_subnet_demo"},{"line_number":23,"context_line":"new_network_demo \u003d test_networks.new_network_demo"}],"source_content_type":"text/x-python","patch_set":1,"id":"4dcf9567_c4819962","line":20,"in_reply_to":"61112421_318ed3d0","updated":"2023-12-04 17:54:54.000000000","message":"Ah I see , thanks for explanation","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"15f46183426d62b4e256c09d87546d2d4ebb5fba","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Imported fixtures"},{"line_number":20,"context_line":"subnet_name \u003d test_networks.subnet_name"},{"line_number":21,"context_line":"network_name \u003d test_networks.network_name"},{"line_number":22,"context_line":"new_subnet_demo \u003d test_networks.new_subnet_demo"},{"line_number":23,"context_line":"new_network_demo \u003d test_networks.new_network_demo"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"859d9b1f_cf523bf6","line":21,"updated":"2023-12-04 17:11:28.000000000","message":"Ditto","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"100920f59c8c9ecddc93917732fd01e4b8ac99d8","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Imported fixtures"},{"line_number":20,"context_line":"subnet_name \u003d test_networks.subnet_name"},{"line_number":21,"context_line":"network_name \u003d test_networks.network_name"},{"line_number":22,"context_line":"new_subnet_demo \u003d test_networks.new_subnet_demo"},{"line_number":23,"context_line":"new_network_demo \u003d test_networks.new_network_demo"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f3cb0e3e_5b932b67","line":21,"in_reply_to":"859d9b1f_cf523bf6","updated":"2023-12-04 17:46:45.000000000","message":"Ditto","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"fae91e68abddd078a5f7b0635338f1dc46c4660b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Imported fixtures"},{"line_number":20,"context_line":"subnet_name \u003d test_networks.subnet_name"},{"line_number":21,"context_line":"network_name \u003d test_networks.network_name"},{"line_number":22,"context_line":"new_subnet_demo \u003d test_networks.new_subnet_demo"},{"line_number":23,"context_line":"new_network_demo \u003d test_networks.new_network_demo"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"72eec411_4c272b5d","line":21,"in_reply_to":"f3cb0e3e_5b932b67","updated":"2023-12-04 17:54:54.000000000","message":"Done","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"751e68398ef73df52d65658a6dd2cdde8c4cdae6","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        router\u003dnew_router_demo.id,"},{"line_number":76,"context_line":"        subnet_id\u003dnew_subnet_demo.id,"},{"line_number":77,"context_line":"    )"},{"line_number":78,"context_line":"    yield interface"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def test_create_router_demo(login, driver, router_name, openstack_demo,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba77ffdf_eb8011e8","line":78,"updated":"2023-12-04 16:38:00.000000000","message":"Maybe this should be a regular function, not a fixture? Or even just a piece of code inside the test?\n\nYou only use it once, and it doesn\u0027t require cleanup. I see no reason for making it a fixture.","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"100920f59c8c9ecddc93917732fd01e4b8ac99d8","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        router\u003dnew_router_demo.id,"},{"line_number":76,"context_line":"        subnet_id\u003dnew_subnet_demo.id,"},{"line_number":77,"context_line":"    )"},{"line_number":78,"context_line":"    yield interface"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def test_create_router_demo(login, driver, router_name, openstack_demo,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c6c5809a_c3d4dc5b","line":78,"in_reply_to":"ba77ffdf_eb8011e8","updated":"2023-12-04 17:46:45.000000000","message":"The same as you commented in previous patch.\n\n\nYes, I use it only once yet (I am not sure if it will be needed in some another tests). But it is \"precondition\" or part of the setUp for the test. Although it does not require cleanup (not every fixture require cleanup) I do not see any reason why not to use it as a fixture, when it is not part of the test but setUp of the test.\nI like this way to separate what exactly is test (steps in test_..) and what is setUp/TearDown part (steps done by fixtures). I think that it is clearest way. Also when you get an output, it will show you on the very first line if the Error appeared in setUp, tearDown or in test. So I think that is the correct way how to use the fixtures.\n\nDo you have some specific reason why not to use it like that? Or what do you see as an advantage in using it as a common function? I see only negatives.","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"89c64ca2932c71a5aabc37323f3ee4026e1e407a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        router\u003dnew_router_demo.id,"},{"line_number":76,"context_line":"        subnet_id\u003dnew_subnet_demo.id,"},{"line_number":77,"context_line":"    )"},{"line_number":78,"context_line":"    yield interface"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def test_create_router_demo(login, driver, router_name, openstack_demo,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b0a06ce_1ec91f32","line":78,"in_reply_to":"c6c5809a_c3d4dc5b","updated":"2023-12-05 16:48:36.000000000","message":"Done","commit_id":"938d2974a73582cff75f6d1636253481f00cfd5d"}]}