)]}'
{"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/tables.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"036b5330359f5ad35723235a21cb9d368272f3f1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    data_type_singular \u003d _(\"Template\")"},{"line_number":57,"context_line":"    data_type_plural \u003d _(\"Templates\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def allowed(self, request, template):"},{"line_number":60,"context_line":"        return True"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def action(self, request, template_id):"}],"source_content_type":"text/x-python","patch_set":42,"id":"baada198_a27b5b79","line":59,"updated":"2014-07-07 21:36:00.000000000","message":"remove this method, it\u0027s unnecessary, default is True.","commit_id":"bc7b8bdab5fc5aca006a5bd809a1f9dd4102f5a7"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/tabs.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"f12172cb22462a12214e44bc31562cdcc55396e1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_context_data(self, request):"},{"line_number":33,"context_line":"        template_id \u003d self.tab_group.kwargs[\u0027template_id\u0027]"},{"line_number":34,"context_line":"        template \u003d saharaclient.nodegroup_template_get(request, template_id)"},{"line_number":35,"context_line":"        flavor \u003d nova.flavor_get(request, template.flavor_id)"},{"line_number":36,"context_line":"        return {\"template\": template, \"flavor\": flavor}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"baada198_e2073016","line":34,"updated":"2014-07-14 16:16:03.000000000","message":"two api calls not in try/except","commit_id":"f5fab10fd84a2f634d56a25c596d8e92eabf7e52"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"efd7ec0691728edd06f4a1a0d23f4458b6279662","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_context_data(self, request):"},{"line_number":33,"context_line":"        template_id \u003d self.tab_group.kwargs[\u0027template_id\u0027]"},{"line_number":34,"context_line":"        template \u003d saharaclient.nodegroup_template_get(request, template_id)"},{"line_number":35,"context_line":"        flavor \u003d nova.flavor_get(request, template.flavor_id)"},{"line_number":36,"context_line":"        return {\"template\": template, \"flavor\": flavor}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"baada198_88ebf5a2","line":34,"in_reply_to":"baada198_e2073016","updated":"2014-07-14 16:53:33.000000000","message":"Done","commit_id":"f5fab10fd84a2f634d56a25c596d8e92eabf7e52"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"f12172cb22462a12214e44bc31562cdcc55396e1","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_context_data(self, request):"},{"line_number":46,"context_line":"        template_id \u003d self.tab_group.kwargs[\u0027template_id\u0027]"},{"line_number":47,"context_line":"        template \u003d saharaclient.nodegroup_template_get(request, template_id)"},{"line_number":48,"context_line":"        return {\"template\": template}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"baada198_a228d886","line":47,"updated":"2014-07-14 16:16:03.000000000","message":"potential uncaught exception from API call","commit_id":"f5fab10fd84a2f634d56a25c596d8e92eabf7e52"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"efd7ec0691728edd06f4a1a0d23f4458b6279662","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_context_data(self, request):"},{"line_number":46,"context_line":"        template_id \u003d self.tab_group.kwargs[\u0027template_id\u0027]"},{"line_number":47,"context_line":"        template \u003d saharaclient.nodegroup_template_get(request, template_id)"},{"line_number":48,"context_line":"        return {\"template\": template}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"baada198_68e301a4","line":47,"in_reply_to":"baada198_a228d886","updated":"2014-07-14 16:53:33.000000000","message":"Done","commit_id":"f5fab10fd84a2f634d56a25c596d8e92eabf7e52"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/templates/data_processing.nodegroup_templates/details.html":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f33fc451652b5144a96e606f0b12071e32d6c914","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Nodegroup Template Details\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"}],"source_content_type":"text/html","patch_set":35,"id":"dab895d6_363128ed","line":2,"updated":"2014-06-30 09:16:06.000000000","message":"\u0027sizeformat\u0027 is not needed there","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"50b892f48877b93eddcad831fc5a4e8bc1a0b7c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n sizeformat %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Nodegroup Template Details\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"}],"source_content_type":"text/html","patch_set":35,"id":"dab895d6_e4d611c5","line":2,"in_reply_to":"dab895d6_363128ed","updated":"2014-06-30 13:24:08.000000000","message":"Done","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/templates/nodegroup_templates/_configure_general_help.html":[{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"ec7fa9ca08baa366d9bddb99b4a582585b35895e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"well\"\u003e"},{"line_number":2,"context_line":"\u003cp\u003e"},{"line_number":3,"context_line":"    This Node Group Template will be created for:"},{"line_number":4,"context_line":"    \u003cbr \u003e"}],"source_content_type":"text/html","patch_set":21,"id":"1ae5cdf2_b88909cc","line":1,"updated":"2014-06-11 22:53:03.000000000","message":"Should this page be i18nized?","commit_id":"3cfe84118d10fe43c85b5accf98b82577930ccfc"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"3b06449c698a8fa6fcbc4e451b4cda374d675a82","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003cb\u003eHadoop version\u003c/b\u003e: {{ hadoop_version }}"},{"line_number":8,"context_line":"    \u003cbr /\u003e"},{"line_number":9,"context_line":"\u003c/p\u003e"},{"line_number":10,"context_line":"\u003cp\u003e"},{"line_number":11,"context_line":"    The Node Group Template object should specify processes that will be launched on each instance. Also an OpenStack flavor is required to boot VMs."},{"line_number":12,"context_line":"\u003c/p\u003e"},{"line_number":13,"context_line":"\u003cp\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"1ae5cdf2_00872813","line":10,"updated":"2014-06-25 09:48:33.000000000","message":"Could you please make help text translatable?","commit_id":"26327959c7460b17ecb31af68f4c13c38343156b"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"a91f2ceb1b5fd64252a80bb24c2bfe5155dc951f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003cb\u003eHadoop version\u003c/b\u003e: {{ hadoop_version }}"},{"line_number":8,"context_line":"    \u003cbr /\u003e"},{"line_number":9,"context_line":"\u003c/p\u003e"},{"line_number":10,"context_line":"\u003cp\u003e"},{"line_number":11,"context_line":"    The Node Group Template object should specify processes that will be launched on each instance. Also an OpenStack flavor is required to boot VMs."},{"line_number":12,"context_line":"\u003c/p\u003e"},{"line_number":13,"context_line":"\u003cp\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"1ae5cdf2_768eed33","line":10,"in_reply_to":"1ae5cdf2_00872813","updated":"2014-06-25 12:59:50.000000000","message":"Done","commit_id":"26327959c7460b17ecb31af68f4c13c38343156b"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/templates/nodegroup_templates/_create_general_help.html":[{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"ec7fa9ca08baa366d9bddb99b4a582585b35895e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cp class\u003d\"well\"\u003e"},{"line_number":2,"context_line":"    Select a plugin and Hadoop version for a new Node group template."},{"line_number":3,"context_line":"\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"1ae5cdf2_d886d5b8","line":1,"updated":"2014-06-11 22:53:03.000000000","message":"i18n?","commit_id":"3cfe84118d10fe43c85b5accf98b82577930ccfc"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"3b06449c698a8fa6fcbc4e451b4cda374d675a82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cp class\u003d\"well\"\u003e"},{"line_number":2,"context_line":"    Select a plugin and Hadoop version for a new Node group template."},{"line_number":3,"context_line":"\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"1ae5cdf2_208a641a","line":2,"updated":"2014-06-25 09:48:33.000000000","message":"Same here","commit_id":"26327959c7460b17ecb31af68f4c13c38343156b"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"a91f2ceb1b5fd64252a80bb24c2bfe5155dc951f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cp class\u003d\"well\"\u003e"},{"line_number":2,"context_line":"    Select a plugin and Hadoop version for a new Node group template."},{"line_number":3,"context_line":"\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"1ae5cdf2_969d3969","line":2,"in_reply_to":"1ae5cdf2_208a641a","updated":"2014-06-25 12:59:50.000000000","message":"Done","commit_id":"26327959c7460b17ecb31af68f4c13c38343156b"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/templates/nodegroup_templates/configure.html":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"769f8f045d2d2251d43568a4be856f7e11e9710c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Create Node Group Template\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_b11cbf14","line":6,"updated":"2014-06-19 08:23:55.000000000","message":"Please remove \"Sahara\" from the title.","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"b03ca4ee8a895316c1f342b232d61b09c7d8097a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Create Node Group Template\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_ec03b70a","line":6,"in_reply_to":"1ae5cdf2_b11cbf14","updated":"2014-06-20 13:46:43.000000000","message":"Done","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a6430df5c40343a7d33eb8aacf81aca93ab75d5c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"    {% include \u0027horizon/common/_workflow.html\u0027 %}"},{"line_number":11,"context_line":"{% endblock %}\u003c!DOCTYPE html\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_7e31f6eb","line":11,"updated":"2014-06-20 11:02:38.000000000","message":"Please remove \"\u003c!DOCTYPE html\u003e\"","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"29ac4e85da36520c88917d9f48dba7ebb70879f1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"    {% include \u0027horizon/common/_workflow.html\u0027 %}"},{"line_number":11,"context_line":"{% endblock %}\u003c!DOCTYPE html\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_8d1856ce","line":11,"in_reply_to":"1ae5cdf2_7e31f6eb","updated":"2014-06-20 13:45:36.000000000","message":"Done","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/templates/nodegroup_templates/create.html":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"769f8f045d2d2251d43568a4be856f7e11e9710c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_11bad3e0","line":1,"updated":"2014-06-19 08:23:55.000000000","message":"It appears that we have two similar templates, this one and configure.html. Could you please explain why?","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"b03ca4ee8a895316c1f342b232d61b09c7d8097a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_6c6407e5","line":1,"in_reply_to":"1ae5cdf2_11bad3e0","updated":"2014-06-20 13:46:43.000000000","message":"I believe that one of the views is \"ajax-modal\" while the other view is not.  I think that the original code may have had differences between the templates (or at least the potential for differences).","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"769f8f045d2d2251d43568a4be856f7e11e9710c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Create Node Group Template\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_51d9bb54","line":6,"updated":"2014-06-19 08:23:55.000000000","message":"Please remove \"Sahara\" from the title.","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"b03ca4ee8a895316c1f342b232d61b09c7d8097a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Create Node Group Template\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_8c5f930e","line":6,"in_reply_to":"1ae5cdf2_51d9bb54","updated":"2014-06-20 13:46:43.000000000","message":"Done","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a6430df5c40343a7d33eb8aacf81aca93ab75d5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_5e927a9f","line":1,"updated":"2014-06-20 11:02:38.000000000","message":"Could you please clarify why do you need two identical templates: this one and configure.html?","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b5277a033b74ebd4966c71995b21fd835fbc464f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_400e90e6","line":1,"in_reply_to":"1ae5cdf2_0db7e685","updated":"2014-06-25 09:41:37.000000000","message":"Ok, this one answers my question. Let them both live for a while.","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"29ac4e85da36520c88917d9f48dba7ebb70879f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Create Node Group Template\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_0db7e685","line":1,"in_reply_to":"1ae5cdf2_5e927a9f","updated":"2014-06-20 13:45:36.000000000","message":"Again, I can only guess that the original versions had differences.  They are still used in different views, so there is the potential for differences in the future.  Ideally, I\u0027d prefer to look into such a refactor as part of our dev cycle rather than as part of the merge.","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a6430df5c40343a7d33eb8aacf81aca93ab75d5c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"    {% include \u0027horizon/common/_workflow.html\u0027 %}"},{"line_number":11,"context_line":"{% endblock %}\u003c!DOCTYPE html\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_7eb6563f","line":11,"updated":"2014-06-20 11:02:38.000000000","message":"ditto","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"29ac4e85da36520c88917d9f48dba7ebb70879f1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"    {% include \u0027horizon/common/_workflow.html\u0027 %}"},{"line_number":11,"context_line":"{% endblock %}\u003c!DOCTYPE html\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_4dac8e35","line":11,"in_reply_to":"1ae5cdf2_7eb6563f","updated":"2014-06-20 13:45:36.000000000","message":"Done","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/templates/nodegroup_templates/details.html":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"769f8f045d2d2251d43568a4be856f7e11e9710c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Nodegroup Template Details\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara node group template details\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_d1c30b56","line":6,"updated":"2014-06-19 08:23:55.000000000","message":"Same about \"Sahara\"","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/templates/nodegroup_templates/nodegroup_templates.html":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"769f8f045d2d2251d43568a4be856f7e11e9710c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Sahara\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Node Group Templates\") %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_517e1b1c","line":3,"updated":"2014-06-19 08:23:55.000000000","message":"Please replace with functional name.","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"b03ca4ee8a895316c1f342b232d61b09c7d8097a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Sahara\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Node Group Templates\") %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_8ce4f33c","line":3,"in_reply_to":"1ae5cdf2_517e1b1c","updated":"2014-06-20 13:46:43.000000000","message":"Done","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"769f8f045d2d2251d43568a4be856f7e11e9710c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Sahara\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Node Group Templates\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_31a6efc1","line":6,"updated":"2014-06-19 08:23:55.000000000","message":"ditto","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"b03ca4ee8a895316c1f342b232d61b09c7d8097a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Sahara\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Sahara - Node Group Templates\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":22,"id":"1ae5cdf2_acdfef64","line":6,"in_reply_to":"1ae5cdf2_31a6efc1","updated":"2014-06-20 13:46:43.000000000","message":"Done","commit_id":"8da4b187f894704c36715126e4eec124bad12a62"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a6430df5c40343a7d33eb8aacf81aca93ab75d5c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Data Processing\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Data Processing - Node Group Templates\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_5ec0ba7b","line":6,"updated":"2014-06-20 11:02:38.000000000","message":"Please remove \"Data Processing\" from this title. One for the page title would be enough.","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"29ac4e85da36520c88917d9f48dba7ebb70879f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Data Processing\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"    {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Data Processing - Node Group Templates\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":24,"id":"1ae5cdf2_cd1c1e7a","line":6,"in_reply_to":"1ae5cdf2_5ec0ba7b","updated":"2014-06-20 13:45:36.000000000","message":"Done","commit_id":"769e97ed0afc51b8aaef707ff5fbd14e9a3bd4da"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/tests.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"f12172cb22462a12214e44bc31562cdcc55396e1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":6,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":47,"id":"baada198_22df686a","line":5,"updated":"2014-07-14 16:16:03.000000000","message":"remove as you don\u0027t work for Nebula, or do you??","commit_id":"f5fab10fd84a2f634d56a25c596d8e92eabf7e52"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/urls.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"56cfee2488dc4309417096f44171e7e8ed0678b0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from django.conf import urls"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import openstack_dashboard.dashboards.project. \\"},{"line_number":18,"context_line":"    data_processing.nodegroup_templates.views as views"}],"source_content_type":"text/x-python","patch_set":45,"id":"baada198_5a00ca65","line":15,"updated":"2014-07-14 13:42:11.000000000","message":"Please consider using:\n\n from django.conf.urls import patterns  # noqa\n from django.conf.urls import url  # noqa\n\nfor consistency with the other Horizon code.","commit_id":"2d2b05d0e74f78a8e82285015bc4ea98fbcaaf4c"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"618a043c4ca387774ae3a0d8084d69df44d32047","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from django.conf import urls"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import openstack_dashboard.dashboards.project. \\"},{"line_number":18,"context_line":"    data_processing.nodegroup_templates.views as views"}],"source_content_type":"text/x-python","patch_set":45,"id":"baada198_8dff8e33","line":15,"in_reply_to":"baada198_5a00ca65","updated":"2014-07-14 14:05:31.000000000","message":"Done","commit_id":"2d2b05d0e74f78a8e82285015bc4ea98fbcaaf4c"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/views.py":[{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"5b7e92e76d23aca9cae3080829335125c827e2ca","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_initial(self):"},{"line_number":92,"context_line":"        initial \u003d super(CopyNodegroupTemplateView, self).get_initial()"},{"line_number":93,"context_line":"        initial.update({\u0027template_id\u0027: self.kwargs[\u0027template_id\u0027]})"},{"line_number":94,"context_line":"        return initial"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_3c450317","line":93,"updated":"2014-05-15 20:52:21.000000000","message":"Don\u0027t update a dict with a single-element-dict.  Just set the value:\ninitial[\u0027template_id\u0027] \u003d self.kwargs[\u0027template_id\u0027]","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"aeae4dceca66d032d9688af6f116905748661b9a","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_initial(self):"},{"line_number":92,"context_line":"        initial \u003d super(CopyNodegroupTemplateView, self).get_initial()"},{"line_number":93,"context_line":"        initial.update({\u0027template_id\u0027: self.kwargs[\u0027template_id\u0027]})"},{"line_number":94,"context_line":"        return initial"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_5e527135","line":93,"in_reply_to":"7adec928_3c450317","updated":"2014-05-19 17:59:59.000000000","message":"Done","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"52d37bfc5f8ded2f07ea7121849917931f7c9ebc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \u0027project/data_processing.nodegroup_templates/nodegroup_templates.html\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_data(self):"},{"line_number":40,"context_line":"        return saharaclient.nodegroup_template_list(self.request)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NodegroupTemplateDetailsView(tabs.TabView):"}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_f227ecc7","line":40,"updated":"2014-07-07 16:24:28.000000000","message":"Should this client call be wrapped in a try/except with appropriate error handling?","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"16ac27d40b3ffe791df9b99b132434b7f0be2550","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \u0027project/data_processing.nodegroup_templates/nodegroup_templates.html\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_data(self):"},{"line_number":40,"context_line":"        return saharaclient.nodegroup_template_list(self.request)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NodegroupTemplateDetailsView(tabs.TabView):"}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_5bb8b310","line":40,"in_reply_to":"baada198_f227ecc7","updated":"2014-07-07 17:24:42.000000000","message":"Yes, done","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"52d37bfc5f8ded2f07ea7121849917931f7c9ebc","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def get_object(self, *args, **kwargs):"},{"line_number":86,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":87,"context_line":"            template_id \u003d self.kwargs[\u0027template_id\u0027]"},{"line_number":88,"context_line":"            template \u003d saharaclient.nodegroup_template_get(self.request,"},{"line_number":89,"context_line":"                                                           template_id)"},{"line_number":90,"context_line":"            self._object \u003d template"},{"line_number":91,"context_line":"        return self._object"}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_322ec4a5","line":88,"updated":"2014-07-07 16:24:28.000000000","message":"Should this client call be wrapped in a try/except with appropriate error handling?","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"16ac27d40b3ffe791df9b99b132434b7f0be2550","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def get_object(self, *args, **kwargs):"},{"line_number":86,"context_line":"        if not hasattr(self, \"_object\"):"},{"line_number":87,"context_line":"            template_id \u003d self.kwargs[\u0027template_id\u0027]"},{"line_number":88,"context_line":"            template \u003d saharaclient.nodegroup_template_get(self.request,"},{"line_number":89,"context_line":"                                                           template_id)"},{"line_number":90,"context_line":"            self._object \u003d template"},{"line_number":91,"context_line":"        return self._object"}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_9b0b2bd5","line":88,"in_reply_to":"baada198_322ec4a5","updated":"2014-07-07 17:24:42.000000000","message":"Yes, done","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"8af62605c12dc5e8e5a8ab24137902f1478b0a3e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            data \u003d []"},{"line_number":45,"context_line":"            exceptions.handle(self.request,"},{"line_number":46,"context_line":"                              _(\"Unable to fetch node group template list.\"))"},{"line_number":47,"context_line":"        return data"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"baada198_78a47608","line":46,"updated":"2014-07-08 15:08:08.000000000","message":"Unresolved reference here.","commit_id":"6c4a24d2cce63cc11371f937ec491a990accd1c7"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"32307458287945652ba3ccbb81eb545002066b71","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        except Exception:"},{"line_number":44,"context_line":"            data \u003d []"},{"line_number":45,"context_line":"            exceptions.handle(self.request,"},{"line_number":46,"context_line":"                              _(\"Unable to fetch node group template list.\"))"},{"line_number":47,"context_line":"        return data"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"baada198_ce5cdc4f","line":46,"in_reply_to":"baada198_78a47608","updated":"2014-07-08 16:10:45.000000000","message":"Done","commit_id":"6c4a24d2cce63cc11371f937ec491a990accd1c7"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/workflows/copy.py":[{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"5b7e92e76d23aca9cae3080829335125c827e2ca","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        request.GET \u003d request.GET.copy()"},{"line_number":40,"context_line":"        request.GET.update({\"plugin_name\": plugin})"},{"line_number":41,"context_line":"        request.GET.update({\"hadoop_version\": hadoop_version})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        super(CopyNodegroupTemplate, self).__init__(request, context_seed,"},{"line_number":44,"context_line":"                                                    entry_point, *args,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_1c5767cb","line":41,"updated":"2014-05-15 20:52:21.000000000","message":"These two updates can be done with one command, passing in a 2 element dict, or just set the values.  But don\u0027t update twice each with a single element dict.\n\nrequest.GET.update({\"plugin_name\": plugin, \"hadoop_version\": hadoop_version})\n\nor\n\nrequest.GET[\"plugin_name\"] \u003d plugin\nrequest.GET[\"hadoop_version\"] \u003d hadoop_version","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"aeae4dceca66d032d9688af6f116905748661b9a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        request.GET \u003d request.GET.copy()"},{"line_number":40,"context_line":"        request.GET.update({\"plugin_name\": plugin})"},{"line_number":41,"context_line":"        request.GET.update({\"hadoop_version\": hadoop_version})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        super(CopyNodegroupTemplate, self).__init__(request, context_seed,"},{"line_number":44,"context_line":"                                                    entry_point, *args,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_fe0edd39","line":41,"in_reply_to":"7adec928_1c5767cb","updated":"2014-05-19 17:59:59.000000000","message":"Done","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"5b7e92e76d23aca9cae3080829335125c827e2ca","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    if process in processes:"},{"line_number":77,"context_line":"                        _service \u003d service"},{"line_number":78,"context_line":"                        break"},{"line_number":79,"context_line":"                processes_dict.update({\"%s:%s\" % (_service, process): process})"},{"line_number":80,"context_line":"            fields[\"processes\"].initial \u003d processes_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_9c01b7b1","line":79,"updated":"2014-05-15 20:52:21.000000000","message":"Heh, once again, just set the value:\n\nprocesses_dict[\"%s:%s\" % (_service, process)] \u003d process","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"aeae4dceca66d032d9688af6f116905748661b9a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    if process in processes:"},{"line_number":77,"context_line":"                        _service \u003d service"},{"line_number":78,"context_line":"                        break"},{"line_number":79,"context_line":"                processes_dict.update({\"%s:%s\" % (_service, process): process})"},{"line_number":80,"context_line":"            fields[\"processes\"].initial \u003d processes_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_5917eb44","line":79,"in_reply_to":"7adec928_9c01b7b1","updated":"2014-05-19 17:59:59.000000000","message":"Done","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"52d37bfc5f8ded2f07ea7121849917931f7c9ebc","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                fields[\u0027floating_ip_pool\u0027].initial \u003d template.floating_ip_pool"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"            processes_dict \u003d dict()"},{"line_number":66,"context_line":"            plugin_details \u003d saharaclient.plugin_get_version_details("},{"line_number":67,"context_line":"                request,"},{"line_number":68,"context_line":"                plugin,"},{"line_number":69,"context_line":"                hadoop_version)"}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_721bdc80","line":66,"updated":"2014-07-07 16:24:28.000000000","message":"Should this client call be wrapped in a try/except with appropriate error handling?","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"16ac27d40b3ffe791df9b99b132434b7f0be2550","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                fields[\u0027floating_ip_pool\u0027].initial \u003d template.floating_ip_pool"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"            processes_dict \u003d dict()"},{"line_number":66,"context_line":"            plugin_details \u003d saharaclient.plugin_get_version_details("},{"line_number":67,"context_line":"                request,"},{"line_number":68,"context_line":"                plugin,"},{"line_number":69,"context_line":"                hadoop_version)"}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_dbe923b8","line":66,"in_reply_to":"baada198_721bdc80","updated":"2014-07-07 17:24:42.000000000","message":"Yes. Done","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"}],"openstack_dashboard/dashboards/project/data_processing/nodegroup_templates/workflows/create.py":[{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"5b7e92e76d23aca9cae3080829335125c827e2ca","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    class Meta:"},{"line_number":142,"context_line":"        name \u003d _(\"Configure Node Group Template\")"},{"line_number":143,"context_line":"        help_text_template \u003d \\"},{"line_number":144,"context_line":"            (\"project/nodegroup_templates/_configure_general_help.html\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class GeneralConfig(workflows.Step):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_1c25a75b","line":144,"updated":"2014-05-15 20:52:21.000000000","message":"Nit: the parens are unnecessary here.","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"aeae4dceca66d032d9688af6f116905748661b9a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    class Meta:"},{"line_number":142,"context_line":"        name \u003d _(\"Configure Node Group Template\")"},{"line_number":143,"context_line":"        help_text_template \u003d \\"},{"line_number":144,"context_line":"            (\"project/nodegroup_templates/_configure_general_help.html\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class GeneralConfig(workflows.Step):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_b9562f04","line":144,"in_reply_to":"7adec928_1c25a75b","updated":"2014-05-19 17:59:59.000000000","message":"Done","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f33fc451652b5144a96e606f0b12071e32d6c914","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class GeneralConfigAction(workflows.Action):"},{"line_number":38,"context_line":"    nodegroup_name \u003d forms.CharField(label\u003d_(\"Template Name\"),"},{"line_number":39,"context_line":"                                     required\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":42,"context_line":"                                  required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_76d56042","line":39,"updated":"2014-06-30 09:16:06.000000000","message":"\u0027required\u0027 is True by default","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"50b892f48877b93eddcad831fc5a4e8bc1a0b7c8","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class GeneralConfigAction(workflows.Action):"},{"line_number":38,"context_line":"    nodegroup_name \u003d forms.CharField(label\u003d_(\"Template Name\"),"},{"line_number":39,"context_line":"                                     required\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":42,"context_line":"                                  required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_24d809ef","line":39,"in_reply_to":"dab895d6_76d56042","updated":"2014-06-30 13:24:08.000000000","message":"Done","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f33fc451652b5144a96e606f0b12071e32d6c914","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                  widget\u003dforms.Textarea)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    flavor \u003d forms.ChoiceField(label\u003d_(\"OpenStack Flavor\"),"},{"line_number":46,"context_line":"                               required\u003dTrue)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    storage \u003d forms.ChoiceField("},{"line_number":49,"context_line":"        label\u003d_(\"Storage location\"),"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_96caf49f","line":46,"updated":"2014-06-30 09:16:06.000000000","message":"ditto","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"50b892f48877b93eddcad831fc5a4e8bc1a0b7c8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                  widget\u003dforms.Textarea)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    flavor \u003d forms.ChoiceField(label\u003d_(\"OpenStack Flavor\"),"},{"line_number":46,"context_line":"                               required\u003dTrue)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    storage \u003d forms.ChoiceField("},{"line_number":49,"context_line":"        label\u003d_(\"Storage location\"),"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_44e5fda6","line":46,"in_reply_to":"dab895d6_96caf49f","updated":"2014-06-30 13:24:08.000000000","message":"Done","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f33fc451652b5144a96e606f0b12071e32d6c914","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    storage \u003d forms.ChoiceField("},{"line_number":49,"context_line":"        label\u003d_(\"Storage location\"),"},{"line_number":50,"context_line":"        required\u003dTrue,"},{"line_number":51,"context_line":"        help_text\u003d_(\"Storage\"),"},{"line_number":52,"context_line":"        choices\u003d[(\"ephemeral_drive\", \"Ephemeral Drive\"),"},{"line_number":53,"context_line":"                 (\"cinder_volume\", \"Cinder Volume\")],"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_b6cff8af","line":50,"updated":"2014-06-30 09:16:06.000000000","message":"ditto","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"50b892f48877b93eddcad831fc5a4e8bc1a0b7c8","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    storage \u003d forms.ChoiceField("},{"line_number":49,"context_line":"        label\u003d_(\"Storage location\"),"},{"line_number":50,"context_line":"        required\u003dTrue,"},{"line_number":51,"context_line":"        help_text\u003d_(\"Storage\"),"},{"line_number":52,"context_line":"        choices\u003d[(\"ephemeral_drive\", \"Ephemeral Drive\"),"},{"line_number":53,"context_line":"                 (\"cinder_volume\", \"Cinder Volume\")],"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_64e201a1","line":50,"in_reply_to":"dab895d6_b6cff8af","updated":"2014-06-30 13:24:08.000000000","message":"Done","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f33fc451652b5144a96e606f0b12071e32d6c914","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.fields[\"processes\"] \u003d forms.MultipleChoiceField("},{"line_number":103,"context_line":"            label\u003d_(\"Processes\"),"},{"line_number":104,"context_line":"            required\u003dTrue,"},{"line_number":105,"context_line":"            widget\u003dforms.CheckboxSelectMultiple(),"},{"line_number":106,"context_line":"            help_text\u003d_(\"Processes to be launched in node group\"),"},{"line_number":107,"context_line":"            choices\u003dprocess_choices)"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_d6c38c88","line":104,"updated":"2014-06-30 09:16:06.000000000","message":"ditto","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"50b892f48877b93eddcad831fc5a4e8bc1a0b7c8","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        self.fields[\"processes\"] \u003d forms.MultipleChoiceField("},{"line_number":103,"context_line":"            label\u003d_(\"Processes\"),"},{"line_number":104,"context_line":"            required\u003dTrue,"},{"line_number":105,"context_line":"            widget\u003dforms.CheckboxSelectMultiple(),"},{"line_number":106,"context_line":"            help_text\u003d_(\"Processes to be launched in node group\"),"},{"line_number":107,"context_line":"            choices\u003dprocess_choices)"}],"source_content_type":"text/x-python","patch_set":35,"id":"dab895d6_84ee358a","line":104,"in_reply_to":"dab895d6_d6c38c88","updated":"2014-06-30 13:24:08.000000000","message":"Done","commit_id":"0117130055fbbb2a70be02c766bf33273807ed95"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"52d37bfc5f8ded2f07ea7121849917931f7c9ebc","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        plugin, hadoop_version \u003d whelpers.\\"},{"line_number":78,"context_line":"            get_plugin_and_hadoop_version(request)"},{"line_number":79,"context_line":"        process_choices \u003d []"},{"line_number":80,"context_line":"        version_details \u003d saharaclient.plugin_get_version_details(request,"},{"line_number":81,"context_line":"                                                            plugin,"},{"line_number":82,"context_line":"                                                            hadoop_version)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_f20e0c3a","line":80,"updated":"2014-07-07 16:24:28.000000000","message":"Should this client call be wrapped in a try/except with appropriate error handling?","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"16ac27d40b3ffe791df9b99b132434b7f0be2550","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        plugin, hadoop_version \u003d whelpers.\\"},{"line_number":78,"context_line":"            get_plugin_and_hadoop_version(request)"},{"line_number":79,"context_line":"        process_choices \u003d []"},{"line_number":80,"context_line":"        version_details \u003d saharaclient.plugin_get_version_details(request,"},{"line_number":81,"context_line":"                                                            plugin,"},{"line_number":82,"context_line":"                                                            hadoop_version)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"baada198_7b66572b","line":80,"in_reply_to":"baada198_f20e0c3a","updated":"2014-07-07 17:24:42.000000000","message":"yes, done","commit_id":"b9179e2285cf0fb358cf6a3318676447671eb8a5"}],"openstack_dashboard/dashboards/project/data_processing/utils/helpers.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"56cfee2488dc4309417096f44171e7e8ed0678b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Mirantis Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":45,"id":"baada198_9a6fc291","line":1,"updated":"2014-07-14 13:42:11.000000000","message":"Please remove the copyright.","commit_id":"2d2b05d0e74f78a8e82285015bc4ea98fbcaaf4c"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"618a043c4ca387774ae3a0d8084d69df44d32047","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Mirantis Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":45,"id":"baada198_cd8c26da","line":1,"in_reply_to":"baada198_9a6fc291","updated":"2014-07-14 14:05:31.000000000","message":"Done","commit_id":"2d2b05d0e74f78a8e82285015bc4ea98fbcaaf4c"}],"openstack_dashboard/dashboards/project/data_processing/utils/workflow_helpers.py":[{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"5b7e92e76d23aca9cae3080829335125c827e2ca","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    if advanced_fields is not None:"},{"line_number":80,"context_line":"        for ad_field_name, ad_field_value in advanced_fields:"},{"line_number":81,"context_line":"            class_fields[ad_field_name] \u003d ad_field_value"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    action_meta \u003d type(\u0027Meta\u0027, (object, ),"},{"line_number":84,"context_line":"                       dict(help_text_template\u003d(\"project\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_fce47be2","line":81,"updated":"2014-05-15 20:52:21.000000000","message":"I think this for-loop can be replaced with:\nclass_fields.update(advanced_fields)","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"5b7e92e76d23aca9cae3080829335125c827e2ca","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if service not in configs_dict:"},{"line_number":131,"context_line":"                configs_dict[service] \u003d dict()"},{"line_number":132,"context_line":"            if (val is None or"},{"line_number":133,"context_line":"                    unicode(defaults[service][config]) \u003d\u003d unicode(val)):"},{"line_number":134,"context_line":"                continue"},{"line_number":135,"context_line":"            configs_dict[service][config] \u003d val"},{"line_number":136,"context_line":"    return configs_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_5c6f2f2b","line":133,"updated":"2014-05-15 20:52:21.000000000","message":"I can\u0027t really tell from just reading the code if this is a non-issue, but if either service or config are missing from their respective dicts above, we\u0027ll get a KeyError.","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"aeae4dceca66d032d9688af6f116905748661b9a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if service not in configs_dict:"},{"line_number":131,"context_line":"                configs_dict[service] \u003d dict()"},{"line_number":132,"context_line":"            if (val is None or"},{"line_number":133,"context_line":"                    unicode(defaults[service][config]) \u003d\u003d unicode(val)):"},{"line_number":134,"context_line":"                continue"},{"line_number":135,"context_line":"            configs_dict[service][config] \u003d val"},{"line_number":136,"context_line":"    return configs_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_d9a77b09","line":133,"in_reply_to":"7adec928_5c6f2f2b","updated":"2014-05-19 17:59:59.000000000","message":"Should be a non-issue.  The values here come from our hadoop distro specific plugins, which are tested.  I\u0027ll double check to be sure we aren\u0027t horribly exposed here.","commit_id":"01c22ff7ab45b3c93682d6811959ceb390bd0f6c"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"56cfee2488dc4309417096f44171e7e8ed0678b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Mirantis Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":45,"id":"baada198_3a0eb6e5","line":1,"updated":"2014-07-14 13:42:11.000000000","message":"ditto","commit_id":"2d2b05d0e74f78a8e82285015bc4ea98fbcaaf4c"}]}
