)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"e814dc2431a5d09c81b56e25ae0d62f9f51ef30b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c8fd7b1_6b095a01","updated":"2024-07-18 10:30:04.000000000","message":"Please take a look.","commit_id":"4968102ff317a3be4f705803c9ede01a9572b12f"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"44f2cb83ee35e9343f9c242ae3e78efe0abcbc2b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2219d87f_8fb82cdc","updated":"2024-07-28 15:45:40.000000000","message":"Please take a look!","commit_id":"fcce68a914f49938137785a4635d781b5a1741df"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"0de2ca72b30d3e815be332700b76a7e75ab5dd33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2c3bcf90_bf04ad13","updated":"2024-07-31 16:13:42.000000000","message":"Properly I will just let reviewers add themselves here. I tried to some core reviewers earlier but no response from them. I am sorry if I bothered you. Thank you so much!","commit_id":"fcce68a914f49938137785a4635d781b5a1741df"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"d9ffe45f1cf20db0e1b477780b323eb11c2687b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4c8c9383_9edae051","in_reply_to":"2219d87f_8fb82cdc","updated":"2024-07-31 06:28:38.000000000","message":"Done","commit_id":"fcce68a914f49938137785a4635d781b5a1741df"}],"openstack_dashboard/dashboards/project/networks/subnets/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"d0275f9c7de97c3d0542f98ab68d669ff348804f","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            initial[key] \u003d subnet[key]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        initial[\u0027gateway_ip\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        initial[\u0027no_gateway\u0027] \u003d (subnet[\u0027gateway_ip\u0027] is None)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if initial[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":88,"context_line":"            initial[\u0027ipv6_modes\u0027] \u003d utils.get_ipv6_modes_menu_from_attrs("}],"source_content_type":"text/x-python","patch_set":2,"id":"4002d6f6_801017a6","line":85,"updated":"2024-07-22 10:14:03.000000000","message":"should we do the same thing here?","commit_id":"4968102ff317a3be4f705803c9ede01a9572b12f"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"44f2cb83ee35e9343f9c242ae3e78efe0abcbc2b","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            initial[key] \u003d subnet[key]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        initial[\u0027gateway_ip\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        initial[\u0027no_gateway\u0027] \u003d (subnet[\u0027gateway_ip\u0027] is None)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if initial[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":88,"context_line":"            initial[\u0027ipv6_modes\u0027] \u003d utils.get_ipv6_modes_menu_from_attrs("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f54765e_30a1ac35","line":85,"in_reply_to":"180134e2_ffba0bf2","updated":"2024-07-28 15:45:40.000000000","message":"Please take a look!","commit_id":"4968102ff317a3be4f705803c9ede01a9572b12f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"d297975dfc94bc2059eb8252230ce7c7d41eae13","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            initial[key] \u003d subnet[key]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        initial[\u0027gateway_ip\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        initial[\u0027no_gateway\u0027] \u003d (subnet[\u0027gateway_ip\u0027] is None)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if initial[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":88,"context_line":"            initial[\u0027ipv6_modes\u0027] \u003d utils.get_ipv6_modes_menu_from_attrs("}],"source_content_type":"text/x-python","patch_set":2,"id":"924ff682_1e76dbef","line":85,"in_reply_to":"3f54765e_30a1ac35","updated":"2024-07-30 06:58:29.000000000","message":"Acknowledged","commit_id":"4968102ff317a3be4f705803c9ede01a9572b12f"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"938461d0485e83ce6faebce6c07cda64315429a1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            initial[key] \u003d subnet[key]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        initial[\u0027gateway_ip\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        initial[\u0027no_gateway\u0027] \u003d (subnet[\u0027gateway_ip\u0027] is None)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if initial[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":88,"context_line":"            initial[\u0027ipv6_modes\u0027] \u003d utils.get_ipv6_modes_menu_from_attrs("}],"source_content_type":"text/x-python","patch_set":2,"id":"180134e2_ffba0bf2","line":85,"in_reply_to":"4002d6f6_801017a6","updated":"2024-07-22 16:46:29.000000000","message":"I applied it in my latest patch. Please take a look, thank you!","commit_id":"4968102ff317a3be4f705803c9ede01a9572b12f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"5cdaf258f31ce259d29e57e04d3e944613340ffe","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        initial[\u0027gateway_ip\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        initial[\u0027no_gateway\u0027] \u003d ("},{"line_number":86,"context_line":"            \u0027gateway_ip\u0027 in subnet and subnet.get[\u0027gateway_ip\u0027] is None"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":"        if initial[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":89,"context_line":"            initial[\u0027ipv6_modes\u0027] \u003d utils.get_ipv6_modes_menu_from_attrs("},{"line_number":90,"context_line":"                subnet[\u0027ipv6_ra_mode\u0027], subnet[\u0027ipv6_address_mode\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5283a7e7_d453665e","line":87,"updated":"2024-07-29 10:41:35.000000000","message":"Did you test this? get should take normal parens, as this is a method call.\nalternatively, something like this could work:\n\ninitial[\u0027no_gateway\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027) is None","commit_id":"4e43081063cccc1a48d9e5612cc8e95c87a9e026"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"fef229769a5139da27ac5c81dd502c956493639f","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        initial[\u0027gateway_ip\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        initial[\u0027no_gateway\u0027] \u003d ("},{"line_number":86,"context_line":"            \u0027gateway_ip\u0027 in subnet and subnet.get[\u0027gateway_ip\u0027] is None"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":"        if initial[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":89,"context_line":"            initial[\u0027ipv6_modes\u0027] \u003d utils.get_ipv6_modes_menu_from_attrs("},{"line_number":90,"context_line":"                subnet[\u0027ipv6_ra_mode\u0027], subnet[\u0027ipv6_address_mode\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"6958cf28_da4019ac","line":87,"in_reply_to":"5283a7e7_d453665e","updated":"2024-07-29 16:00:10.000000000","message":"This is patch 4 (so everything here is outdated). Maybe you should take a look at my patch 5 (latest patch). Thank you!","commit_id":"4e43081063cccc1a48d9e5612cc8e95c87a9e026"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"05991e66e22525d75fbcf4979020751ea7b66f21","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        initial[\u0027gateway_ip\u0027] \u003d subnet.get(\u0027gateway_ip\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        initial[\u0027no_gateway\u0027] \u003d ("},{"line_number":86,"context_line":"            \u0027gateway_ip\u0027 in subnet and subnet.get[\u0027gateway_ip\u0027] is None"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":"        if initial[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":89,"context_line":"            initial[\u0027ipv6_modes\u0027] \u003d utils.get_ipv6_modes_menu_from_attrs("},{"line_number":90,"context_line":"                subnet[\u0027ipv6_ra_mode\u0027], subnet[\u0027ipv6_address_mode\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"2459aa0a_aa4ac673","line":87,"in_reply_to":"6958cf28_da4019ac","updated":"2024-07-29 16:01:36.000000000","message":"Please take a look at my patch latest patch (Patch 5). This code in patch 4 is outdated. Thank you so much","commit_id":"4e43081063cccc1a48d9e5612cc8e95c87a9e026"}]}
